Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19535
to look at the new patch set (#4).
Change subject: drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation
......................................................................
drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation
tis_close() must be called after tis_open() otherwise the locked
locality isn't released and the sessions hangs.
Tested=PC Engines APU2
Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98
Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org>
---
M src/drivers/pc80/tpm/romstage.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/19535/4
--
To view, visit https://review.coreboot.org/19535
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19535
to look at the new patch set (#3).
Change subject: drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation.
......................................................................
drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation.
tis_close() must be called after tis_open() otherwise the locked
locality isn't released and the sessions hangs.
The deactivate command of the TPM should be executed after
the startup is done. So that we can be sure that the TPM
exists and is functional.
Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98
Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org>
---
M src/drivers/pc80/tpm/romstage.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/19535/3
--
To view, visit https://review.coreboot.org/19535
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19523 )
Change subject: mb/lenovo/s230u: fix sata port map for the msata port
......................................................................
Patch Set 5:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/53115/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/8949/ : SUCCESS
--
To view, visit https://review.coreboot.org/19523
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e9e96f0d0849b1e8c4e02aa4f686ceb5e10b3ab
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Bill XIE <persmule(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19535 )
Change subject: drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation.
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
https://review.coreboot.org/#/c/19535/2/src/drivers/pc80/tpm/romstage.c
File src/drivers/pc80/tpm/romstage.c:
Line 192: tis_close();
you can't close it, you haven't opened it yet.
Line 197: tis_close();
you can't close it, you haven't opened it yet.
--
To view, visit https://review.coreboot.org/19535
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Bill XIE has posted comments on this change. ( https://review.coreboot.org/19522 )
Change subject: mb/gigabyte/ga-b75m-d3h: add libgfxinit support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/19522/1//COMMIT_MSG
Commit Message:
PS1, Line 9:
> … work
Do you have the condition to test the board? If so, could you help me to confirm whether the latest version of my patchset works on the vga port? I have only an LCD television with vga and hdmi ports at hands, and I do not know whether vga's failure is due to the non-standard television.
--
To view, visit https://review.coreboot.org/19522
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If00a7247df0c32b3d1f489fb92d86baaa8fdf8ba
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Bill XIE <persmule(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes