coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: drivers/pc80/tpm: Fix missing tis_close() function and TPM d...
by Philipp Deppenwiese (Code Review) 03 May '17

03 May '17

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19535 to look at the new patch set (#2). Change subject: drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation. ...................................................................... drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation. tis_close() must be called after tis_open() otherwise the locked locality isn't released and … [View More]

1 0

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3h: add libgfxinit support
by build bot (Jenkins) (Code Review) 03 May '17

03 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19522 ) Change subject: mb/gigabyte/ga-b75m-d3h: add libgfxinit support ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53111/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/8945/ : ABORTED -- To view, visit https://review.coreboot.org/19522 To unsubscribe, visit https://review.coreboot.… [View More]

1 0

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3h: add libgfxinit support
by Bill XIE (Code Review) 03 May '17

03 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19522 to look at the new patch set (#4). Change subject: mb/gigabyte/ga-b75m-d3h: add libgfxinit support ...................................................................... mb/gigabyte/ga-b75m-d3h: add libgfxinit support Currently native video init works on port HDMI1 (wired to the on-board DVI-D socket) and HDMI3 (the on-board HDMI port), both text mode and fb mode, but fails … [View More]

1 0

Change in coreboot[master]: drivers/pc80/tpm: Fix missing tis_close() function and TPM d...
by Philipp Deppenwiese (Code Review) 03 May '17

03 May '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19535 ) Change subject: drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation. ...................................................................... Patch Set 1: Now I see what you mean. In the coreboot implementation a temporary deactivate via the startup method is called. Not a physical presence deactivate command. I will move this out of this patch into an extra change. -- To view, … [View More]

1 0

Change in coreboot[master]: drivers/pc80/tpm: Fix missing tis_close() function and TPM d...
by Philipp Deppenwiese (Code Review) 03 May '17

03 May '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19535 ) Change subject: drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation. ...................................................................... Patch Set 1: (2 comments) @Patrick can you be more specific giving -2 for a change without any explanation and referenced line of code is somehow hard to understand https://review.coreboot.org/#/c/19535/1//COMMIT_MSG Commit Message: PS1, … [View More]

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by Arthur Heymans (Code Review) 03 May '17

03 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19500 ) Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... Patch Set 19: ok still works as expect: correct backlight when edid string in list, notice message when not. -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment … [View More]

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by Arthur Heymans (Code Review) 03 May '17

03 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19500 ) Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... Patch Set 19: > >> When does _this_ code get tested? > > > > what do you mean? like the values for displays? > > No, I mean this exact commit. It obviously didn't compile, yet > stated > the added value is tested. So … [View More]

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by Arthur Heymans (Code Review) 03 May '17

03 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19500 ) Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... Patch Set 19: > When does _this_ code get tested? what do you mean? like the values for displays? -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-… [View More]

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by build bot (Jenkins) (Code Review) 03 May '17

03 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19500 ) Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... Patch Set 19: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53110/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8944/ : SUCCESS -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https:… [View More]

1 0

Change in coreboot[master]: mb/lenovo/x200: Make button on dock to undock work
by build bot (Jenkins) (Code Review) 03 May '17

03 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19539 ) Change subject: mb/lenovo/x200: Make button on dock to undock work ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53109/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8943/ : SUCCESS -- To view, visit https://review.coreboot.org/19539 To unsubscribe, visit https://review.… [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017