Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19551 )
Change subject: [UNTESTED]mb/lenovo/t400: Generate undock event with dock button
......................................................................
Patch Set 1:
> Tested on T500 and docking.
> The docking key now does generate an undock event.
Thanks for testing.
--
To view, visit https://review.coreboot.org/19551
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1161ed5f5c30201d2ad156d8fce4e8a90e65bff6
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19551 )
Change subject: [UNTESTED]mb/lenovo/t400: Generate undock event with dock button
......................................................................
Patch Set 1: Code-Review+2
Tested on T500 and docking.
The docking key now does generate an undock event.
--
To view, visit https://review.coreboot.org/19551
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1161ed5f5c30201d2ad156d8fce4e8a90e65bff6
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19552
to look at the new patch set (#2).
Change subject: [NOTFORMERGE]mb/lenovo/t400: Quick and dirty dock hotplug support
......................................................................
[NOTFORMERGE]mb/lenovo/t400: Quick and dirty dock hotplug support
Change-Id: I9676880540fe9e4c84c6fd47b8c85e76f54a8a68
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/x86/lapic/Makefile.inc
M src/lib/Makefile.inc
M src/mainboard/lenovo/t400/Makefile.inc
M src/mainboard/lenovo/t400/acpi/dock.asl
A src/mainboard/lenovo/t400/smi.h
A src/mainboard/lenovo/t400/smihandler.c
M src/southbridge/intel/i82801ix/i82801ix.h
M src/southbridge/intel/i82801ix/smihandler.c
8 files changed, 208 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/19552/2
--
To view, visit https://review.coreboot.org/19552
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9676880540fe9e4c84c6fd47b8c85e76f54a8a68
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Duncan Laurie has uploaded a new change for review. ( https://review.coreboot.org/19550 )
Change subject: mb/google/eve: Remove code to set keyboard backlight at boot
......................................................................
mb/google/eve: Remove code to set keyboard backlight at boot
Remove the code that was enabling the keyboard backlight at boot
since this is not desired behavior for this device.
BUG=b:35581264
TEST=build and boot on Eve and ensure keyboard backlight does
not turn on when booting but can still be enabled in the OS.
Change-Id: I7229cf962597c0de74dc005f7afb9408f7a66f42
Signed-off-by: Duncan Laurie <dlaurie(a)chromium.org>
---
M src/mainboard/google/eve/bootblock.c
1 file changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/19550/1
diff --git a/src/mainboard/google/eve/bootblock.c b/src/mainboard/google/eve/bootblock.c
index 872825f..5e92bb0 100644
--- a/src/mainboard/google/eve/bootblock.c
+++ b/src/mainboard/google/eve/bootblock.c
@@ -14,13 +14,10 @@
* GNU General Public License for more details.
*/
-#include <arch/io.h>
#include <bootblock_common.h>
#include <ec/google/chromeec/ec.h>
#include <gpio.h>
#include <soc/gpio.h>
-#include <soc/iomap.h>
-#include <soc/pm.h>
#include "gpio.h"
static void early_config_gpio(void)
@@ -30,12 +27,5 @@
void bootblock_mainboard_init(void)
{
- uint32_t pm1_cnt = inl(ACPI_BASE_ADDRESS + PM1_CNT);
- uint32_t pm1_sts = inl(ACPI_BASE_ADDRESS + PM1_STS);
-
- /* Turn on keyboard backlight to indicate we are booting */
- if (!((pm1_sts & WAK_STS) && (acpi_sleep_from_pm1(pm1_cnt) == ACPI_S3)))
- google_chromeec_kbbacklight(75);
-
early_config_gpio();
}
--
To view, visit https://review.coreboot.org/19550
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7229cf962597c0de74dc005f7afb9408f7a66f42
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org>