Lee Leahy has posted comments on this change. ( https://review.coreboot.org/19534 )
Change subject: Documentation/Intel: Add vboot documentation
......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/#/c/19534/1/Documentation/Intel/vboot.html
File Documentation/Intel/vboot.html:
PS1, Line 23: verifies the firmware and places m
> Remove *verification*?
Done
PS1, Line 37: manufacture
> manufacturer
Done
PS1, Line 70: The f
> The
Done
PS1, Line 134: an a
> Only *an*.
Done
PS1, Line 352: allow
> allows
Done
PS1, Line 353: Chrome O
> Chrome OS
Done
PS1, Line 354: ot void th
> Should Google Chromeboxes be mentioned too?
Switched Chromebook to system. I don't know that I have a full list of the Chrome platforms, there seem to be Chromebooks, Chromeboxes, Chromebases, etc. All of these are listed on Google's Chromebook site: https://www.google.com/chromebook/find/
--
To view, visit https://review.coreboot.org/19534
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie17b8443772f596de0c9d8afe6f4ec3ac4d4fef8
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19534
to look at the new patch set (#2).
Change subject: Documentation/Intel: Add vboot documentation
......................................................................
Documentation/Intel: Add vboot documentation
Add documentation which describes how to build and sign a coreboot image
which enables vboot.
TEST=None
Change-Id: Ie17b8443772f596de0c9d8afe6f4ec3ac4d4fef8
Signed-off-by: Lee Leahy <Leroy.P.Leahy(a)intel.com>
---
M Documentation/Intel/index.html
A Documentation/Intel/vboot.html
2 files changed, 374 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/19534/2
--
To view, visit https://review.coreboot.org/19534
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie17b8443772f596de0c9d8afe6f4ec3ac4d4fef8
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19542 )
Change subject: [UNTESTED]mb/lenovo/t400: Make dock LEDs behave like vendor bios
......................................................................
[UNTESTED]mb/lenovo/t400: Make dock LEDs behave like vendor bios
Fetched from vendor DSDT and same as smm T60 dock code.
No idea if dock/undock events are correctly here, but it is certainly
useful as a visual aid to see if those work.
Change-Id: Ia3ff479dba687216c537bc810ec561dfc98d25b1
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/mainboard/lenovo/t400/acpi/dock.asl
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/19542/1
diff --git a/src/mainboard/lenovo/t400/acpi/dock.asl b/src/mainboard/lenovo/t400/acpi/dock.asl
index e2aa53e..11d52d1 100644
--- a/src/mainboard/lenovo/t400/acpi/dock.asl
+++ b/src/mainboard/lenovo/t400/acpi/dock.asl
@@ -27,10 +27,14 @@
if (Arg0) {
/* connect dock */
Store (1, \GP28)
+ TLED(0x08, 0x00)
+ TLED(0x09, 0x80)
Store (1, \_SB.PCI0.LPCB.EC.DKR1)
} else {
/* disconnect dock */
Store (0, \GP28)
+ TLED(0x08, 0x00)
+ TLED(0x09, 0x00)
Store (0, \_SB.PCI0.LPCB.EC.DKR1)
}
Xor(Arg0, \_SB.PCI0.LPCB.EC.DKR1, Local0)
--
To view, visit https://review.coreboot.org/19542
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3ff479dba687216c537bc810ec561dfc98d25b1
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19428 )
Change subject: soc/intel/common/block: Add Intel XDCI code support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19428/1/src/soc/intel/common/block/xdci/xdc…
File src/soc/intel/common/block/xdci/xdci.c:
Line 42: .devices = pci_device_ids,
> Or you let the SoC demultiplex the single callout. Or put a local wrapper t
i will try to implement something like that as you said, but can we address the same in next set of common code implementation phase. I'm internally tracking if we can complete all IP code by next 1-2 week. And in this process we may figure out the amount of repetition
--
To view, visit https://review.coreboot.org/19428
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cbc686a00c26b92be2847b6bd6c2e5aa5a690f7
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com>
Gerrit-HasComments: Yes
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/19539 )
Change subject: mb/lenovo/x200: Make button on dock to undock work
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19539
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib74408802e977d9caabcb815c9cbd06bd8dbe395
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kevin Keijzer <kevin(a)librepractice.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Bill XIE has posted comments on this change. ( https://review.coreboot.org/19522 )
Change subject: mb/gigabyte/ga-b75m-d3h: add libgfxinit support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/19522/1//COMMIT_MSG
Commit Message:
PS1, Line 9:
> Just fetch me a Linux kernel log (with drm.debug=0x6). I might
Here is the kernel log with vga port used and drm.debug=0x6:
https://gist.githubusercontent.com/persmule/76a8ebcab77e158d7e2b444e3313927…
--
To view, visit https://review.coreboot.org/19522
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If00a7247df0c32b3d1f489fb92d86baaa8fdf8ba
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Bill XIE <persmule(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes