Martin Roth has posted comments on this change. ( https://review.coreboot.org/19964 )
Change subject: sb/lynxpoint: add ACPI method to generate USB port info
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19964
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If63d5637a0469eeace0d935cca961e8d04fdfb1a
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19963 )
Change subject: google/parrot: add board-specific USB port info
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19963
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58ea0b43f7f2c2692630df3bdb06af92566c1202
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19962 )
Change subject: sb/bd82x6x: add ACPI method to generate USB port info
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19962
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib83660d6548112ceb6c75a31e5ce6c4a6041ccfb
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19970 )
Change subject: google/auron: add board-specific USB port info
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19970
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id17f21c23540d2e3d5a902a2174b66c7a5a5f3e0
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19971 )
Change subject: google/jecht: add board-specific USB port info
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19971
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b15aac9c4971e2ae230106016fba3a583ec6c9a
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/19977 )
Change subject: nb/intel/sandybridge: Remove unecessary reserved resources
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19977/1//COMMIT_MSG
Commit Message:
Line 11: on SNB, but that bug has long since been fixed. Commit
> It has to be a runtime decision and I was too lazy to write
ok, I'll drop this and fix the ACPI then. My thought would be to set a gnvs var based on same condition as used in northbridge code, then use that as a conditional in the ACPI
--
To view, visit https://review.coreboot.org/19977
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e14a73dbdb9d62dfd7d942a79659a5997f97971
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/19977 )
Change subject: nb/intel/sandybridge: Remove unecessary reserved resources
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19977/1//COMMIT_MSG
Commit Message:
Line 11: on SNB, but that bug has long since been fixed. Commit
> I didn't, I compared SNB and IVB errata (the issue is not
ok, but why aren't the ACPI regions restricted to just SNB?
--
To view, visit https://review.coreboot.org/19977
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e14a73dbdb9d62dfd7d942a79659a5997f97971
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/19977 )
Change subject: nb/intel/sandybridge: Remove unecessary reserved resources
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19977/1//COMMIT_MSG
Commit Message:
Line 11: on SNB, but that bug has long since been fixed. Commit
> Well you need the OS to allocate a framebuffer in the broken
how did you trigger it for testing against IVB when you did the patch to restrict to SNB only?
--
To view, visit https://review.coreboot.org/19977
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e14a73dbdb9d62dfd7d942a79659a5997f97971
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes