Martin Roth has posted comments on this change. ( https://review.coreboot.org/19974 )
Change subject: google/rambi: add board-specific USB port info
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19974
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7ce3d135d6ffe53ab1566d5258d01b052ac47f4
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/19965 )
Change subject: sb/lynxpoint: add missing USB port defs
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/19965/1/src/southbridge/intel/lynxpoint/acp…
File src/southbridge/intel/lynxpoint/acpi/usb.asl:
PS1, Line 412: // How many are there?
> remove now?
removed, as well as the one above for ehci
PS1, Line 419: 7
> 6?
fixed
--
To view, visit https://review.coreboot.org/19965
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d2f93351435cccd62e8fe4d95ad3467aa09de69
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19965
to look at the new patch set (#2).
Change subject: sb/lynxpoint: add missing USB port defs
......................................................................
sb/lynxpoint: add missing USB port defs
Add device/address stubs for XHCI USB ports 7, 10-13.
Stub data will be supplemented by board-specific info
added in subsequent commits.
Change-Id: I7d2f93351435cccd62e8fe4d95ad3467aa09de69
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/southbridge/intel/lynxpoint/acpi/usb.asl
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/19965/2
--
To view, visit https://review.coreboot.org/19965
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d2f93351435cccd62e8fe4d95ad3467aa09de69
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19973 )
Change subject: soc/baytrail: add ACPI method to generate USB port info
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19973/1/src/soc/intel/baytrail/acpi/xhci.asl
File src/soc/intel/baytrail/acpi/xhci.asl:
PS1, Line 29:
Indented too far?
--
To view, visit https://review.coreboot.org/19973
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad947ae2cd541d3407455b218c2b352b9a373718
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19972 )
Change subject: soc/baytrail: add missing USB port defs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19972
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae874a9ba01e9428e07cf7ff15e663365b2354a9
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19969 )
Change subject: soc/broadwell: add ACPI method to generate USB port info
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19969
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e6699fe3eaafbe6847479d45c70a1d57bd327a
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19968 )
Change subject: soc/broadwell: add missing USB port defs
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19968/1/src/soc/intel/broadwell/acpi/xhci.a…
File src/soc/intel/broadwell/acpi/xhci.asl:
PS1, Line 358: // How many are there?
remove?
--
To view, visit https://review.coreboot.org/19968
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice86bd226a70bd5996430e7a68a026cc825ba187
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19967 )
Change subject: google/slippy: add board-specific USB port info
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19967
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3b5b1161f62ac0b840380679acafeff363cf45
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19966 )
Change subject: google/beltino: add board-specific USB port info
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19966
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5b540949ea071f7165876e12ac1ef50e62d2b22
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19965 )
Change subject: sb/lynxpoint: add missing USB port defs
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/19965/1/src/southbridge/intel/lynxpoint/acp…
File src/southbridge/intel/lynxpoint/acpi/usb.asl:
PS1, Line 412: // How many are there?
remove now?
PS1, Line 419: 7
6?
--
To view, visit https://review.coreboot.org/19965
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d2f93351435cccd62e8fe4d95ad3467aa09de69
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes