Martin Roth has posted comments on this change. ( https://review.coreboot.org/19961 )
Change subject: ec/ene_kb3940q: correct ACPI battery data fed into ToString()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19961
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I395cc7fbdf26c8cc816e47107e552c0533580fa1
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19959 )
Change subject: google/parrot: make chromeos.c compilation conditional on CONFIG_CHROMEOS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19959
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8ef1f4c521b2a7308941299f2501073937bdf4a
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19957 )
Change subject: google/lulu: enable SATA device to sleep in S0
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19957
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib15f8b51db19b3d9d2e135f85c71a15a45a2ffbd
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/19973 )
Change subject: soc/baytrail: add ACPI method to generate USB port info
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19973/1/src/soc/intel/baytrail/acpi/xhci.asl
File src/soc/intel/baytrail/acpi/xhci.asl:
PS1, Line 29:
> Indented too far?
whoops, fixed
--
To view, visit https://review.coreboot.org/19973
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad947ae2cd541d3407455b218c2b352b9a373718
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19973
to look at the new patch set (#2).
Change subject: soc/baytrail: add ACPI method to generate USB port info
......................................................................
soc/baytrail: add ACPI method to generate USB port info
Add ACPI method GPLD to generate port location data when
passed visiblity info. Will be used by _PLD method in
board-specific USB .asl files.
Change-Id: Iad947ae2cd541d3407455b218c2b352b9a373718
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/soc/intel/baytrail/acpi/xhci.asl
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/19973/2
--
To view, visit https://review.coreboot.org/19973
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad947ae2cd541d3407455b218c2b352b9a373718
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19968
to look at the new patch set (#2).
Change subject: soc/broadwell: add missing USB port defs
......................................................................
soc/broadwell: add missing USB port defs
Add device/address stubs for XHCI USB ports 7/8, 10-15.
Stub data will be supplemented by board-specific info
added in subsequent commits.
Change-Id: Ice86bd226a70bd5996430e7a68a026cc825ba187
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/soc/intel/broadwell/acpi/xhci.asl
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/19968/2
--
To view, visit https://review.coreboot.org/19968
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ice86bd226a70bd5996430e7a68a026cc825ba187
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/19968 )
Change subject: soc/broadwell: add missing USB port defs
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19968/1/src/soc/intel/broadwell/acpi/xhci.a…
File src/soc/intel/broadwell/acpi/xhci.asl:
PS1, Line 358: // How many are there?
> remove?
done
--
To view, visit https://review.coreboot.org/19968
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice86bd226a70bd5996430e7a68a026cc825ba187
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19965 )
Change subject: sb/lynxpoint: add missing USB port defs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/19965
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d2f93351435cccd62e8fe4d95ad3467aa09de69
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No