coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: cr50: check if the new image needs to be enabled and act on it
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18946 ) Change subject: cr50: check if the new image needs to be enabled and act on it ...................................................................... Patch Set 7: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/53231/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/9052/ : SUCCESS -- To view, visit https://review.coreboot.org/18946 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45fd6058c03f32ff8edccd56ca2aa5359d9b21b1 Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: cr50: check if the new image needs to be enabled and act on it
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18946 ) Change subject: cr50: check if the new image needs to be enabled and act on it ...................................................................... Patch Set 6: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/53228/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/9050/ : SUCCESS -- To view, visit https://review.coreboot.org/18946 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45fd6058c03f32ff8edccd56ca2aa5359d9b21b1 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/google/chromeec: provide reboot function
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19573 ) Change subject: ec/google/chromeec: provide reboot function ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53229/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9051/ : SUCCESS -- To view, visit https://review.coreboot.org/19573 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1458bd7119b0df626a043ff3806c15ffb5446c9a Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: cr50: check if the new image needs to be enabled and act on it
by Furquan Shaikh (Code Review) 05 May '17

05 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18946 ) Change subject: cr50: check if the new image needs to be enabled and act on it ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/18946/6/src/vendorcode/google/chromeos/cr50… File src/vendorcode/google/chromeos/cr50_enable_update.c: PS6, Line 59: poweroff Not all boards provide poweroff? -- To view, visit https://review.coreboot.org/18946 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45fd6058c03f32ff8edccd56ca2aa5359d9b21b1 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: ec/google/chromeec: provide reboot function
by Furquan Shaikh (Code Review) 05 May '17

05 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19573 ) Change subject: ec/google/chromeec: provide reboot function ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/19573 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1458bd7119b0df626a043ff3806c15ffb5446c9a Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/google/chromeec: provide reboot function
by Furquan Shaikh (Code Review) 05 May '17

05 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19573 ) Change subject: ec/google/chromeec: provide reboot function ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19573/1/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c: PS1, Line 205: int > As it turns out I can just return google_chromeec_command()'s return value. Yes, that makes sense. -- To view, visit https://review.coreboot.org/19573 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1458bd7119b0df626a043ff3806c15ffb5446c9a Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/lenovo/*/romstage: Remove COMA IO port
by Arthur Heymans (Code Review) 05 May '17

05 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19571 ) Change subject: mb/lenovo/*/romstage: Remove COMA IO port ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/19571/1//COMMIT_MSG Commit Message: PS1, Line 9: neither do : they have working dock support. Docks used to feature superio/serial port but is this really relevant here? Sidenote: you might want to look at vendor dsdt for dock ACPI events. -- To view, visit https://review.coreboot.org/19571 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7e818f87e70e3f559d0769ccde89c35da961d6 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: ec/google/chromeec: provide reboot function
by Furquan Shaikh (Code Review) 05 May '17

05 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19573 ) Change subject: ec/google/chromeec: provide reboot function ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19573/1/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c: PS1, Line 205: int do we need a return value since we returning 0 always? -- To view, visit https://review.coreboot.org/19573 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1458bd7119b0df626a043ff3806c15ffb5446c9a Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel XDCI code support
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19428 ) Change subject: soc/intel/common/block: Add Intel XDCI code support ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53227/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9049/ : SUCCESS -- To view, visit https://review.coreboot.org/19428 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cbc686a00c26b92be2847b6bd6c2e5aa5a690f7 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Use XDCI common code
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19429 ) Change subject: soc/intel/apollolake: Use XDCI common code ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53226/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9048/ : SUCCESS -- To view, visit https://review.coreboot.org/19429 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4649bffe1bb90d7df6a72b5334793bf8f0fdbaeb Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017