coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: amd/pi/mainboards: Consolidate early duplicated code
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18434 ) Change subject: amd/pi/mainboards: Consolidate early duplicated code ...................................................................... Patch Set 18: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53244/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9064/ : SUCCESS -- To view, visit https://review.coreboot.org/18434 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id10580ecc439df10df26ca99881772f328e7bdd0 Gerrit-PatchSet: 18 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi: Re-factor spi_crop_chunk
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19386 ) Change subject: drivers/spi: Re-factor spi_crop_chunk ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53241/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9061/ : SUCCESS -- To view, visit https://review.coreboot.org/19386 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81c199413f879c664682088e93bfa3f91c6a46e5 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: vendorcode/amd/pi/00670F00: Clarify CAR disable
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18492 ) Change subject: vendorcode/amd/pi/00670F00: Clarify CAR disable ...................................................................... Patch Set 16: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53243/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9063/ : SUCCESS -- To view, visit https://review.coreboot.org/18492 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77e53262212e00bce9145b0bc3909ad8651f2328 Gerrit-PatchSet: 16 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Zheng Bao <fishbaozi(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi/00670F00: Add AMD PSP support for Stoney Ridge
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19157 ) Change subject: amd/pi/00670F00: Add AMD PSP support for Stoney Ridge ...................................................................... Patch Set 18: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53242/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9062/ : SUCCESS -- To view, visit https://review.coreboot.org/19157 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf111470b261d6516b878e88be471967abe681b3 Gerrit-PatchSet: 18 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Provide common block fast_spi_flash_ctrlr
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19575 ) Change subject: soc/intel/common: Provide common block fast_spi_flash_ctrlr ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53240/ : SUCCESS -- To view, visit https://review.coreboot.org/19575 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7228ae885018d1e23e6e80dd8ce227b0d99d84a6 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi/00670F00: Add AMD PSP support for Stoney Ridge
by Marshall Dawson (Code Review) 05 May '17

05 May '17

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19157 ) Change subject: amd/pi/00670F00: Add AMD PSP support for Stoney Ridge ...................................................................... Patch Set 14: (2 comments) https://review.coreboot.org/#/c/19157/17//COMMIT_MSG Commit Message: Line 7: amd/pi/00670F00: Add AMD PSP support for Stoney Ridge > This change touches agesawrapper.c file and moving amd_initcpuio() affects Sorry, I must have missed the request -- I thought I suggested the possibility and don't recall any interest. Split done. https://review.coreboot.org/#/c/19157/14/src/northbridge/amd/pi/00670F00/ps… File src/northbridge/amd/pi/00670F00/psp.c: Line 196: status_to_string(cmd_status)); > Sure, displayed error _string_ will change since you have different cmd_sta It don't see any commands that should expect anything coming back in header.status. I'll change the function to report it only if the PSP modifies the value.. -- To view, visit https://review.coreboot.org/19157 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf111470b261d6516b878e88be471967abe681b3 Gerrit-PatchSet: 14 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: amd/pi: Relocate amd_initcpuio
by Marshall Dawson (Code Review) 05 May '17

05 May '17

Marshall Dawson has uploaded a new change for review. ( https://review.coreboot.org/19574 ) Change subject: amd/pi: Relocate amd_initcpuio ...................................................................... amd/pi: Relocate amd_initcpuio Move amd_initcpuio() to the end of amdinitpost(). A subsequent patch will use this to communicate to the PSP. Change-Id: I3ec97d9b4ce4f58c3931068213c5dc7109d39397 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/northbridge/amd/pi/agesawrapper.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/19574/1 diff --git a/src/northbridge/amd/pi/agesawrapper.c b/src/northbridge/amd/pi/agesawrapper.c index 0afd0ca..f7515c0 100644 --- a/src/northbridge/amd/pi/agesawrapper.c +++ b/src/northbridge/amd/pi/agesawrapper.c @@ -172,6 +172,9 @@ /* Initialize heap space */ EmptyHeap(); + /* Enable MMIO on AMD CPU Address Map Controller */ + amd_initcpuio(); + return status; } @@ -245,9 +248,6 @@ AGESA_STATUS status; AMD_INTERFACE_PARAMS AmdParamStruct; AMD_MID_PARAMS *MidParam; - - /* Enable MMIO on AMD CPU Address Map Controller */ - amd_initcpuio (); LibAmdMemFill (&AmdParamStruct, 0, -- To view, visit https://review.coreboot.org/19574 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3ec97d9b4ce4f58c3931068213c5dc7109d39397 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: drivers/spi: Re-factor spi_crop_chunk
by Furquan Shaikh (Code Review) 05 May '17

05 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19386 ) Change subject: drivers/spi: Re-factor spi_crop_chunk ...................................................................... Patch Set 2: (6 comments) https://review.coreboot.org/#/c/19386/2//COMMIT_MSG Commit Message: PS2, Line 14: Size of 0 indicates any transfer size is fine > Dot/period at end of sentence. Done PS2, Line 17: ). > Switch the ) and .. Done PS2, Line 13: 1. max_xfer_size: Maximum transfer size supported by the controller : (Size of 0 indicates any transfer size is fine) : 2. deduct_cmd_len: Whether cmd_len needs to be deducted from the : max_xfer_size to determine max data size that can be : transferred. (This is used by the amd boards). > Add a line break to make the enumeration more visible? Done https://review.coreboot.org/#/c/19386/2/src/include/spi-generic.h File src/include/spi-generic.h: PS2, Line 91: contoller > you can fix this tipo while here :) Done PS2, Line 99: (0 = No limit) > what about using UINTMAX_MAX for no limit to make it more explicit? Done PS2, Line 113: deduct_cmd_len > thinking about someone implementing a new SPI controller using max_xfer_siz I have added an assert in spi_crop_chunk to ensure that max_xfer_size is not 0 for the controllers that require use of the crop chunk. -- To view, visit https://review.coreboot.org/19386 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81c199413f879c664682088e93bfa3f91c6a46e5 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: drivers/pc80/tpm: Refactor init_tpm() implementation
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19555 ) Change subject: drivers/pc80/tpm: Refactor init_tpm() implementation ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53237/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9058/ : SUCCESS -- To view, visit https://review.coreboot.org/19555 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c51ce402f43466e211bc1990335fd320d685829 Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Provide common block fast_spi_flash_ctrlr
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19575 ) Change subject: soc/intel/common: Provide common block fast_spi_flash_ctrlr ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53239/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/9060/ : SUCCESS -- To view, visit https://review.coreboot.org/19575 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7228ae885018d1e23e6e80dd8ce227b0d99d84a6 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017