Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19575 )
Change subject: soc/intel/common: Provide common block fast_spi_flash_ctrlr
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/19575/2/src/soc/intel/common/block/fast_spi…
File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:
Line 354: const struct spi_ctrlr fast_spi_flash_ctrlr = {
> Did we want to test that cs == 0 like the prev ->setup() routines?
Yeah, I was thinking about that too, but did not add that since we are allowing SoCs to provide bus-ctrlr mapping. I will add it back.
Maybe we should have a config option which says SPI_FLASH_BUS and have that check? In fact that SPI_FLASH_BUS can be used within coreboot at a number of places.
--
To view, visit https://review.coreboot.org/19575
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7228ae885018d1e23e6e80dd8ce227b0d99d84a6
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19567 )
Change subject: intelmetool: Use correct type for pointer
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/19567
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8d778e97090668ad9308a82b44c6b2b599fd6c3
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Wise (Debian) <pabs(a)debian.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No