coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: qemu/vexpress-a9: Discover RAM size.
by Vladimir Serbinenko (Code Review) 12 May '17

12 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/13754 to look at the new patch set (#6). Change subject: qemu/vexpress-a9: Discover RAM size. ...................................................................... qemu/vexpress-a9: Discover RAM size. Probe RAM to find its size instead of hardcoding 1024M. Also properly export it to memory map. Change-Id: Ib411f0a068bd247a9e0cd0a59689a3896921483e Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- M src/mainboard/emulation/qemu-armv7/Kconfig M src/mainboard/emulation/qemu-armv7/cbmem.c A src/mainboard/emulation/qemu-armv7/mainboard.c A src/mainboard/emulation/qemu-armv7/mainboard.h 4 files changed, 108 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/13754/6 -- To view, visit https://review.coreboot.org/13754 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib411f0a068bd247a9e0cd0a59689a3896921483e Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intel/common: drop duplicate initializer
by Patrick Georgi (Code Review) 12 May '17

12 May '17

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/19656 ) Change subject: intel/common: drop duplicate initializer ...................................................................... intel/common: drop duplicate initializer Change-Id: I99d0bd7d9b897a10edce35316e095e0223522c54 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Found-by: clang Reviewed-on: https://review.coreboot.org/19656 Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Andrey Petrov <andrey.petrov(a)intel.com> Reviewed-by: Edward O'Callaghan <quasisec(a)google.com> Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Andrey Petrov: Looks good to me, approved Aaron Durbin: Looks good to me, approved Philippe Mathieu-Daudé: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, but someone else must approve build bot (Jenkins): Verified diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index 5c136df..1990cd1 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -464,7 +464,6 @@ .read_resources = pci_dev_read_resources, .enable_resources = pci_dev_enable_resources, .init = pci_dev_init, - .enable_resources = pci_dev_enable_resources }; static const struct pci_driver cse_driver __pci_driver = { -- To view, visit https://review.coreboot.org/19656 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d0bd7d9b897a10edce35316e095e0223522c54 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: xcompile: silence clang when referencing packed structs' mem...
by Patrick Georgi (Code Review) 12 May '17

12 May '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/19659 ) Change subject: xcompile: silence clang when referencing packed structs' members ...................................................................... Patch Set 1: > Hi Patrick, which job/file is that? Isn't it safer to remove this > warning locally instead of the whole codebase? multiple locations, and it's bogus everywhere: if we use packed structs, it's because we expect a certain memory layout (and I know, modern C compilers needn't adhere to any reasonable interpretation of that). If we refer to any such element, it might not be aligned, we know, we don't care. -- To view, visit https://review.coreboot.org/19659 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5400f50d8b5b462270c700f7ff90d9d517278e71 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/storage: Delay after SD SWITCH operations
by Philippe Mathieu-Daudé (Code Review) 12 May '17

12 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19671 ) Change subject: drivers/storage: Delay after SD SWITCH operations ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19671/1/src/drivers/storage/sd.c File src/drivers/storage/sd.c: PS1, Line 139: int delay can be const -- To view, visit https://review.coreboot.org/19671 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I938e227a142e43ed6afda80d56af90df0bae1b05 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: vexpress: add gfx init
by Philippe Mathieu-Daudé (Code Review) 12 May '17

12 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/13749 ) Change subject: vexpress: add gfx init ...................................................................... Patch Set 7: Code-Review-1 (2 comments) I put a -1 to wait your reply about memory barrier. https://review.coreboot.org/#/c/13749/7/src/mainboard/emulation/qemu-armv7/… File src/mainboard/emulation/qemu-armv7/mainboard.c: PS7, Line 32: uint32_t * shouldn't this be volatile? PS7, Line 33: pl111[0] = (width / 4) - 4; why not better use the safer write32() from <arch/io.h> which use memory barriers? (same following lines) -- To view, visit https://review.coreboot.org/13749 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eff29b74d7df331dcbf2c25799eaae4911e54fc Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: drivers/pc80/rtc: Rename mc146818rtc_early.c -> _romcc.c
by Philippe Mathieu-Daudé (Code Review) 12 May '17

12 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19663 ) Change subject: drivers/pc80/rtc: Rename mc146818rtc_early.c -> _romcc.c ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/19663 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ea08de034766c8140b320075d36d5e811582fa Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Reviewer: lava.coreboot.org <lavacoreboot(a)gmail.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/common: drop duplicate initializer
by Philippe Mathieu-Daudé (Code Review) 12 May '17

12 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19656 ) Change subject: intel/common: drop duplicate initializer ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/19656 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99d0bd7d9b897a10edce35316e095e0223522c54 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: toolchain.inc: Use -Wstack-usage only on gcc
by Philippe Mathieu-Daudé (Code Review) 12 May '17

12 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19657 ) Change subject: toolchain.inc: Use -Wstack-usage only on gcc ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/19657/1/toolchain.inc File toolchain.inc: PS1, Line 82: ifeq ($(CONFIG_COMPILER_GCC),y) what about commenting here something like "restrict to GCC, not supported with Clang"? (improved) -- To view, visit https://review.coreboot.org/19657 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c22171dedc77df24e739ec26335010f0f443963 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: arch/arm64: Use variables of the right size for msr/mrs opcodes
by Philippe Mathieu-Daudé (Code Review) 12 May '17

12 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19661 ) Change subject: arch/arm64: Use variables of the right size for msr/mrs opcodes ...................................................................... Patch Set 1: Code-Review-1 (5 comments) https://review.coreboot.org/#/c/19661/1/src/arch/arm64/armv8/lib/clock.c File src/arch/arm64/armv8/lib/clock.c: PS1, Line 24: uint32_t Clang appears to be right, why not use use(uint64_t freq)? it seems cleaner to me. https://review.coreboot.org/#/c/19661/1/src/arch/arm64/armv8/lib/pstate.c File src/arch/arm64/armv8/lib/pstate.c: PS1, Line 51: uint32_t same here, uint64_t arg PS1, Line 199: uint32_t and here uint64_t fpcr PS1, Line 229: uint32_t also here uint64_t nzcv PS1, Line 287: uint32_t here, and many following ;) -- To view, visit https://review.coreboot.org/19661 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c8b9fe3a1adc521e393c2e2a0216f7f425a2a3e Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: xcompile: silence clang when referencing packed structs' mem...
by Philippe Mathieu-Daudé (Code Review) 12 May '17

12 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19659 ) Change subject: xcompile: silence clang when referencing packed structs' members ...................................................................... Patch Set 1: Hi Patrick, which job/file is that? Isn't it safer to remove this warning locally instead of the whole codebase? -- To view, visit https://review.coreboot.org/19659 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5400f50d8b5b462270c700f7ff90d9d517278e71 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017