coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: nb/intel/gm45: Add romstage timestamps
by Philippe Mathieu-Daudé (Code Review) 13 May '17

13 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19678 ) Change subject: nb/intel/gm45: Add romstage timestamps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/19678 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I558e6c63caf95ec5279ec5a866b54fb199116469 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: xcompile: silence clang when referencing packed structs' mem...
by Philippe Mathieu-Daudé (Code Review) 13 May '17

13 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19659 ) Change subject: xcompile: silence clang when referencing packed structs' members ...................................................................... Patch Set 1: Code-Review-1 > multiple locations, and it's bogus everywhere: if we use packed > structs, it's because we expect a certain memory layout (and I > know, modern C compilers needn't adhere to any reasonable > interpretation of that). If we refer to any such element, it might > not be aligned, we know, we don't care. I agree x86 and armv7 don't care (on armv7 as long as it does not cross memory map boundaries), however armv4 and mips do care. I don't know about riscv/power. That's why I wonder where clang reported this warning. Maybe it worths disabling it checking $SUBARCH not matching arm-armv4 and mips*-mips? -- To view, visit https://review.coreboot.org/19659 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5400f50d8b5b462270c700f7ff90d9d517278e71 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x: Fix uninitialized variable issue
by build bot (Jenkins) (Code Review) 13 May '17

13 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19680 ) Change subject: nb/intel/x4x: Fix uninitialized variable issue ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9381/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53591/ : SUCCESS -- To view, visit https://review.coreboot.org/19680 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee2beda30d8c74df0f412622c3ff3357819e386b Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/*/romstage: Remove COM IO port
by build bot (Jenkins) (Code Review) 13 May '17

13 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19571 ) Change subject: mb/lenovo/*/romstage: Remove COM IO port ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9380/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53590/ : SUCCESS -- To view, visit https://review.coreboot.org/19571 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7e818f87e70e3f559d0769ccde89c35da961d6 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x: Fix uninitialized variable issue
by Philippe Mathieu-Daudé (Code Review) 13 May '17

13 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19680 ) Change subject: nb/intel/x4x: Fix uninitialized variable issue ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/19680 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee2beda30d8c74df0f412622c3ff3357819e386b Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/*/romstage: Remove COM IO port
by Patrick Rudolph (Code Review) 13 May '17

13 May '17

Hello Arthur Heymans, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19571 to look at the new patch set (#2). Change subject: mb/lenovo/*/romstage: Remove COM IO port ...................................................................... mb/lenovo/*/romstage: Remove COM IO port All those boards do not have a serial port. Don't attempt to decode the COMA/COMB IO range. Change-Id: Ide7e818f87e70e3f559d0769ccde89c35da961d6 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/lenovo/l520/romstage.c M src/mainboard/lenovo/s230u/romstage.c M src/mainboard/lenovo/t420/romstage.c M src/mainboard/lenovo/t420s/romstage.c M src/mainboard/lenovo/t430s/romstage.c M src/mainboard/lenovo/t520/romstage.c M src/mainboard/lenovo/t530/romstage.c M src/mainboard/lenovo/x1_carbon_gen1/romstage.c M src/mainboard/lenovo/x220/romstage.c M src/mainboard/lenovo/x230/romstage.c 10 files changed, 9 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/19571/2 -- To view, visit https://review.coreboot.org/19571 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide7e818f87e70e3f559d0769ccde89c35da961d6 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/cbmem: mmap underflow on low addresses
by build bot (Jenkins) (Code Review) 13 May '17

13 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19679 ) Change subject: util/cbmem: mmap underflow on low addresses ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53589/ : SUCCESS -- To view, visit https://review.coreboot.org/19679 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32b0c15b2f1aa43fc57656d5d2d5f0e4e90e94ef Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbmem: mmap underflow on low addresses
by Patrick Georgi (Code Review) 13 May '17

13 May '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/19679 ) Change subject: util/cbmem: mmap underflow on low addresses ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19679 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32b0c15b2f1aa43fc57656d5d2d5f0e4e90e94ef Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x: Remove stale, redundant, buggy write
by build bot (Jenkins) (Code Review) 13 May '17

13 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19680 ) Change subject: nb/intel/x4x: Remove stale, redundant, buggy write ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53588/ : SUCCESS -- To view, visit https://review.coreboot.org/19680 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee2beda30d8c74df0f412622c3ff3357819e386b Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x: Remove stale, redundant, buggy write
by build bot (Jenkins) (Code Review) 13 May '17

13 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19680 ) Change subject: nb/intel/x4x: Remove stale, redundant, buggy write ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53587/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/9379/ : SUCCESS -- To view, visit https://review.coreboot.org/19680 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee2beda30d8c74df0f412622c3ff3357819e386b Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017