coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: mb/lenovo/t430: Fix PCIe hot-plug ports
by Patrick Rudolph (Code Review) 31 May '17

31 May '17

Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/19928 ) Change subject: mb/lenovo/t430: Fix PCIe hot-plug ports ...................................................................... mb/lenovo/t430: Fix PCIe hot-plug ports Port 0 is connected to SD-card reader. Don't mark it as hot-plugable. Change-Id: I5d3d4c7541683a6c09aac47ca251a6dad23ad1ab Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Reviewed-on: https://review.coreboot.org/19928 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/lenovo/t430/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Arthur Heymans: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index 86c8756..0a121b7 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -47,7 +47,7 @@ register "gpi13_routing" = "2" register "gpi1_routing" = "2" register "p_cnt_throttling_supported" = "1" - register "pcie_hotplug_map" = "{ 1, 0, 1, 0, 0, 0, 0, 0 }" + register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 0, 0, 0, 0 }" register "pcie_port_coalesce" = "1" register "sata_interface_speed_support" = "0x3" register "sata_port_map" = "0x17" -- To view, visit https://review.coreboot.org/19928 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d3d4c7541683a6c09aac47ca251a6dad23ad1ab Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb: Use register name and fix regist...
by build bot (Jenkins) (Code Review) 31 May '17

31 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19954 ) Change subject: sb/intel/bd82x6x/early_usb: Use register name and fix register lock ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/54633/ : SUCCESS -- To view, visit https://review.coreboot.org/19954 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f2f3f196c12489613333ab9f6098443edda927f Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/arm/include/armv7/arch: Correct keyword organization in...
by build bot (Jenkins) (Code Review) 31 May '17

31 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19991 ) Change subject: arch/arm/include/armv7/arch: Correct keyword organization in cpu.h ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/54632/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/10345/ : SUCCESS -- To view, visit https://review.coreboot.org/19991 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibacc5ee9fabff7fec2abd5534312cf3ab1bb28cf Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb: Use register name and fix regist...
by Patrick Rudolph (Code Review) 31 May '17

31 May '17

Hello Philippe Mathieu-Daudé, Arthur Heymans, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19954 to look at the new patch set (#3). Change subject: sb/intel/bd82x6x/early_usb: Use register name and fix register lock ...................................................................... sb/intel/bd82x6x/early_usb: Use register name and fix register lock Use register name instead of magic value. Only reset previously set bit instead of all bits. Change-Id: I4f2f3f196c12489613333ab9f6098443edda927f Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/southbridge/intel/bd82x6x/early_usb.c M src/southbridge/intel/bd82x6x/pch.h 2 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/19954/3 -- To view, visit https://review.coreboot.org/19954 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4f2f3f196c12489613333ab9f6098443edda927f Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intel/bakersport_fsp: Move into bayleybay_fsp as a variant
by Philipp Deppenwiese (Code Review) 31 May '17

31 May '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19077 ) Change subject: intel/bakersport_fsp: Move into bayleybay_fsp as a variant ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19077 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5712c1b399570bd7ab7fc9e42af25fbf15a0ba78 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Lee Leahy Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/arm/include/armv7/arch: Correct keyword organization in...
by Logan Carlson (Code Review) 31 May '17

31 May '17

Hello Philippe Mathieu-Daudé, Stefan Reinauer, Philipp Deppenwiese, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19991 to look at the new patch set (#2). Change subject: arch/arm/include/armv7/arch: Correct keyword organization in cpu.h ...................................................................... arch/arm/include/armv7/arch: Correct keyword organization in cpu.h Move the inline keyword in between the static keyword and the return type. Change-Id: Ibacc5ee9fabff7fec2abd5534312cf3ab1bb28cf Signed-off-by: Logan Carlson <logancarlson(a)google.com> --- M src/arch/arm/include/armv7/arch/cpu.h 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/19991/2 -- To view, visit https://review.coreboot.org/19991 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibacc5ee9fabff7fec2abd5534312cf3ab1bb28cf Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: arch/arm: Correct checkpatch errors
by Philipp Deppenwiese (Code Review) 31 May '17

31 May '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19989 ) Change subject: arch/arm: Correct checkpatch errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19989 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74b68f485adff1e6f0fa433e51e12b59ccea654b Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/arm/include/armv7/arch: Correct keyword organization in...
by Philipp Deppenwiese (Code Review) 31 May '17

31 May '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19991 ) Change subject: arch/arm/include/armv7/arch: Correct keyword organization in cpu.h ...................................................................... Patch Set 1: Code-Review-1 Hey, you forgot the last inline static ;) -- To view, visit https://review.coreboot.org/19991 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibacc5ee9fabff7fec2abd5534312cf3ab1bb28cf Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/amd/quadcore: Correct checkpatch errors
by Logan Carlson (Code Review) 31 May '17

31 May '17

Logan Carlson has abandoned this change. ( https://review.coreboot.org/19990 ) Change subject: cpu/amd/quadcore: Correct checkpatch errors ...................................................................... Abandoned Duplicated corrections from patch 19987. -- To view, visit https://review.coreboot.org/19990 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Idc48d1177db474649cddd8a2f496e330eaabb113 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mc_tcu3: Remove all hwinfo files from mainboard directory
by Werner Zeh (Code Review) 31 May '17

31 May '17

Werner Zeh has submitted this change and it was merged. ( https://review.coreboot.org/19982 ) Change subject: mc_tcu3: Remove all hwinfo files from mainboard directory ...................................................................... mc_tcu3: Remove all hwinfo files from mainboard directory To unify the hwinfo handling along all Siemens MC boards the hwinfo files have to be removed from the mainboard directory. They will be added to cbfs in site-local/Makefile.inc. Change-Id: Ia3dcb2e0118527b37aed872740273c4fa7004aef Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> Reviewed-on: https://review.coreboot.org/19982 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_tcu3/Makefile.inc D src/mainboard/siemens/mc_tcu3/hwinfo.hex D src/mainboard/siemens/mc_tcu3/hwinfo10.hex D src/mainboard/siemens/mc_tcu3/hwinfo12.hex D src/mainboard/siemens/mc_tcu3/hwinfo15.hex D src/mainboard/siemens/mc_tcu3/hwinfo19.hex 6 files changed, 1 insertion(+), 21 deletions(-) Approvals: Mario Scheithauer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/siemens/mc_tcu3/Makefile.inc b/src/mainboard/siemens/mc_tcu3/Makefile.inc index 2922eef..05b4e60 100644 --- a/src/mainboard/siemens/mc_tcu3/Makefile.inc +++ b/src/mainboard/siemens/mc_tcu3/Makefile.inc @@ -2,6 +2,7 @@ ## This file is part of the coreboot project. ## ## Copyright (C) 2013 Google Inc. +## Copyright (C) 2017 Siemens AG ## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by @@ -17,24 +18,3 @@ ramstage-y += irqroute.c ramstage-y += lcd_panel.c ramstage-y += ptn3460.c - -cbfs-files-y += hwinfo.hex -hwinfo.hex-file := hwinfo.hex -hwinfo.hex-type := raw -hwinfo.hex-align := 0x1000 - -cbfs-files-y += hwinfo10.hex -hwinfo10.hex-file := hwinfo10.hex -hwinfo10.hex-type := raw - -cbfs-files-y += hwinfo12.hex -hwinfo12.hex-file := hwinfo12.hex -hwinfo12.hex-type := raw - -cbfs-files-y += hwinfo15.hex -hwinfo15.hex-file := hwinfo15.hex -hwinfo15.hex-type := raw - -cbfs-files-y += hwinfo19.hex -hwinfo19.hex-file := hwinfo19.hex -hwinfo19.hex-type := raw diff --git a/src/mainboard/siemens/mc_tcu3/hwinfo.hex b/src/mainboard/siemens/mc_tcu3/hwinfo.hex deleted file mode 100644 index bbf6783..0000000 --- a/src/mainboard/siemens/mc_tcu3/hwinfo.hex +++ /dev/null Binary files differ diff --git a/src/mainboard/siemens/mc_tcu3/hwinfo10.hex b/src/mainboard/siemens/mc_tcu3/hwinfo10.hex deleted file mode 100644 index 390c6b4..0000000 --- a/src/mainboard/siemens/mc_tcu3/hwinfo10.hex +++ /dev/null Binary files differ diff --git a/src/mainboard/siemens/mc_tcu3/hwinfo12.hex b/src/mainboard/siemens/mc_tcu3/hwinfo12.hex deleted file mode 100644 index 471af4f..0000000 --- a/src/mainboard/siemens/mc_tcu3/hwinfo12.hex +++ /dev/null Binary files differ diff --git a/src/mainboard/siemens/mc_tcu3/hwinfo15.hex b/src/mainboard/siemens/mc_tcu3/hwinfo15.hex deleted file mode 100644 index 4cbbe5b..0000000 --- a/src/mainboard/siemens/mc_tcu3/hwinfo15.hex +++ /dev/null Binary files differ diff --git a/src/mainboard/siemens/mc_tcu3/hwinfo19.hex b/src/mainboard/siemens/mc_tcu3/hwinfo19.hex deleted file mode 100644 index f8510fc..0000000 --- a/src/mainboard/siemens/mc_tcu3/hwinfo19.hex +++ /dev/null Binary files differ -- To view, visit https://review.coreboot.org/19982 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3dcb2e0118527b37aed872740273c4fa7004aef Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
389
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017