coreboot-gerrit March 2017

coreboot-gerrit@coreboot.org

1 participants
2925 discussions

Change in coreboot[master]: soc/intel/skylake: Clean up code by using common System Agen...
by Subrata Banik (Code Review) 28 Mar '17

28 Mar '17

Hello Aaron Durbin, Pratikkumar V Prajapati, Barnali Sarkar, dhaval v sharma, Balaji Manigandan, Paul Menzel, build bot (Jenkins), Hannah Williams, Pratikkumar Prajapati, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18566 to look at the new patch set (#18). Change subject: soc/intel/skylake: Clean up code by using common System Agent module ...................................................................... soc/intel/skylake: Clean up code by using common System Agent module This patch currently contains the SA initialization required for bootblock phase - 1. Use SOC_INTEL_COMMON_BLOCK_SA kconfig for common SA code. 2. Perform PCIEXBAR programming based on soc configurable PCIEX_LENGTH_xxxMB 3. Use common systemagent header file. Change-Id: I0fa0a60f680b9b00b7f26f1875c553612b123a8e Signed-off-by: Barnali Sarkar <barnali.sarkar(a)intel.com> Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/Makefile.inc D src/soc/intel/skylake/bootblock/systemagent.c M src/soc/intel/skylake/include/soc/bootblock.h M src/soc/intel/skylake/include/soc/iomap.h M src/soc/intel/skylake/include/soc/systemagent.h 6 files changed, 10 insertions(+), 60 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/18566/18 -- To view, visit https://review.coreboot.org/18566 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0fa0a60f680b9b00b7f26f1875c553612b123a8e Gerrit-PatchSet: 18 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/common/block: Add cache as ram init and teardown code
by Subrata Banik (Code Review) 28 Mar '17

28 Mar '17

Hello Aaron Durbin, Barnali Sarkar, dhaval v sharma, Balaji Manigandan, Paul Menzel, Rizwan Qureshi, build bot (Jenkins), Hannah Williams, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18381 to look at the new patch set (#37). Change subject: soc/intel/common/block: Add cache as ram init and teardown code ...................................................................... soc/intel/common/block: Add cache as ram init and teardown code Create sample model for common car init and teardown programming. TEST=Booted Reef, KCRD/EVE, GLKRVP with CAR_CQOS, CAR_NEM_ENHANCED and CAR_NEM configs till post code 0x2a. Change-Id: Iffd0c3e3ca81a3d283d5f1da115222a222e6b157 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/drivers/intel/fsp1_1/after_raminit.S A src/soc/intel/common/block/cpu/Kconfig A src/soc/intel/common/block/cpu/Makefile.inc A src/soc/intel/common/block/cpu/car/cache_as_ram.S A src/soc/intel/common/block/cpu/car/exit_car.S M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/Makefile.inc D src/soc/intel/skylake/bootblock/cache_as_ram.S D src/soc/intel/skylake/include/soc/car_teardown.S M src/soc/intel/skylake/romstage/car_stage_fsp20.S 10 files changed, 601 insertions(+), 341 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/18381/37 -- To view, visit https://review.coreboot.org/18381 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iffd0c3e3ca81a3d283d5f1da115222a222e6b157 Gerrit-PatchSet: 37 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/apollolake: Clean up code by using common CAR init
by Subrata Banik (Code Review) 28 Mar '17

28 Mar '17

Hello Aaron Durbin, Barnali Sarkar, Paul Menzel, build bot (Jenkins), Furquan Shaikh, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18555 to look at the new patch set (#24). Change subject: soc/intel/apollolake: Clean up code by using common CAR init ...................................................................... soc/intel/apollolake: Clean up code by using common CAR init This patch currently contains common CAR initialization required in bootblock phase along with common MSR header - 1. Use SOC_INTEL_COMMON_BLOCK_CAR to have common CAR initialization and CAR teardown. 2. Use common MSR header "intelblocks/msr.h" inside soc/cpu.h Change-Id: I67f909f50a24f009b3e35388665251be1dde40f7 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/Makefile.inc D src/soc/intel/apollolake/bootblock/cache_as_ram.S D src/soc/intel/apollolake/exit_car.S M src/soc/intel/apollolake/include/soc/cpu.h 5 files changed, 17 insertions(+), 385 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/18555/24 -- To view, visit https://review.coreboot.org/18555 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I67f909f50a24f009b3e35388665251be1dde40f7 Gerrit-PatchSet: 24 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: vboot: Move remaining features out of vendorcode/google/chro...
by build bot (Jenkins) (Code Review) 28 Mar '17

28 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18984 ) Change subject: vboot: Move remaining features out of vendorcode/google/chromeos ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50838/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6815/ : SUCCESS -- To view, visit https://review.coreboot.org/18984 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e2e31150ebf5a96b6fe507ebeb53a41ecf88122 Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: Remove libverstage as separate library and source file class
by build bot (Jenkins) (Code Review) 28 Mar '17

28 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18302 ) Change subject: Remove libverstage as separate library and source file class ...................................................................... Patch Set 13: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50839/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6816/ : SUCCESS -- To view, visit https://review.coreboot.org/18302 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb84a9bf1cd54f2e02ca1f665740a9c88d88df4 Gerrit-PatchSet: 13 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Disallow separate verstage after romstage, try to cla...
by build bot (Jenkins) (Code Review) 28 Mar '17

28 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18983 ) Change subject: vboot: Disallow separate verstage after romstage, try to clarify logic ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50837/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6814/ : SUCCESS -- To view, visit https://review.coreboot.org/18983 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf60040af4eff711d9b80ee0e5950ce05958b3aa Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: chromeos / broadwell / jecht: Make save_chromeos_gpios() jec...
by build bot (Jenkins) (Code Review) 28 Mar '17

28 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18981 ) Change subject: chromeos / broadwell / jecht: Make save_chromeos_gpios() jecht-specific ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50835/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6813/ : SUCCESS -- To view, visit https://review.coreboot.org/18981 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cf67a75a052d1c86eda0393b6a9fbbe255fedf8 Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT
by build bot (Jenkins) (Code Review) 28 Mar '17

28 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18982 ) Change subject: vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50836/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6812/ : SUCCESS -- To view, visit https://review.coreboot.org/18982 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83e1b3e0f34f75c2395b4c464651e373724b2e6 Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Code clean up to use soc/intel/common/...
by Subrata Banik (Code Review) 28 Mar '17

28 Mar '17

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18555 ) Change subject: soc/intel/apollolake: Code clean up to use soc/intel/common/block/cpu/car ...................................................................... Patch Set 23: (5 comments) https://review.coreboot.org/#/c/18555/23//COMMIT_MSG Commit Message: Line 7: soc/intel/apollolake: Code clean up to use soc/intel/common/block/cpu/car > What do you do with the *code clean-up*? Revert? Do? Done PS23, Line 9: This patch to address below programming > Sorry, I don’t understand that sentence. Maybe: Done PS23, Line 10: 1. Use SOC_INTEL_COMMON_BLOCK_CAR to have common CAR initialization : and CAR teardown. : 2. Use common MSR header "intelblocks/msr.h" inside soc/cpu.h > Could the commit be split up to have one commit for each one of the enumera sure paul, for future common code patch we will try to address this concern. https://review.coreboot.org/#/c/18555/23/src/soc/intel/apollolake/Kconfig File src/soc/intel/apollolake/Kconfig: Line 257: > Unrelated change. i don't understand this comments. did you mean why added new line? I think it was already there. https://github.com/coreboot/coreboot/blob/master/src/soc/intel/apollolake/K… PS23, Line 286: Tear Down > lowercase: tear down Done -- To view, visit https://review.coreboot.org/18555 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67f909f50a24f009b3e35388665251be1dde40f7 Gerrit-PatchSet: 23 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by def...
by build bot (Jenkins) (Code Review) 28 Mar '17

28 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18980 ) Change subject: vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by default ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50834/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6811/ : SUCCESS -- To view, visit https://review.coreboot.org/18980 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9cbaa7df530580a97f00ef238e3d9a8a86a4a7f Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2017