coreboot-gerrit March 2017

coreboot-gerrit@coreboot.org

1 participants
2925 discussions

Change in coreboot[master]: util/futility/Makefile: Update clean target
by Martin Roth (Code Review) 29 Mar '17

29 Mar '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/18998 ) Change subject: util/futility/Makefile: Update clean target ...................................................................... util/futility/Makefile: Update clean target - Fix clean target to pass if output doesn't exist - Make sure $(RM) is actually defined Change-Id: Ibcdb0e329084f58b27c3f53213a237d02c922a51 Signed-off-by: Martin Roth <gaumless(a)gmail.com> Reviewed-on: https://review.coreboot.org/18998 Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-by: Paul Kocialkowski <contact(a)paulk.fr> Tested-by: build bot (Jenkins) Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- M util/futility/Makefile 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Aaron Durbin: Looks good to me, approved Philippe Mathieu-Daudé: Looks good to me, but someone else must approve Paul Kocialkowski: Looks good to me, but someone else must approve Paul Menzel: Looks good to me, but someone else must approve build bot (Jenkins): Verified diff --git a/util/futility/Makefile b/util/futility/Makefile index 36f2b31..cce5da6 100644 --- a/util/futility/Makefile +++ b/util/futility/Makefile @@ -1,5 +1,6 @@ top ?= $(abspath ../..) objutil ?= $(top)/util +RM ?= rm HOSTCC ?= $(CC) VBOOT_SOURCE ?= $(top)/3rdparty/vboot @@ -9,8 +10,8 @@ .PHONY: clean clean: - $(RM) $(objutil)/futility/futility - $(RM) -r $(objutil)/futility/build + $(RM) -f $(objutil)/futility/futility + $(RM) -rf $(objutil)/futility/build distclean: clean -- To view, visit https://review.coreboot.org/18998 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcdb0e329084f58b27c3f53213a237d02c922a51 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: src/lib/jpeg: Fix missing closing brace
by build bot (Jenkins) (Code Review) 29 Mar '17

29 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19032 ) Change subject: src/lib/jpeg: Fix missing closing brace ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50900/ : SUCCESS -- To view, visit https://review.coreboot.org/19032 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/lib/jpeg: Fix missing closing brace
by Youness Alaoui (Code Review) 29 Mar '17

29 Mar '17

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19032 ) Change subject: src/lib/jpeg: Fix missing closing brace ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/19032/2//COMMIT_MSG Commit Message: Line 12: This was introduced in commit > Please use the short hash and put the summary in parenthesis after it. Done -- To view, visit https://review.coreboot.org/19032 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: src/lib/jpeg: Fix missing closing brace
by Youness Alaoui (Code Review) 29 Mar '17

29 Mar '17

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19032 to look at the new patch set (#3). Change subject: src/lib/jpeg: Fix missing closing brace ...................................................................... src/lib/jpeg: Fix missing closing brace There's a missing closing brace in fillbits function of jpeg.c which caused an avalanche of compilation errors. This was introduced in commit 491c5b60 (src/lib: Move assignment out of if condition) which was reviewed in gerrit at https://review.coreboot.org/18761 and it prevents coreboot from building when CONFIG_BOOTSPLASH is set. Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761 Signed-off-by: Youness Alaoui <youness.alaoui(a)puri.sm> --- M src/lib/jpeg.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/19032/3 -- To view, visit https://review.coreboot.org/19032 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: src/lib/jpeg: Fix missing closing brace
by Martin Roth (Code Review) 29 Mar '17

29 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19032 ) Change subject: src/lib/jpeg: Fix missing closing brace ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19032/1//COMMIT_MSG Commit Message: Line 18: that commit builds even though it didn't. > Ah! That explains it. I thought the buildbot was building multiple configur Agreed. We're trying. -- To view, visit https://review.coreboot.org/19032 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: src/lib/jpeg: Fix missing closing brace
by build bot (Jenkins) (Code Review) 29 Mar '17

29 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19032 ) Change subject: src/lib/jpeg: Fix missing closing brace ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50899/ : SUCCESS -- To view, visit https://review.coreboot.org/19032 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/lib/jpeg: Fix missing closing brace
by Youness Alaoui (Code Review) 28 Mar '17

28 Mar '17

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19032 ) Change subject: src/lib/jpeg: Fix missing closing brace ...................................................................... Patch Set 1: (3 comments) I've trimmed down the commit message and fixed the stuff you mentioned. https://review.coreboot.org/#/c/19032/1//COMMIT_MSG Commit Message: PS1, Line 7: accolade > Not sure if it's generally called like that? Oh, you're right, my mistake, I think it's "curly bracket" or "braces" in English. Accolade is a French term and I wasn't sure if it was correct, then forgot to check/confirm. PS1, Line 15: https://review.coreboot.org/18761 > Mentioning the upstream commit would be easier to follow and is less Good point, will do. Line 18: that commit builds even though it didn't. > It's only compiled with CONFIG_BOOTSPLASH being set. Ah! That explains it. I thought the buildbot was building multiple configurations to test most of the code coverage. I guess it doesn't. Might be good to change it. -- To view, visit https://review.coreboot.org/19032 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: src/lib/jpeg: Fix missing closing brace
by Youness Alaoui (Code Review) 28 Mar '17

28 Mar '17

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19032 to look at the new patch set (#2). Change subject: src/lib/jpeg: Fix missing closing brace ...................................................................... src/lib/jpeg: Fix missing closing brace There's a missing closing brace in fillbits function of jpeg.c which caused an avalanche of compilation errors. This was introduced in commit 491c5b60d01d5fa7d27c281335343e67519e799c which was reviewed in gerrit at https://review.coreboot.org/18761 and it prevents coreboot from building when CONFIG_BOOTSPLASH is set. Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761 Signed-off-by: Youness Alaoui <youness.alaoui(a)puri.sm> --- M src/lib/jpeg.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/19032/2 -- To view, visit https://review.coreboot.org/19032 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: src/lib/jpeg: Fix missing closing accolade
by build bot (Jenkins) (Code Review) 28 Mar '17

28 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19032 ) Change subject: src/lib/jpeg: Fix missing closing accolade ...................................................................... Patch Set 1: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50898/ : SUCCESS -- To view, visit https://review.coreboot.org/19032 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi/hudson: Add fanless SMU firmware to build
by build bot (Jenkins) (Code Review) 28 Mar '17

28 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19002 ) Change subject: amd/pi/hudson: Add fanless SMU firmware to build ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50897/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6871/ : SUCCESS -- To view, visit https://review.coreboot.org/19002 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib44860780c8d5fb00c47f775a2a83b82ff3e1821 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2017