coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: mb/google/fizz: Override IccMax settings
by Gaggery Tsai (Code Review) 28 Dec '17

28 Dec '17

Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/23020 ) Change subject: mb/google/fizz: Override IccMax settings ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c File src/mainboard/google/fizz/ramstage.c: https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.… PS1, Line 21: static void mainboard_setup_iccmax(config_t *conf) > should we move this code to skylake common code rather that board specific code? […] I think we can do some clean-up in vr_config.c since fsp 2.0 provides default well-defined settings for various SKUs. -- To view, visit https://review.coreboot.org/23020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ffe0cb73981850005b20fefb6664cfab74fbca Gerrit-Change-Number: 23020 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Dec 2017 14:06:46 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/fizz: Override IccMax settings
by Kane Chen (Code Review) 28 Dec '17

28 Dec '17

Kane Chen has posted comments on this change. ( https://review.coreboot.org/23020 ) Change subject: mb/google/fizz: Override IccMax settings ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c File src/mainboard/google/fizz/ramstage.c: https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.… PS1, Line 21: static void mainboard_setup_iccmax(config_t *conf) should we move this code to skylake common code rather that board specific code? thanks. https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.… PS1, Line 41: if else if thanks. -- To view, visit https://review.coreboot.org/23020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ffe0cb73981850005b20fefb6664cfab74fbca Gerrit-Change-Number: 23020 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Dec 2017 09:23:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [TEST]mb/asrock/g41c-gs: Add the revision 1 variant
by build bot (Jenkins) (Code Review) 28 Dec '17

28 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21292 ) Change subject: [TEST]mb/asrock/g41c-gs: Add the revision 1 variant ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19815/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65060/ : SUCCESS -- To view, visit https://review.coreboot.org/21292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib69c2ac0a9dc1b5c46220d2d2d5239edc99b0516 Gerrit-Change-Number: 21292 Gerrit-PatchSet: 10 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Dec 2017 08:59:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [TEST]mb/asrock/g41c-gs: Add the revision 1 variant
by build bot (Jenkins) (Code Review) 28 Dec '17

28 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21292 ) Change subject: [TEST]mb/asrock/g41c-gs: Add the revision 1 variant ...................................................................... Patch Set 9: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/19814/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/65059/ : ABORTED -- To view, visit https://review.coreboot.org/21292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib69c2ac0a9dc1b5c46220d2d2d5239edc99b0516 Gerrit-Change-Number: 21292 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Dec 2017 08:50:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [TEST]mb/asrock/g41c-gs: Add the revision 1 variant
by build bot (Jenkins) (Code Review) 28 Dec '17

28 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21292 ) Change subject: [TEST]mb/asrock/g41c-gs: Add the revision 1 variant ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19813/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65058/ : SUCCESS -- To view, visit https://review.coreboot.org/21292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib69c2ac0a9dc1b5c46220d2d2d5239edc99b0516 Gerrit-Change-Number: 21292 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Dec 2017 08:07:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/fizz: Override IccMax settings
by build bot (Jenkins) (Code Review) 28 Dec '17

28 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23020 ) Change subject: mb/google/fizz: Override IccMax settings ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19812/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65057/ : SUCCESS -- To view, visit https://review.coreboot.org/23020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ffe0cb73981850005b20fefb6664cfab74fbca Gerrit-Change-Number: 23020 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Dec 2017 07:16:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/fizz: Override IccMax settings
by Gaggery Tsai (Code Review) 28 Dec '17

28 Dec '17

Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/23020 Change subject: mb/google/fizz: Override IccMax settings ...................................................................... mb/google/fizz: Override IccMax settings According to Intel document #559100 KBL EDS v2.8, section 7.2 DC specifications, the IccMax setting for KBL-U, KBL-U42 and Celeron are different. This patch sets Celeron as default SKU in device tree and overrides the IccMax settings for KBL-U and KBL-U42 at pre-FSPS. +----------------+-------------+---------------+-------+-------+ | Domain/Setting | SA | IA | GTUS | GTS | +----------------+-------------+---------------+-------+-------+ | IccMax | 6A(U42) | 64A(U42) | 31A | 31A | | | 4.5A(Others)| 29A(Celeron) | 31A | 31A |(Default) | | | 32A(i3/i5) | 31A | 31A | +----------------+-------------+-------+-------+-------+-------+ BUG=b:71369428 BRANCH=None TEST=emerge-fizz coreboot chromeos-bootimage & Ensure the KBL-U42, KBL-U and Celeron SKUs are identified correctly and IccMax settings are passed to FSPS correctly. Change-Id: I32ffe0cb73981850005b20fefb6664cfab74fbca Signed-off-by: Gaggery Tsai <gaggery.tsai(a)intel.com> --- A src/mainboard/google/fizz/common.h M src/mainboard/google/fizz/devicetree.cb M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/fizz/ramstage.c 4 files changed, 85 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/23020/1 diff --git a/src/mainboard/google/fizz/common.h b/src/mainboard/google/fizz/common.h new file mode 100644 index 0000000..f5714ba --- /dev/null +++ b/src/mainboard/google/fizz/common.h @@ -0,0 +1,31 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2017 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the + * GNU General Public License for more details. + */ + +#ifndef __MAINBOARD_COMMON_H__ +#define __MAINBOARD_COMMON_H__ + +#define FIZZ_SKU_ID_I7_U42 0x4 +#define FIZZ_SKU_ID_I3 0x1 +#define FIZZ_SKU_ID_I5 0x2 +#define FIZZ_PL2_I7_U42 44 +#define FIZZ_PL2_OTHERS 29 + +#define FIZZ_ICCMAX_SA_I7_U42 6 +#define FIZZ_ICCMAX_CORE_I7_U42 64 +#define FIZZ_ICCMAX_CORE_I3_I5 32 + +uint8_t board_sku_id(void); + +#endif diff --git a/src/mainboard/google/fizz/devicetree.cb b/src/mainboard/google/fizz/devicetree.cb index e94dd26..5550328 100644 --- a/src/mainboard/google/fizz/devicetree.cb +++ b/src/mainboard/google/fizz/devicetree.cb @@ -102,20 +102,23 @@ register "pirqg_routing" = "PCH_IRQ11" register "pirqh_routing" = "PCH_IRQ11" - # VR Settings Configuration for 4 Domains - #+----------------+-------+-------+-------+-------+ - #| Domain/Setting | SA | IA | GTUS | GTS | - #+----------------+-------+-------+-------+-------+ - #| Psi1Threshold | 20A | 20A | 20A | 20A | - #| Psi2Threshold | 4A | 5A | 5A | 5A | - #| Psi3Threshold | 1A | 1A | 1A | 1A | - #| Psi3Enable | 1 | 1 | 1 | 1 | - #| Psi4Enable | 1 | 1 | 1 | 1 | - #| ImonSlope | 0 | 0 | 0 | 0 | - #| ImonOffset | 0 | 0 | 0 | 0 | - #| IccMax | 7A | 34A | 35A | 35A | - #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V | - #+----------------+-------+-------+-------+-------+ + # Initial VR Settings Configuration for 4 Domains + # Some SKUs needs to be overriden somewhere else. + #+----------------+-------------+---------------+-------+-------+ + #| Domain/Setting | SA | IA | GTUS | GTS | + #+----------------+-------------+---------------+-------+-------+ + #| Psi1Threshold | 20A | 20A | 20A | 20A | + #| Psi2Threshold | 4A | 5A | 5A | 5A | + #| Psi3Threshold | 1A | 1A | 1A | 1A | + #| Psi3Enable | 1 | 1 | 1 | 1 | + #| Psi4Enable | 1 | 1 | 1 | 1 | + #| ImonSlope | 0 | 0 | 0 | 0 | + #| ImonOffset | 0 | 0 | 0 | 0 | + #| IccMax | 6A(U42) | 64A(U42) | 31A | 31A | + #| | 4.5A(Others)| 29A(Celeron) | 31A | 31A |(Default) + #| | | 32A(i3/i5) | 31A | 31A | + #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V | + #+----------------+-------------+-------+-------+-------+-------+ register "domain_vr_config[VR_SYSTEM_AGENT]" = "{ .vr_config_enable = 1, .psi1threshold = VR_CFG_AMP(20), @@ -125,7 +128,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(7), + .icc_max = VR_CFG_AMP(4.5), .voltage_limit = 1520, }" @@ -138,7 +141,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(34), + .icc_max = VR_CFG_AMP(29), .voltage_limit = 1520, }" @@ -151,7 +154,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(35), + .icc_max = VR_CFG_AMP(31), .voltage_limit = 1520, }" @@ -164,7 +167,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(35), + .icc_max = VR_CFG_AMP(31), .voltage_limit = 1520, }" diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 98c0078..4aa72bd 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -21,6 +21,7 @@ #include <ec/google/chromeec/ec.h> #include <gpio.h> #include <mainboard/google/fizz/gpio.h> +#include <mainboard/google/fizz/common.h> #include <smbios.h> #include <soc/gpio.h> #include <soc/pci_devs.h> @@ -28,9 +29,6 @@ #include <string.h> #include <vendorcode/google/chromeos/chromeos.h> -#define FIZZ_SKU_ID_I7_U42 0x4 -#define FIZZ_PL2_I7_U42 44 -#define FIZZ_PL2_OTHERS 29 /* * For type-C chargers, set PL2 to 90% of max power to account for * cable loss and FET Rdson loss in the path from the source. @@ -81,7 +79,7 @@ static const char *oem_id = "GOOGLE"; static const char *oem_table_id = "FIZZ"; -static uint8_t board_sku_id(void) +uint8_t board_sku_id(void) { static int id = -1; const gpio_t sku_id_gpios[] = { diff --git a/src/mainboard/google/fizz/ramstage.c b/src/mainboard/google/fizz/ramstage.c index 6dafe65..a297828 100644 --- a/src/mainboard/google/fizz/ramstage.c +++ b/src/mainboard/google/fizz/ramstage.c @@ -14,10 +14,40 @@ */ #include <soc/ramstage.h> - +#include <soc/pci_devs.h> #include "gpio.h" +#include "common.h" + +static void mainboard_setup_iccmax(config_t *conf) +{ + int sku_id = board_sku_id(); + /* + * Iccmax table from Doc #55910 Section 7.2 DC Specifications + * +----------------+-------------+---------------+-------+-------+ + * | Domain/Setting | SA | IA | GTUS | GTS | + * +----------------+-------------+---------------+-------+-------+ + * | IccMax | 6A(U42) | 64A(U42) | 31A | 31A | + * | | 4.5A(Others)| 29A(Celeron) | 31A | 31A |(Default) + * | | | 32A(i3/i5) | 31A | 31A | + * +----------------+-------------+-------+-------+-------+-------+ + */ + + /* Assumed default Iccmax setting in device tree is for Celeron */ + if (sku_id == FIZZ_SKU_ID_I7_U42) { + conf->domain_vr_config[VR_SYSTEM_AGENT].icc_max = VR_CFG_AMP(FIZZ_ICCMAX_SA_I7_U42); + conf->domain_vr_config[VR_IA_CORE].icc_max = VR_CFG_AMP(FIZZ_ICCMAX_CORE_I7_U42); + } + + if (sku_id == FIZZ_SKU_ID_I3 || sku_id == FIZZ_SKU_ID_I5) + conf->domain_vr_config[VR_IA_CORE].icc_max = VR_CFG_AMP(FIZZ_ICCMAX_CORE_I3_I5); + +} void mainboard_silicon_init_params(FSP_SIL_UPD *params) { + device_t root = SA_DEV_ROOT; + config_t *conf = root->chip_info; + gpio_configure_pads(gpio_table, ARRAY_SIZE(gpio_table)); + mainboard_setup_iccmax(conf); } -- To view, visit https://review.coreboot.org/23020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I32ffe0cb73981850005b20fefb6664cfab74fbca Gerrit-Change-Number: 23020 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Add device setting for sata power optimization
by build bot (Jenkins) (Code Review) 28 Dec '17

28 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23018 ) Change subject: soc/intel/skylake: Add device setting for sata power optimization ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19810/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65054/ : SUCCESS -- To view, visit https://review.coreboot.org/23018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9099c5c97765a118bdee64da303cb3ba6ceb951b Gerrit-Change-Number: 23018 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Dec 2017 06:41:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/fizz: Enable SataPwrOptEnable FSP UPD
by build bot (Jenkins) (Code Review) 28 Dec '17

28 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23019 ) Change subject: google/fizz: Enable SataPwrOptEnable FSP UPD ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/65056/ : SUCCESS -- To view, visit https://review.coreboot.org/23019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb991f6889c5ff3181a670bc7702314049fa983c Gerrit-Change-Number: 23019 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Dec 2017 06:40:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/fizz: Enable SataPwrOptEnable FSP UPD
by build bot (Jenkins) (Code Review) 28 Dec '17

28 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23019 ) Change subject: google/fizz: Enable SataPwrOptEnable FSP UPD ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/65055/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/19811/ : SUCCESS -- To view, visit https://review.coreboot.org/23019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb991f6889c5ff3181a670bc7702314049fa983c Gerrit-Change-Number: 23019 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Dec 2017 06:33:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
156
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017