Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/23020 )
Change subject: mb/google/fizz: Override IccMax settings ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c File src/mainboard/google/fizz/ramstage.c:
https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c... PS1, Line 21: static void mainboard_setup_iccmax(config_t *conf)
should we move this code to skylake common code rather that board specific code? […]
I think we can do some clean-up in vr_config.c since fsp 2.0 provides default well-defined settings for various SKUs.