Kane Chen has posted comments on this change. ( https://review.coreboot.org/23020 )
Change subject: mb/google/fizz: Override IccMax settings ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c File src/mainboard/google/fizz/ramstage.c:
https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c... PS1, Line 21: static void mainboard_setup_iccmax(config_t *conf) should we move this code to skylake common code rather that board specific code? thanks.
https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c... PS1, Line 41: if else if thanks.