coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: drivers/pc80/tpm: Remove unused ACPI opregion
by Duncan Laurie (Code Review) 13 Dec '17

13 Dec '17

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/22854 Change subject: drivers/pc80/tpm: Remove unused ACPI opregion ...................................................................... drivers/pc80/tpm: Remove unused ACPI opregion The opregion and fields are left over from when ACPI ASL code was reading registers to determine the current setup. Now that the ACPI device is generated with the correct information already this code is not used at all and can be removed from the tree. Change-Id: If89d90cc7105ed21e2134ac99224f6f8214cc8ad Signed-off-by: Duncan Laurie <dlaurie(a)chromium.org> --- M src/drivers/pc80/tpm/tpm.c 1 file changed, 0 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/22854/1 diff --git a/src/drivers/pc80/tpm/tpm.c b/src/drivers/pc80/tpm/tpm.c index c0afd4c..3e65bfd 100644 --- a/src/drivers/pc80/tpm/tpm.c +++ b/src/drivers/pc80/tpm/tpm.c @@ -872,8 +872,6 @@ { const char *path = acpi_device_path(dev->bus->dev); u32 arg; - struct opregion opreg = OPREGION("TREG", SYSTEMMEMORY, - CONFIG_TPM_TIS_BASE_ADDRESS, 0x5000); if (!path) { path = "\\_SB_.PCI0.LPCB"; @@ -887,37 +885,7 @@ acpigen_write_name("_HID"); acpigen_emit_eisaid("PNP0C31"); - acpigen_write_name("_CID"); - acpigen_emit_eisaid("PNP0C31"); - acpigen_write_name_integer("_UID", 1); - - acpigen_write_opregion(&opreg); - - struct fieldlist tpm_field_list[] = { - /* - * TPM_INT_ENABLE_0 - * bit 0 : dataAvailIntEnable, - * bit 1 : stsValidIntEnable, - * bit 2 : localityChangeIntEnable, - * bit 3:4 typePolarity. - */ - FIELDLIST_OFFSET(0x8), - FIELDLIST_NAMESTR("INTE", 3), - FIELDLIST_NAMESTR("ITPL", 2), - - /* TPM_INT_VECTOR_0 */ - FIELDLIST_OFFSET(0xC), - FIELDLIST_NAMESTR("IVEC", 4), - - /* TPM_DID_VID */ - FIELDLIST_OFFSET(0xf00), - FIELDLIST_NAMESTR("DVID", 32), - }; - - acpigen_write_field(opreg.name, tpm_field_list, - ARRAY_SIZE(tpm_field_list), - FIELD_BYTEACC | FIELD_NOLOCK | FIELD_PRESERVE); u32 did_vid = tpm_read_did_vid(0); if (did_vid > 0 && did_vid < 0xffffffff) -- To view, visit https://review.coreboot.org/22854 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If89d90cc7105ed21e2134ac99224f6f8214cc8ad Gerrit-Change-Number: 22854 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org>

1 0

Change in coreboot[master]: fix src/soc/amd/common/agesawrapper_call.h
by Martin Roth (Code Review) 13 Dec '17

13 Dec '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22850 ) Change subject: fix src/soc/amd/common/agesawrapper_call.h ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22850/1/src/soc/amd/common/block/pi/amd_lat… File src/soc/amd/common/block/pi/amd_late_init.c: https://review.coreboot.org/#/c/22850/1/src/soc/amd/common/block/pi/amd_lat… PS1, Line 31: Instead of adding the printks, this could have just been changed to: do_agesawrapper(agesawrapper_amdinitlate, "amdinitlate"); Is there a reason we don't want to use do_agesawrapper? -- To view, visit https://review.coreboot.org/22850 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51917d3961a51d4e725ff45b04f45eefe149855 Gerrit-Change-Number: 22850 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 21:54:53 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Remove "\t" from name table
by build bot (Jenkins) (Code Review) 13 Dec '17

13 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22785 ) Change subject: soc/amd/stoneyridge: Remove "\t" from name table ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19278/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64479/ : SUCCESS -- To view, visit https://review.coreboot.org/22785 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92dfac9b64932fb0cd3359abd4d1aac651535f1a Gerrit-Change-Number: 22785 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 20:56:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: fix src/soc/amd/common/agesawrapper_call.h
by build bot (Jenkins) (Code Review) 13 Dec '17

13 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22850 ) Change subject: fix src/soc/amd/common/agesawrapper_call.h ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19277/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64478/ : SUCCESS -- To view, visit https://review.coreboot.org/22850 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51917d3961a51d4e725ff45b04f45eefe149855 Gerrit-Change-Number: 22850 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 20:37:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: fix src/soc/amd/common/agesawrapper_call.h
by Richard Spiegel (Code Review) 13 Dec '17

13 Dec '17

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22850 ) Change subject: fix src/soc/amd/common/agesawrapper_call.h ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22850/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/22850/1//COMMIT_MSG@17 PS1, Line 17: EST= Test missing, will be added. -- To view, visit https://review.coreboot.org/22850 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51917d3961a51d4e725ff45b04f45eefe149855 Gerrit-Change-Number: 22850 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Comment-Date: Wed, 13 Dec 2017 20:29:52 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: fix src/soc/amd/common/agesawrapper_call.h
by Richard Spiegel (Code Review) 13 Dec '17

13 Dec '17

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22850 ) Change subject: fix src/soc/amd/common/agesawrapper_call.h ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22850/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/22850/1//COMMIT_MSG@7 PS1, Line 7: f Already changed to caps, awaiting next commit. -- To view, visit https://review.coreboot.org/22850 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51917d3961a51d4e725ff45b04f45eefe149855 Gerrit-Change-Number: 22850 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Comment-Date: Wed, 13 Dec 2017 20:28:40 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: fix src/soc/amd/common/agesawrapper_call.h
by Richard Spiegel (Code Review) 13 Dec '17

13 Dec '17

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/22850 Change subject: fix src/soc/amd/common/agesawrapper_call.h ...................................................................... fix src/soc/amd/common/agesawrapper_call.h Solve issues related to agesawrapper_call.h that came up at review 75dd50e233 (review 19724). This includes a hard coded table size and 2 macros: AGESAWRAPPER_PRE_CONSOLE() and AGESAWRAPPER(). Remove AGESAWRAPPER_PRE_CONSOLE(), and replace AGESAWRAPPER() calls with the actual content of the macro. BUG=b:62240989 TEST= Change-Id: Ic51917d3961a51d4e725ff45b04f45eefe149855 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/common/block/include/amdblocks/agesawrapper_call.h M src/soc/amd/common/block/pi/amd_late_init.c M src/soc/amd/stoneyridge/bootblock/bootblock.c M src/soc/amd/stoneyridge/chip.c M src/soc/amd/stoneyridge/northbridge.c M src/soc/amd/stoneyridge/romstage.c 6 files changed, 47 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/22850/1 diff --git a/src/soc/amd/common/block/include/amdblocks/agesawrapper_call.h b/src/soc/amd/common/block/include/amdblocks/agesawrapper_call.h index 4854bee..1188f05 100644 --- a/src/soc/amd/common/block/include/amdblocks/agesawrapper_call.h +++ b/src/soc/amd/common/block/include/amdblocks/agesawrapper_call.h @@ -37,7 +37,7 @@ "AGESA_WARNING", "AGESA_ERROR", "AGESA_CRITICAL", "AGESA_FATAL" }; - if (sret > 7) + if (sret >= ARRAY_SIZE(statusStrings)) return "unknown"; /* Non-AGESA error code */ return statusStrings[sret]; } @@ -51,9 +51,5 @@ name, decodeAGESA_STATUS(ret)); return (u32)ret; } - -#define AGESAWRAPPER(func) do_agesawrapper(agesawrapper_ ## func, #func) - -#define AGESAWRAPPER_PRE_CONSOLE(func) agesawrapper_ ## func() #endif /* __AGESAWRAPPER_CALL_H__ */ diff --git a/src/soc/amd/common/block/pi/amd_late_init.c b/src/soc/amd/common/block/pi/amd_late_init.c index 65667b9..12c01b5 100644 --- a/src/soc/amd/common/block/pi/amd_late_init.c +++ b/src/soc/amd/common/block/pi/amd_late_init.c @@ -25,15 +25,23 @@ static void agesawrapper_post_device(void *unused) { + AGESA_STATUS ret; + if (acpi_is_wakeup_s3()) return; - AGESAWRAPPER(amdinitlate); + printk(BIOS_DEBUG, "agesawrapper_amdinitlate() entry\n"); + ret = agesawrapper_amdinitlate(); + printk(BIOS_DEBUG, "agesawrapper_amdinitlate() returned %s\n", + decodeAGESA_STATUS(ret)); if (!acpi_s3_resume_allowed()) return; - AGESAWRAPPER(amdS3Save); + printk(BIOS_DEBUG, "agesawrapper_amdS3Save() entry\n"); + ret = agesawrapper_amdS3Save(); + printk(BIOS_DEBUG, "agesawrapper_amdS3Save() returned %s\n", + decodeAGESA_STATUS(ret)); } BOOT_STATE_INIT_ENTRY(BS_POST_DEVICE, BS_ON_EXIT, diff --git a/src/soc/amd/stoneyridge/bootblock/bootblock.c b/src/soc/amd/stoneyridge/bootblock/bootblock.c index 030c990..7f44351 100644 --- a/src/soc/amd/stoneyridge/bootblock/bootblock.c +++ b/src/soc/amd/stoneyridge/bootblock/bootblock.c @@ -106,6 +106,8 @@ void bootblock_soc_init(void) { + AGESA_STATUS ret; + if (IS_ENABLED(CONFIG_STONEYRIDGE_UART)) assert(CONFIG_UART_FOR_CONSOLE >= 0 && CONFIG_UART_FOR_CONSOLE <= 1); @@ -117,8 +119,14 @@ load_smu_fw1(); post_code(0x37); - AGESAWRAPPER(amdinitreset); + printk(BIOS_DEBUG, "agesawrapper_amdinitreset() entry\n"); + ret = agesawrapper_amdinitreset(); + printk(BIOS_DEBUG, "agesawrapper_amdinitreset() returned %s\n", + decodeAGESA_STATUS(ret)); post_code(0x38); - AGESAWRAPPER(amdinitearly); /* APs will not exit amdinitearly */ + printk(BIOS_DEBUG, "agesawrapper_amdinitearly() entry\n"); + ret = agesawrapper_amdinitearly(); + printk(BIOS_DEBUG, "agesawrapper_amdinitearly() returned %s\n", + decodeAGESA_STATUS(ret)); } diff --git a/src/soc/amd/stoneyridge/chip.c b/src/soc/amd/stoneyridge/chip.c index 8d6a8e4..77e68a1 100644 --- a/src/soc/amd/stoneyridge/chip.c +++ b/src/soc/amd/stoneyridge/chip.c @@ -81,12 +81,17 @@ static void earliest_ramstage(void *unused) { + AGESA_STATUS ret; + post_code(0x46); if (IS_ENABLED(CONFIG_SOC_AMD_PSP_SELECTABLE_SMU_FW)) psp_load_named_blob(MBOX_BIOS_CMD_SMU_FW2, "smu_fw2"); post_code(0x47); - AGESAWRAPPER(amdinitenv); + printk(BIOS_DEBUG, "agesawrapper_amdinitenv() entry\n"); + ret = agesawrapper_amdinitenv(); + printk(BIOS_DEBUG, "agesawrapper_amdinitenv() returned %s\n", + decodeAGESA_STATUS(ret)); } BOOT_STATE_INIT_ENTRY(BS_PRE_DEVICE, BS_ON_ENTRY, earliest_ramstage, NULL); diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c index 27b5388..fed52fc 100644 --- a/src/soc/amd/stoneyridge/northbridge.c +++ b/src/soc/amd/stoneyridge/northbridge.c @@ -423,13 +423,23 @@ void domain_enable_resources(device_t dev) { - if (acpi_is_wakeup_s3()) - AGESAWRAPPER(fchs3laterestore); + AGESA_STATUS ret; + + if (acpi_is_wakeup_s3()) { + printk(BIOS_DEBUG, "agesawrapper_fchs3laterestore() entry\n"); + ret = agesawrapper_fchs3laterestore(); + printk(BIOS_DEBUG, + "agesawrapper_fchs3laterestore() returned %s\n", + decodeAGESA_STATUS(ret)); + } /* Must be called after PCI enumeration and resource allocation */ - if (!acpi_is_wakeup_s3()) - AGESAWRAPPER(amdinitmid); - + if (!acpi_is_wakeup_s3()) { + printk(BIOS_DEBUG, "agesawrapper_amdinitmid() entry\n"); + ret = agesawrapper_amdinitmid(); + printk(BIOS_DEBUG, "agesawrapper_amdinitmid() returned %s\n", + decodeAGESA_STATUS(ret)); + } printk(BIOS_DEBUG, " ader - leaving domain_enable_resources.\n"); } diff --git a/src/soc/amd/stoneyridge/romstage.c b/src/soc/amd/stoneyridge/romstage.c index 7c738ad..66b3989 100644 --- a/src/soc/amd/stoneyridge/romstage.c +++ b/src/soc/amd/stoneyridge/romstage.c @@ -41,11 +41,15 @@ msr_t mtrr_cap = rdmsr(MTRR_CAP_MSR); int vmtrrs = mtrr_cap.lo & MTRR_CAP_VCNT; int i; + AGESA_STATUS ret; console_init(); post_code(0x40); - AGESAWRAPPER(amdinitpost); + printk(BIOS_DEBUG, "agesawrapper_amdinitpost() entry\n"); + ret = agesawrapper_amdinitpost(); + printk(BIOS_DEBUG, "agesawrapper_amdinitpost() returned %s\n", + decodeAGESA_STATUS(ret)); post_code(0x41); /* -- To view, visit https://review.coreboot.org/22850 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic51917d3961a51d4e725ff45b04f45eefe149855 Gerrit-Change-Number: 22850 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: amd/common/psp: Add BootDone command
by build bot (Jenkins) (Code Review) 13 Dec '17

13 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22787 ) Change subject: amd/common/psp: Add BootDone command ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19272/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64473/ : SUCCESS -- To view, visit https://review.coreboot.org/22787 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8258a9e2f2627bf24342f927a3e7f49b49dc1d88 Gerrit-Change-Number: 22787 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 19:42:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/common/psp: Flush buffer before commands
by build bot (Jenkins) (Code Review) 13 Dec '17

13 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22849 ) Change subject: amd/common/psp: Flush buffer before commands ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19276/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64477/ : SUCCESS -- To view, visit https://review.coreboot.org/22849 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2aa7bbddcb2197aeb9f92683465d014ec97ac64c Gerrit-Change-Number: 22849 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 19:36:21 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/common/psp: Convert structure init to C99
by build bot (Jenkins) (Code Review) 13 Dec '17

13 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22847 ) Change subject: amd/common/psp: Convert structure init to C99 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19274/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64475/ : SUCCESS -- To view, visit https://review.coreboot.org/22847 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e18b3a2c19b8fb17d0f654b16def52517538957 Gerrit-Change-Number: 22847 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 19:30:13 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017