coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: Snappy: hack Melfas kernel driver to prevent VTSP power drop
by build bot (Jenkins) (Code Review) 13 Dec '17

13 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22858 ) Change subject: Snappy: hack Melfas kernel driver to prevent VTSP power drop ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64490/ : SUCCESS -- To view, visit https://review.coreboot.org/22858 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0451ff0c3df97cb2474e30542a2f46ba67d82a Gerrit-Change-Number: 22858 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 23:49:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Snappy: hack Melfas kernel driver to prevent VTSP power drop
by build bot (Jenkins) (Code Review) 13 Dec '17

13 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22858 ) Change subject: Snappy: hack Melfas kernel driver to prevent VTSP power drop ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64489/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/19286/ : SUCCESS -- To view, visit https://review.coreboot.org/22858 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0451ff0c3df97cb2474e30542a2f46ba67d82a Gerrit-Change-Number: 22858 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 23:43:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vendorcode/amd/agesa: CPU ucode AGESA Fam15 mobile
by build bot (Jenkins) (Code Review) 13 Dec '17

13 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22843 ) Change subject: vendorcode/amd/agesa: CPU ucode AGESA Fam15 mobile ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64488/ : SUCCESS -- To view, visit https://review.coreboot.org/22843 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbfee47ce1d5081640d6924e2b12f5213a7fcadb Gerrit-Change-Number: 22843 Gerrit-PatchSet: 4 Gerrit-Owner: awokd(a)danwin1210.me Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: awokd(a)danwin1210.me Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 23:42:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Snappy: hack Melfas kernel driver to prevent VTSP power drop
by Kevin Chiu (Code Review) 13 Dec '17

13 Dec '17

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/22858 Change subject: Snappy: hack Melfas kernel driver to prevent VTSP power drop ...................................................................... Snappy: hack Melfas kernel driver to prevent VTSP power drop Melfas kernel TS driver (melfas_mip4.c) will look up "ce" GPIO during driver probe in ACPI _DSD. But FW does not report "ce-gpios" but "enable-gpios" in _DSD. Kernel will obtain GPIO from _CRS by index "0" without ID. Melfas driver does not have separate condition for MIT-410 so driver will set TS IC power off in probe. FW now may need to add back "reset" pin in order to hack this condition to let Melfas driver get "useless" GPIO so TS IC power (VTSP) will not drop during driver probe. BUG=b:70149336 BRANCH=reef TEST=emerge-snappy coreboot Change-Id: Icf0451ff0c3df97cb2474e30542a2f46ba67d82a Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- M src/mainboard/google/reef/variants/snappy/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/22858/1 diff --git a/src/mainboard/google/reef/variants/snappy/devicetree.cb b/src/mainboard/google/reef/variants/snappy/devicetree.cb index f40c330..4b0981e 100644 --- a/src/mainboard/google/reef/variants/snappy/devicetree.cb +++ b/src/mainboard/google/reef/variants/snappy/devicetree.cb @@ -198,6 +198,8 @@ register "desc" = ""Melfas Touchscreen"" register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)" register "probed" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)" + register "reset_delay_ms" = "1" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152)" register "enable_delay_ms" = "5" register "has_power_resource" = "1" -- To view, visit https://review.coreboot.org/22858 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icf0451ff0c3df97cb2474e30542a2f46ba67d82a Gerrit-Change-Number: 22858 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>

1 0

Change in coreboot[master]: vendorcode/amd/agesa: CPU ucode AGESA Fam15 mobile
by build bot (Jenkins) (Code Review) 13 Dec '17

13 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22843 ) Change subject: vendorcode/amd/agesa: CPU ucode AGESA Fam15 mobile ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64487/ : ABORTED -- To view, visit https://review.coreboot.org/22843 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbfee47ce1d5081640d6924e2b12f5213a7fcadb Gerrit-Change-Number: 22843 Gerrit-PatchSet: 3 Gerrit-Owner: awokd(a)danwin1210.me Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: awokd(a)danwin1210.me Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 23:36:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: fix src/soc/amd/common/agesawrapper_call.h
by Richard Spiegel (Code Review) 13 Dec '17

13 Dec '17

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22850 ) Change subject: fix src/soc/amd/common/agesawrapper_call.h ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22850/1/src/soc/amd/common/block/pi/amd_lat… File src/soc/amd/common/block/pi/amd_late_init.c: https://review.coreboot.org/#/c/22850/1/src/soc/amd/common/block/pi/amd_lat… PS1, Line 31: > Instead of adding the printks, this could have just been changed to: No reason at all, and I actually did not delete it. I just thought that for someone reading it, having it fully expanded was clearer than do_agesawrapper() which would require the person to search the function and see that it expanded into 2 prints and one AGESA call. -- To view, visit https://review.coreboot.org/22850 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51917d3961a51d4e725ff45b04f45eefe149855 Gerrit-Change-Number: 22850 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 22:36:33 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: util/gitconfig: Make gitconfig a bash script
by build bot (Jenkins) (Code Review) 13 Dec '17

13 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22857 ) Change subject: util/gitconfig: Make gitconfig a bash script ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19285/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64486/ : SUCCESS -- To view, visit https://review.coreboot.org/22857 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bc8cf688a3ad211b57c8ca0e6b1e86c82dc6a37 Gerrit-Change-Number: 22857 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 22:33:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi: Enable flashconsole in verstage
by build bot (Jenkins) (Code Review) 13 Dec '17

13 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22855 ) Change subject: drivers/spi: Enable flashconsole in verstage ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19283/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64484/ : SUCCESS -- To view, visit https://review.coreboot.org/22855 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd8a82dc962ece85b9fb3d2f5654369e821922eb Gerrit-Change-Number: 22855 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 22:27:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/gitconfig: Make gitconfig a bash script
by Marc Jones (Code Review) 13 Dec '17

13 Dec '17

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/22857 Change subject: util/gitconfig: Make gitconfig a bash script ...................................................................... util/gitconfig: Make gitconfig a bash script The gitconfig target has a few bashisms and would fail silently on systems that use a POSIX standard sh (like Ubuntu dash). Remove the code from the makefile and put it in a bash script that is called by the gitconfig target. Change-Id: I3bc8cf688a3ad211b57c8ca0e6b1e86c82dc6a37 Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M Makefile.inc A util/gitconfig/gitconfig.sh 2 files changed, 30 insertions(+), 28 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/22857/1 diff --git a/Makefile.inc b/Makefile.inc index f93b4bd..413f7ad 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -570,34 +570,7 @@ dongle.py -c /dev/term/1 $(obj)/coreboot.rom EOF gitconfig: - [ -d .git ] - mkdir -p .git/hooks - for hook in commit-msg pre-commit ; do \ - if [ util/gitconfig/$$hook -nt .git/hooks/$$hook -o \ - ! -x .git/hooks/$$hook ]; then \ - sed -e "s,%MAKE%,$(MAKE),g" util/gitconfig/$$hook > .git/hooks/$$hook; \ - chmod +x .git/hooks/$$hook; \ - fi; \ - done - # Now set up thehooks for 3rdparty/ - for hooks in .git/modules/{3rdparty/blobs,libhwbase,libgfxinit}/hooks; do \ - if [ -d $$hooks -a \ - $ util/gitconfig/commit-msg -nt $$hooks/commit-msg -o \ - ! -x $$hooks/commit-msg $ ]; then \ - sed -e "s,%MAKE%,$(MAKE),g" util/gitconfig/commit-msg > $$hooks/commit-msg; \ - chmod +x $$hooks/commit-msg; \ - fi \ - done - for d in 3rdparty/{blobs,libhwbase,libgfxinit}; do \ - if [ -d $$d ]; then \ - (cd $$d; \ - git config remote.origin.push HEAD:refs/for/master); \ - fi; \ - done - git config remote.origin.push HEAD:refs/for/master - git config alias.sup '!git submodule update --remote --rebase && git submodule update --init --checkout' - git config alias.sup-destroy '!git submodule deinit --force "$$(git rev-parse --show-toplevel)"; git submodule init && git submodule update --checkout' - (git config --includes user.name >/dev/null && git config --includes user.email >/dev/null) || (printf 'Please configure your name and email in git:\n\n git config --global user.name "Your Name Comes Here"\n git config --global user.email your.email(a)example.com\n'; exit 1) + util/gitconfig/gitconfig.sh include util/crossgcc/Makefile.inc diff --git a/util/gitconfig/gitconfig.sh b/util/gitconfig/gitconfig.sh new file mode 100755 index 0000000..84587f1 --- /dev/null +++ b/util/gitconfig/gitconfig.sh @@ -0,0 +1,29 @@ +#!/bin/bash +[ -d .git ] +mkdir -p .git/hooks +for hook in commit-msg pre-commit ; do \ + if [ util/gitconfig/$hook -nt .git/hooks/$hook -o \ + ! -x .git/hooks/$hook ]; then \ + sed -e "s,%MAKE%,remake,g" util/gitconfig/$hook > .git/hooks/$hook; \ + chmod +x .git/hooks/$hook; \ + fi; \ +done +# Now set up the hooks for 3rdparty/ +for hooks in .git/modules/{3rdparty/blobs,libhwbase,libgfxinit}/hooks; do \ + if [ -d $hooks -a \ + $ util/gitconfig/commit-msg -nt $hooks/commit-msg -o \ + ! -x $hooks/commit-msg $ ]; then \ + sed -e "s,%MAKE%,remake,g" util/gitconfig/commit-msg > $hooks/commit-msg; \ + chmod +x $hooks/commit-msg; \ + fi \ +done +for d in 3rdparty/{blobs,libhwbase,libgfxinit}; do \ + if [ -d $d ]; then \ + (cd $d; \ + git config remote.origin.push HEAD:refs/for/master); \ + fi; \ +done +git config remote.origin.push HEAD:refs/for/master +git config alias.sup '!git submodule update --remote --rebase && git submodule update --init --checkout' +git config alias.sup-destroy '!git submodule deinit --force "$(git rev-parse --show-toplevel)"; git submodule init && git submodule update --checkout' +(git config --includes user.name >/dev/null && git config --includes user.email >/dev/null) || (printf 'Please configure your name and email in git:\n\n git config --global user.name "Your Name Comes Here"\n git config --global user.email your.email(a)example.com\n'; exit 1) -- To view, visit https://review.coreboot.org/22857 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3bc8cf688a3ad211b57c8ca0e6b1e86c82dc6a37 Gerrit-Change-Number: 22857 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: drivers/pc80/tpm: Remove unused ACPI opregion
by build bot (Jenkins) (Code Review) 13 Dec '17

13 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22854 ) Change subject: drivers/pc80/tpm: Remove unused ACPI opregion ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19282/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64483/ : SUCCESS -- To view, visit https://review.coreboot.org/22854 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If89d90cc7105ed21e2134ac99224f6f8214cc8ad Gerrit-Change-Number: 22854 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 22:23:39 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017