coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: mb/google/nami: Revise speaker enable pin from A22 to A23
by Gaggery Tsai (Code Review) 14 Dec '17

14 Dec '17

Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/22863 Change subject: mb/google/nami: Revise speaker enable pin from A22 to A23 ...................................................................... mb/google/nami: Revise speaker enable pin from A22 to A23 According to schematic, the speaker enabling pin is GPP_A23. BUG=b:70646770 TEST=emerge-nami coreboot Change-Id: I4661749d0852f25e855d84f9416db67867545cb4 Signed-off-by: Gaggery Tsai <gaggery.tsai(a)intel.com> --- M src/mainboard/google/poppy/variants/nami/gpio.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/22863/1 diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c index 81fb129..e9e46c3 100644 --- a/src/mainboard/google/poppy/variants/nami/gpio.c +++ b/src/mainboard/google/poppy/variants/nami/gpio.c @@ -57,10 +57,10 @@ PAD_CFG_NC(GPP_A20), /* A21 : ISH_GP3 ==> NC */ PAD_CFG_NC(GPP_A21), - /* A22 : ISH_GP4 ==> PCH_SPK_EN */ - PAD_CFG_GPO(GPP_A22, 1, DEEP), - /* A23 : ISH_GP5 ==> NC */ - PAD_CFG_NC(GPP_A23), + /* A22 : ISH_GP4 ==> NC */ + PAD_CFG_NC(GPP_A22), + /* A23 : ISH_GP5 ==> PCH_SPK_EN */ + PAD_CFG_GPO(GPP_A23, 1, DEEP), /* B0 : CORE_VID0 ==> NC(T3) */ PAD_CFG_NC(GPP_B0), -- To view, visit https://review.coreboot.org/22863 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4661749d0852f25e855d84f9416db67867545cb4 Gerrit-Change-Number: 22863 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix UART2 serial log broken issue
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22862 ) Change subject: soc/intel/cannonlake: Fix UART2 serial log broken issue ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64503/ : SUCCESS -- To view, visit https://review.coreboot.org/22862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f9df5e8d6490090ed65b06bdd0b40f824d36a8a Gerrit-Change-Number: 22862 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 14 Dec 2017 08:33:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix UART2 serial log broken issue
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22862 ) Change subject: soc/intel/cannonlake: Fix UART2 serial log broken issue ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64502/ : SUCCESS -- To view, visit https://review.coreboot.org/22862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f9df5e8d6490090ed65b06bdd0b40f824d36a8a Gerrit-Change-Number: 22862 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 14 Dec 2017 06:44:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix UART2 serial log brokenness issue
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22862 ) Change subject: soc/intel/cannonlake: Fix UART2 serial log brokenness issue ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19296/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64501/ : SUCCESS -- To view, visit https://review.coreboot.org/22862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f9df5e8d6490090ed65b06bdd0b40f824d36a8a Gerrit-Change-Number: 22862 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Dec 2017 06:01:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix UART2 serial log brokenness issue
by Subrata Banik (Code Review) 14 Dec '17

14 Dec '17

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/22862 Change subject: soc/intel/cannonlake: Fix UART2 serial log brokenness issue ...................................................................... soc/intel/cannonlake: Fix UART2 serial log brokenness issue Cannonlake rvp serial log has been regressed with CL:22771. This patch ensures UART2 PCI device resource enumeration is working and we are getting serial log as expected. Change-Id: I1f9df5e8d6490090ed65b06bdd0b40f824d36a8a Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/cannonlake/uart.c 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/22862/1 diff --git a/src/soc/intel/cannonlake/uart.c b/src/soc/intel/cannonlake/uart.c index 21b6417..6aad685 100644 --- a/src/soc/intel/cannonlake/uart.c +++ b/src/soc/intel/cannonlake/uart.c @@ -13,8 +13,6 @@ * GNU General Public License for more details. */ -#define __SIMPLE_DEVICE__ - #include <assert.h> #include <cbmem.h> #include <console/uart.h> @@ -30,6 +28,7 @@ #include <soc/pci_devs.h> #include <soc/pcr_ids.h> +#if !ENV_RAMSTAGE /* Serial IO UART controller legacy mode */ #define PCR_SERIAL_IO_GPPRVRW7 0x618 #define PCR_SIO_PCH_LEGACY_UART(idx) (1 << (idx)) @@ -51,14 +50,6 @@ PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1)} /* TX */ } }; - -#if IS_ENABLED(CONFIG_DRIVERS_UART_8250MEM) -uintptr_t uart_platform_base(int idx) -{ - /* We can only have one serial console at a time */ - return UART_BASE_0_ADDR(idx); -} -#endif void pch_uart_init(void) { @@ -85,6 +76,15 @@ gpio_configure_pads(p->pads, ARRAY_SIZE(p->pads)); } +#endif + +#if IS_ENABLED(CONFIG_DRIVERS_UART_8250MEM) +uintptr_t uart_platform_base(int idx) +{ + /* We can only have one serial console at a time */ + return UART_BASE_0_ADDR(idx); +} +#endif device_t pch_uart_get_debug_controller(void) { -- To view, visit https://review.coreboot.org/22862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1f9df5e8d6490090ed65b06bdd0b40f824d36a8a Gerrit-Change-Number: 22862 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: mb/google/poppy: Enable speaker and codec for nami
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22861 ) Change subject: mb/google/poppy: Enable speaker and codec for nami ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19295/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64500/ : SUCCESS -- To view, visit https://review.coreboot.org/22861 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf4059f8ea3d5e34f33f0be227897a8cca636fa Gerrit-Change-Number: 22861 Gerrit-PatchSet: 2 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Dec 2017 03:53:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Enable speaker and codec for nami
by Gaggery Tsai (Code Review) 14 Dec '17

14 Dec '17

Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/22861 ) Change subject: mb/google/poppy: Enable speaker and codec for nami ...................................................................... Patch Set 2: needs to be verified before review. -- To view, visit https://review.coreboot.org/22861 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf4059f8ea3d5e34f33f0be227897a8cca636fa Gerrit-Change-Number: 22861 Gerrit-PatchSet: 2 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Dec 2017 03:44:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Enable speaker and codec for nami
by Gaggery Tsai (Code Review) 14 Dec '17

14 Dec '17

Hello Gaggery Tsai, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22861 to look at the new patch set (#2). Change subject: mb/google/poppy: Enable speaker and codec for nami ...................................................................... mb/google/poppy: Enable speaker and codec for nami Nami uses MAX98357A speaker amplifier and DA7219 codec. This patch adds max98357a and da7219 under I2C #3 in devicetree and add SPK DMIC nhlt support for 4CH DMIC. Besides, according to schematic, revise speaker enabling from A22 to A23 pin. Change-Id: Iecf4059f8ea3d5e34f33f0be227897a8cca636fa Signed-off-by: Gaggery Tsai <gaggery.tsai(a)intel.com> --- M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/variants/nami/Makefile.inc M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nami/gpio.c A src/mainboard/google/poppy/variants/nami/nhlt.c 5 files changed, 72 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/22861/2 -- To view, visit https://review.coreboot.org/22861 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iecf4059f8ea3d5e34f33f0be227897a8cca636fa Gerrit-Change-Number: 22861 Gerrit-PatchSet: 2 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Fix src/soc/amd/common/agesawrapper_call.h
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22850 ) Change subject: Fix src/soc/amd/common/agesawrapper_call.h ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19293/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64498/ : SUCCESS -- To view, visit https://review.coreboot.org/22850 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51917d3961a51d4e725ff45b04f45eefe149855 Gerrit-Change-Number: 22850 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Dec 2017 03:39:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Enable speaker and codec for nami
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22861 ) Change subject: mb/google/poppy: Enable speaker and codec for nami ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64499/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/19294/ : SUCCESS -- To view, visit https://review.coreboot.org/22861 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf4059f8ea3d5e34f33f0be227897a8cca636fa Gerrit-Change-Number: 22861 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Dec 2017 03:38:37 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017