coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: mb/google/fizz: revise LED0 behavior for link speed 100Mb
by Gaggery Tsai (Code Review) 21 Dec '17

21 Dec '17

Hello Gaggery Tsai, build bot (Jenkins), David Wu, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/22964 to look at the new patch set (#3). Change subject: mb/google/fizz: revise LED0 behavior for link speed 100Mb ...................................................................... mb/google/fizz: revise LED0 behavior for link speed 100Mb This patch revises LED0 Green light behavior from patch 2ecf3f8c. For 100Mb link speed, LED0 should be OFF. BUG=b:65437780, b:68284778, b:69950854, b:65808944 BRANCH=None TEST=Run DUT with 100Mb and 1000Mb ethernet connection and observe LED0 is behaving as expected. Change-Id: Ia805c955711b8ce77eba087a28427a005c456fa1 Signed-off-by: Gaggery Tsai <gaggery.tsai(a)intel.com> --- M src/mainboard/google/fizz/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/22964/3 -- To view, visit https://review.coreboot.org/22964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia805c955711b8ce77eba087a28427a005c456fa1 Gerrit-Change-Number: 22964 Gerrit-PatchSet: 3 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/fizz: revise LED0 behavior for link speed 100Mb
by build bot (Jenkins) (Code Review) 21 Dec '17

21 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22964 ) Change subject: mb/google/fizz: revise LED0 behavior for link speed 100Mb ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64861/ : FAILURE -- To view, visit https://review.coreboot.org/22964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia805c955711b8ce77eba087a28427a005c456fa1 Gerrit-Change-Number: 22964 Gerrit-PatchSet: 2 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Dec 2017 03:24:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/fizz: revise LED0 behavior for link speed 100Mb
by David Wu (Code Review) 21 Dec '17

21 Dec '17

David Wu has uploaded a new patch set (#2) to the change originally created by Gaggery Tsai. ( https://review.coreboot.org/22964 ) Change subject: mb/google/fizz: revise LED0 behavior for link speed 100Mb ...................................................................... mb/google/fizz: revise LED0 behavior for link speed 100Mb This patch revises LED0 Green light behavior from patch 2ecf3f8c. For 100Mb link speed, LED0 should be OFF. BUG=b:65437780, b:68284778, b:69950854, b:65808944 BRANCH=None TEST=Run DUT with 100Mb and 1000Mb ethernet connection and observe LED0 is behaving as expected. Change-Id: Ia805c955711b8ce77eba087a28427a005c456fa1 Signed-off-by: Gaggery Tsai <gaggery.tsai(a)intel.com> --- M src/mainboard/google/fizz/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/22964/2 -- To view, visit https://review.coreboot.org/22964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia805c955711b8ce77eba087a28427a005c456fa1 Gerrit-Change-Number: 22964 Gerrit-PatchSet: 2 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/fizz: revise LED0 behavior for link speed 100Mb
by David Wu (Code Review) 21 Dec '17

21 Dec '17

David Wu has posted comments on this change. ( https://review.coreboot.org/22964 ) Change subject: mb/google/fizz: revise LED0 behavior for link speed 100Mb ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/22964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia805c955711b8ce77eba087a28427a005c456fa1 Gerrit-Change-Number: 22964 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Dec 2017 03:21:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/fizz: revise LED0 behavior for link speed 100Mb
by build bot (Jenkins) (Code Review) 21 Dec '17

21 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22964 ) Change subject: mb/google/fizz: revise LED0 behavior for link speed 100Mb ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19636/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64860/ : SUCCESS -- To view, visit https://review.coreboot.org/22964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia805c955711b8ce77eba087a28427a005c456fa1 Gerrit-Change-Number: 22964 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Dec 2017 03:07:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/fizz: revise LED0 behavior for link speed 100Mb
by Gaggery Tsai (Code Review) 21 Dec '17

21 Dec '17

Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/22964 Change subject: mb/google/fizz: revise LED0 behavior for link speed 100Mb ...................................................................... mb/google/fizz: revise LED0 behavior for link speed 100Mb This patch revises LED0 Green light behavior from patch 2ecf3f8c. For 100Mb link speed, LED0 should be OFF. BUG=b:65437780, b:68284778, b:69950854 BRANCH=None TEST=Run DUT with 100Mb and 1000Mb ethernet connection and observe LED0 is behaving as expected. Change-Id: Ia805c955711b8ce77eba087a28427a005c456fa1 Signed-off-by: Gaggery Tsai <gaggery.tsai(a)intel.com> --- M src/mainboard/google/fizz/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/22964/1 diff --git a/src/mainboard/google/fizz/devicetree.cb b/src/mainboard/google/fizz/devicetree.cb index 18031d6..8adc4ce 100644 --- a/src/mainboard/google/fizz/devicetree.cb +++ b/src/mainboard/google/fizz/devicetree.cb @@ -291,7 +291,7 @@ device pci 19.2 off end # I2C #4 device pci 1c.0 on # PCI Express Port 1 chip drivers/net - register "customized_leds" = "0x0fa7" + register "customized_leds" = "0x0fa5" register "wake" = "GPE0_PCI_EXP" device pci 00.0 on end end @@ -311,7 +311,7 @@ device pci 1c.7 off end # PCI Express Port 8 device pci 1d.0 on # PCI Express Port 9 for 2nd LAN chip drivers/net - register "customized_leds" = "0x0fa7" + register "customized_leds" = "0x0fa5" device pci 00.0 on end end end # PCI Express Port 9 for BtoB -- To view, visit https://review.coreboot.org/22964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia805c955711b8ce77eba087a28427a005c456fa1 Gerrit-Change-Number: 22964 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Select SOC_INTEL_COMMON_BLOCK_LPC_DMI
by build bot (Jenkins) (Code Review) 21 Dec '17

21 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22963 ) Change subject: soc/intel/cannonlake: Select SOC_INTEL_COMMON_BLOCK_LPC_DMI ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19635/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64859/ : SUCCESS -- To view, visit https://review.coreboot.org/22963 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I179949a1ff5cc5d148492ac1d243b2374f505616 Gerrit-Change-Number: 22963 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Dec 2017 01:15:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common: Program OPI PCR LPC registers
by build bot (Jenkins) (Code Review) 21 Dec '17

21 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22941 ) Change subject: soc/intel/common: Program OPI PCR LPC registers ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19634/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64858/ : SUCCESS -- To view, visit https://review.coreboot.org/22941 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I520afa8c5b2113efab7b224c7f3002fb30ff57f4 Gerrit-Change-Number: 22941 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Dec 2017 01:09:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Select SOC_INTEL_COMMON_BLOCK_LPC_DMI
by Lijian Zhao (Code Review) 21 Dec '17

21 Dec '17

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/22963 Change subject: soc/intel/cannonlake: Select SOC_INTEL_COMMON_BLOCK_LPC_DMI ...................................................................... soc/intel/cannonlake: Select SOC_INTEL_COMMON_BLOCK_LPC_DMI BUG=b.70765863 Change-Id: I179949a1ff5cc5d148492ac1d243b2374f505616 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/22963/1 diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index beb812b..a4779f9 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -55,7 +55,7 @@ select SOC_INTEL_COMMON_BLOCK_GSPI select SOC_INTEL_COMMON_BLOCK_ITSS select SOC_INTEL_COMMON_BLOCK_I2C - select SOC_INTEL_COMMON_BLOCK_LPC + select SOC_INTEL_COMMON_BLOCK_LPC_DMI select SOC_INTEL_COMMON_BLOCK_LPSS select SOC_INTEL_COMMON_BLOCK_P2SB select SOC_INTEL_COMMON_BLOCK_PCR -- To view, visit https://review.coreboot.org/22963 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I179949a1ff5cc5d148492ac1d243b2374f505616 Gerrit-Change-Number: 22963 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>

1 0

Change in coreboot[master]: libpayload/arch/x86: support read cpu speed from msr
by build bot (Jenkins) (Code Review) 21 Dec '17

21 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22943 ) Change subject: libpayload/arch/x86: support read cpu speed from msr ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19633/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64857/ : SUCCESS -- To view, visit https://review.coreboot.org/22943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69da73ab479785c7b5d8add15705c1cd42925a75 Gerrit-Change-Number: 22943 Gerrit-PatchSet: 3 Gerrit-Owner: JianfengX Zhou <jianfengx.zhou(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: JianfengX Zhou <jianfengx.zhou(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Dec 2017 00:45:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017