build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22935 )
Change subject: superio/f71869ad: Add temperature sensor type
......................................................................
Patch Set 2:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/19653/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/64879/ : SUCCESS
--
To view, visit https://review.coreboot.org/22935
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af0d93061ec49aec7a9181cdf7affd60fbdca73
Gerrit-Change-Number: 22935
Gerrit-PatchSet: 2
Gerrit-Owner: Renze Nicolai <renze(a)rnplus.nl>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 21 Dec 2017 15:06:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22966 )
Change subject: mainboard/nf81-t56n-lf: Add temperature sensor configuration
......................................................................
Patch Set 2:
Build Failed
https://qa.coreboot.org/job/coreboot-gerrit/64878/ : FAILURE
--
To view, visit https://review.coreboot.org/22966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42980988267621def6576f771f1d8a853500e867
Gerrit-Change-Number: 22966
Gerrit-PatchSet: 2
Gerrit-Owner: Renze Nicolai <renze(a)rnplus.nl>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 21 Dec 2017 14:54:08 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Renze Nicolai has uploaded this change for review. ( https://review.coreboot.org/22966
Change subject: mainboard/nf81-t56n-lf: Add temperature sensor configuration
......................................................................
mainboard/nf81-t56n-lf: Add temperature sensor configuration
This patch adds the temperature sensor type device tree setting,
configured to be the default value as stated in the superio datasheet.
(page 60)
bit 7-4: reserved (0)
bit 3: T3_MODE 1 (default) = BJT, 0 = thermistor
bit 2: T2_MODE 1 (default) = BJT, 0 = thermistor
bit 1: T1_MODE 1 (default) = BJT, 0 = thermistor
bit 0: reserved (0)
This results in a default value of 0x0E
This change is needed to make sure behaviour does not change after
applying change 22935 which adds the temperature sensor type
devicetree configuration option
Change-Id: I42980988267621def6576f771f1d8a853500e867
Signed-off-by: Renze Nicolai <renze(a)rnplus.nl>
---
M src/mainboard/jetway/nf81-t56n-lf/devicetree.cb
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/22966/1
diff --git a/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb b/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb
index 0db35ce..dd442b2 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb
+++ b/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb
@@ -68,6 +68,7 @@
register "hwm_fan1_seg2_speed_count" = "0x0e"
register "hwm_fan1_seg3_speed_count" = "0x07"
register "hwm_fan1_temp_map_sel" = "0x8c"
+ register "hwm_temp_sensor_type" = "0x0E" # default value
#
# XXX: 4e is the default index port and .xy is the
# LDN indexing the pnp_info array found in the superio.c
--
To view, visit https://review.coreboot.org/22966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I42980988267621def6576f771f1d8a853500e867
Gerrit-Change-Number: 22966
Gerrit-PatchSet: 1
Gerrit-Owner: Renze Nicolai <renze(a)rnplus.nl>