coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/amd/common: Move files to common/block
by Richard Spiegel (Code Review) 07 Dec '17

07 Dec '17

Hello build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/22765 to look at the new patch set (#2). Change subject: soc/amd/common: Move files to common/block ...................................................................... soc/amd/common: Move files to common/block The following files need to be moved: amd_pci_util.c, amd_pci_util.h and spi.c. The remaining files are AGESA related and will be part of a separate issue/commit. BUG=b:62240201 TEST=Build with no error gardenia and kahlee (no code change, just folder reorg). Change-Id: I3f965afa21124d4874d3b7bfe0f404a58b070e23 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/mainboard/amd/gardenia/mainboard.c M src/mainboard/amd/gardenia/mptable.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kahlee/mptable.c M src/soc/amd/common/Makefile.inc R src/soc/amd/common/block/include/amdblocks/amd_pci_util.h A src/soc/amd/common/block/pci/Kconfig A src/soc/amd/common/block/pci/Makefile.inc R src/soc/amd/common/block/pci/amd_pci_util.c A src/soc/amd/common/block/spi/Kconfig A src/soc/amd/common/block/spi/Makefile.inc R src/soc/amd/common/block/spi/spi.c M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/southbridge.c 14 files changed, 32 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/22765/2 -- To view, visit https://review.coreboot.org/22765 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f965afa21124d4874d3b7bfe0f404a58b070e23 Gerrit-Change-Number: 22765 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/amd/common: Move files to common/block
by Richard Spiegel (Code Review) 07 Dec '17

07 Dec '17

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22765 ) Change subject: soc/amd/common: Move files to common/block ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/22765/1/src/soc/amd/common/block/pci/amd_pc… File src/soc/amd/common/block/pci/amd_pci_util.c: https://review.coreboot.org/#/c/22765/1/src/soc/amd/common/block/pci/amd_pc… PS1, Line 177: printk > Remove the added space please. Ok, my mistake. https://review.coreboot.org/#/c/22765/1/src/soc/amd/common/block/spi/Kconfig File src/soc/amd/common/block/spi/Kconfig: https://review.coreboot.org/#/c/22765/1/src/soc/amd/common/block/spi/Kconfi… PS1, Line 5: This option allows the SOC to use AMD common PCI utilities : to program IRQ. If this option is not used, the SOC must : implement these functions separately. > Wrong help message. Ok, will fix it. -- To view, visit https://review.coreboot.org/22765 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f965afa21124d4874d3b7bfe0f404a58b070e23 Gerrit-Change-Number: 22765 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:19:35 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mainboard/intel/glkrvp: Configure Prmrr and Enable SGX
by build bot (Jenkins) (Code Review) 07 Dec '17

07 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21278 ) Change subject: mainboard/intel/glkrvp: Configure Prmrr and Enable SGX ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19092/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64273/ : SUCCESS -- To view, visit https://review.coreboot.org/21278 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa39df4a1da84bae49551a9626257bda0729752b Gerrit-Change-Number: 21278 Gerrit-PatchSet: 5 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:18:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/soc/intel/apollolake: include helpers.h in chip.h
by build bot (Jenkins) (Code Review) 07 Dec '17

07 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22774 ) Change subject: src/soc/intel/apollolake: include helpers.h in chip.h ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19091/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64272/ : SUCCESS -- To view, visit https://review.coreboot.org/22774 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idfdee637a9b66a30be31b9ed113e1a44e4032f34 Gerrit-Change-Number: 22774 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:18:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Add SMI and SCI support for ESPI
by build bot (Jenkins) (Code Review) 07 Dec '17

07 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22758 ) Change subject: soc/intel/apollolake: Add SMI and SCI support for ESPI ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19089/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64270/ : SUCCESS -- To view, visit https://review.coreboot.org/22758 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b8372ffbe0949ddd4aa83bdd7c0a01ade3ed40e Gerrit-Change-Number: 22758 Gerrit-PatchSet: 4 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:18:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/soc/intel/apollolake: include helpers.h in chip.h
by Pratikkumar V Prajapati (Code Review) 07 Dec '17

07 Dec '17

Pratikkumar V Prajapati has uploaded this change for review. ( https://review.coreboot.org/22774 Change subject: src/soc/intel/apollolake: include helpers.h in chip.h ...................................................................... src/soc/intel/apollolake: include helpers.h in chip.h include helpers.h in chip.h so that devicetree can use macros from helpers.h Change-Id: Idfdee637a9b66a30be31b9ed113e1a44e4032f34 Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com> --- M src/soc/intel/apollolake/chip.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/22774/1 diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h index 92e814b..a6edfc4 100644 --- a/src/soc/intel/apollolake/chip.h +++ b/src/soc/intel/apollolake/chip.h @@ -19,6 +19,7 @@ #ifndef _SOC_APOLLOLAKE_CHIP_H_ #define _SOC_APOLLOLAKE_CHIP_H_ +#include <commonlib/helpers.h> #include <soc/gpe.h> #include <soc/gpio.h> #include <intelblocks/lpc_lib.h> -- To view, visit https://review.coreboot.org/22774 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idfdee637a9b66a30be31b9ed113e1a44e4032f34 Gerrit-Change-Number: 22774 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>

1 0

Change in coreboot[master]: buildgcc: Drop libelf/elfutils
by build bot (Jenkins) (Code Review) 07 Dec '17

07 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22773 ) Change subject: buildgcc: Drop libelf/elfutils ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19086/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64267/ : SUCCESS https://qa.coreboot.org/job/coreboot-toolchain/393/ : SUCCESS -- To view, visit https://review.coreboot.org/22773 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff308a9bed9ae3842557d251b75d1faadfafe0da Gerrit-Change-Number: 22773 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 18:29:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Delete early_setup.c
by build bot (Jenkins) (Code Review) 07 Dec '17

07 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22569 ) Change subject: amd/stoneyridge: Delete early_setup.c ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19088/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64269/ : SUCCESS -- To view, visit https://review.coreboot.org/22569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe75a2d5cc46641e9d0af462a8a0ba5bb7a0f9c3 Gerrit-Change-Number: 22569 Gerrit-PatchSet: 8 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 18:12:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Delete early_setup.c
by build bot (Jenkins) (Code Review) 07 Dec '17

07 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22569 ) Change subject: amd/stoneyridge: Delete early_setup.c ...................................................................... Patch Set 7: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/64268/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/19087/ : SUCCESS -- To view, visit https://review.coreboot.org/22569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe75a2d5cc46641e9d0af462a8a0ba5bb7a0f9c3 Gerrit-Change-Number: 22569 Gerrit-PatchSet: 7 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 17:03:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: kahlee/ec.c: Use new wide IO function
by build bot (Jenkins) (Code Review) 07 Dec '17

07 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22591 ) Change subject: kahlee/ec.c: Use new wide IO function ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19085/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64266/ : SUCCESS -- To view, visit https://review.coreboot.org/22591 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea17f4f636aab6bd8b05b1b3bed53a677164e74 Gerrit-Change-Number: 22591 Gerrit-PatchSet: 5 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 16:55:18 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017