coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: intel/bd82x6x: Add missing IRQ routes
by build bot (Jenkins) (Code Review) 07 Dec '17

07 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22622 ) Change subject: intel/bd82x6x: Add missing IRQ routes ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19096/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64278/ : SUCCESS -- To view, visit https://review.coreboot.org/22622 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id14f4e2fb03e0a9149c443487665f6eb04c4d3bd Gerrit-Change-Number: 22622 Gerrit-PatchSet: 4 Gerrit-Owner: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 21:46:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Change Scarlet SKU ID pins to pull-ups
by build bot (Jenkins) (Code Review) 07 Dec '17

07 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22775 ) Change subject: google/gru: Change Scarlet SKU ID pins to pull-ups ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19095/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64277/ : SUCCESS -- To view, visit https://review.coreboot.org/22775 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9314617e01d35898254984529f269d4442e736f1 Gerrit-Change-Number: 22775 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 21:26:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Move files to common/block
by Richard Spiegel (Code Review) 07 Dec '17

07 Dec '17

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22765 ) Change subject: soc/amd/common: Move files to common/block ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/22765/2/src/soc/amd/common/block/spi/Kconfig File src/soc/amd/common/block/spi/Kconfig: https://review.coreboot.org/#/c/22765/2/src/soc/amd/common/block/spi/Kconfi… PS2, Line 5: This option allows the SOC to use AMD common PCI utilities : to program IRQ. If this option is not used, the SOC must : implement these functions separately. > You fixed up the other one - this help text still needs to be updated. Ok, it's not even related to SPI... will fix. -- To view, visit https://review.coreboot.org/22765 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f965afa21124d4874d3b7bfe0f404a58b070e23 Gerrit-Change-Number: 22765 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 21:06:29 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: google/gru: Change Scarlet SKU ID pins to pull-ups
by Julius Werner (Code Review) 07 Dec '17

07 Dec '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/22775 ) Change subject: google/gru: Change Scarlet SKU ID pins to pull-ups ...................................................................... Patch Set 1: Code-Review+2 Assumed trivial so I'll +2 myself... -- To view, visit https://review.coreboot.org/22775 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9314617e01d35898254984529f269d4442e736f1 Gerrit-Change-Number: 22775 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Comment-Date: Thu, 07 Dec 2017 21:01:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Change Scarlet SKU ID pins to pull-ups
by Julius Werner (Code Review) 07 Dec '17

07 Dec '17

Julius Werner has uploaded this change for review. ( https://review.coreboot.org/22775 Change subject: google/gru: Change Scarlet SKU ID pins to pull-ups ...................................................................... google/gru: Change Scarlet SKU ID pins to pull-ups These pins need to be pull-ups. I forgot. BUG=b:69373077 Change-Id: I9314617e01d35898254984529f269d4442e736f1 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/gru/boardid.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/22775/1 diff --git a/src/mainboard/google/gru/boardid.c b/src/mainboard/google/gru/boardid.c index 9dc7b05..af56f1d 100644 --- a/src/mainboard/google/gru/boardid.c +++ b/src/mainboard/google/gru/boardid.c @@ -88,6 +88,7 @@ gpio_t pins[3] = {[2] = GPIO(3, D, 6), [1] = GPIO(3, D, 5), [0] = GPIO(3, D, 4)}; /* GPIO3_D4 is LSB */ - sku_id = gpio_base2_value(pins, ARRAY_SIZE(pins)); + + sku_id = gpio_pullup_base2_value(pins, ARRAY_SIZE(pins)); return sku_id; } -- To view, visit https://review.coreboot.org/22775 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9314617e01d35898254984529f269d4442e736f1 Gerrit-Change-Number: 22775 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>

1 0

Change in coreboot[master]: soc/amd/common: Move files to common/block
by Martin Roth (Code Review) 07 Dec '17

07 Dec '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22765 ) Change subject: soc/amd/common: Move files to common/block ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/22765/2/src/soc/amd/common/block/spi/Kconfig File src/soc/amd/common/block/spi/Kconfig: https://review.coreboot.org/#/c/22765/2/src/soc/amd/common/block/spi/Kconfi… PS2, Line 5: This option allows the SOC to use AMD common PCI utilities : to program IRQ. If this option is not used, the SOC must : implement these functions separately. You fixed up the other one - this help text still needs to be updated. -- To view, visit https://review.coreboot.org/22765 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f965afa21124d4874d3b7bfe0f404a58b070e23 Gerrit-Change-Number: 22765 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 21:00:31 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: google/scarlet: update Kingdisplay kd097d04 timing
by Julius Werner (Code Review) 07 Dec '17

07 Dec '17

Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/22746 ) Change subject: google/scarlet: update Kingdisplay kd097d04 timing ...................................................................... google/scarlet: update Kingdisplay kd097d04 timing With the old timing, the hblank time isn't large enough, it may cause display artifacts. So fix it. BUG=b:70160653 TEST=panel work on Scarlet rev2 board Change-Id: Ib061f5e215611d20f59e3f24cfe3c7fbc507ebed Signed-off-by: Lin Huang <hl(a)rock-chips.com> Reviewed-on: https://review.coreboot.org/22746 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/gru/mainboard.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved diff --git a/src/mainboard/google/gru/mainboard.c b/src/mainboard/google/gru/mainboard.c index d83c486..9a241f5 100644 --- a/src/mainboard/google/gru/mainboard.c +++ b/src/mainboard/google/gru/mainboard.c @@ -527,14 +527,14 @@ static const struct edid_mode kd097d04_edid_mode = { .name = "1536x2048@60Hz", - .pixel_clock = 213000, + .pixel_clock = 216000, .refresh = 60, .ha = 1536, - .hbl = 164, - .hso = 70, + .hbl = 186, + .hso = 81, .hspw = 24, .va = 2048, - .vbl = 44, + .vbl = 42, .vso = 17, .vspw = 2, }; -- To view, visit https://review.coreboot.org/22746 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib061f5e215611d20f59e3f24cfe3c7fbc507ebed Gerrit-Change-Number: 22746 Gerrit-PatchSet: 2 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nickey yang <nickey.yang(a)rock-chips.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add RO_REGION_ONLY
by build bot (Jenkins) (Code Review) 07 Dec '17

07 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22766 ) Change subject: soc/amd/stoneyridge: Add RO_REGION_ONLY ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19094/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64276/ : SUCCESS -- To view, visit https://review.coreboot.org/22766 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieafe4a5ec4a5e3177e4e23fcf42afa2626a0b19f Gerrit-Change-Number: 22766 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 20:51:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Move files to common/block
by build bot (Jenkins) (Code Review) 07 Dec '17

07 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22765 ) Change subject: soc/amd/common: Move files to common/block ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19093/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64275/ : SUCCESS -- To view, visit https://review.coreboot.org/22765 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f965afa21124d4874d3b7bfe0f404a58b070e23 Gerrit-Change-Number: 22765 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:45:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/compulab/intense_pc: enable SuperIO UART
by build bot (Jenkins) (Code Review) 07 Dec '17

07 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22737 ) Change subject: mb/compulab/intense_pc: enable SuperIO UART ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19090/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64271/ : SUCCESS -- To view, visit https://review.coreboot.org/22737 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11a4c532ed73a0cf27d6e7bef6e04035c3942567 Gerrit-Change-Number: 22737 Gerrit-PatchSet: 4 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:38:35 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017