coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: google/kahlee/: Add SPD function
by build bot (Jenkins) (Code Review) 22 Nov '17

22 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22486 ) Change subject: google/kahlee/: Add SPD function ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18569/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63671/ : SUCCESS -- To view, visit https://review.coreboot.org/22486 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I789002bfadc1a2b24f9046708986d29c0e2daf33 Gerrit-Change-Number: 22486 Gerrit-PatchSet: 6 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 22 Nov 2017 07:52:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Rename board_id to memory_sku
by Marc Jones (Code Review) 22 Nov '17

22 Nov '17

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/22561 Change subject: google/kahlee: Rename board_id to memory_sku ...................................................................... google/kahlee: Rename board_id to memory_sku Rename the GPIOs that are named as board_id to memory_skus. Report the boardid received from the EC. BUG=b:69649438 Change-Id: I84bacead3daf829c97f595c4c11a243953243c29 Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/kahlee/Makefile.inc D src/mainboard/google/kahlee/boardid.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/kahlee/variants/baseboard/memory.c 6 files changed, 7 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/22561/1 diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index 7173f1d..6cb9e2a 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -19,6 +19,7 @@ select BOARD_ROMSIZE_KB_8192 select DRIVERS_PS2_KEYBOARD select EC_GOOGLE_CHROMEEC + select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_LPC select HAVE_OPTION_TABLE select HAVE_ACPI_TABLES diff --git a/src/mainboard/google/kahlee/Makefile.inc b/src/mainboard/google/kahlee/Makefile.inc index 131eba3..55c80a4 100644 --- a/src/mainboard/google/kahlee/Makefile.inc +++ b/src/mainboard/google/kahlee/Makefile.inc @@ -19,12 +19,10 @@ bootblock-y += ec.c romstage-y += BiosCallOuts.c -romstage-y += boardid.c romstage-y += chromeos.c romstage-y += OemCustomize.c ramstage-y += BiosCallOuts.c -ramstage-y += boardid.c ramstage-y += chromeos.c ramstage-y += ec.c ramstage-y += OemCustomize.c diff --git a/src/mainboard/google/kahlee/boardid.c b/src/mainboard/google/kahlee/boardid.c deleted file mode 100644 index 5b59f32..0000000 --- a/src/mainboard/google/kahlee/boardid.c +++ /dev/null @@ -1,32 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2017 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <boardid.h> -#include <console/console.h> -#include <gpio.h> -#include <variant/gpio.h> -#include <baseboard/variants.h> - -uint8_t board_id(void) -{ - MAYBE_STATIC int id = -1; - - if (id < 0) { - id = variant_board_id(); - printk(BIOS_SPEW, "Board ID: %#x.\n", id); - } - - return id; -} diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index 643bda1..f757504 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -20,6 +20,7 @@ #include <amd_pci_util.h> #include <cbmem.h> #include <baseboard/variants.h> +#include <boardid.h> #include <soc/nvs.h> #include <soc/smi.h> #include <variant/ec.h> @@ -86,6 +87,9 @@ { const struct sci_source *gpes; size_t num; + int boardid = board_id(); + + printk(BIOS_INFO, "Board ID: %d\n", boardid); mainboard_ec_init(); diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h index cf995fc..45d287a 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h @@ -23,6 +23,6 @@ const GPIO_CONTROL *get_gpio_table(void); const struct sci_source *get_gpe_table(size_t *num); -uint8_t variant_board_id(void); +uint8_t variant_memory_sku(void); #endif /* __BASEBOARD_VARIANTS_H__ */ diff --git a/src/mainboard/google/kahlee/variants/baseboard/memory.c b/src/mainboard/google/kahlee/variants/baseboard/memory.c index ae8734e..daa5ef9 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/memory.c +++ b/src/mainboard/google/kahlee/variants/baseboard/memory.c @@ -17,7 +17,7 @@ #include <baseboard/variants.h> #include <variant/gpio.h> -uint8_t __attribute__((weak)) variant_board_id(void) +uint8_t __attribute__((weak)) variant_memory_sku(void) { gpio_t pads[] = { [3] = MEM_CONFIG3, -- To view, visit https://review.coreboot.org/22561 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I84bacead3daf829c97f595c4c11a243953243c29 Gerrit-Change-Number: 22561 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Disable camera devices
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22559 ) Change subject: mb/google/poppy/variants/nautilus: Disable camera devices ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18567/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63669/ : SUCCESS -- To view, visit https://review.coreboot.org/22559 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7de37cbf9c32fa063f55a2e54986e33b66acfa3b Gerrit-Change-Number: 22559 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: shkim <sh_.kim(a)samsung.com> Gerrit-Comment-Date: Wed, 22 Nov 2017 06:57:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Disable DPTF
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22560 ) Change subject: mb/google/poppy/variants/nautilus: Disable DPTF ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18568/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63670/ : SUCCESS -- To view, visit https://review.coreboot.org/22560 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68f2442e00718a4edbb34661d31d3a415d41c29f Gerrit-Change-Number: 22560 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: shkim <sh_.kim(a)samsung.com> Gerrit-Comment-Date: Wed, 22 Nov 2017 06:57:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Add variant support for camera asl
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22558 ) Change subject: mb/google/poppy: Add variant support for camera asl ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63668/ : SUCCESS -- To view, visit https://review.coreboot.org/22558 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f0b489e74739aa4708283d58d8b7626b77a89a3 Gerrit-Change-Number: 22558 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: shkim <sh_.kim(a)samsung.com> Gerrit-Comment-Date: Wed, 22 Nov 2017 06:54:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: chromeec: Change the API for hostevent/wake masks to handle 64-bit
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22551 ) Change subject: chromeec: Change the API for hostevent/wake masks to handle 64-bit ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18564/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63665/ : SUCCESS -- To view, visit https://review.coreboot.org/22551 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If59f3f2b1a2aa5ce95883df3e72efc4a32de1190 Gerrit-Change-Number: 22551 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 22 Nov 2017 06:53:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Disable DPTF
by Furquan Shaikh (Code Review) 21 Nov '17

21 Nov '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22560 Change subject: mb/google/poppy/variants/nautilus: Disable DPTF ...................................................................... mb/google/poppy/variants/nautilus: Disable DPTF This change disables DPTF until the support is properly added in dptf.asl Change-Id: I68f2442e00718a4edbb34661d31d3a415d41c29f Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/dptf.asl 2 files changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/22560/1 diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index 253088a..ca22da4 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -21,9 +21,6 @@ # EC memory map range is 0x900-0x9ff register "gen3_dec" = "0x00fc0901" - # Enable DPTF - register "dptf_enable" = "1" - # Enable S0ix register "s0ix_enable" = "1" diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/dptf.asl b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/dptf.asl index a9ec742..216b76f 100644 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/dptf.asl @@ -13,4 +13,4 @@ * GNU General Public License for more details. */ -#include <baseboard/acpi/dptf.asl> +/* Dummy file until DPTF support is added. */ -- To view, visit https://review.coreboot.org/22560 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I68f2442e00718a4edbb34661d31d3a415d41c29f Gerrit-Change-Number: 22560 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy: Add variant support for camera asl
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22558 ) Change subject: mb/google/poppy: Add variant support for camera asl ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63667/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18566/ : SUCCESS -- To view, visit https://review.coreboot.org/22558 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f0b489e74739aa4708283d58d8b7626b77a89a3 Gerrit-Change-Number: 22558 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 22 Nov 2017 06:48:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Disable camera devices
by Furquan Shaikh (Code Review) 21 Nov '17

21 Nov '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22559 Change subject: mb/google/poppy/variants/nautilus: Disable camera devices ...................................................................... mb/google/poppy/variants/nautilus: Disable camera devices This change disables camera devices until camera support is properly added for nautilus. Change-Id: I7de37cbf9c32fa063f55a2e54986e33b66acfa3b Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/poppy/variants/nautilus/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/22559/1 diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index efaea3f..253088a 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -41,8 +41,8 @@ register "XdciEnable" = "0" register "SsicPortEnable" = "0" register "SmbusEnable" = "1" - register "Cio2Enable" = "1" - register "SaImguEnable" = "1" + register "Cio2Enable" = "0" + register "SaImguEnable" = "0" register "ScsEmmcEnabled" = "1" register "ScsEmmcHs400Enabled" = "1" register "ScsSdCardEnabled" = "2" -- To view, visit https://review.coreboot.org/22559 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7de37cbf9c32fa063f55a2e54986e33b66acfa3b Gerrit-Change-Number: 22559 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy: Add variant support for camera asl
by Furquan Shaikh (Code Review) 21 Nov '17

21 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22558 to look at the new patch set (#4). Change subject: mb/google/poppy: Add variant support for camera asl ...................................................................... mb/google/poppy: Add variant support for camera asl This change adds infrastructure to allow variants to define their own camera.asl file. - Poppy and soraka use the one provided by baseboard. - Dummy file is added for nautilus since it does not have camera support enabled yet. TEST=Verified that DSDT table remains the same with and without this change. Change-Id: I0f0b489e74739aa4708283d58d8b7626b77a89a3 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/poppy/dsdt.asl A src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl R src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl R src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/mipi_camera.asl A src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/camera.asl A src/mainboard/google/poppy/variants/poppy/include/variant/acpi/camera.asl A src/mainboard/google/poppy/variants/soraka/include/variant/acpi/camera.asl 7 files changed, 67 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/22558/4 -- To view, visit https://review.coreboot.org/22558 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0f0b489e74739aa4708283d58d8b7626b77a89a3 Gerrit-Change-Number: 22558 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017