coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: util/intelmetool: Add Skylake support
by Patrick Rudolph (Code Review) 25 Nov '17

25 Nov '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/22599 Change subject: util/intelmetool: Add Skylake support ...................................................................... util/intelmetool: Add Skylake support Skylake doesn't have RCBA anymore. Don't try to access RCBA on Skylake platforms. FIXME: Add support for P2SB. Change-Id: I920b1dac124bf0fc6d13fd9ceab12ecd575c1252 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M util/intelmetool/intelmetool.c 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/22599/1 diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c index 0b0e509..65249bd 100644 --- a/util/intelmetool/intelmetool.c +++ b/util/intelmetool/intelmetool.c @@ -75,6 +75,22 @@ return !strncmp((char *)&regs, "GenuineIntel", CPU_ID_SIZE-1); } +static int isSkylakeCompatibel(void) +{ + regs_t regs; + unsigned int level = 0; + unsigned int family, model, ext_model; + unsigned int eax = 1; + + __get_cpuid(level, &eax, &regs.ebx, &regs.ecx, &regs.edx); + + family = ((eax & 0xf00) >> 8); + ext_model = ((eax & 0xf0000) >> 12); + model = ((eax & 0xf0) >> 4); + return (family == 6 && model == 0xe && ext_model == 4) && + (family == 6 && model == 0xe && ext_model == 5); +} + /* You need >4GB total ram, in kernel cmdline, use 'mem=1000m' * then this code will clone to absolute memory address 0xe0000000 * which can be read using a mmap tool at that offset. @@ -178,6 +194,11 @@ static int activate_me(void) { + /* RCBA is supported up to Intel's 5th Gen. CPUs */ + if (isSkylakeCompatibel()) + /* FIXME: Add Skylake support */ + return 0; + if (read_rcba32(FD2, &fd2)) { printf("Error reading RCBA\n"); return 1; @@ -197,6 +218,11 @@ static void rehide_me(void) { + /* RCBA is supported up to Intel's 5th Gen. CPUs */ + if (isSkylakeCompatibel()) + /* FIXME: Add Skylake support */ + return; + if (fd2 & 0x2) { if (debug) printf("Re-hiding MEI device..."); -- To view, visit https://review.coreboot.org/22599 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I920b1dac124bf0fc6d13fd9ceab12ecd575c1252 Gerrit-Change-Number: 22599 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: util/intelmetool: Fix some platforms
by Philipp Deppenwiese (Code Review) 25 Nov '17

25 Nov '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22598 ) Change subject: util/intelmetool: Fix some platforms ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22598 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafe3f5c22c6caeedc556933405b9f6d83ec876a1 Gerrit-Change-Number: 22598 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 14:06:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/intelmetool: Fix some platforms
by build bot (Jenkins) (Code Review) 25 Nov '17

25 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22598 ) Change subject: util/intelmetool: Fix some platforms ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18653/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63768/ : SUCCESS -- To view, visit https://review.coreboot.org/22598 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafe3f5c22c6caeedc556933405b9f6d83ec876a1 Gerrit-Change-Number: 22598 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 14:05:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/intelmetool: Fix some platforms
by Patrick Rudolph (Code Review) 25 Nov '17

25 Nov '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/22598 Change subject: util/intelmetool: Fix some platforms ...................................................................... util/intelmetool: Fix some platforms Bootguard: * Fix Mac support (ME_version can't be detected) * Skip MSR read on older platforms (as it would fail anyway) * Refactor MSR error handling * Print Bootguard state "Unknown" on MSR read error Change-Id: Iafe3f5c22c6caeedc556933405b9f6d83ec876a1 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M util/intelmetool/intelmetool.c M util/intelmetool/msr.c 2 files changed, 17 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/22598/1 diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c index 2e22899..0b0e509 100644 --- a/util/intelmetool/intelmetool.c +++ b/util/intelmetool/intelmetool.c @@ -308,9 +308,6 @@ const char *name; uint64_t bootguard = 0; - if (msr_bootguard(&bootguard, debug) < 0) - return; - if (pci_platform_scan()) exit(1); @@ -328,9 +325,11 @@ bootguard &= ~0xff; } - if (ME_major_ver < 9 || - (ME_major_ver == 9 && ME_minor_ver < 5) || - !BOOTGUARD_CAPABILITY(bootguard)) { + /* ME_major_ver is zero on some platforms (Mac) */ + if (ME_major_ver && + (ME_major_ver < 9 || + (ME_major_ver == 9 && ME_minor_ver < 5) || + !BOOTGUARD_CAPABILITY(bootguard))) { print_cap("BootGuard ", 0); printf(CGRN "\nYour system isn't bootguard ready. You can " "flash other firmware!\n" RESET); @@ -338,6 +337,12 @@ return; } + if (msr_bootguard(&bootguard, debug) < 0) { + printf("ME Capability: %-43s: " CCYN "%s\n" RESET, + "BootGuard Mode", "Unknown"); + return; + } + print_cap("BootGuard ", 1); if (pci_read_long(dev, 0x40) & 0x10) printf(CYEL "Your southbridge configuration is insecure!! " diff --git a/util/intelmetool/msr.c b/util/intelmetool/msr.c index 1010c0e..d1e510f 100644 --- a/util/intelmetool/msr.c +++ b/util/intelmetool/msr.c @@ -26,28 +26,23 @@ #ifndef __DARWIN__ static int fd_msr = 0; -static uint64_t rdmsr(int addr) +static int rdmsr(int addr, uint64_t *msr) { - uint32_t buf[2]; - uint64_t msr = 0; - if (lseek(fd_msr, (off_t) addr, SEEK_SET) == -1) { perror("Could not lseek() to MSR"); close(fd_msr); return -1; } - if (read(fd_msr, buf, 8) == 8) { - msr = buf[1]; - msr <<= 32; - msr |= buf[0]; + if (read(fd_msr, msr, 8) == 8) { close(fd_msr); - return msr; + return 0; } if (errno == EIO) { perror("IO error couldn't read MSR."); close(fd_msr); + /* On older platforms the MSR might not exists */ return -2; } @@ -68,7 +63,8 @@ return -1; } - *msr = rdmsr(MSR_BOOTGUARD); + if (rdmsr(MSR_BOOTGUARD, msr) < 0) + return -1; #endif if (!debug) -- To view, visit https://review.coreboot.org/22598 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iafe3f5c22c6caeedc556933405b9f6d83ec876a1 Gerrit-Change-Number: 22598 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: util/intelmetool: Add bootguard information dump support
by build bot (Jenkins) (Code Review) 25 Nov '17

25 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/16328 ) Change subject: util/intelmetool: Add bootguard information dump support ...................................................................... Patch Set 27: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18652/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63767/ : SUCCESS -- To view, visit https://review.coreboot.org/16328 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifeec8e20fa8efc35d7db4c6a84be1f118dccfc4a Gerrit-Change-Number: 16328 Gerrit-PatchSet: 27 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathias Krause <minipli(a)googlemail.com> Gerrit-Reviewer: Maximilian Schander <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 13:18:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/intelmetool: Fix lint errors and warnings
by build bot (Jenkins) (Code Review) 25 Nov '17

25 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22521 ) Change subject: util/intelmetool: Fix lint errors and warnings ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63766/ : SUCCESS -- To view, visit https://review.coreboot.org/22521 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8e3617ebb34c47959d6619dfbc7189045e6b8f7 Gerrit-Change-Number: 22521 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 13:15:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/intelmetool: Add bootguard information dump support
by Philipp Deppenwiese (Code Review) 25 Nov '17

25 Nov '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/16328 ) Change subject: util/intelmetool: Add bootguard information dump support ...................................................................... Patch Set 26: Code-Review+2 -- To view, visit https://review.coreboot.org/16328 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifeec8e20fa8efc35d7db4c6a84be1f118dccfc4a Gerrit-Change-Number: 16328 Gerrit-PatchSet: 26 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathias Krause <minipli(a)googlemail.com> Gerrit-Reviewer: Maximilian Schander <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 12:54:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/intelmetool: Fix lint errors and warnings
by Philipp Deppenwiese (Code Review) 25 Nov '17

25 Nov '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22521 ) Change subject: util/intelmetool: Fix lint errors and warnings ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/22521 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8e3617ebb34c47959d6619dfbc7189045e6b8f7 Gerrit-Change-Number: 22521 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 12:51:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: acpi/tpm: remove non-existent IRQ for Infineon TPM chip
by Philipp Deppenwiese (Code Review) 25 Nov '17

25 Nov '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22582 ) Change subject: acpi/tpm: remove non-existent IRQ for Infineon TPM chip ...................................................................... Patch Set 2: -Code-Review Does it affect other TPMs ?? -- To view, visit https://review.coreboot.org/22582 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id510c73cfdc14b7f82b0cc695691b55423185a0b Gerrit-Change-Number: 22582 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 12:47:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: acpi/tpm: remove non-existent IRQ for Infineon TPM chip
by Philipp Deppenwiese (Code Review) 25 Nov '17

25 Nov '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22582 ) Change subject: acpi/tpm: remove non-existent IRQ for Infineon TPM chip ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/22582 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id510c73cfdc14b7f82b0cc695691b55423185a0b Gerrit-Change-Number: 22582 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 12:46:52 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017