coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: lenovo/x230: increase backlight PWM frequency
by Arthur Heymans (Code Review) 25 Nov '17

25 Nov '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/22592 ) Change subject: lenovo/x230: increase backlight PWM frequency ...................................................................... Patch Set 1: Even on LED backlit displays this tends to vary over pannels with too high frequency not working all that well either. But 220Hz is to slow for sure... -- To view, visit https://review.coreboot.org/22592 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71434233b50e8e2adf47326cd4c4dd98ca38a542 Gerrit-Change-Number: 22592 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 12:24:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/riscv: Remove supervisor_trap_entry
by build bot (Jenkins) (Code Review) 25 Nov '17

25 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22595 ) Change subject: arch/riscv: Remove supervisor_trap_entry ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63765/ : SUCCESS -- To view, visit https://review.coreboot.org/22595 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7324d9c8897d5c4e9d4784e7bc2a055890eab698 Gerrit-Change-Number: 22595 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 11:54:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: acpi/tpm: update TPM preprocessor guards
by Philipp Deppenwiese (Code Review) 25 Nov '17

25 Nov '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22581 ) Change subject: acpi/tpm: update TPM preprocessor guards ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22581 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c0d67dd3b044fe468002dff9eeb4f75f9934f9 Gerrit-Change-Number: 22581 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 11:13:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soraka: move WLAN_PE_RST gpio pad entry to early_gpio_table
by Rizwan Qureshi (Code Review) 25 Nov '17

25 Nov '17

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/22587 ) Change subject: soraka: move WLAN_PE_RST gpio pad entry to early_gpio_table ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/22587 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c7a4a3871a3bff69c1136379c78a8368c6258a6 Gerrit-Change-Number: 22587 Gerrit-PatchSet: 4 Gerrit-Owner: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 04:17:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: inteltool: add hint for the compiler to avoid fall through warning
by build bot (Jenkins) (Code Review) 25 Nov '17

25 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22597 ) Change subject: inteltool: add hint for the compiler to avoid fall through warning ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18651/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63764/ : SUCCESS -- To view, visit https://review.coreboot.org/22597 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0cafb73a54ed4166830f6a4449558ab813a9dbe Gerrit-Change-Number: 22597 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Nov 2017 00:57:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: inteltool: add hint for the compiler to avoid fall through warning
by Felix Held (Code Review) 25 Nov '17

25 Nov '17

Felix Held has uploaded this change for review. ( https://review.coreboot.org/22597 Change subject: inteltool: add hint for the compiler to avoid fall through warning ...................................................................... inteltool: add hint for the compiler to avoid fall through warning The fall through is intended here, so add a comment that gcc will notice and stop warning about this. Change-Id: Id0cafb73a54ed4166830f6a4449558ab813a9dbe Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> --- M util/inteltool/pcie.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/22597/1 diff --git a/util/inteltool/pcie.c b/util/inteltool/pcie.c index 541d9ca..af65a57 100644 --- a/util/inteltool/pcie.c +++ b/util/inteltool/pcie.c @@ -363,6 +363,7 @@ case PCI_DEVICE_ID_INTEL_CORE_2ND_GEN_E3: dmi_registers = sandybridge_dmi_registers; size = ARRAY_SIZE(sandybridge_dmi_registers); + // fall through case PCI_DEVICE_ID_INTEL_CORE_3RD_GEN_D: /* pretty printing not implemented yet */ case PCI_DEVICE_ID_INTEL_CORE_3RD_GEN_M: case PCI_DEVICE_ID_INTEL_CORE_3RD_GEN_E3: -- To view, visit https://review.coreboot.org/22597 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id0cafb73a54ed4166830f6a4449558ab813a9dbe Gerrit-Change-Number: 22597 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>

1 0

Change in coreboot[master]: intel/gma: fix RPNFREQ_VAL bitmask
by build bot (Jenkins) (Code Review) 24 Nov '17

24 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22596 ) Change subject: intel/gma: fix RPNFREQ_VAL bitmask ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18650/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63763/ : SUCCESS -- To view, visit https://review.coreboot.org/22596 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f51c4929df83f948fcb7dc06e07ac3cc4ccf4f2 Gerrit-Change-Number: 22596 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Nov 2017 23:54:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/gma: fix RPNFREQ_VAL bitmask
by Felix Held (Code Review) 24 Nov '17

24 Nov '17

Felix Held has uploaded this change for review. ( https://review.coreboot.org/22596 Change subject: intel/gma: fix RPNFREQ_VAL bitmask ...................................................................... intel/gma: fix RPNFREQ_VAL bitmask gma.c of Nehalem was copied from Sandy/Ivy Bridge, so fix it there too Change-Id: I5f51c4929df83f948fcb7dc06e07ac3cc4ccf4f2 Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/sandybridge/gma.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/22596/1 diff --git a/src/northbridge/intel/nehalem/gma.c b/src/northbridge/intel/nehalem/gma.c index 0db8f3c..520b10e 100644 --- a/src/northbridge/intel/nehalem/gma.c +++ b/src/northbridge/intel/nehalem/gma.c @@ -491,7 +491,7 @@ /* RPNFREQ_VAL comes from MCHBAR 0x5998 23:16 (8 bits!? use 7) */ reg32 = MCHBAR32(0x5998); reg32 >>= 16; - reg32 &= 0xef; + reg32 &= 0x7f; reg32 <<= 25; gtt_write(0xa008, reg32); diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c index 61b9008..d9a9869 100644 --- a/src/northbridge/intel/sandybridge/gma.c +++ b/src/northbridge/intel/sandybridge/gma.c @@ -501,7 +501,7 @@ /* RPNFREQ_VAL comes from MCHBAR 0x5998 23:16 (8 bits!? use 7) */ reg32 = MCHBAR32(0x5998); reg32 >>= 16; - reg32 &= 0xef; + reg32 &= 0x7f; reg32 <<= 25; gtt_write(0xa008, reg32); -- To view, visit https://review.coreboot.org/22596 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5f51c4929df83f948fcb7dc06e07ac3cc4ccf4f2 Gerrit-Change-Number: 22596 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>

1 0

Change in coreboot[master]: riscv: Remove config string support
by build bot (Jenkins) (Code Review) 24 Nov '17

24 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22594 ) Change subject: riscv: Remove config string support ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18648/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63761/ : SUCCESS -- To view, visit https://review.coreboot.org/22594 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71398fb4861dbaf7eefc6e6f222bb7159798fafa Gerrit-Change-Number: 22594 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Nov 2017 23:26:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/riscv: Unify trap return
by build bot (Jenkins) (Code Review) 24 Nov '17

24 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21763 ) Change subject: arch/riscv: Unify trap return ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18644/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63757/ : SUCCESS -- To view, visit https://review.coreboot.org/21763 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9de0c92b3f925e8f4db00d7281222a07db68b2ae Gerrit-Change-Number: 21763 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Nov 2017 23:15:05 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017