coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs
by Elyes HAOUAS (Code Review) 26 Nov '17

26 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22604 to look at the new patch set (#3). Change subject: [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs ...................................................................... [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/intel/speedstep/acpi.c 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/22604/3 -- To view, visit https://review.coreboot.org/22604 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs
by build bot (Jenkins) (Code Review) 26 Nov '17

26 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 ) Change subject: [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/63785/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/18666/ : SUCCESS -- To view, visit https://review.coreboot.org/22604 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 26 Nov 2017 16:35:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs
by Elyes HAOUAS (Code Review) 26 Nov '17

26 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22604 to look at the new patch set (#2). Change subject: [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs ...................................................................... [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/intel/speedstep/acpi.c 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/22604/2 -- To view, visit https://review.coreboot.org/22604 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs
by build bot (Jenkins) (Code Review) 26 Nov '17

26 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 ) Change subject: [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/63784/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/18665/ : SUCCESS -- To view, visit https://review.coreboot.org/22604 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 26 Nov 2017 16:26:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs
by Elyes HAOUAS (Code Review) 26 Nov '17

26 Nov '17

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/22604 Change subject: [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs ...................................................................... [Test]cpu/intel/speedstep/acpi.c: Add Netburst CPUs Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/intel/speedstep/acpi.c 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/22604/1 diff --git a/src/cpu/intel/speedstep/acpi.c b/src/cpu/intel/speedstep/acpi.c index c154da0..5ffca65 100644 --- a/src/cpu/intel/speedstep/acpi.c +++ b/src/cpu/intel/speedstep/acpi.c @@ -48,9 +48,24 @@ */ static int get_fsb(void) { - const u32 fsbcode = rdmsr(MSR_FSB_FREQ).lo & 7; + + u32 fsbcode; + struct cpuinfo_x86 c; + + get_fms(&c, cpuid_eax(1)); + if ((c.x86)) == 0xf && (c.x86_model) >= 2){ + fsbcode = (rdmsr(MSR_EBC_FREQUENCY_ID).lo >> 16) & 7; + } else { + fsbcode = rdmsr(MSR_FSB_FREQ).lo & 7; + } + switch (fsbcode) { - case 0: return 800; /* / 3 == 266 */ + case 0: + if ((c.x86)) == 0xf && (c.x86_model) == 2) { + return 300; /* / 3 == 100 */ + } else { + return 800; /* / 3 == 266 */ + } case 1: return 400; /* / 3 == 133 */ case 2: return 600; /* / 3 == 200 */ case 3: return 500; /* / 3 == 166 */ -- To view, visit https://review.coreboot.org/22604 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: intel: Use MSR_EBC_FREQUENCY_ID instead of 0x2c
by build bot (Jenkins) (Code Review) 26 Nov '17

26 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22603 ) Change subject: intel: Use MSR_EBC_FREQUENCY_ID instead of 0x2c ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18664/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63783/ : SUCCESS -- To view, visit https://review.coreboot.org/22603 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1b761fc417f1bb000f408d3bed5e8666963f51d Gerrit-Change-Number: 22603 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 26 Nov 2017 14:53:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel: Use MSR_EBC_FREQUENCY_ID instead of 0x2c
by Elyes HAOUAS (Code Review) 26 Nov '17

26 Nov '17

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/22603 Change subject: intel: Use MSR_EBC_FREQUENCY_ID instead of 0x2c ...................................................................... intel: Use MSR_EBC_FREQUENCY_ID instead of 0x2c Change-Id: Ib1b761fc417f1bb000f408d3bed5e8666963f51d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/x86/lapic/apic_timer.c M src/include/cpu/intel/speedstep.h M src/mainboard/asus/p5gc-mx/romstage.c 3 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/22603/1 diff --git a/src/cpu/x86/lapic/apic_timer.c b/src/cpu/x86/lapic/apic_timer.c index 254bb07..e218d29 100644 --- a/src/cpu/x86/lapic/apic_timer.c +++ b/src/cpu/x86/lapic/apic_timer.c @@ -77,13 +77,13 @@ switch (c.x86_model) { case 0x2: car_set_var(g_timer_fsb, - f2x_fsb[(rdmsr(0x2c).lo >> 16) & 7]); + f2x_fsb[(rdmsr(MSR_EBC_FREQUENCY_ID).lo >> 16) & 7]); return 0; case 0x3: case 0x4: case 0x6: car_set_var(g_timer_fsb, - core2_fsb[(rdmsr(0x2c).lo >> 16) & 7]); + core2_fsb[(rdmsr(MSR_EBC_FREQUENCY_ID).lo >> 16) & 7]); return 0; } /* default: fallthrough */ default: diff --git a/src/include/cpu/intel/speedstep.h b/src/include/cpu/intel/speedstep.h index 40234d5..003034c 100644 --- a/src/include/cpu/intel/speedstep.h +++ b/src/include/cpu/intel/speedstep.h @@ -40,6 +40,7 @@ #define IA32_PERF_CTL 0x199 #define MSR_THERM2_CTL 0x19D #define IA32_MISC_ENABLES 0x1A0 +#define MSR_EBC_FREQUENCY_ID 0x2c #define MSR_FSB_FREQ 0xcd #define MSR_FSB_CLOCK_VCC 0xce #define MSR_PMG_CST_CONFIG_CONTROL 0xe2 diff --git a/src/mainboard/asus/p5gc-mx/romstage.c b/src/mainboard/asus/p5gc-mx/romstage.c index a29478c..69db496 100644 --- a/src/mainboard/asus/p5gc-mx/romstage.c +++ b/src/mainboard/asus/p5gc-mx/romstage.c @@ -94,7 +94,7 @@ /* Netburst */ if (((eax >> 8) & 0xf) == 0xf) { - msr = rdmsr(0x2c); + msr = rdmsr(MSR_EBC_FREQUENCY_ID); fsbcfg = (msr.lo >> 16) & 0x7; } else { /* Intel Core 2 */ msr = rdmsr(MSR_FSB_FREQ); -- To view, visit https://review.coreboot.org/22603 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib1b761fc417f1bb000f408d3bed5e8666963f51d Gerrit-Change-Number: 22603 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: mb/hp/8460p: Add TPM support
by Arthur Heymans (Code Review) 26 Nov '17

26 Nov '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/22602 ) Change subject: mb/hp/8460p: Add TPM support ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/22602 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b845928954d203d1c3608b6704fedbd590e1fa9 Gerrit-Change-Number: 22602 Gerrit-PatchSet: 2 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 26 Nov 2017 10:41:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/hp/8460p: Add TPM support
by build bot (Jenkins) (Code Review) 26 Nov '17

26 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22602 ) Change subject: mb/hp/8460p: Add TPM support ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63782/ : SUCCESS -- To view, visit https://review.coreboot.org/22602 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b845928954d203d1c3608b6704fedbd590e1fa9 Gerrit-Change-Number: 22602 Gerrit-PatchSet: 2 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 26 Nov 2017 10:11:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/hp/8460p: Add TPM support
by Bill XIE (Code Review) 26 Nov '17

26 Nov '17

Hello Iru Cai, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22602 to look at the new patch set (#2). Change subject: mb/hp/8460p: Add TPM support ...................................................................... mb/hp/8460p: Add TPM support After apply this change, /dev/tpm0 is visible inside GNU/Linux, and there is a menu items in SeaBIOS' (master only) interface. Change-Id: I3b845928954d203d1c3608b6704fedbd590e1fa9 Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M src/mainboard/hp/8460p/Kconfig M src/mainboard/hp/8460p/devicetree.cb 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/22602/2 -- To view, visit https://review.coreboot.org/22602 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3b845928954d203d1c3608b6704fedbd590e1fa9 Gerrit-Change-Number: 22602 Gerrit-PatchSet: 2 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017