coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22612 ) Change subject: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18720/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63852/ : SUCCESS -- To view, visit https://review.coreboot.org/22612 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f Gerrit-Change-Number: 22612 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 18:35:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: enable_imc_thermal_zone: fix out of bounds read
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22619 ) Change subject: enable_imc_thermal_zone: fix out of bounds read ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18719/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63851/ : SUCCESS -- To view, visit https://review.coreboot.org/22619 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic16edc607358b9a688151735e6fcb3393d3bce80 Gerrit-Change-Number: 22619 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 18:09:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Add SPD function
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22486 ) Change subject: google/kahlee: Add SPD function ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18718/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63850/ : SUCCESS -- To view, visit https://review.coreboot.org/22486 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I789002bfadc1a2b24f9046708986d29c0e2daf33 Gerrit-Change-Number: 22486 Gerrit-PatchSet: 7 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 18:06:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: enable_imc_thermal_zone: fix out of bounds read
by Richard Spiegel (Code Review) 28 Nov '17

28 Nov '17

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/22619 Change subject: enable_imc_thermal_zone: fix out of bounds read ...................................................................... enable_imc_thermal_zone: fix out of bounds read southbridge/amd/pi/hudson/imc.c procedure enable_imc_thermal_zone was identified by coverity as having out of bounds access. Copies of the procedure are present in southbridge/amd/agesa/hudson/imc.c and in soc/amd/stoneyridge/imc.c. Fix the procedure in all 3 files. Fixes coverity CID 1260807: Out-of-bounds read. BUG=b:69835834 TEST=Build and platform boot to OS Change-Id: Ic16edc607358b9a688151735e6fcb3393d3bce80 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/stoneyridge/imc.c M src/southbridge/amd/agesa/hudson/imc.c M src/southbridge/amd/pi/hudson/imc.c 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/22619/1 diff --git a/src/soc/amd/stoneyridge/imc.c b/src/soc/amd/stoneyridge/imc.c index 4c505df..1586997 100644 --- a/src/soc/amd/stoneyridge/imc.c +++ b/src/soc/amd/stoneyridge/imc.c @@ -50,7 +50,7 @@ { AMD_CONFIG_PARAMS StdHeader; UINT8 FunNum; - UINT8 regs[9]; + UINT8 regs[10]; int i; regs[0] = 0; diff --git a/src/southbridge/amd/agesa/hudson/imc.c b/src/southbridge/amd/agesa/hudson/imc.c index 799cc32..3a27d17 100644 --- a/src/southbridge/amd/agesa/hudson/imc.c +++ b/src/southbridge/amd/agesa/hudson/imc.c @@ -60,7 +60,7 @@ { AMD_CONFIG_PARAMS StdHeader; UINT8 FunNum; - UINT8 regs[9]; + UINT8 regs[10]; int i; regs[0] = 0; diff --git a/src/southbridge/amd/pi/hudson/imc.c b/src/southbridge/amd/pi/hudson/imc.c index 53e97fb..6a40013 100644 --- a/src/southbridge/amd/pi/hudson/imc.c +++ b/src/southbridge/amd/pi/hudson/imc.c @@ -56,7 +56,7 @@ { AMD_CONFIG_PARAMS StdHeader; UINT8 FunNum; - UINT8 regs[9]; + UINT8 regs[10]; int i; regs[0] = 0; -- To view, visit https://review.coreboot.org/22619 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic16edc607358b9a688151735e6fcb3393d3bce80 Gerrit-Change-Number: 22619 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: google/kahlee: Rename board_id to memory_sku
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22561 ) Change subject: google/kahlee: Rename board_id to memory_sku ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18717/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63849/ : SUCCESS -- To view, visit https://review.coreboot.org/22561 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84bacead3daf829c97f595c4c11a243953243c29 Gerrit-Change-Number: 22561 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 17:56:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add mainboard call for SPD values
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22485 ) Change subject: soc/amd/stoneyridge: Add mainboard call for SPD values ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18716/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63848/ : SUCCESS -- To view, visit https://review.coreboot.org/22485 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id42622008b49b4559e648a7fa1bfd9f26e1f56a4 Gerrit-Change-Number: 22485 Gerrit-PatchSet: 6 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 17:53:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Set UMA to 384 MiB
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22618 ) Change subject: google/kahlee: Set UMA to 384 MiB ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18715/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63847/ : SUCCESS -- To view, visit https://review.coreboot.org/22618 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613c7ce9feacaeed0c61034d3f45a9a4d0da6bf1 Gerrit-Change-Number: 22618 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 17:42:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Set UMA to 384 MiB
by Marc Jones (Code Review) 28 Nov '17

28 Nov '17

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/22618 Change subject: google/kahlee: Set UMA to 384 MiB ...................................................................... google/kahlee: Set UMA to 384 MiB Update Kahlee and Grunt UMA size to 384 MiB to support memory hungry webgl pages, like Aquarium. BUG=b:69647975 TEST=Run webglsamples.org/aquarium/aquarium.html without a crash. Change-Id: I613c7ce9feacaeed0c61034d3f45a9a4d0da6bf1 Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/mainboard/google/kahlee/variants/grunt/devicetree.cb M src/mainboard/google/kahlee/variants/kahlee/devicetree.cb 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/22618/1 diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb index 6558dec..3520ef4 100644 --- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb @@ -13,6 +13,11 @@ # GNU General Public License for more details. # chip soc/amd/stoneyridge + + register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP" + register "uma_mode" = "UMAMODE_SPECIFIED_SIZE" + register "uma_size" = "384 * MiB" + device cpu_cluster 0 on device lapic 10 on end end diff --git a/src/mainboard/google/kahlee/variants/kahlee/devicetree.cb b/src/mainboard/google/kahlee/variants/kahlee/devicetree.cb index 409e09e..8347398 100644 --- a/src/mainboard/google/kahlee/variants/kahlee/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/kahlee/devicetree.cb @@ -20,7 +20,7 @@ }" register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP" register "uma_mode" = "UMAMODE_SPECIFIED_SIZE" - register "uma_size" = "128 * MiB" + register "uma_size" = "384 * MiB" device cpu_cluster 0 on device lapic 10 on end -- To view, visit https://review.coreboot.org/22618 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I613c7ce9feacaeed0c61034d3f45a9a4d0da6bf1 Gerrit-Change-Number: 22618 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: mb/hp/8460p: Add TPM support
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22602 ) Change subject: mb/hp/8460p: Add TPM support ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18714/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63846/ : SUCCESS -- To view, visit https://review.coreboot.org/22602 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b845928954d203d1c3608b6704fedbd590e1fa9 Gerrit-Change-Number: 22602 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 15:34:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Make use of Intel common Graphics block
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22617 ) Change subject: soc/intel/cannonlake: Make use of Intel common Graphics block ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18713/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63845/ : SUCCESS -- To view, visit https://review.coreboot.org/22617 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa1314ae3fcb4a8a3b55a314e79511f5dcba163d Gerrit-Change-Number: 22617 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 13:30:18 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017