coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: google/fizz: add VBOOT_PHYSICAL_REC_SWITCH config
by Shelley Chen (Code Review) 07 Nov '17

07 Nov '17

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/22368 Change subject: google/fizz: add VBOOT_PHYSICAL_REC_SWITCH config ...................................................................... google/fizz: add VBOOT_PHYSICAL_REC_SWITCH config Now that recovery button has been enabled through cr50, we can add VBOOT_PHYSICAL_REC_SWITCH config and treat the recovery button like any other chromebox. BUG=b:37751915, b:63893483 BRANCH=None TEST=With DUT in normal mode, boot into recovery, press ctrl+d followed by pressing the recovery button. Should successfully boot into dev mode. CQ-DEPEND=CL:737477 Change-Id: I72fb42508083295e317dd06900796dc0cda753f6 Signed-off-by: Shelley Chen <shchen(a)chromium.org> --- M src/mainboard/google/fizz/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/22368/1 diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index 8036b8b..1431db4 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -24,6 +24,7 @@ select EC_GOOGLE_CHROMEEC_SWITCHES select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC select VBOOT_EC_EFS + select VBOOT_PHYSICAL_REC_SWITCH config DRIVER_TPM_I2C_BUS depends on FIZZ_USE_I2C_TPM -- To view, visit https://review.coreboot.org/22368 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I72fb42508083295e317dd06900796dc0cda753f6 Gerrit-Change-Number: 22368 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com>

1 0

Change in coreboot[master]: mb/lenovo/t400/blc.c: Add LTN154P2-L05 to whitelist
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22367 ) Change subject: mb/lenovo/t400/blc.c: Add LTN154P2-L05 to whitelist ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18050/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63100/ : SUCCESS -- To view, visit https://review.coreboot.org/22367 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5546641cb34264e29ccb3398dd68f6144dafe524 Gerrit-Change-Number: 22367 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 20:29:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/t400/blc.c: Add LTN154P2-L05 to whitelist
by Kevin Keijzer (Code Review) 07 Nov '17

07 Nov '17

Kevin Keijzer has uploaded this change for review. ( https://review.coreboot.org/22367 Change subject: mb/lenovo/t400/blc.c: Add LTN154P2-L05 to whitelist ...................................................................... mb/lenovo/t400/blc.c: Add LTN154P2-L05 to whitelist TESTED on Lenovo T500 Change-Id: I5546641cb34264e29ccb3398dd68f6144dafe524 Signed-off-by: Kevin Keijzer <kevin(a)quietlife.nl> --- M src/mainboard/lenovo/t400/blc.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/22367/1 diff --git a/src/mainboard/lenovo/t400/blc.c b/src/mainboard/lenovo/t400/blc.c index 56f6738..8553ae7 100644 --- a/src/mainboard/lenovo/t400/blc.c +++ b/src/mainboard/lenovo/t400/blc.c @@ -29,6 +29,7 @@ {"LTN141WD-L05", 110}, /* T500 */ {"LP154W02-TL06", 110}, + {"LTN154P2-L05", 110}, {"LTN154P3-L02", 110}, }; -- To view, visit https://review.coreboot.org/22367 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5546641cb34264e29ccb3398dd68f6144dafe524 Gerrit-Change-Number: 22367 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Keijzer <kevin(a)quietlife.nl>

1 0

Change in coreboot[master]: intel/cannonlake_rvp: Clean up GPIO programming
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22326 ) Change subject: intel/cannonlake_rvp: Clean up GPIO programming ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18048/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63098/ : SUCCESS -- To view, visit https://review.coreboot.org/22326 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0022b791bd8459ea2afdcd0241b603ce81408785 Gerrit-Change-Number: 22326 Gerrit-PatchSet: 4 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wei-nan Liu <wei-nan.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 19:32:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: add nhlt support
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22325 ) Change subject: mb/google/poppy/variants/nautilus: add nhlt support ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18049/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63099/ : SUCCESS -- To view, visit https://review.coreboot.org/22325 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I104889f54da1de38854bcb72aabbc88b739d6c09 Gerrit-Change-Number: 22325 Gerrit-PatchSet: 5 Gerrit-Owner: Naveen Manohar <naveen.m(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naveen Manohar <naveen.m(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 19:27:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: add nhlt support
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22325 ) Change subject: mb/google/poppy/variants/nautilus: add nhlt support ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63096/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18047/ : SUCCESS -- To view, visit https://review.coreboot.org/22325 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I104889f54da1de38854bcb72aabbc88b739d6c09 Gerrit-Change-Number: 22325 Gerrit-PatchSet: 4 Gerrit-Owner: Naveen Manohar <naveen.m(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naveen Manohar <naveen.m(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 19:16:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/cannonlake_rvp: Clean up GPIO programming
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22326 ) Change subject: intel/cannonlake_rvp: Clean up GPIO programming ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63097/ : ABORTED -- To view, visit https://review.coreboot.org/22326 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0022b791bd8459ea2afdcd0241b603ce81408785 Gerrit-Change-Number: 22326 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wei-nan Liu <wei-nan.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 19:15:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/cannonlake_rvp: Clean up GPIO programming
by Lijian Zhao (Code Review) 07 Nov '17

07 Nov '17

Lijian Zhao has uploaded a new patch set (#3). ( https://review.coreboot.org/22326 ) Change subject: intel/cannonlake_rvp: Clean up GPIO programming ...................................................................... intel/cannonlake_rvp: Clean up GPIO programming Since we move from cannonlake U DDR 4 platform to cannonlake U LPDDR4 platform, it is also critical to revisit the GPIO settings as they are different. Remove unused GPIO setting for old platform, and clean up the native function definition. PAD_CFG_NF can only select NF1,NF2 ..., set to GPIO mode is illegal. TEST=Boot up in chromeos successfully. Change-Id: I0022b791bd8459ea2afdcd0241b603ce81408785 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c 1 file changed, 19 insertions(+), 49 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/22326/3 -- To view, visit https://review.coreboot.org/22326 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0022b791bd8459ea2afdcd0241b603ce81408785 Gerrit-Change-Number: 22326 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wei-nan Liu <wei-nan.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/google/zoombini: Provide memory configuration variant API
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22205 ) Change subject: mainboard/google/zoombini: Provide memory configuration variant API ...................................................................... Patch Set 15: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18046/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63095/ : SUCCESS -- To view, visit https://review.coreboot.org/22205 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I449ab56dfc7a75752944b58ba6291b5ee32f81ad Gerrit-Change-Number: 22205 Gerrit-PatchSet: 15 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Anonymous Coward #1001775 Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 18:56:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Load SMU fimware using PSP
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22058 ) Change subject: soc/amd/stoneyridge: Load SMU fimware using PSP ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18043/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63092/ : SUCCESS -- To view, visit https://review.coreboot.org/22058 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedf768e54a7c3b3e7cf07e266a6906923c0fad42 Gerrit-Change-Number: 22058 Gerrit-PatchSet: 6 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 18:43:57 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017