coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: security/tpm: Setup generic TSPI
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22106 ) Change subject: security/tpm: Setup generic TSPI ...................................................................... Patch Set 28: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/63119/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/18068/ : SUCCESS -- To view, visit https://review.coreboot.org/22106 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb Gerrit-Change-Number: 22106 Gerrit-PatchSet: 28 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 00:30:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/vboot: Add two weak methods for vboot2
by Philipp Deppenwiese (Code Review) 07 Nov '17

07 Nov '17

Hello Aaron Durbin, Julius Werner, Paul Menzel, build bot (Jenkins), Vadim Bendebury, I'd like you to reexamine a change. Please visit https://review.coreboot.org/22102 to look at the new patch set (#8). Change subject: security/vboot: Add two weak methods for vboot2 ...................................................................... security/vboot: Add two weak methods for vboot2 In order to make VBOOT2 independent from the CHROMEOS kconfig option a weak method for get_write_protect_state and get_recovery_mode_switch() is required. Change-Id: I3b1555bd93e1605e04d5c3ea6a752eb1459e426e Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/security/vboot/bootmode.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/22102/8 -- To view, visit https://review.coreboot.org/22102 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3b1555bd93e1605e04d5c3ea6a752eb1459e426e Gerrit-Change-Number: 22102 Gerrit-PatchSet: 8 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: security/tpm: Setup generic TSPI
by Philipp Deppenwiese (Code Review) 07 Nov '17

07 Nov '17

Hello Kyösti Mälkki, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22106 to look at the new patch set (#28). Change subject: security/tpm: Setup generic TSPI ...................................................................... security/tpm: Setup generic TSPI * Remove second software stack from driver level (src/drivers/pc80/tpm/romstage.c) * Re-implement init_tpm() and fix includes. * Move antirollback.h to the vboot directory. * Split antirollback and tspi functions. Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/cpu/intel/haswell/romstage.c M src/drivers/intel/fsp1_1/romstage.c M src/drivers/intel/fsp2_0/memory_init.c M src/drivers/pc80/tpm/Makefile.inc D src/drivers/pc80/tpm/romstage.c M src/mainboard/asus/kgpe-d16/romstage.c M src/mainboard/google/link/romstage.c M src/mainboard/google/parrot/romstage.c M src/mainboard/google/stout/romstage.c M src/mainboard/intel/emeraldlake2/romstage.c M src/mainboard/lenovo/x201/romstage.c M src/mainboard/pcengines/apu2/romstage.c M src/mainboard/samsung/lumpy/romstage.c M src/mainboard/samsung/stumpy/romstage.c M src/northbridge/intel/sandybridge/romstage.c M src/security/tpm/Makefile.inc A src/security/tpm/tspi.h A src/security/tpm/tspi/tspi.c R src/security/vboot/antirollback.h M src/security/vboot/secdata_mock.c M src/security/vboot/secdata_tpm.c M src/security/vboot/vboot_logic.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/broadwell/romstage/romstage.c 24 files changed, 309 insertions(+), 432 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/22106/28 -- To view, visit https://review.coreboot.org/22106 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb Gerrit-Change-Number: 22106 Gerrit-PatchSet: 28 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: security/tpm: Setup generic TSPI
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22106 ) Change subject: security/tpm: Setup generic TSPI ...................................................................... Patch Set 27: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/63118/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/18067/ : SUCCESS -- To view, visit https://review.coreboot.org/22106 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb Gerrit-Change-Number: 22106 Gerrit-PatchSet: 27 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 23:52:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/inteltool: Add Skylake DMIBAR register dumping
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22345 ) Change subject: util/inteltool: Add Skylake DMIBAR register dumping ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18065/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63116/ : SUCCESS -- To view, visit https://review.coreboot.org/22345 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I636f6c3d045e297f1439d3e88e43f41e03db4c8e Gerrit-Change-Number: 22345 Gerrit-PatchSet: 5 Gerrit-Owner: Maximilian Schander <coreboot(a)mimoja.de> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Maximilian Schander <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 23:51:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/tpm: Move TSS stacks into sub-directory
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22105 ) Change subject: security/tpm: Move TSS stacks into sub-directory ...................................................................... Patch Set 12: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18064/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63115/ : SUCCESS -- To view, visit https://review.coreboot.org/22105 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e20d98665c17d39f3f69772093a062bb905f6f9 Gerrit-Change-Number: 22105 Gerrit-PatchSet: 12 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 23:45:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Enable Dialog DA7219 support
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22264 ) Change subject: mb/google/poppy/variants/nautilus: Enable Dialog DA7219 support ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18063/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63114/ : SUCCESS -- To view, visit https://review.coreboot.org/22264 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic815c929f29bec0d26a2981e9933b752c2d84c70 Gerrit-Change-Number: 22264 Gerrit-PatchSet: 5 Gerrit-Owner: Naveen Manohar <naveen.m(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naveen Manohar <naveen.m(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 23:45:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/tpm: Setup generic TSPI
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22106 ) Change subject: security/tpm: Setup generic TSPI ...................................................................... Patch Set 26: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63117/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18066/ : SUCCESS -- To view, visit https://review.coreboot.org/22106 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb Gerrit-Change-Number: 22106 Gerrit-PatchSet: 26 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 23:43:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/tpm: Setup generic TSPI
by Philipp Deppenwiese (Code Review) 07 Nov '17

07 Nov '17

Hello Kyösti Mälkki, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22106 to look at the new patch set (#27). Change subject: security/tpm: Setup generic TSPI ...................................................................... security/tpm: Setup generic TSPI * Remove second software stack from driver level (src/drivers/pc80/tpm/romstage.c) * Re-implement init_tpm() and fix includes. * Move antirollback.h to the vboot directory. * Split antirollback and tspi functions. Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/cpu/intel/haswell/romstage.c M src/drivers/intel/fsp1_1/romstage.c M src/drivers/intel/fsp2_0/memory_init.c M src/drivers/pc80/tpm/Makefile.inc D src/drivers/pc80/tpm/romstage.c M src/mainboard/asus/kgpe-d16/romstage.c M src/mainboard/google/link/romstage.c M src/mainboard/google/parrot/romstage.c M src/mainboard/google/stout/romstage.c M src/mainboard/intel/emeraldlake2/romstage.c M src/mainboard/lenovo/x201/romstage.c M src/mainboard/pcengines/apu2/romstage.c M src/mainboard/samsung/lumpy/romstage.c M src/mainboard/samsung/stumpy/romstage.c M src/northbridge/intel/sandybridge/romstage.c M src/security/tpm/Makefile.inc A src/security/tpm/tspi.h A src/security/tpm/tspi/tspi.c R src/security/vboot/antirollback.h M src/security/vboot/secdata_mock.c M src/security/vboot/secdata_tpm.c M src/security/vboot/vboot_logic.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/broadwell/romstage/romstage.c 24 files changed, 307 insertions(+), 430 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/22106/27 -- To view, visit https://review.coreboot.org/22106 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb Gerrit-Change-Number: 22106 Gerrit-PatchSet: 27 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: security/tpm: Move TSS stacks into sub-directory
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22105 ) Change subject: security/tpm: Move TSS stacks into sub-directory ...................................................................... Patch Set 11: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63113/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18062/ : SUCCESS -- To view, visit https://review.coreboot.org/22105 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e20d98665c17d39f3f69772093a062bb905f6f9 Gerrit-Change-Number: 22105 Gerrit-PatchSet: 11 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 23:36:09 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017