the following patch was just integrated into master:
commit f6ada1c30755f3de22942996bfcf6490a9b7b6e4
Author: Aaron Durbin <adurbin(a)chromium.org>
Date: Wed Feb 10 10:52:47 2016 -0600
lib/coreboot_table: add function to allow arch code to add records
Add lb_arch_add_records() to allow the architecture code to
generically hook into the coreboot table generation.
BUG=chrome-os-partner:50214
BRANCH=glados
TEST=With all subsequent patches confirmed lb_arch_add_records() is
called when a strong symbol is provided.
Change-Id: I7c69c0ff0801392bbcf5aef586a48388b624afd4
Signed-off-by: Aaron Durbin <adurbin(a)chromium.org>
Reviewed-on: https://review.coreboot.org/13669
Tested-by: build bot (Jenkins)
Reviewed-by: Furquan Shaikh <furquan(a)google.com>
Reviewed-by: Andrey Petrov <andrey.petrov(a)intel.com>
See https://review.coreboot.org/13669 for details.
-gerrit
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13751
-gerrit
commit 9bb6b294c48e2f6542d2d8df0bf2e99ef8eea91a
Author: Martin Roth <martinroth(a)google.com>
Date: Fri Feb 19 10:24:25 2016 -0700
kconfig_lint: Fix checks when running in taint mode
The builders run perl scripts in taint mode, and some of the checks
that the kconfig lint script were running were tainted, causing
the script to terminate early when running on the servers.
This checks to see if taint mode is enabled, and untaints the path
if it is. All exernal tools (git & grep) must be in /bin or /usr/bin.
This also removes the check for unused kconfig files if taint mode
is enabled.
Change-Id: I8d1e1c32275f759d085759fb5d8a6c85d4f99539
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
util/lint/kconfig_lint | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint
index b5a62d3..e8445b2 100755
--- a/util/lint/kconfig_lint
+++ b/util/lint/kconfig_lint
@@ -26,6 +26,12 @@ use File::Find;
use Getopt::Long;
use Getopt::Std;
+# If taint mode is enabled, Untaint the path - git and grep must be in /bin or /usr/bin
+if ( ${^TAINT} ) {
+ $ENV{'PATH'} = '/bin:/usr/bin';
+ delete @ENV{ 'IFS', 'CDPATH', 'ENV', 'BASH_ENV' };
+}
+
my $suppress_error_output = 0; # flag to prevent error text
my $suppress_warning_output = 0; # flag to prevent warning text
my $show_note_output = 0; # flag to show minor notes text
@@ -76,9 +82,6 @@ sub Main {
#load the Kconfig tree, checking what we can and building up all the hash tables
build_and_parse_kconfig_tree("$root_dir/Kconfig");
- #run checks based on the data that was found
- find( \&check_if_file_referenced, $root_dir );
-
load_config($config_file) if ($config_file);
check_defaults();
@@ -91,6 +94,14 @@ sub Main {
check_is_enabled();
check_selected_symbols();
+ #run checks based on the data that was found
+ if ( ( !$suppress_warning_output ) && ( ${^TAINT} == 0 ) ) {
+
+ # the find function is tainted - only run it if taint checking
+ # is disabled and warnings are enabled.
+ find( \&check_if_file_referenced, $root_dir );
+ }
+
print_wholeconfig();
if ($errors_found) {
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13751
-gerrit
commit 7432b06b90b7b3be05e1e4ebeffd0e2db732921e
Author: Martin Roth <martinroth(a)google.com>
Date: Fri Feb 19 10:24:25 2016 -0700
kconfig_lint: Fix checks when running in taint mode
The builders run perl scripts in taint mode, and some of the checks
that the kconfig lint script were running were tainted, causing
the script to terminate early when running on the servers.
This checks to see if taint mode is enabled, and untaints the path
if it is. All exernal tools (git & grep) must be in /bin or /usr/bin.
This also removes the check for unused kconfig files if taint mode
is enabled.
Change-Id: I8d1e1c32275f759d085759fb5d8a6c85d4f99539
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
util/lint/kconfig_lint | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint
index b5a62d3..e8445b2 100755
--- a/util/lint/kconfig_lint
+++ b/util/lint/kconfig_lint
@@ -26,6 +26,12 @@ use File::Find;
use Getopt::Long;
use Getopt::Std;
+# If taint mode is enabled, Untaint the path - git and grep must be in /bin or /usr/bin
+if ( ${^TAINT} ) {
+ $ENV{'PATH'} = '/bin:/usr/bin';
+ delete @ENV{ 'IFS', 'CDPATH', 'ENV', 'BASH_ENV' };
+}
+
my $suppress_error_output = 0; # flag to prevent error text
my $suppress_warning_output = 0; # flag to prevent warning text
my $show_note_output = 0; # flag to show minor notes text
@@ -76,9 +82,6 @@ sub Main {
#load the Kconfig tree, checking what we can and building up all the hash tables
build_and_parse_kconfig_tree("$root_dir/Kconfig");
- #run checks based on the data that was found
- find( \&check_if_file_referenced, $root_dir );
-
load_config($config_file) if ($config_file);
check_defaults();
@@ -91,6 +94,14 @@ sub Main {
check_is_enabled();
check_selected_symbols();
+ #run checks based on the data that was found
+ if ( ( !$suppress_warning_output ) && ( ${^TAINT} == 0 ) ) {
+
+ # the find function is tainted - only run it if taint checking
+ # is disabled and warnings are enabled.
+ find( \&check_if_file_referenced, $root_dir );
+ }
+
print_wholeconfig();
if ($errors_found) {
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13751
-gerrit
commit fa2c2da3b1facc7084830dbac309f72d4e01b98b
Author: Martin Roth <martinroth(a)google.com>
Date: Fri Feb 19 10:24:25 2016 -0700
kconfig_lint: check for referenced files if warnings are enabled
The builders are having problems running the 'find' function used in
this check. Since the builders don't check for warnings, just errors,
and this check is only for warnings, by disabling the test if warnings
are disabled, we fix the builders without losing any functionality
of the test.
Change-Id: I8d1e1c32275f759d085759fb5d8a6c85d4f99539
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
util/lint/kconfig_lint | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint
index b5a62d3..33aef02 100755
--- a/util/lint/kconfig_lint
+++ b/util/lint/kconfig_lint
@@ -77,7 +77,12 @@ sub Main {
build_and_parse_kconfig_tree("$root_dir/Kconfig");
#run checks based on the data that was found
- find( \&check_if_file_referenced, $root_dir );
+ unless ($suppress_warning_output) {
+ # This is causing issues on the build servers.
+ # By only running this if warnings are enabled, this saves
+ # a bit of time, and prevents the error on the build servers.
+ find( \&check_if_file_referenced, $root_dir );
+ }
load_config($config_file) if ($config_file);
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13751
-gerrit
commit 11d20abe7887f8c97228babe4d40cf1b7c839287
Author: Martin Roth <martinroth(a)google.com>
Date: Fri Feb 19 10:24:25 2016 -0700
kconfig_lint: check for referenced files if warnings are enabled
The builders are having problems running the 'find' function used in
this check. Since the builders don't check for warnings, just errors,
and this check is only for warnings, by disabling the test if warnings
are disabled, we fix the builders without losing any functionality
of the test.
Change-Id: I8d1e1c32275f759d085759fb5d8a6c85d4f99539
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
util/lint/kconfig_lint | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint
index b5a62d3..33aef02 100755
--- a/util/lint/kconfig_lint
+++ b/util/lint/kconfig_lint
@@ -77,7 +77,12 @@ sub Main {
build_and_parse_kconfig_tree("$root_dir/Kconfig");
#run checks based on the data that was found
- find( \&check_if_file_referenced, $root_dir );
+ unless ($suppress_warning_output) {
+ # This is causing issues on the build servers.
+ # By only running this if warnings are enabled, this saves
+ # a bit of time, and prevents the error on the build servers.
+ find( \&check_if_file_referenced, $root_dir );
+ }
load_config($config_file) if ($config_file);
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13751
-gerrit
commit ad9112b5890915ba09d21dcb65d9b219ce69b481
Author: Martin Roth <martinroth(a)google.com>
Date: Fri Feb 19 10:24:25 2016 -0700
kconfig_lint: check for referenced files if warnings are enabled
The builders are having problems running the 'find' function used in
this check. Since the builders don't check for warnings, just errors,
and this check is only for warnings, by disabling the test if warnings
are disabled, we fix the builders without losing any functionality
of the test.
Change-Id: I8d1e1c32275f759d085759fb5d8a6c85d4f99539
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
util/lint/kconfig_lint | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint
index b5a62d3..33aef02 100755
--- a/util/lint/kconfig_lint
+++ b/util/lint/kconfig_lint
@@ -77,7 +77,12 @@ sub Main {
build_and_parse_kconfig_tree("$root_dir/Kconfig");
#run checks based on the data that was found
- find( \&check_if_file_referenced, $root_dir );
+ unless ($suppress_warning_output) {
+ # This is causing issues on the build servers.
+ # By only running this if warnings are enabled, this saves
+ # a bit of time, and prevents the error on the build servers.
+ find( \&check_if_file_referenced, $root_dir );
+ }
load_config($config_file) if ($config_file);
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13750
-gerrit
commit 05be366662f40f79f21902281173f3c0e49b6615
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Fri Feb 19 16:44:22 2016 +0100
die() when attempting to use bounce bufferon non-i386.
Only i386 has code to support bounce buffer. For others coreboot
would silently discard part of binary which doesn't work and is a hell to debug.
Instead just die.
Change-Id: I37ae24ea5d13aae95f9856a896700a0408747233
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
src/lib/selfboot.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/lib/selfboot.c b/src/lib/selfboot.c
index 6d86159..1123332 100644
--- a/src/lib/selfboot.c
+++ b/src/lib/selfboot.c
@@ -114,6 +114,10 @@ static int relocate_segment(unsigned long buffer, struct segment *seg)
if (!overlaps_coreboot(seg))
return 0;
+#ifndef __i386__
+ die ("bounce buffer not supported");
+#endif
+
start = seg->s_dstaddr;
middle = start + seg->s_filesz;
end = start + seg->s_memsz;