coreboot-gerrit October 2016

coreboot-gerrit@coreboot.org

1 participants
1281 discussions

Patch merged into coreboot/master: nb/gm45, x4x/gma.c remove writes to nonexisting FDI registers
by gerrit＠coreboot.org 19 Oct '16

19 Oct '16

the following patch was just integrated into master: commit ff1286d5003194bdbd78fd3b74d91bb01a77b399 Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Wed Oct 12 01:49:16 2016 +0200 nb/gm45,x4x/gma.c remove writes to nonexisting FDI registers This removes writes to FDI related registers since there is no FDI link on these targets. This is likely a remainder from copying code from later targets. TESTED on Thinkpad x200 (gm45) Change-Id: Id67fdc999185fa184a9ff0e5c3fc9bced04131ad Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/16993 Reviewed-by: Martin Roth <martinroth(a)google.com> Tested-by: build bot (Jenkins) See https://review.coreboot.org/16993 for details. -gerrit

1 0

Patch merged into coreboot/master: nb/i945, gm45, x4x/gma.c: fix unsigned arithmetics
by gerrit＠coreboot.org 19 Oct '16

19 Oct '16

the following patch was just integrated into master: commit 75f9131453c0e046f69ab4a8db7a3af7efcf6038 Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Wed Oct 12 01:04:28 2016 +0200 nb/i945,gm45,x4x/gma.c: fix unsigned arithmetics This issue was found by Coverity Scan, CID 1364118. Change-Id: Iba3c0f4f952729d9e0987d928b63ef8b8fe8841e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/16992 Reviewed-by: Martin Roth <martinroth(a)google.com> Tested-by: build bot (Jenkins) See https://review.coreboot.org/16992 for details. -gerrit

1 0

Patch merged into coreboot/master: nb/gm45, x4x/gma.c: Compute p2 in VGA init instead of hardcoding it
by gerrit＠coreboot.org 19 Oct '16

19 Oct '16

the following patch was just integrated into master: commit 063cd5f6eee0ad9416e62eac4a168591220f53d0 Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Wed Oct 12 00:05:00 2016 +0200 nb/gm45,x4x/gma.c: Compute p2 in VGA init instead of hardcoding it According to: "Intel ® 965 Express Chipset Family and Intel ® G35 Express Chipset Graphics Controller PR" the p2 divisor needs to be 10 when the dotclock is below 225MHz and 5 when its above 225MHz. Change-Id: I363039b6fd92051c4be4fdc88788f27527645944 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/16991 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.h(a)gmx.de> See https://review.coreboot.org/16991 for details. -gerrit

1 0

Patch merged into coreboot/master: mb/asus/kcma-d8, kgpe-d16: use MAINBOARD_DO_NATIVE_VGA_INIT
by gerrit＠coreboot.org 19 Oct '16

19 Oct '16

the following patch was just integrated into master: commit f2b8d7cbd6d92adac26cbd639bb51f29b237fbc0 Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Mon Oct 10 23:59:05 2016 +0200 mb/asus/kcma-d8,kgpe-d16: use MAINBOARD_DO_NATIVE_VGA_INIT MAINBOARD_HAS_NATIVE_VGA_INIT_TEXTMODECFG should only occur together with MAINBOARD_HAS_NATIVE_VGA_INIT. It seems to be used to just have to have the option to be able to select SEABIOS_VGA_COREBOOT. This patch makes these boards use MAINBOARD_DO_NATIVE_VGA_INIT and MAINBOARD_HAS_NATIVE_VGA_INIT to have it select SEABIOS_VGA_COREBOOT by default when SeaBIOS is chosen. Change-Id: If0a36af1883a3d62b16a61483733be981a85e5e2 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/16981 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.h(a)gmx.de> See https://review.coreboot.org/16981 for details. -gerrit

1 0

Patch set updated for coreboot: mb/asus/kcma-d8, kgpe-d16: use MAINBOARD_DO_NATIVE_VGA_INIT
by Martin Roth 19 Oct '16

19 Oct '16

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16981 -gerrit commit 1cf8451609e892038ff691e3a0c93aa8418ad1d3 Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Mon Oct 10 23:59:05 2016 +0200 mb/asus/kcma-d8,kgpe-d16: use MAINBOARD_DO_NATIVE_VGA_INIT MAINBOARD_HAS_NATIVE_VGA_INIT_TEXTMODECFG should only occur together with MAINBOARD_HAS_NATIVE_VGA_INIT. It seems to be used to just have to have the option to be able to select SEABIOS_VGA_COREBOOT. This patch makes these boards use MAINBOARD_DO_NATIVE_VGA_INIT and MAINBOARD_HAS_NATIVE_VGA_INIT to have it select SEABIOS_VGA_COREBOOT by default when SeaBIOS is chosen. Change-Id: If0a36af1883a3d62b16a61483733be981a85e5e2 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- payloads/external/SeaBIOS/Kconfig | 2 +- src/mainboard/asus/kcma-d8/Kconfig | 3 ++- src/mainboard/asus/kgpe-d16/Kconfig | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/payloads/external/SeaBIOS/Kconfig b/payloads/external/SeaBIOS/Kconfig index 32e6c3e..a9d701d 100644 --- a/payloads/external/SeaBIOS/Kconfig +++ b/payloads/external/SeaBIOS/Kconfig @@ -54,7 +54,7 @@ config SEABIOS_THREAD_OPTIONROMS config SEABIOS_VGA_COREBOOT prompt "Include generated option rom that implements legacy VGA BIOS compatibility" default y - depends on !VGA_BIOS && (MAINBOARD_DO_NATIVE_VGA_INIT || MAINBOARD_HAS_NATIVE_VGA_INIT_TEXTMODECFG) + depends on !VGA_BIOS && MAINBOARD_DO_NATIVE_VGA_INIT bool help Coreboot can initialize the GPU of some mainboards. diff --git a/src/mainboard/asus/kcma-d8/Kconfig b/src/mainboard/asus/kcma-d8/Kconfig index 1542279..6e84fa8 100644 --- a/src/mainboard/asus/kcma-d8/Kconfig +++ b/src/mainboard/asus/kcma-d8/Kconfig @@ -33,7 +33,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_ACPI_RESUME select DRIVERS_I2C_W83795 select DRIVERS_ASPEED_AST2050 - select MAINBOARD_HAS_NATIVE_VGA_INIT_TEXTMODECFG + select MAINBOARD_DO_NATIVE_VGA_INIT + select MAINBOARD_HAS_NATIVE_VGA_INIT config MAINBOARD_DIR string diff --git a/src/mainboard/asus/kgpe-d16/Kconfig b/src/mainboard/asus/kgpe-d16/Kconfig index a65cecc..19bf728 100644 --- a/src/mainboard/asus/kgpe-d16/Kconfig +++ b/src/mainboard/asus/kgpe-d16/Kconfig @@ -34,7 +34,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_ACPI_RESUME select DRIVERS_I2C_W83795 select DRIVERS_ASPEED_AST2050 - select MAINBOARD_HAS_NATIVE_VGA_INIT_TEXTMODECFG + select MAINBOARD_DO_NATIVE_VGA_INIT + select MAINBOARD_HAS_NATIVE_VGA_INIT config MAINBOARD_DIR string

1 0

Patch merged into coreboot/master: Select SEABIOS_VGA_COREBOOT when native graphic init is selected
by gerrit＠coreboot.org 19 Oct '16

19 Oct '16

the following patch was just integrated into master: commit 31bc716d6bbf9a3c99c708bffadd1da43e0b5bfd Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Mon Oct 10 20:22:10 2016 +0200 Select SEABIOS_VGA_COREBOOT when native graphic init is selected Change-Id: I19db898a5e76bf9c151934c7979316fb3737e881 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/16965 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.h(a)gmx.de> See https://review.coreboot.org/16965 for details. -gerrit

1 0

Patch set updated for coreboot: northbridge/intel/i5000: Convert 'for(; ; )' to 'die'
by HAOUAS Elyes 19 Oct '16

19 Oct '16

HAOUAS Elyes (ehaouas(a)noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17006 -gerrit commit 590533a59b450a319e5b7b3fc36af9d3e97044ea Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Wed Oct 12 19:57:38 2016 +0200 northbridge/intel/i5000: Convert 'for(;;)' to 'die' Change-Id: I1ceea759a40d740503bde725ad6d72fab4aa7971 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- src/northbridge/intel/i5000/raminit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/northbridge/intel/i5000/raminit.c b/src/northbridge/intel/i5000/raminit.c index 1a802b0..de05cc2 100644 --- a/src/northbridge/intel/i5000/raminit.c +++ b/src/northbridge/intel/i5000/raminit.c @@ -353,8 +353,7 @@ static int i5000_amb_smbus_write(struct i5000_fbdimm *d, int byte1, int byte2) printk(BIOS_ERR, "SMBus write failed: %d/%d/%d, byte1 %02x, byte2 %02x status %04x\n", d->branch->num, d->channel->num, d->num, byte1, byte2, status); - for (;;); - return -1; + die("Error: SMBus write failed"); } static int i5000_amb_smbus_read(struct i5000_fbdimm *d, int byte1, u8 *out)

1 0

Patch set updated for coreboot: northbridge/intel/i5000: Convert 'for(; ; )' to 'die'
by HAOUAS Elyes 19 Oct '16

19 Oct '16

HAOUAS Elyes (ehaouas(a)noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17006 -gerrit commit d3b7c86e9ae3172e5360b44d1057f8130ccec7ac Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Wed Oct 12 19:57:38 2016 +0200 northbridge/intel/i5000: Convert 'for(;;)' to 'die' Change-Id: I1ceea759a40d740503bde725ad6d72fab4aa7971 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- src/northbridge/intel/i5000/raminit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/northbridge/intel/i5000/raminit.c b/src/northbridge/intel/i5000/raminit.c index 1a802b0..07ef068 100644 --- a/src/northbridge/intel/i5000/raminit.c +++ b/src/northbridge/intel/i5000/raminit.c @@ -353,7 +353,7 @@ static int i5000_amb_smbus_write(struct i5000_fbdimm *d, int byte1, int byte2) printk(BIOS_ERR, "SMBus write failed: %d/%d/%d, byte1 %02x, byte2 %02x status %04x\n", d->branch->num, d->channel->num, d->num, byte1, byte2, status); - for (;;); + die("Error: SMBus write failed"); return -1; }

1 0

Patch set updated for coreboot: northbridge/intel/i5000: Convert 'for(; ; )' to 'die'
by HAOUAS Elyes 19 Oct '16

19 Oct '16

HAOUAS Elyes (ehaouas(a)noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17006 -gerrit commit ba5bba6d13324c42fb37981667d5b1bd7579afb5 Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Wed Oct 12 19:57:38 2016 +0200 northbridge/intel/i5000: Convert 'for(;;)' to 'die' Change-Id: I1ceea759a40d740503bde725ad6d72fab4aa7971 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- src/northbridge/intel/i5000/raminit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/northbridge/intel/i5000/raminit.c b/src/northbridge/intel/i5000/raminit.c index 1a802b0..81bbcfc 100644 --- a/src/northbridge/intel/i5000/raminit.c +++ b/src/northbridge/intel/i5000/raminit.c @@ -351,9 +351,9 @@ static int i5000_amb_smbus_write(struct i5000_fbdimm *d, int byte1, int byte2) if (status & I5000_SPD_WOD && timeout) return 0; - printk(BIOS_ERR, "SMBus write failed: %d/%d/%d, byte1 %02x, byte2 %02x status %04x\n", + printk(BIOS_ERR, ("SMBus write failed: %d/%d/%d, byte1 %02x, byte2 %02x status %04x\n", d->branch->num, d->channel->num, d->num, byte1, byte2, status); - for (;;); + die("Error: SMBus write failed"); return -1; }

1 0

Patch set updated for coreboot: northbridge/intel/i5000: Convert 'for(; ; )' to 'die'
by HAOUAS Elyes 19 Oct '16

19 Oct '16

HAOUAS Elyes (ehaouas(a)noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17006 -gerrit commit 28eb05f7e28ff571d68e349bedb1597b6aa74e1d Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Wed Oct 12 19:57:38 2016 +0200 northbridge/intel/i5000: Convert 'for(;;)' to 'die' Change-Id: I1ceea759a40d740503bde725ad6d72fab4aa7971 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- src/northbridge/intel/i5000/raminit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/northbridge/intel/i5000/raminit.c b/src/northbridge/intel/i5000/raminit.c index 1a802b0..03a95dc 100644 --- a/src/northbridge/intel/i5000/raminit.c +++ b/src/northbridge/intel/i5000/raminit.c @@ -351,9 +351,9 @@ static int i5000_amb_smbus_write(struct i5000_fbdimm *d, int byte1, int byte2) if (status & I5000_SPD_WOD && timeout) return 0; - printk(BIOS_ERR, "SMBus write failed: %d/%d/%d, byte1 %02x, byte2 %02x status %04x\n", + printk(BIOS_ERR,("SMBus write failed: %d/%d/%d, byte1 %02x, byte2 %02x status %04x\n", d->branch->num, d->channel->num, d->num, byte1, byte2, status); - for (;;); + die("Error: SMBus write failed"); return -1; }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2016