Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13512
-gerrit
commit bdddeb28ee89523446e800255abc566b549d131f
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Fri Jan 29 19:42:02 2016 +0100
Revert "northbridge/intel/sandybridge: Fix random raminit failures"
It break x230 access to channel 1.
This reverts commit 9f1fbb9a3002e8d74d53d7973bd1c7e3d4879238.
Change-Id: I8a3b13d17729f25cea3460ac2f87bca3c193d388
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
src/northbridge/intel/sandybridge/raminit.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c
index 151a7ec..8a287c1 100644
--- a/src/northbridge/intel/sandybridge/raminit.c
+++ b/src/northbridge/intel/sandybridge/raminit.c
@@ -2334,17 +2334,7 @@ static void discover_timB(ramctr_timing * ctrl, int channel, int slotrank)
}
FOR_ALL_LANES {
struct run rn = get_longest_zero_run(statistics[lane], 128);
- if (rn.start < rn.middle) {
- ctrl->timings[channel][slotrank].lanes[lane].timB = rn.start;
- } else {
- /* In this case statistics[lane][7f] and statistics[lane][0] are
- * both zero.
- * Prefer a smaller value over rn.start to prevent failures in
- * the following write tests.
- */
- ctrl->timings[channel][slotrank].lanes[lane].timB = 0;
- }
-
+ ctrl->timings[channel][slotrank].lanes[lane].timB = rn.start;
if (rn.all)
die("timB discovery failed");
printram("Bval: %d, %d, %d, %x\n", channel, slotrank,
the following patch was just integrated into master:
commit 1bf5e6409678d04fd15f9625460078853118521c
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Thu Jan 28 22:34:50 2016 +0100
build system: allow modifying cbfstool options for files-in-regions
By implementing a more complex options-for-region function, special
needs for certain files in certain regions can be dealt with.
Change-Id: I2e1e08d5357b717011c41675f76908bf2319f91d
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Reviewed-on: https://review.coreboot.org/13505
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin(a)chromium.org>
Tested-by: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com>
See https://review.coreboot.org/13505 for details.
-gerrit
the following patch was just integrated into master:
commit efe7ff0f81902f59784b798fa54568cb03b68e78
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Thu Jan 28 22:22:38 2016 +0100
build system: Unwind multi-region cbfstool add commands
Add files to fmap regions one-by-one, so we can modify options
per-file-per-region.
Change-Id: Ic3ff5a4e563796c9fdd5705236aef37c883abf5e
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Reviewed-on: https://review.coreboot.org/13504
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/13504 for details.
-gerrit
the following patch was just integrated into master:
commit ddc30767dce49da80c10cdb981a8c06a533bac28
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Thu Jan 28 21:57:29 2016 +0100
build system: deduplicate users of cbfs-add-cmd
When adding the cbfstool remove requirement of the UPDATE_IMAGE path to
cbfs-add-cmd, prebuil[dt]-files become identical in both cases.
Change-Id: I80faaf1c83368b9dd00a9f247bf89e6d596be996
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Reviewed-on: https://review.coreboot.org/13503
Tested-by: build bot (Jenkins)
Tested-by: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com>
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/13503 for details.
-gerrit
the following patch was just integrated into master:
commit 60fad89091dec4f34803a3320de73198b1124002
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Thu Jan 28 21:51:55 2016 +0100
build system: deduplicate use of cbfs-autogen-attributes
Also drop the second argument to cbfs-add-cmd because it's not needed
anymore.
Change-Id: Ie01d73f6b2aff09caccc397f72d6d8065624aebe
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Reviewed-on: https://review.coreboot.org/13502
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/13502 for details.
-gerrit
the following patch was just integrated into master:
commit 35a2bcaa213e68f6254350d9f94a700d68c6e550
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Thu Jan 28 21:50:37 2016 +0100
build system: deduplicate the addition of alignment/base arguments
Change-Id: I951606333d19cd6bf655294b8b3097884b6ac9e6
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Reviewed-on: https://review.coreboot.org/13501
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/13501 for details.
-gerrit
the following patch was just integrated into master:
commit 93d53677da570f47e94940ffaf696ec2f9a18e0e
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Thu Jan 28 21:47:31 2016 +0100
build system: pass $(file) explicitly
And not in the global context.
Change-Id: Ife7394b1343663456c24316df6a07d883adb9ee9
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Reviewed-on: https://review.coreboot.org/13500
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/13500 for details.
-gerrit
the following patch was just integrated into master:
commit 172f8865865dba897e316c8f029e290a3fd101d8
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Thu Jan 28 21:37:16 2016 +0100
build system: separate cbfstool add invocations into separate commands
They used to be chained into a single make shell invocation but now
they're individual commands, which makes them easier to manage.
Change-Id: I22394fd31989d5180790818153f466c0e7ebbedd
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Reviewed-on: https://review.coreboot.org/13499
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/13499 for details.
-gerrit