coreboot-gerrit July 2015

coreboot-gerrit@coreboot.org

1 participants
1048 discussions

New patch to review for coreboot: samsung/exynos5250: Enable bootblock console
by Patrick Georgi 31 Jul '15

31 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11102 -gerrit commit 961df61bbdaec41d2ba1b5f02b7323f8318cebbc Author: Patrick Georgi <pgeorgi(a)google.com> Date: Fri Jul 31 17:27:23 2015 +0200 samsung/exynos5250: Enable bootblock console Change-Id: I7b177b4c57f8e304167610205196ecfe4beb4fea Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- src/soc/samsung/exynos5250/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/src/soc/samsung/exynos5250/Kconfig b/src/soc/samsung/exynos5250/Kconfig index 2008650..c8a8929 100644 --- a/src/soc/samsung/exynos5250/Kconfig +++ b/src/soc/samsung/exynos5250/Kconfig @@ -6,5 +6,6 @@ config CPU_SAMSUNG_EXYNOS5250 select HAVE_MONOTONIC_TIMER select GENERIC_UDELAY select HAVE_UART_SPECIAL + select BOOTBLOCK_CONSOLE bool default n

1 0

New patch to review for coreboot: samsung/exynos5250: Add vboot2 memory region
by Patrick Georgi 31 Jul '15

31 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11101 -gerrit commit 1ea04a00e721e519cbc68bad552d7027acda1815 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Fri Jul 31 17:27:23 2015 +0200 samsung/exynos5250: Add vboot2 memory region Change-Id: Ia7d2cafc958859be782f63c956dbd632e28bcf11 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- src/soc/samsung/exynos5250/include/soc/memlayout.ld | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/soc/samsung/exynos5250/include/soc/memlayout.ld b/src/soc/samsung/exynos5250/include/soc/memlayout.ld index 00e9057..3b5b034 100644 --- a/src/soc/samsung/exynos5250/include/soc/memlayout.ld +++ b/src/soc/samsung/exynos5250/include/soc/memlayout.ld @@ -18,6 +18,7 @@ */ #include <memlayout.h> +#include <vendorcode/google/chromeos/memlayout.h> #include <arch/header.ld> @@ -35,7 +36,8 @@ SECTIONS ROMSTAGE(0x2030000, 128K) /* 32K hole */ TTB(0x2058000, 16K) - PRERAM_CBFS_CACHE(0x205C000, 96K) + PRERAM_CBFS_CACHE(0x205C000, 80K) + VBOOT2_WORK(0x2070000, 16K) STACK(0x2074000, 16K) SRAM_END(0x2078000)

1 0

New patch to review for coreboot: imgtech/pistacho: Add vboot2 memory region
by Patrick Georgi 31 Jul '15

31 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11100 -gerrit commit ced0bf593475d8cfed55788e295a88f515a0e61e Author: Patrick Georgi <pgeorgi(a)google.com> Date: Fri Jul 31 17:27:23 2015 +0200 imgtech/pistacho: Add vboot2 memory region Change-Id: I375397d4a1db6fef6b40421590f315c0f7eb0948 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- src/soc/imgtec/pistachio/include/soc/memlayout.ld | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/soc/imgtec/pistachio/include/soc/memlayout.ld b/src/soc/imgtec/pistachio/include/soc/memlayout.ld index b36d47e..366b20a 100644 --- a/src/soc/imgtec/pistachio/include/soc/memlayout.ld +++ b/src/soc/imgtec/pistachio/include/soc/memlayout.ld @@ -18,6 +18,7 @@ */ #include <memlayout.h> +#include <vendorcode/google/chromeos/memlayout.h> #include <arch/header.ld> @@ -39,7 +40,8 @@ SECTIONS */ SRAM_START(0x1a000000) ROMSTAGE(0x1a005000, 40K) - PRERAM_CBFS_CACHE(0x1a00f000, 68K) + VBOOT2_WORK(0x1a00f000, 12K) + PRERAM_CBFS_CACHE(0x1a012000, 56K) SRAM_END(0x1a020000) /* Bootblock executes out of KSEG0 and sets up the identity mapping.

1 0

New patch to review for coreboot: google/urara: Stub out get_write_protect_state()
by Patrick Georgi 31 Jul '15

31 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11099 -gerrit commit f65010d26345520c6a7522065779a8a6046ddd28 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Fri Jul 31 17:21:15 2015 +0200 google/urara: Stub out get_write_protect_state() vboot2 requires it Change-Id: I63bc3f176af72da8ea172a09aa536a10f1184b14 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- src/mainboard/google/urara/Makefile.inc | 1 + src/mainboard/google/urara/chromeos.c | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/src/mainboard/google/urara/Makefile.inc b/src/mainboard/google/urara/Makefile.inc index 234ab66..10140b3 100644 --- a/src/mainboard/google/urara/Makefile.inc +++ b/src/mainboard/google/urara/Makefile.inc @@ -20,6 +20,7 @@ bootblock-y += boardid.c ramstage-y += boardid.c +romstage-$(CONFIG_CHROMEOS) += chromeos.c ramstage-$(CONFIG_CHROMEOS) += chromeos.c ramstage-y += mainboard.c diff --git a/src/mainboard/google/urara/chromeos.c b/src/mainboard/google/urara/chromeos.c index f95e3db..620289d 100644 --- a/src/mainboard/google/urara/chromeos.c +++ b/src/mainboard/google/urara/chromeos.c @@ -18,9 +18,15 @@ */ #include <boot/coreboot_tables.h> +#include <bootmode.h> #include <console/console.h> #include <gpio.h> +int get_write_protect_state(void) +{ + printk(BIOS_ERR, "%s unsupported, but called\n", __func__); + return 0; +} void fill_lb_gpios(struct lb_gpios *gpios) {

1 0

New patch to review for coreboot: google/stout: Fix ELOG related ifdefs
by Patrick Georgi 31 Jul '15

31 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11098 -gerrit commit 8fe04adfac04b17ee6bc680f37f3c11b10fc3e96 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Fri Jul 31 17:18:16 2015 +0200 google/stout: Fix ELOG related ifdefs The used functions require the ELOG_GSMI feature, not just ELOG. Change-Id: If38cf0b710d9236012bfb1f0b119c10f9e533a25 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- src/mainboard/google/stout/ec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mainboard/google/stout/ec.c b/src/mainboard/google/stout/ec.c index 0c3b942..e652a41 100644 --- a/src/mainboard/google/stout/ec.c +++ b/src/mainboard/google/stout/ec.c @@ -81,7 +81,7 @@ void stout_ec_finalize_smm(void) if (ec_reg & 0x8) { printk(BIOS_ERR, " EC Fan Error\n"); critical_shutdown = 1; -#if CONFIG_ELOG +#if CONFIG_ELOG_GSMI elog_add_event_word(EC_EVENT_BATTERY_CRITICAL, EC_EVENT_FAN_ERROR); #endif } @@ -91,7 +91,7 @@ void stout_ec_finalize_smm(void) if (ec_reg & 0x80) { printk(BIOS_ERR, " EC Thermal Device Error\n"); critical_shutdown = 1; -#if CONFIG_ELOG +#if CONFIG_ELOG_GSMI elog_add_event_word(EC_EVENT_BATTERY_CRITICAL, EC_EVENT_THERMAL); #endif } @@ -103,14 +103,14 @@ void stout_ec_finalize_smm(void) if ((ec_reg & 0xCF) == 0xC0) { printk(BIOS_ERR, " EC Critical Battery Error\n"); critical_shutdown = 1; -#if CONFIG_ELOG +#if CONFIG_ELOG_GSMI elog_add_event_word(ELOG_TYPE_EC_EVENT, EC_EVENT_BATTERY_CRITICAL); #endif } if ((ec_reg & 0x8F) == 0x8F) { printk(BIOS_ERR, " EC Read Battery Error\n"); -#if CONFIG_ELOG +#if CONFIG_ELOG_GSMI elog_add_event_word(ELOG_TYPE_EC_EVENT, EC_EVENT_BATTERY); #endif }

1 0

New patch to review for coreboot: what-jenkins-does: make CPU count configurable
by Patrick Georgi 31 Jul '15

31 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11097 -gerrit commit 005ec5fbf4773fa2a763a3ef58bfa6f47ee9ad25 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Fri Jul 31 16:54:44 2015 +0200 what-jenkins-does: make CPU count configurable Change-Id: I55eb833dba3b13c46138f7d1facc31d999e52db4 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- Makefile.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.inc b/Makefile.inc index 0cb597f..ef9b522 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -681,7 +681,8 @@ $(obj)/board_id: printf $(CONFIG_BOARD_ID_STRING) > $@ JENKINS_PAYLOAD?=none +CPUS?=4 what-jenkins-does: - util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c 4 -z -p $(JENKINS_PAYLOAD) + util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) (cd payloads/libpayload; unset COREBOOT_BUILD_DIR; $(MAKE) $(if $(JENKINS_NOCCACHE),,CONFIG_LP_CCACHE=y) V=$(V) Q=$(Q) junit.xml) $(MAKE) V=$(V) Q=$(Q) -C util/cbmem junit.xml

1 0

New patch to review for coreboot: what-jenkins-does: make its payload selection overridable
by Patrick Georgi 31 Jul '15

31 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11096 -gerrit commit bd3bbbceaee9461fec1babfee930057dd061d9fb Author: Patrick Georgi <pgeorgi(a)google.com> Date: Fri Jul 31 16:54:12 2015 +0200 what-jenkins-does: make its payload selection overridable Change-Id: Ifbdc6bf73595a0d04a8ae09c80394787b6f76d13 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.inc b/Makefile.inc index 2a4eaf6..0cb597f 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -680,7 +680,7 @@ board_id-type := raw $(obj)/board_id: printf $(CONFIG_BOARD_ID_STRING) > $@ -JENKINS_PAYLOAD=none +JENKINS_PAYLOAD?=none what-jenkins-does: util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c 4 -z -p $(JENKINS_PAYLOAD) (cd payloads/libpayload; unset COREBOOT_BUILD_DIR; $(MAKE) $(if $(JENKINS_NOCCACHE),,CONFIG_LP_CCACHE=y) V=$(V) Q=$(Q) junit.xml)

1 0

New patch to review for coreboot: what-jenkins-does: Adapt to recent libpayload kconfig changes
by Patrick Georgi 31 Jul '15

31 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11095 -gerrit commit 9386b0aa5f45c4581cb0a51356de63a6a203a367 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Fri Jul 31 16:39:06 2015 +0200 what-jenkins-does: Adapt to recent libpayload kconfig changes Since we don't actually use this target at this time, it was bitrotting. Fix it up, so we can start to use it. Change-Id: I27d2ed4fb2640680acf739a87d61cb0d1463d705 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.inc b/Makefile.inc index 14fa990..2a4eaf6 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -683,5 +683,5 @@ $(obj)/board_id: JENKINS_PAYLOAD=none what-jenkins-does: util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c 4 -z -p $(JENKINS_PAYLOAD) - (cd payloads/libpayload; $(MAKE) $(if $(JENKINS_NOCCACHE),,CONFIG_CCACHE=y) V=$(V) Q=$(Q) junit.xml) + (cd payloads/libpayload; unset COREBOOT_BUILD_DIR; $(MAKE) $(if $(JENKINS_NOCCACHE),,CONFIG_LP_CCACHE=y) V=$(V) Q=$(Q) junit.xml) $(MAKE) V=$(V) Q=$(Q) -C util/cbmem junit.xml

1 0

New patch to review for coreboot: abuild: avoid hanging in oldconfig for parallel builds
by Patrick Georgi 31 Jul '15

31 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11094 -gerrit commit 0c6f2ba71f80c079edfe0c7da497f467ff1b1dc4 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Fri Jul 31 16:46:55 2015 +0200 abuild: avoid hanging in oldconfig for parallel builds oldconfig may wait for some input. Since we don't care while building tools, just provide something. Change-Id: I1c6f1b46957301886a7645cfb6c6bd264437aa7e Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- util/abuild/abuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/abuild/abuild b/util/abuild/abuild index f556972..9516da5 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -594,7 +594,7 @@ build_all_targets() printf "$configoptions" > $TMPCFG $MAKE -j $cpus DOTCONFIG=$TMPCFG obj=$TARGET/temp objutil=$TARGET/sharedutils allnoconfig printf "$configoptions" >> $TMPCFG - $MAKE -j $cpus DOTCONFIG=$TMPCFG obj=$TARGET/temp objutil=$TARGET/sharedutils oldconfig 2>/dev/null |head > /dev/null + yes "" 2>/dev/null | $MAKE -j $cpus DOTCONFIG=$TMPCFG obj=$TARGET/temp objutil=$TARGET/sharedutils oldconfig 2>/dev/null |head > /dev/null BUILDPREFIX= if [ "$scanbuild" = "true" ]; then scanbuild_out=$TARGET/sharedutils-scanbuild

1 0

New patch to review for coreboot: abuild: in junit output, name chromeos builds different from normal ones
by Patrick Georgi 31 Jul '15

31 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11093 -gerrit commit 6283c21857a57daa81418e453a781c57cef0e393 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Fri Jul 31 16:30:04 2015 +0200 abuild: in junit output, name chromeos builds different from normal ones This will allow building and reporting both in one pass. Change-Id: Id7dbe63c7628cb97d9cf190c151bf23c7b264a89 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- util/abuild/abuild | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/abuild/abuild b/util/abuild/abuild index e347988..f556972 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -241,7 +241,7 @@ function compile_target etime=`perl -e 'print time();' 2>/dev/null || date +%s` duration=$(( $etime - $stime )) - junit " <testcase classname='board' name='$VENDOR/$MAINBOARD' time='$duration' >" + junit " <testcase classname='board${testclass/#/.}' name='$VENDOR/$MAINBOARD' time='$duration' >" if [ $ret -eq 0 ]; then junit "<system-out>" @@ -479,6 +479,7 @@ chromeos=false clean_work=false customizing="" configoptions="" +testclass= while true ; do case "$1" in -J|--junit) shift; mode=junit; rm -f $XMLFILE ;; @@ -538,6 +539,7 @@ while true ; do ;; -x|--chromeos) shift chromeos=true + testclass=chromeos customizing="${customizing}, chrome os" configoptions="${configoptions}CONFIG_CHROMEOS=y\n" ;;

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
105
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2015