coreboot-gerrit July 2015

coreboot-gerrit@coreboot.org

1 participants
1048 discussions

Patch merged into coreboot/master: libpayload: Keep stack boundary small on x86
by gerrit＠coreboot.org 01 Jul '15

01 Jul '15

the following patch was just integrated into master: commit 909b916e56dcbb9e4fa1334055cea998b03d99b4 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Wed Jul 1 11:31:40 2015 -0700 libpayload: Keep stack boundary small on x86 There is no measurable performance impact, but this positively impacts the memory used by payloads. Change-Id: Ib2bdba4a7bf2a4c2391a20b3225bbb44422d3194 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: http://review.coreboot.org/10751 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/10751 for details. -gerrit

1 0

New patch to review for coreboot: libpayload: update xcompile script
by Patrick Georgi 01 Jul '15

01 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10756 -gerrit commit 0cc0dceb32ff83f1ae871a26e43ec24f53266048 Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Wed Jul 1 20:53:00 2015 +0200 libpayload: update xcompile script Copy from coreboot. at some point it probably should just reuse coreboot's version. Change-Id: Iee905a9060983ff85e2e70bde69a221c64a07cbc Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- payloads/libpayload/util/xcompile/xcompile | 317 +++++++++++++++++++---------- 1 file changed, 210 insertions(+), 107 deletions(-) diff --git a/payloads/libpayload/util/xcompile/xcompile b/payloads/libpayload/util/xcompile/xcompile index 859688c..1af02ad 100644 --- a/payloads/libpayload/util/xcompile/xcompile +++ b/payloads/libpayload/util/xcompile/xcompile @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash # # This file is part of the coreboot project. # @@ -20,6 +20,7 @@ # TMPFILE="" +XGCCPATH=${1:-"`pwd`/util/crossgcc/xgcc/bin/"} die() { echo "ERROR: $*" >&2 @@ -32,46 +33,78 @@ clean_up() { fi } +# Create temporary file(s). +TMPFILE="$(mktemp /tmp/temp.XXXX 2>/dev/null || echo /tmp/temp.78gOIUGz)" +touch "$TMPFILE" +trap clean_up EXIT + + program_exists() { type "$1" >/dev/null 2>&1 } + +if [ "$(${XGCCPATH}/iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then + IASL=${XGCCPATH}iasl +elif [ "$(iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then + IASL=iasl +else + die "no iasl found" +fi + +if program_exists gcc; then + HOSTCC=gcc +elif program_exists cc; then + HOSTCC=cc +else + die "no host compiler found" +fi + +cat <<EOF +# platform agnostic and host tools +IASL:=${IASL} +HOSTCC?=${HOSTCC} + +EOF + testcc() { local tmp_c="$TMPFILE.c" local tmp_o="$TMPFILE.o" rm -f "$tmp_c" "$tmp_o" - echo "_start(void) {}" >"$tmp_c" - "$1" -nostdinc -nostdlib -Werror $2 "$tmp_c" -o "$tmp_o" >/dev/null 2>&1 + echo "void _start(void) {}" >"$tmp_c" + "$1" -nostdlib -Werror $2 "$tmp_c" -o "$tmp_o" >/dev/null 2>&1 } testas() { - local gccprefixes="$1" + local gccprefix="$1" local twidth="$2" local arch="$3" local use_dash_twidth="$4" + local endian="$5" local obj_file="$TMPFILE.o" local full_arch="elf$twidth-$arch" rm -f "$obj_file" [ -n "$use_dash_twidth" ] && use_dash_twidth="--$twidth" - ${gccprefixes}as $use_dash_twidth -o "$obj_file" $TMPFILE 2>/dev/null || - return 1 + [ -n "$endian" ] && endian="-$endian" + ${gccprefix}as $use_dash_twidth $endian -o "$obj_file" $TMPFILE \ + 2>/dev/null || return 1 # Check output content type. - local obj_type="$(${gccprefixes}objdump -p $obj_file)" + local obj_type="$(${gccprefix}objdump -p $obj_file)" local obj_arch="$(expr "$obj_type" : '.*format $.[a-z0-9-]*$')" [ "$obj_arch" = "$full_arch" ] || return 1 # Architecture matched. - GCCPREFIX="$gccprefixes" + GCCPREFIX="$gccprefix" - if [ -z "$use_dash_twidth" ]; then - ASFLAGS="" - CFLAGS="" - LDFLAGS="" - else + unset ASFLAGS LDFLAGS + unset CFLAGS_GCC CFLAGS_CLANG + + if [ -n "$use_dash_twidth" ]; then ASFLAGS="--$twidth" - CFLAGS="-m$twidth" + CFLAGS_GCC="-m$twidth" + CFLAGS_CLANG="-m$twidth" LDFLAGS="-b $full_arch" fi @@ -80,7 +113,8 @@ testas() { [ -n "$use_dash_twidth" ] && case "$full_arch" in "elf32-i386" ) LDFLAGS="$LDFLAGS -melf_i386" - CFLAGS="$CFLAGS -Wl,-b,elf32-i386 -Wl,-melf_i386" + CFLAGS_GCC="$CFLAGS_GCC -Wl,-b,elf32-i386 -Wl,-melf_i386" + CFLAGS_CLANG="$CFLAGS_GCC -Wl,-b,elf32-i386 -Wl,-melf_i386" ;; esac @@ -91,94 +125,160 @@ detect_special_flags() { local architecture="$1" # GCC 4.6 is much more picky about unused variables. # Turn off it's warnings for now: - testcc "$CC" "$CFLAGS -Wno-unused-but-set-variable " && - CFLAGS="$CFLAGS -Wno-unused-but-set-variable " + testcc "$GCC" "$CFLAGS_GCC -Wno-unused-but-set-variable " && + CFLAGS_GCC="$CFLAGS_GCC -Wno-unused-but-set-variable " + + # Check for an operational -m32/-m64 + testcc "$GCC" "$CFLAGS_GCC -m$TWIDTH " && + CFLAGS_GCC="$CFLAGS_GCC -m$TWIDTH " # Use bfd linker instead of gold if available: - testcc "$CC" "$CFLAGS -fuse-ld=bfd" && - CFLAGS="$CFLAGS -fuse-ld=bfd" && LINKER_SUFFIX='.bfd' + testcc "$GCC" "$CFLAGS_GCC -fuse-ld=bfd" && + CFLAGS_GCC="$CFLAGS_GCC -fuse-ld=bfd" && LINKER_SUFFIX='.bfd' - testcc "$CC" "$CFLAGS -Wa,--divide" && - CFLAGS="$CFLAGS -Wa,--divide" - testcc "$CC" "$CFLAGS -fno-stack-protector"&& - CFLAGS="$CFLAGS -fno-stack-protector" - testcc "$CC" "$CFLAGS -Wl,--build-id=none" && - CFLAGS="$CFLAGS -Wl,--build-id=none" + testcc "$GCC" "$CFLAGS_GCC -fno-stack-protector"&& + CFLAGS_GCC="$CFLAGS_GCC -fno-stack-protector" + testcc "$GCC" "$CFLAGS_GCC -Wl,--build-id=none" && + CFLAGS_GCC="$CFLAGS_GCC -Wl,--build-id=none" case "$architecture" in - arm ) - # testcc "$CC" "$CFLAGS -mcpu=cortex-a9" && - # CFLAGS="$CFLAGS -mcpu=cortex-a9" - ;; - - arm64-generic ) - ;; - mips ) - testcc "$CC" "CFLAGS -mxgot" && - CFLAGS="$CFLAGS -mxgot" - ;; + x86) + testcc "$GCC" "$CFLAGS_GCC -Wa,--divide" && + CFLAGS_GCC="$CFLAGS_GCC -Wa,--divide" + testcc "$CLANG" "$CFLAGS_CLANG -Wa,--divide" && + CFLAGS_CLANG="$CFLAGS_CLANG -Wa,--divide" + # Always build for i686 -- no sse/mmx instructions since SMM + # modules are compiled using these flags. Note that this + # doesn't prevent a project using xcompile to explicitly + # specify -mmsse, etc flags. + CFLAGS_GCC="$CFLAGS_GCC -march=i686" + ;; + x64) + testcc "$GCC" "$CFLAGS_GCC -Wa,--divide" && + CFLAGS_GCC="$CFLAGS_GCC -Wa,--divide" + testcc "$CLANG" "$CFLAGS_CLANG -Wa,--divide" && + CFLAGS_CLANG="$CFLAGS_CLANG -Wa,--divide" + ;; + mipsel) + testcc "$GCC" "$CFLAGS_GCC -mno-abicalls -fno-pic" && \ + CFLAGS_GCC+=" -mno-abicalls -fno-pic" + + # Enforce little endian mode. + testcc "$GCC" "$CFLAGS_GCC -EL" && \ + CFLAGS_GCC+=" -EL" + ;; esac } +detect_compiler_runtime() { + test -z "$CLANG" || \ + CC_RT_CLANG="`${CLANG} ${CFLAGS} -print-librt-file-name 2>/dev/null`" + test -z "$GCC" || \ + CC_RT_GCC="`${GCC} ${CFLAGS} -print-libgcc-file-name`" +} + report_arch_toolchain() { cat <<EOF -# elf${TWIDTH}-${TBFDARCH} toolchain (${GCCPREFIX}gcc) -CC_${TARCH}:=${GCCPREFIX}gcc ${CFLAGS} +# elf${TWIDTH}-${TBFDARCH} toolchain (${GCC}) +ARCH_SUPPORTED+=${TARCH} +SUBARCH_SUPPORTED+=${TSUPP-${TARCH}} +ifeq (\$(CONFIG_COMPILER_GCC),y) +CC_${TARCH}:=${GCC} +CFLAGS_${TARCH}:=${CFLAGS_GCC} +COMPILER_RT_${TARCH}:=${CC_RT_GCC} +COMPILER_RT_FLAGS_${TARCH}:=${CC_RT_EXTRA_GCC} +else +CC_${TARCH}:=${CLANG} +CFLAGS_${TARCH}:=${CFLAGS_CLANG} +CFLAGS_${TARCH}+=-no-integrated-as -Qunused-arguments -m${TWIDTH} +# tone down compiler warnings +CFLAGS_${TARCH}+=-Wno-unused-variable -Wno-unused-function -Wno-tautological-compare -Wno-shift-overflow +COMPILER_RT_${TARCH}:=${CC_RT_CLANG} +COMPILER_RT_FLAGS_${TARCH}:=${CC_RT_EXTRA_CLANG} +endif +CPP_${TARCH}:=${GCCPREFIX}cpp AS_${TARCH}:=${GCCPREFIX}as ${ASFLAGS} -LD_${TARCH}:=${GCCPREFIX}ld ${LDFLAGS} +LD_${TARCH}:=${GCCPREFIX}ld${LINKER_SUFFIX} ${LDFLAGS} NM_${TARCH}:=${GCCPREFIX}nm OBJCOPY_${TARCH}:=${GCCPREFIX}objcopy OBJDUMP_${TARCH}:=${GCCPREFIX}objdump READELF_${TARCH}:=${GCCPREFIX}readelf STRIP_${TARCH}:=${GCCPREFIX}strip AR_${TARCH}:=${GCCPREFIX}ar +CROSS_COMPILE_${TARCH}:=${GCCPREFIX} EOF } -# Create temporary file(s). -TMPFILE="$(mktemp /tmp/temp.XXXX 2>/dev/null || echo /tmp/temp.78gOIUGz)" -touch "$TMPFILE" -trap clean_up EXIT +# Architecture definitions +SUPPORTED_ARCHITECTURES="arm arm64 mipsel riscv x64 x86" -# Architecture definition -SUPPORTED_ARCHITECTURE="arm arm64 mipsel x86" +arch_config_arm() { + TARCH="arm" + TBFDARCHS="littlearm" + TCLIST="armv7a armv7-a" + TWIDTH="32" + TSUPP="arm armv4 armv7 armv7_m" + TABI="eabi" +} -# ARM Architecture -TARCH_arm="arm" -TBFDARCH_arm="littlearm" -TCLIST_arm="armv7a armv7-a" -TWIDTH_arm="32" +arch_config_arm64() { + TARCH="arm64" + TBFDARCHS="littleaarch64" + TCLIST="aarch64" + TWIDTH="64" + TSUPP="arm64 armv8_64" + TABI="elf" +} -# ARM64 Architecture -TARCH_arm64="arm64" -TBFDARCH_arm64="littleaarch64" -TCLIST_arm64="aarch64" -TWIDTH_arm64="64" +arch_config_riscv() { + TARCH="riscv" + TBFDARCHS="littleriscv" + TCLIST="riscv" + TWIDTH="64" + TABI="elf" +} -# MIPS Architecture (Little Endian) -TARCH_mipsel="mipsel" -TBFDARCH_mipsel="tradlittlemips littlemips" -TCLIST_mipsel="mipsel" -TWIDTH_mipsel="32" +arch_config_x64() { + TARCH="x86_64" + TBFDARCHS="x86-64" + TCLIST="x86_64" + TWIDTH="64" + TABI="elf" +} -# X86 Architecture -TARCH_x86="i386" -TBFDARCH_x86="i386" -TCLIST_x86="i386 x86_64" -TWIDTH_x86="32" +arch_config_x86() { + TARCH="x86_32" + TBFDARCHS="i386" + TCLIST="i386 x86_64" + TWIDTH="32" + TABI="elf" + CC_RT_EXTRA_GCC="--wrap __divdi3 --wrap __udivdi3 --wrap __moddi3 --wrap __umoddi3" +} -XGCCPATH=${1:-"`pwd`/../../util/crossgcc/xgcc/bin/"} +arch_config_mipsel() { + TARCH="mips" + TBFDARCHS="tradlittlemips littlemips" + TCLIST="mipsel" + TWIDTH="32" + TSUPP="mips mipsel" + TABI="elf" + TENDIAN="EL" +} + +test_architecture() { + local architecture=$1 + local endian gccprefix search -# This loops over all supported architectures. -for architecture in $SUPPORTED_ARCHITECTURE; do GCCPREFIX="invalid" - TARCH="$(eval echo \$TARCH_$architecture)" - TBFDARCHS="$(eval echo \$TBFDARCH_$architecture)" - TCLIST="$(eval echo \$TCLIST_$architecture)" - TWIDTH="$(eval echo \$TWIDTH_$architecture)" - [ -z "$TARCH" -o -z "$TCLIST" -o -z "$TWIDTH" ] && - die "Missing architecture definition for $architecture." + unset TABI TARCH TBFDARCH TCLIST TENDIAN TSUPP TWIDTH + unset CC_RT_EXTRA_GCC CC_RT_EXTRA_CLANG + unset GCC CLANG + if type arch_config_$architecture > /dev/null; then + arch_config_$architecture + else + die "no architecture definition for $architecture" + fi # To override toolchain, define CROSS_COMPILE_$arch or CROSS_COMPILE as # environment variable. @@ -187,48 +287,51 @@ for architecture in $SUPPORTED_ARCHITECTURE; do search="$(eval echo \$CROSS_COMPILE_$architecture 2>/dev/null)" search="$search $CROSS_COMPILE" for toolchain in $TCLIST; do - search="$search $XGCCPATH$toolchain-elf-" - search="$search $toolchain-elf-" - search="$search $XGCCPATH$toolchain-eabi-" - search="$search $toolchain-eabi-" + search="$search $XGCCPATH$toolchain-$TABI-" + search="$search $toolchain-$TABI-" + search="$search $toolchain-linux-gnu-" + search="$search $toolchain-" done echo "# $architecture TARCH_SEARCH=$search" # Search toolchain by checking assembler capability. for TBFDARCH in $TBFDARCHS; do - for gccprefixes in $search ""; do - program_exists "${gccprefixes}as" || continue - testas "$gccprefixes" "$TWIDTH" "$TBFDARCH" "" && break - testas "$gccprefixes" "$TWIDTH" "$TBFDARCH" "TRUE" && break + for gccprefix in $search ""; do + program_exists "${gccprefix}as" || continue + for endian in $TENDIAN ""; do + testas "$gccprefix" "$TWIDTH" "$TBFDARCH" \ + "" "$endian" && break 3 + testas "$gccprefix" "$TWIDTH" "$TBFDARCH" \ + "TRUE" "$endian" && break 3 + done done - [ "$GCCPREFIX" = "invalid" ] || break done - - if [ "$GCCPREFIX" = "invalid" ]; then - echo "Warning: no suitable GCC for $architecture." >&2 - continue + if [ "invalid" != "$GCCPREFIX" ]; then + GCC="${GCCPREFIX}gcc" fi - CC="${GCCPREFIX}"gcc - detect_special_flags "$architecture" - report_arch_toolchain -done - -if [ "$(${XGCCPATH}/iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then - IASL=${XGCCPATH}iasl -else - IASL=iasl -fi + for clang_arch in $TCLIST invalid; do + testcc "clang" "-target ${clang_arch}-$TABI -c" && break + done -if program_exists gcc; then - HOSTCC=gcc -else - HOSTCC=cc -fi + if [ "invalid" != "$clang_arch" ]; then + # FIXME: this may break in a clang && !gcc configuration, + # but that's more of a clang limitation. Let's be optimistic + # that this will change in the future. + CLANG="clang -target ${clang_arch}-${TABI} -ccc-gcc-name ${GCC}" + fi -cat <<EOF -IASL:=${IASL} + if [ -z "$GCC" -a -z "$CLANG" ]; then + echo "Warning: no suitable compiler for $architecture." >&2 + return 1 + fi +} -# native toolchain -HOSTCC:=${HOSTCC} -EOF +# This loops over all supported architectures. +for architecture in $SUPPORTED_ARCHITECTURES; do + if test_architecture $architecture; then + detect_special_flags "$architecture" + detect_compiler_runtime "$architecture" + report_arch_toolchain + fi +done

1 0

New patch to review for coreboot: libpayload: Fix compilation on ARM with GDB enabled
by Stefan Reinauer 01 Jul '15

01 Jul '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10755 -gerrit commit c94733c6f3e9af765f3128d58029ec9a0ab5607f Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Wed Jul 1 11:48:57 2015 -0700 libpayload: Fix compilation on ARM with GDB enabled Without this, gdb_enter() is not defined. Change-Id: I067dce371ee817d6ac77387fcbe42a9a7deb6438 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- payloads/libpayload/arch/arm/virtual.c | 1 + 1 file changed, 1 insertion(+) diff --git a/payloads/libpayload/arch/arm/virtual.c b/payloads/libpayload/arch/arm/virtual.c index 0d53e50..acca057 100644 --- a/payloads/libpayload/arch/arm/virtual.c +++ b/payloads/libpayload/arch/arm/virtual.c @@ -27,6 +27,7 @@ * SUCH DAMAGE. */ +#include <libpayload.h> #include <assert.h> #include <die.h> #include <stdlib.h>

1 0

New patch to review for coreboot: linker scripts: Fix symbol handling for pre-RAM cbmem console
by Patrick Georgi 01 Jul '15

01 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10754 -gerrit commit 5c178567ec3ac95a70851b10d4bbdda26e4fb30b Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Wed Jul 1 20:30:56 2015 +0200 linker scripts: Fix symbol handling for pre-RAM cbmem console Some ld versions (eg. the one used in the chromium build system) mis-handled the redefined symbol in romstage.ld, so use the feature that exists for precisely that purpose. Change-Id: I184310ab20a02f6b3d569798448eac78b13e88a3 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- src/lib/romstage.ld | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/romstage.ld b/src/lib/romstage.ld index 7d552a7..ba154ef 100644 --- a/src/lib/romstage.ld +++ b/src/lib/romstage.ld @@ -37,8 +37,8 @@ *(.rodata.*); *(.data); *(.data.*); - _preram_cbmem_console = DEFINED(_preram_cbmem_console) ? _preram_cbmem_console : 0; - _epreram_cbmem_console = DEFINED(_epreram_cbmem_console) ? _epreram_cbmem_console : 0; + PROVIDE(_preram_cbmem_console = .); + PROVIDE(_epreram_cbmem_console = _preram_cbmem_console); . = ALIGN(8); }

1 0

New patch to review for coreboot: rockchip/rk3288: Initialize CPU in bootblock
by Patrick Georgi 01 Jul '15

01 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10753 -gerrit commit 3eebb09dfe30749fd9892b0c4010ec360f586d8b Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Wed Jul 1 20:29:42 2015 +0200 rockchip/rk3288: Initialize CPU in bootblock Some basic MMU setup is required to allow unaligned memory accesses that happen across our entire codebase. Change-Id: If5a84e19a7a3e47d6009fd073b1323dfb25e6a06 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Found-by: Julius Werner <jwerner(a)chromium.org> --- src/soc/rockchip/rk3288/Makefile.inc | 2 +- src/soc/rockchip/rk3288/bootblock.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/rockchip/rk3288/Makefile.inc b/src/soc/rockchip/rk3288/Makefile.inc index 0ec127b..cd523b0 100644 --- a/src/soc/rockchip/rk3288/Makefile.inc +++ b/src/soc/rockchip/rk3288/Makefile.inc @@ -21,7 +21,7 @@ ifeq ($(CONFIG_SOC_ROCKCHIP_RK3288),y) IDBTOOL = util/rockchip/make_idb.py -#bootblock-y += bootblock.c +bootblock-y += bootblock.c bootblock-y += cbmem.c ifeq ($(CONFIG_BOOTBLOCK_CONSOLE),y) bootblock-$(CONFIG_DRIVERS_UART) += uart.c diff --git a/src/soc/rockchip/rk3288/bootblock.c b/src/soc/rockchip/rk3288/bootblock.c index ce0ab33..d60c860 100644 --- a/src/soc/rockchip/rk3288/bootblock.c +++ b/src/soc/rockchip/rk3288/bootblock.c @@ -27,7 +27,7 @@ #include <soc/timer.h> #include <symbols.h> -static void bootblock_soc_init(void) +void bootblock_soc_init(void) { rkclk_init();

1 0

New patch to review for coreboot: nvidia/tegra210: Drop unused Kconfig symbol
by Patrick Georgi 01 Jul '15

01 Jul '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10752 -gerrit commit dd35057935e1c95cba18110a45f8a6f6eab2f48e Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Wed Jul 1 20:22:39 2015 +0200 nvidia/tegra210: Drop unused Kconfig symbol The deleted symbols aren't used anywhere in the coreboot tree and come from the downstream chromeos-2013.04 branch. Change-Id: I0ebc2936dff400cf8fe68794c86ac583aba2a14b Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- src/soc/nvidia/tegra210/Kconfig | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/soc/nvidia/tegra210/Kconfig b/src/soc/nvidia/tegra210/Kconfig index 257345e..b0f3a02 100644 --- a/src/soc/nvidia/tegra210/Kconfig +++ b/src/soc/nvidia/tegra210/Kconfig @@ -13,10 +13,7 @@ config SOC_NVIDIA_TEGRA210 select GENERIC_UDELAY select HAVE_HARD_RESET select HAVE_UART_SPECIAL - select HAVE_UART_MEMORY_MAPPED - select EARLY_CONSOLE select ARM_BOOTBLOCK_CUSTOM - select DYNAMIC_CBMEM select ARM64_USE_ARM_TRUSTED_FIRMWARE select HAS_PRECBMEM_TIMESTAMP_REGION select CHROMEOS_RAMOOPS_NON_ACPI

1 0

New patch to review for coreboot: libpayload: Keep stack boundary small on x86
by Stefan Reinauer 01 Jul '15

01 Jul '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10751 -gerrit commit 97f444010dfc8f239606f9a0d6bfea1ad7677299 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Wed Jul 1 11:31:40 2015 -0700 libpayload: Keep stack boundary small on x86 There is no measurable performance impact, but this positively impacts the memory used by payloads. Change-Id: Ib2bdba4a7bf2a4c2391a20b3225bbb44422d3194 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- payloads/libpayload/arch/x86/Makefile.inc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/payloads/libpayload/arch/x86/Makefile.inc b/payloads/libpayload/arch/x86/Makefile.inc index 87b3e9e..6517bf1 100644 --- a/payloads/libpayload/arch/x86/Makefile.inc +++ b/payloads/libpayload/arch/x86/Makefile.inc @@ -27,6 +27,8 @@ ## SUCH DAMAGE. ## +CFLAGS += -mpreferred-stack-boundary=2 + head.o-y += head.S libc-y += main.c sysinfo.c libc-y += timer.c coreboot.c util.S

1 0

New patch to review for coreboot: libpayload: always compile with -ffunction-sections
by Stefan Reinauer 01 Jul '15

01 Jul '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10750 -gerrit commit 8bf54f4578ecb431f75aa6e49e848da57007037a Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Wed Jul 1 11:30:03 2015 -0700 libpayload: always compile with -ffunction-sections This does not hurt, and it allows the linker to produce much smaller binaries in some circumstances. Change-Id: Ibf9f24c210d6d2ed40451b4cf0d68ce88220bc5f Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- payloads/libpayload/Makefile.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/payloads/libpayload/Makefile.inc b/payloads/libpayload/Makefile.inc index a3094aa..9b182b6 100644 --- a/payloads/libpayload/Makefile.inc +++ b/payloads/libpayload/Makefile.inc @@ -59,6 +59,7 @@ INCLUDES := -Iinclude -Iinclude/$(ARCHDIR-y) -I$(obj) -include include/kconfig.h CFLAGS = $(EXTRA_CFLAGS) $(INCLUDES) -Os -pipe -nostdinc -ggdb3 CFLAGS += -nostdlib -fno-builtin -ffreestanding -fomit-frame-pointer +CFLAGS += -ffunction-sections CFLAGS += -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS += -Wwrite-strings -Wredundant-decls -Wno-trigraphs CFLAGS += -Wstrict-aliasing -Wshadow -Werror

1 0

Patch merged into coreboot/master: tegra210: Include correct include files
by gerrit＠coreboot.org 01 Jul '15

01 Jul '15

the following patch was just integrated into master: commit d0ed7eef7413cc753b03e2cfba36ef9208491d71 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Wed Jul 1 10:40:08 2015 -0700 tegra210: Include correct include files Some include files were unnecessary, and program_loading.h was missing. Change-Id: Ief3d970af5fbbb6b79da06ba3ea1d8613bfc314f Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: http://review.coreboot.org/10749 Reviewed-by: Marc Jones <marc.jones(a)se-eng.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/10749 for details. -gerrit

1 0

New patch to review for coreboot: tegra210: Include correct include files
by Stefan Reinauer 01 Jul '15

01 Jul '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10749 -gerrit commit de17a314d34aa6c1e0e9b4b06c6ca2434b3f3862 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Wed Jul 1 10:40:08 2015 -0700 tegra210: Include correct include files Some include files were unnecessary, and program_loading.h was missing. Change-Id: Ief3d970af5fbbb6b79da06ba3ea1d8613bfc314f Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- src/soc/nvidia/tegra210/verstage.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/soc/nvidia/tegra210/verstage.c b/src/soc/nvidia/tegra210/verstage.c index 1241f24..6a4df29 100644 --- a/src/soc/nvidia/tegra210/verstage.c +++ b/src/soc/nvidia/tegra210/verstage.c @@ -20,11 +20,9 @@ #include <arch/cache.h> #include <arch/exception.h> #include <arch/hlt.h> -#include <arch/stages.h> -#include <console/console.h> #include <soc/verstage.h> -#include <timestamp.h> -#include <vendorcode/google/chromeos/chromeos.h> +#include <console/console.h> +#include <program_loading.h> void __attribute__((weak)) verstage_mainboard_init(void) {

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2015