New patch to review for coreboot: linker scripts: Fix symbol handling for pre-RAM cbmem console
Patrick Georgi (pgeorgi@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10754 -gerrit commit 5c178567ec3ac95a70851b10d4bbdda26e4fb30b Author: Patrick Georgi <pgeorgi@chromium.org> Date: Wed Jul 1 20:30:56 2015 +0200 linker scripts: Fix symbol handling for pre-RAM cbmem console Some ld versions (eg. the one used in the chromium build system) mis-handled the redefined symbol in romstage.ld, so use the feature that exists for precisely that purpose. Change-Id: I184310ab20a02f6b3d569798448eac78b13e88a3 Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> --- src/lib/romstage.ld | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/romstage.ld b/src/lib/romstage.ld index 7d552a7..ba154ef 100644 --- a/src/lib/romstage.ld +++ b/src/lib/romstage.ld @@ -37,8 +37,8 @@ *(.rodata.*); *(.data); *(.data.*); - _preram_cbmem_console = DEFINED(_preram_cbmem_console) ? _preram_cbmem_console : 0; - _epreram_cbmem_console = DEFINED(_epreram_cbmem_console) ? _epreram_cbmem_console : 0; + PROVIDE(_preram_cbmem_console = .); + PROVIDE(_epreram_cbmem_console = _preram_cbmem_console); . = ALIGN(8); }
participants (1)
-
Patrick Georgi