coreboot-gerrit March 2015

coreboot-gerrit@coreboot.org

1 participants
2443 discussions

Patch set updated for coreboot: c664279 northbride/i945/gma: revert patch that hardcodes tft_brightness
by Francis Rowe 16 Mar '15

16 Mar '15

Francis Rowe (info(a)gluglug.org.uk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8697 -gerrit commit c66427992163c61c381fab4c9fd74e1feb877546 Author: Francis Rowe <info(a)gluglug.org.uk> Date: Mon Mar 16 07:06:30 2015 +0000 northbride/i945/gma: revert patch that hardcodes tft_brightness It was an accident. Change-Id: Ib421d33da7e853f509e9e58fad864fb8a36526de Signed-off-by: Francis Rowe <info(a)gluglug.org.uk> --- src/northbridge/intel/i945/gma.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index cee0640..d556a06 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -472,14 +472,17 @@ static void gma_func0_disable(struct device *dev) static void gma_func1_init(struct device *dev) { u32 reg32; + u8 val; /* IGD needs to be Bus Master, also enable IO accesss */ reg32 = pci_read_config32(dev, PCI_COMMAND); pci_write_config32(dev, PCI_COMMAND, reg32 | PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY | PCI_COMMAND_IO); - /* Permanently set tft_brightness to 0xff. Ignore nvramtool configuration */ - pci_write_config8(dev, 0xf4, 0xff); + if (get_option(&val, "tft_brightness") == CB_SUCCESS) + pci_write_config8(dev, 0xf4, val); + else + pci_write_config8(dev, 0xf4, 0xff); } static void gma_set_subsystem(device_t dev, unsigned vendor, unsigned device)

1 0

New patch to review for coreboot: 4c18a2e northbride/i945/gma: revert patch that hardcodes tft_brightness
by Francis Rowe 16 Mar '15

16 Mar '15

Francis Rowe (info(a)gluglug.org.uk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8697 -gerrit commit 4c18a2e4bd63e348866e71f0975c6227a3a1fe77 Author: Francis Rowe <info(a)gluglug.org.uk> Date: Mon Mar 16 07:06:30 2015 +0000 northbride/i945/gma: revert patch that hardcodes tft_brightness I messed up. Change-Id: Ib421d33da7e853f509e9e58fad864fb8a36526de Signed-off-by: Francis Rowe <info(a)gluglug.org.uk> --- src/northbridge/intel/i945/gma.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index cee0640..d556a06 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -472,14 +472,17 @@ static void gma_func0_disable(struct device *dev) static void gma_func1_init(struct device *dev) { u32 reg32; + u8 val; /* IGD needs to be Bus Master, also enable IO accesss */ reg32 = pci_read_config32(dev, PCI_COMMAND); pci_write_config32(dev, PCI_COMMAND, reg32 | PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY | PCI_COMMAND_IO); - /* Permanently set tft_brightness to 0xff. Ignore nvramtool configuration */ - pci_write_config8(dev, 0xf4, 0xff); + if (get_option(&val, "tft_brightness") == CB_SUCCESS) + pci_write_config8(dev, 0xf4, val); + else + pci_write_config8(dev, 0xf4, 0xff); } static void gma_set_subsystem(device_t dev, unsigned vendor, unsigned device)

1 0

Patch set updated for coreboot: 608e934 NOTFORMERGE: i945: permanently set tft_brightness to 0xff
by Francis Rowe 16 Mar '15

16 Mar '15

Francis Rowe (info(a)gluglug.org.uk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7561 -gerrit commit 608e934eb26f0d6d16663d2dd249c66d456a30d9 Author: Francis Rowe <info(a)gluglug.org.uk> Date: Sun Nov 23 06:19:48 2014 +0000 NOTFORMERGE: i945: permanently set tft_brightness to 0xff Fixes bug where you increase brightness on X60 from top and it resets to zero. Change-Id: I33c15b5b6f8ab180c1cc83fdcdc2f48930bdd829 Signed-off-by: Francis Rowe <info(a)gluglug.org.uk>

1 0

Patch set updated for coreboot: 5621b5f NOTFORMERGE: i945: permanently set tft_brightness to 0xff
by Francis Rowe 16 Mar '15

16 Mar '15

Francis Rowe (info(a)gluglug.org.uk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7561 -gerrit commit 5621b5f2a05ae803155989d3461d2106ea5af4b3 Author: Francis Rowe <info(a)gluglug.org.uk> Date: Sun Nov 23 06:19:48 2014 +0000 NOTFORMERGE: i945: permanently set tft_brightness to 0xff Change-Id: I33c15b5b6f8ab180c1cc83fdcdc2f48930bdd829 Signed-off-by: Francis Rowe <info(a)gluglug.org.uk>

1 0

Patch merged into coreboot/master: 8e3da74 mainboards/amd: Fix incorrect reboot_bits location
by gerrit＠coreboot.org 16 Mar '15

16 Mar '15

the following patch was just integrated into master: commit 8e3da749ed912834ddf9b78bff956a2b7d269945 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Sat Mar 14 17:59:51 2015 -0500 mainboards/amd: Fix incorrect reboot_bits location Change-Id: Iead07df714f4f1bbaae6b564431fb4edf7b18ac2 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/8684 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See http://review.coreboot.org/8684 for details. -gerrit

1 0

Patch set updated for coreboot: adfd906 device/Kconfig: Select native graphics init by default
by Alexandru Gagniuc 15 Mar '15

15 Mar '15

Alexandru Gagniuc (mr.nuke.me(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5957 -gerrit commit adfd9066136f853cf8f53c4510d8c1b1ed790d9c Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Jun 7 21:50:21 2014 +0200 device/Kconfig: Select native graphics init by default We want to always build-test native VGA init, and encourage people to use it instead of VBIOS. Change-Id: I47ed328ce8ce3516ad3997978a01d2359d9b1ca8 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Signed-off-by: Francis Rowe <info(a)gluglug.org.uk> --- src/device/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/device/Kconfig b/src/device/Kconfig index 7f43888..dcb52ac 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -38,7 +38,7 @@ config MAINBOARD_HAS_NATIVE_VGA_INIT_TEXTMODECFG config MAINBOARD_DO_NATIVE_VGA_INIT bool "Use native graphics initialization" depends on MAINBOARD_HAS_NATIVE_VGA_INIT - default n + default y help Some mainboards, such as the Google Link, allow initializing the display without the need of a binary only VGA OPROM. Enabling this option may be

1 0

Patch set updated for coreboot: 118513e packardbell/ms2290: Fix build with native graphics init
by Alexandru Gagniuc 15 Mar '15

15 Mar '15

Alexandru Gagniuc (mr.nuke.me(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6985 -gerrit commit 118513ea44e971a3dde7363a2bd04af90d0ac21c Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Sep 27 10:02:15 2014 +0200 packardbell/ms2290: Fix build with native graphics init Fix native VGA init build issues introduced by commit * a2a906e4 Consolidate intel vga int15 hooks Include the header file `drivers/intel/gma/int15.h` unconditionally, so that the prototype of `install_intel_vga_int15_handler()` is always to be found. Change-Id: Ie64f9510f49fe9d67b14ce27d7e789d6007ca0a6 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/mainboard/packardbell/ms2290/mainboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c index c14e9b7..9e64f5c 100644 --- a/src/mainboard/packardbell/ms2290/mainboard.c +++ b/src/mainboard/packardbell/ms2290/mainboard.c @@ -35,8 +35,8 @@ #include <pc80/mc146818rtc.h> #include <arch/x86/include/arch/acpigen.h> -#if CONFIG_PCI_OPTION_ROM_RUN_YABEL || CONFIG_PCI_OPTION_ROM_RUN_REALMODE #include <drivers/intel/gma/int15.h> +#if CONFIG_PCI_OPTION_ROM_RUN_YABEL || CONFIG_PCI_OPTION_ROM_RUN_REALMODE #include <arch/interrupt.h> #endif #include <pc80/keyboard.h>

1 0

Patch set updated for coreboot: c9cab6f packardbell/ms2290: Fix build with native graphics init
by Alexandru Gagniuc 15 Mar '15

15 Mar '15

Alexandru Gagniuc (mr.nuke.me(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6985 -gerrit commit c9cab6fc30d406ce88271a698e2c515e104fe1a3 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Sep 27 10:02:15 2014 +0200 packardbell/ms2290: Fix build with native graphics init Fix up commit a2a906e4 (Consolidate intel vga int15 hooks) [1] breaking the build of Packard Bell EasyNote LM85 (MS2290) with native graphics initialization enabled. src/mainboard/packardbell/ms2290/mainboard.c: In function 'mainboard_enable': src/mainboard/packardbell/ms2290/mainboard.c:127:2: error: implicit declaration of function 'install_intel_vga_int15_handler' [-Werror=implicit-function-declaration] src/mainboard/packardbell/ms2290/mainboard.c:127:34: error: 'GMA_INT15_ACTIVE_LFP_INT_LVDS' undeclared (first use in this function) src/mainboard/packardbell/ms2290/mainboard.c:127:34: note: each undeclared identifier is reported only once for each function it appears in src/mainboard/packardbell/ms2290/mainboard.c:127:65: error: 'GMA_INT15_PANEL_FIT_DEFAULT' undeclared (first use in this function) src/mainboard/packardbell/ms2290/mainboard.c:127:94: error: 'GMA_INT15_BOOT_DISPLAY_LFP' undeclared (first use in this function) Include the header file `drivers/intel/gma/int15.h` unconditionally, so that the prototype of `install_intel_vga_int15_handler()` is always to be found. [1] http://review.coreboot.org/6820 Change-Id: Ie64f9510f49fe9d67b14ce27d7e789d6007ca0a6 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/mainboard/packardbell/ms2290/mainboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c index c14e9b7..9e64f5c 100644 --- a/src/mainboard/packardbell/ms2290/mainboard.c +++ b/src/mainboard/packardbell/ms2290/mainboard.c @@ -35,8 +35,8 @@ #include <pc80/mc146818rtc.h> #include <arch/x86/include/arch/acpigen.h> -#if CONFIG_PCI_OPTION_ROM_RUN_YABEL || CONFIG_PCI_OPTION_ROM_RUN_REALMODE #include <drivers/intel/gma/int15.h> +#if CONFIG_PCI_OPTION_ROM_RUN_YABEL || CONFIG_PCI_OPTION_ROM_RUN_REALMODE #include <arch/interrupt.h> #endif #include <pc80/keyboard.h>

1 0

Patch set updated for coreboot: 598f905 device/Kconfig: Select native graphics init by default
by Alexandru Gagniuc 15 Mar '15

15 Mar '15

Alexandru Gagniuc (mr.nuke.me(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5957 -gerrit commit 598f90500b83be287e473de8f1f925c1f4841fe4 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Jun 7 21:50:21 2014 +0200 device/Kconfig: Select native graphics init by default We want to always build-test native VGA init, and encourage people to use it instead of VBIOS. Change-Id: I47ed328ce8ce3516ad3997978a01d2359d9b1ca8 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Signed-off-by: Francis Rowe <info(a)gluglug.org.uk> --- src/device/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/device/Kconfig b/src/device/Kconfig index 58dcc1b..3d47602 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -32,7 +32,7 @@ config MAINBOARD_HAS_NATIVE_VGA_INIT_TEXTMODECFG config MAINBOARD_DO_NATIVE_VGA_INIT bool "Use native graphics initialization" depends on MAINBOARD_HAS_NATIVE_VGA_INIT - default n + default y help Some mainboards, such as the Google Link, allow initializing the display without the need of a binary only VGA OPROM. Enabling this option may be

1 0

Patch merged into coreboot/master: 71512b2 northbridge/i945/gma: fix build error with native graphics init
by gerrit＠coreboot.org 15 Mar '15

15 Mar '15

the following patch was just integrated into master: commit 71512b2cf6cc00a455fa354d87092c6473ee117c Author: Francis Rowe <info(a)gluglug.org.uk> Date: Mon Mar 16 05:31:40 2015 +0000 northbridge/i945/gma: fix build error with native graphics init Tested on an X60, Native graphics init still works perfectly. Change-Id: I91be3baa658e0332028c512c5a4cb0aee07d540a Signed-off-by: Francis Rowe <info(a)gluglug.org.uk> Reviewed-on: http://review.coreboot.org/8696 Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/8696 for details. -gerrit

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2015