coreboot-gerrit November 2015

coreboot-gerrit@coreboot.org

1 participants
1544 discussions

Patch set updated for coreboot: nvramtool: Makefile: install: use $(INSTALL) instead of mkdir
by Stefan Reinauer 11 Nov '15

11 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12405 -gerrit commit 6b32bb19e37ea5f6565596d4eb068670417d7109 Author: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Date: Wed Nov 11 05:44:10 2015 +0100 nvramtool: Makefile: install: use $(INSTALL) instead of mkdir Change-Id: Icee9b37030558d12da74f898c7f78625a5735277 Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> --- util/nvramtool/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile index b92adda..09c3ed9 100644 --- a/util/nvramtool/Makefile +++ b/util/nvramtool/Makefile @@ -59,9 +59,9 @@ dep: @$(CC) -MM -MG *.c > .dependencies install: $(PROGRAM) - mkdir -p $(DESTDIR)$(PREFIX)/sbin + $(INSTALL) -d $(DESTDIR)$(PREFIX)/sbin + $(INSTALL) -d $(DESTDIR)$(PREFIX)/share/man/man8 $(INSTALL) $(PROGRAM) $(DESTDIR)$(PREFIX)/sbin - mkdir -p $(DESTDIR)$(PREFIX)/share/man/man8 $(INSTALL) -p -m644 cli/$(PROGRAM).8 $(DESTDIR)$(PREFIX)/share/man/man8 .PHONY: all clean distclean dep

1 0

Patch set updated for coreboot: cbmem: Makefile: Add install target
by Stefan Reinauer 11 Nov '15

11 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12404 -gerrit commit 1224cef5de1d49564fa646792ac36aed04a0fb61 Author: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Date: Wed Nov 11 05:40:11 2015 +0100 cbmem: Makefile: Add install target Change-Id: Ib20481e43e6ca5b56c630cdc0eb7b1b01311cbb6 Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> --- util/cbmem/Makefile | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/util/cbmem/Makefile b/util/cbmem/Makefile index 113c690..ef45bed 100644 --- a/util/cbmem/Makefile +++ b/util/cbmem/Makefile @@ -13,11 +13,13 @@ ## GNU General Public License for more details. ## -PROGRAM = cbmem -ROOT = ../../src -CC ?= $(CROSS_COMPILE)gcc -CFLAGS ?= -O2 -CFLAGS += -Wall -Werror +PROGRAM = cbmem +ROOT = ../../src +CC ?= $(CROSS_COMPILE)gcc +INSTALL ?= /usr/bin/install +PREFIX ?= /usr/local +CFLAGS ?= -O2 +CFLAGS += -Wall -Werror CPPFLAGS += -I $(ROOT)/commonlib/include OBJS = $(PROGRAM).o @@ -29,6 +31,10 @@ $(PROGRAM): $(OBJS) clean: rm -f $(PROGRAM) *.o *~ junit.xml +install: $(PROGRAM) + $(INSTALL) -d $(DESTDIR)$(PREFIX)/sbin/ + $(INSTALL) cbmem $(DESTDIR)$(PREFIX)/sbin/ + distclean: clean rm -f .dependencies

1 0

Patch set updated for coreboot: cbfstool: Makefile: Add install target
by Stefan Reinauer 11 Nov '15

11 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12403 -gerrit commit 92413637207a83849bf7fcbf6a0e89af8937ddad Author: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Date: Wed Nov 11 05:27:25 2015 +0100 cbfstool: Makefile: Add install target Change-Id: I5df7033e1e52c78e97cdbd26aef2d7824ea67f8b Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> --- util/cbfstool/Makefile | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/util/cbfstool/Makefile b/util/cbfstool/Makefile index 64db0b3..662a5a4 100644 --- a/util/cbfstool/Makefile +++ b/util/cbfstool/Makefile @@ -3,10 +3,14 @@ objutil ?= $(top)/util CONFIG_FMD_GENPARSER := y -HOSTCC ?= $(CC) +HOSTCC ?= $(CC) +INSTALL ?= /usr/bin/install +PREFIX ?= /usr/local -.PHONY: all -all: $(objutil)/cbfstool/cbfstool \ +all: cbfstool + +.PHONY: cbfstool +cbfstool: $(objutil)/cbfstool/cbfstool \ $(objutil)/cbfstool/fmaptool \ $(objutil)/cbfstool/rmodtool \ @@ -17,4 +21,11 @@ clean: $(RM) $(objutil)/cbfstool/fmaptool $(fmapobj) $(RM) $(objutil)/cbfstool/rmodtool $(rmodobj) +.PHONY: install +install: cbfstool + $(INSTALL) -d $(DESTDIR)$(PREFIX)/bin + $(INSTALL) cbfstool $(DESTDIR)$(PREFIX)/bin + $(INSTALL) fmaptool $(DESTDIR)$(PREFIX)/bin + $(INSTALL) rmodtool $(DESTDIR)$(PREFIX)/bin + include Makefile.inc

1 0

Patch merged into coreboot/master: southbridge/amd/sb700: Add option to disable SATA ALPM
by gerrit＠coreboot.org 11 Nov '15

11 Nov '15

the following patch was just integrated into master: commit 83b776137399bcfa9427e7a60d5f1620ee2d1985 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Thu Jun 18 11:48:02 2015 -0500 southbridge/amd/sb700: Add option to disable SATA ALPM The AMD Register Programming Reference states that the user should have the option to disable Active Link Power Management for two reasons. First, some drives may not function correctly with the ALPM implementation of the SP5100, and second there are some situations where low latency access is more important than the power savings created by using ALPM. Allow the user to disable ALPM if desired. Change-Id: I88055cbb4df4d7ba811cef7056c0a6ca2612fcb0 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/11993 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/11993 for details. -gerrit

1 0

Patch merged into coreboot/master: mainboard/asus/kgpe-d16: Add missing IRQ routing for PIKE card
by gerrit＠coreboot.org 11 Nov '15

11 Nov '15

the following patch was just integrated into master: commit f902722357d5b8a34585c38e9e5c870330f8ccbc Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Fri Jun 12 13:32:52 2015 -0500 mainboard/asus/kgpe-d16: Add missing IRQ routing for PIKE card Change-Id: I6eba36dad71a2a2713181382484dc0e0976e1dad Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/11988 Tested-by: build bot (Jenkins) Tested-by: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/11988 for details. -gerrit

1 0

Patch merged into coreboot/master: northbridge/amd/amdmct: Verify MCT NVRAM options before skipping training
by gerrit＠coreboot.org 11 Nov '15

11 Nov '15

the following patch was just integrated into master: commit f70946ff4d70d763ce75bf3876bc94dc708275b1 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Wed Jun 10 10:46:17 2015 -0500 northbridge/amd/amdmct: Verify MCT NVRAM options before skipping training Change-Id: If26e5d148a906d63bd1407b8ffa58f08ae6b4275 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/11986 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/11986 for details. -gerrit

1 0

New patch to review for coreboot: cbfstool: Allows mixed-state fmap regions to work
by Patrick Georgi 11 Nov '15

11 Nov '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12416 -gerrit commit a75172c094552e3f7fcaa4aabc463372743d28ea Author: Patrick Georgi <pgeorgi(a)google.com> Date: Wed Nov 11 15:35:24 2015 +0100 cbfstool: Allows mixed-state fmap regions to work When using FMAP regions (with option -r) that were generated with a master header (as done by cbfstool copy, eg. in Chrome OS' build system), there were differences in interpretation of the master header's fields. Normalize for that by not sanity-checking the master header's size field (there are enough other tests) and by dealing with region offsets properly. BUG=chromium:445938 BRANCH=tot TEST=`cbfstool /build/veyron_minnie/firmware/image.dev.bin print -r FW_MAIN_A` shows that region's directory (instead of claiming that there's no CBFS at all, or showing an empty directory). Change-Id: Ia840c823739d4ca144a7f861573d6d1b4113d799 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: 0e5364d291f45e4705e83c0331e128e35ab226d3 Original-Change-Id: Ie28edbf55ec56b7c78160000290ef3c57fda0f0e Original-Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Original-Reviewed-on: https://chromium-review.googlesource.com/312210 Original-Commit-Ready: Patrick Georgi <pgeorgi(a)chromium.org> Original-Tested-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> --- util/cbfstool/cbfs_image.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index f5ef680..2b25011 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -1168,12 +1168,11 @@ int cbfs_walk(struct cbfs_image *image, cbfs_entry_callback callback, return count; } -static int cbfs_header_valid(struct cbfs_header *header, size_t size) +static int cbfs_header_valid(struct cbfs_header *header) { if ((ntohl(header->magic) == CBFS_HEADER_MAGIC) && ((ntohl(header->version) == CBFS_HEADER_VERSION1) || (ntohl(header->version) == CBFS_HEADER_VERSION2)) && - (ntohl(header->romsize) <= size) && (ntohl(header->offset) < ntohl(header->romsize))) return 1; return 0; @@ -1190,7 +1189,7 @@ struct cbfs_header *cbfs_find_header(char *data, size_t size, if (forced_offset < (size - sizeof(struct cbfs_header))) { /* Check if the forced header is valid. */ header = (struct cbfs_header *)(data + forced_offset); - if (cbfs_header_valid(header, size)) + if (cbfs_header_valid(header)) return header; return NULL; } @@ -1202,7 +1201,7 @@ struct cbfs_header *cbfs_find_header(char *data, size_t size, (size_t)rel_offset, (size_t)-rel_offset, offset); if (offset >= size - sizeof(*header) || - !cbfs_header_valid((struct cbfs_header *)(data + offset), size)) { + !cbfs_header_valid((struct cbfs_header *)(data + offset))) { // Some use cases append non-CBFS data to the end of the ROM. DEBUG("relative offset seems wrong, scanning whole image...\n"); offset = 0; @@ -1210,7 +1209,7 @@ struct cbfs_header *cbfs_find_header(char *data, size_t size, for (; offset + sizeof(*header) < size; offset++) { header = (struct cbfs_header *)(data + offset); - if (!cbfs_header_valid(header, size)) + if (!cbfs_header_valid(header)) continue; if (!found++) result = header; @@ -1228,9 +1227,15 @@ struct cbfs_header *cbfs_find_header(char *data, size_t size, struct cbfs_file *cbfs_find_first_entry(struct cbfs_image *image) { assert(image); - return image->has_header ? (struct cbfs_file *)(image->buffer.data + - image->header.offset) : - (struct cbfs_file *)image->buffer.data; + if (image->has_header) + /* header.offset is relative to start of flash, not + * start of region, so use it with the full image. + */ + return (struct cbfs_file *) + (buffer_get_original_backing(&image->buffer) + + image->header.offset); + else + return (struct cbfs_file *)buffer_get(&image->buffer); } struct cbfs_file *cbfs_find_next_entry(struct cbfs_image *image,

1 0

New patch to review for coreboot: cbfstool: Add way to access entire backing data for a buffer
by Patrick Georgi 11 Nov '15

11 Nov '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12415 -gerrit commit 42f743c0b68a9eb3a2aee377ae1bbcffaa7a776c Author: Patrick Georgi <pgeorgi(a)google.com> Date: Wed Nov 11 18:43:11 2015 +0100 cbfstool: Add way to access entire backing data for a buffer This is required to handle certain relative-to-flash-start offsets. BUG=none BRANCH=tot TEST=none Change-Id: I8b30c7b532e330af5db4b8ed65b21774c6cbbd25 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: 596ba1aaa62aedb2b214ca55444e3068b9cb1044 Original-Change-Id: Idc9a5279f16951befec4d84aab35117988f7edb7 Original-Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Original-Reviewed-on: https://chromium-review.googlesource.com/312220 Original-Commit-Ready: Patrick Georgi <pgeorgi(a)chromium.org> Original-Tested-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> --- util/cbfstool/common.c | 2 +- util/cbfstool/common.h | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/util/cbfstool/common.c b/util/cbfstool/common.c index 44836ab..09a7449 100644 --- a/util/cbfstool/common.c +++ b/util/cbfstool/common.c @@ -115,7 +115,7 @@ void buffer_delete(struct buffer *buffer) buffer->name = NULL; } if (buffer->data) { - free(buffer->data - buffer->offset); + free(buffer_get_original_backing(buffer)); buffer->data = NULL; } buffer->offset = 0; diff --git a/util/cbfstool/common.h b/util/cbfstool/common.h index b61c2c0..561a17a 100644 --- a/util/cbfstool/common.h +++ b/util/cbfstool/common.h @@ -120,6 +120,14 @@ static inline bool buffer_check_magic(const struct buffer *b, const char *magic, memcmp(b->data, magic, magic_len) == 0; } +/* Returns the start of the underlying buffer, with the offset undone */ +static inline void *buffer_get_original_backing(const struct buffer *b) +{ + if (!b) + return NULL; + return b->data - b->offset; +} + /* Creates an empty memory buffer with given size. * Returns 0 on success, otherwise non-zero. */ int buffer_create(struct buffer *buffer, size_t size, const char *name);

1 0

New patch to review for coreboot: intel/kunimitsu: This patch enables wakeup from S0ix using headset button.
by Patrick Georgi 11 Nov '15

11 Nov '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12414 -gerrit commit 7279688977bd994ece9f55c4a3eb77831592f447 Author: Saurabh Satija <saurabh.satija(a)intel.com> Date: Mon Nov 2 16:15:51 2015 -0800 intel/kunimitsu: This patch enables wakeup from S0ix using headset button. Kernel needs to set Audio IRQ as wake capable. BUG=chrome-os-partner:47450 BRANCH=NONE TEST=System wakes up from S0ix by pressing headset buttons. Change-Id: I0f89d05b4c5449e5e3277dde938d941e4ad8cbea Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: 65bf434f7c7e1662211f9c8bf61eeb4f41bdc675 Original-Change-Id: I7b5b564023044b4458eb0976488018b3226f4c70 Original-Signed-off-by: Saurabh Satija <saurabh.satija(a)intel.com> Original-Reviewed-on: https://chromium-review.googlesource.com/311793 Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> --- src/mainboard/intel/kunimitsu/acpi/mainboard.asl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mainboard/intel/kunimitsu/acpi/mainboard.asl b/src/mainboard/intel/kunimitsu/acpi/mainboard.asl index a5a90c6..73d43bc 100644 --- a/src/mainboard/intel/kunimitsu/acpi/mainboard.asl +++ b/src/mainboard/intel/kunimitsu/acpi/mainboard.asl @@ -141,6 +141,7 @@ Scope (\_SB.PCI0.I2C4) Name (_HID, "10508825") Name (_DDN, "NAU88L25 Codec") Name (_UID, 1) + Name (_S0W, 4) Name (_DSD, Package () { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () {

1 0

New patch to review for coreboot: libpayload: udc/dwc2: Ignore setup packet in check for queue empty during shutdown
by Patrick Georgi 11 Nov '15

11 Nov '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12413 -gerrit commit cdf7573a7fdf77afe6dd696cc6cc9c113a8f16e2 Author: Furquan Shaikh <furquan(a)google.com> Date: Fri Nov 6 22:22:56 2015 -0800 libpayload: udc/dwc2: Ignore setup packet in check for queue empty during shutdown DWC2 UDC controller always requires an active packet to be present in EP0-OUT to ensure proper operation of control plane. Thus, during shutdown ignore EP0-OUT for queue empty check if only 1 packet is present. BUG=b:24676003 BRANCH=None TEST=Compiles successfully. "fastboot reboot-bootloader" reboots device without timeout in udc shutdown. Change-Id: Iafe46c80f58c4cd57f8d58f060d805b603506bbd Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: 4e7c27d849c0411aae58e60a24d8170a27ab8485 Original-Change-Id: Ifa493ce0e41964ee7ca8bb3a1f4bb8726fa11173 Original-Signed-off-by: Furquan Shaikh <furquan(a)google.com> Original-Reviewed-on: https://chromium-review.googlesource.com/311257 Original-Commit-Ready: Furquan Shaikh <furquan(a)chromium.org> Original-Tested-by: Furquan Shaikh <furquan(a)chromium.org> Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> --- payloads/libpayload/drivers/udc/dwc2.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/payloads/libpayload/drivers/udc/dwc2.c b/payloads/libpayload/drivers/udc/dwc2.c index dc9eb7c..cde3a76 100644 --- a/payloads/libpayload/drivers/udc/dwc2.c +++ b/payloads/libpayload/drivers/udc/dwc2.c @@ -704,9 +704,21 @@ static void dwc2_shutdown(struct usbdev_ctrl *this) is_empty = 1; this->poll(this); for (i = 0; i < 16; i++) - for (j = 0; j < 2; j++) + for (j = 0; j < 2; j++) { + /* + * EP0-OUT needs to always have an active packet + * for proper operation of control packet + * flow. Thus, ignore if only 1 packet is + * present in EP0-OUT. + */ + if ((i == 0) && (j == 0) && + SIMPLEQ_SINGLETON(&p->eps[0][0].job_queue, + queue)) + continue; + if (!SIMPLEQ_EMPTY(&p->eps[i][j].job_queue)) is_empty = 0; + } } if (timer_us(shutdown_timer_us) >= shutdown_timeout_us)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2015