coreboot-gerrit November 2015

coreboot-gerrit@coreboot.org

1 participants
1544 discussions

Patch merged into coreboot/master: Remove dependency for HAS_PRECBMEM_TIMESTAMP_REGION
by gerrit＠coreboot.org 18 Nov '15

18 Nov '15

the following patch was just integrated into master: commit 355dfda3f010ca57195ca47d02b346586e946cc3 Author: Martin Roth <martinroth(a)google.com> Date: Mon Aug 24 16:42:31 2015 -0600 Remove dependency for HAS_PRECBMEM_TIMESTAMP_REGION HAS_PRECBMEM_TIMESTAMP_REGION was dependent on COLLECT_TIMESTAMPS, but should be allowed to be selected independently. My thought is that the code may only be used when collecting timestamps, the HAS prefix signifies that this is a platform configuration option. This fix could also be done by adding 'if COLLECT_TIMESTAMPS' everywhere that 'select HAS_PRECBMEM_TIMESTAMP_REGION' is used Change-Id: Iaf4895475c38a855a048dc9b82d4c97e5e3f4e5c Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: http://review.coreboot.org/11338 Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See http://review.coreboot.org/11338 for details. -gerrit

1 0

New patch to review for coreboot: google/lars & intel/kunimitsu: Fix Kconfig warnings
by Martin Roth 18 Nov '15

18 Nov '15

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12460 -gerrit commit 89da4f30f108ec2c46be3813a413ff1a14d44089 Author: Martin Roth <martinroth(a)google.com> Date: Wed Nov 18 15:19:07 2015 -0700 google/lars & intel/kunimitsu: Fix Kconfig warnings EC_SOFTWARE_SYNC depends on CHROMEOS, so move it into the CHROMEOS section. This fixes the kconfig warning: warning: (CHROMEOS && BOARD_SPECIFIC_OPTIONS ...) selects EC_SOFTWARE_SYNC which has unmet direct dependencies (MAINBOARD_HAS_CHROMEOS && CHROMEOS && VBOOT_VERIFY_FIRMWARE) Change-Id: I459f48fd18c7568c4584df7d4aefa69dec3e4907 Signed-off-by: Martin Roth <martinroth(a)google.com> --- src/mainboard/google/lars/Kconfig | 2 +- src/mainboard/intel/kunimitsu/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/lars/Kconfig b/src/mainboard/google/lars/Kconfig index 4a1bce9..70e6726 100644 --- a/src/mainboard/google/lars/Kconfig +++ b/src/mainboard/google/lars/Kconfig @@ -9,7 +9,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select EC_GOOGLE_CHROMEEC_LPC select EC_GOOGLE_CHROMEEC_MEC select EC_GOOGLE_CHROMEEC_PD - select EC_SOFTWARE_SYNC select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE @@ -25,6 +24,7 @@ config CHROMEOS select LID_SWITCH select VBOOT_OPROM_MATTERS select VIRTUAL_DEV_SWITCH + select EC_SOFTWARE_SYNC config IRQ_SLOT_COUNT int diff --git a/src/mainboard/intel/kunimitsu/Kconfig b/src/mainboard/intel/kunimitsu/Kconfig index 4132e86..5a5b3cd 100644 --- a/src/mainboard/intel/kunimitsu/Kconfig +++ b/src/mainboard/intel/kunimitsu/Kconfig @@ -9,7 +9,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select EC_GOOGLE_CHROMEEC_LPC select EC_GOOGLE_CHROMEEC_MEC select EC_GOOGLE_CHROMEEC_PD - select EC_SOFTWARE_SYNC select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE @@ -25,6 +24,7 @@ config CHROMEOS select LID_SWITCH select VBOOT_OPROM_MATTERS select VIRTUAL_DEV_SWITCH + select EC_SOFTWARE_SYNC config IRQ_SLOT_COUNT int

1 0

Patch merged into coreboot/master: Kconfig: fix typo in description of the TRACE option
by gerrit＠coreboot.org 18 Nov '15

18 Nov '15

the following patch was just integrated into master: commit 8420ad4b41c52d38acd56e4bfe447ce0f0a1721e Author: Ben Gardner <gardner.ben(a)gmail.com> Date: Wed Nov 18 10:46:53 2015 -0600 Kconfig: fix typo in description of the TRACE option Change-Id: Icec6d047530e64228a3e71a636af4266ed5a73f0 Signed-off-by: Ben Gardner <gardner.ben(a)gmail.com> Reviewed-on: http://review.coreboot.org/12457 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See http://review.coreboot.org/12457 for details. -gerrit

1 0

Patch merged into coreboot/master: fsp1_0: Update rangeley to revision POSTGOLD4
by gerrit＠coreboot.org 18 Nov '15

18 Nov '15

the following patch was just integrated into master: commit 68b79cdda4b1cadd9dde09918753e871a868fc27 Author: Marcin Wojciechowski <marcin.wojciechowski(a)intel.com> Date: Thu Nov 12 16:05:42 2015 +0100 fsp1_0: Update rangeley to revision POSTGOLD4 Alignment of Intel Firmware Support Package 1.0 Rangeley header and source files to the revision: POSTGOLD4 Detail changelog can be found at http://www.intel.com/fsp FSP release date September 24, 2015 Change-Id: If1a6f95aed3e9a60af9af8cf9cd466a560ef0fe2 Signed-off-by: Marcin Wojciechowski <marcin.wojciechowski(a)intel.com> Reviewed-on: http://review.coreboot.org/12418 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See http://review.coreboot.org/12418 for details. -gerrit

1 0

New patch to review for coreboot: cbmem: fix fault on console overflow
by Ben Gardner 18 Nov '15

18 Nov '15

Ben Gardner (gardner.ben(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12459 -gerrit commit bc4cd8582946f8469db8ac3d4e7f2b4369142922 Author: Ben Gardner <gardner.ben(a)gmail.com> Date: Wed Nov 18 14:37:45 2015 -0600 cbmem: fix fault on console overflow In dump_console(), if cursor > size the following will fault, as only size + 1 bytes were allocated: console_c[cursor] = 0; That line is not needed, since size <= console and this line is present: console_c[size] = 0; Change-Id: If1c9a6fe0d926c767e2aff947254f22b2758c234 Signed-off-by: Ben Gardner <gardner.ben(a)gmail.com> --- util/cbmem/cbmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c index 3c7f49b..3df571e 100644 --- a/util/cbmem/cbmem.c +++ b/util/cbmem/cbmem.c @@ -696,7 +696,6 @@ static void dump_console(void) size + sizeof(size) + sizeof(cursor), 1); memcpy(console_c, console_p + 8, size); console_c[size] = 0; - console_c[cursor] = 0; printf("%s\n", console_c); if (size < cursor)

1 0

New patch to review for coreboot: Makefiles: Add / Update help for makefile targets
by Martin Roth 18 Nov '15

18 Nov '15

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12458 -gerrit commit 5337c852b1138a39bc5760730f39eac81b7110ed Author: Martin Roth <martinroth(a)google.com> Date: Wed Nov 18 13:09:23 2015 -0700 Makefiles: Add / Update help for makefile targets Currently running 'make help' just gives help for the kconfig targets. This adds help for common coreboot and toolchain targets. It stops printing some of the less common kconfig targets, but still leaves them in the makefile as documentation. Change-Id: I2a00fcbc06f05dc4029a91f3dff830c19e4d1329 Signed-off-by: Martin Roth <martinroth(a)google.com> --- Makefile | 15 +++++++++++++++ Makefile.inc | 11 +++++++++++ util/kconfig/Makefile | 16 +++++++++------- 3 files changed, 35 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 107f3c8..00e0349 100644 --- a/Makefile +++ b/Makefile @@ -91,6 +91,21 @@ DOXYGEN_OUTPUT_DIR := doxygen all: real-all +help:: + @echo '*** coreboot platform ***' + @echo ' Use "make [target] V=1" for extra build debug information' + @echo ' all - Build coreboot' + @echo ' clean - Remove coreboot build artifacts' + @echo ' distclean - Remove build artifacts and config files' + @echo ' doxygen - Build doxygen documentation for coreboot' + @echo ' what-jenkins-does - Run platform build tests (Use CPUS=# for more cores)' + @echo ' printall - print makefile info for debugging' + @echo ' lint / lint-stable - run coreboot lint tools (all / minimal)' + @echo ' gitconfig - set up git to subnit patches to coreboot' + @echo ' ctags / ctags-project - make ctags file for all of coreboot or current board' + @echo ' cscope / cscope-project - make cscope.out file for coreboot or current board' + @echo + # This include must come _before_ the pattern rules below! # Order _does_ matter for pattern rules. include $(srck)/Makefile diff --git a/Makefile.inc b/Makefile.inc index b85a2cb..0f1e367 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -442,6 +442,17 @@ gitconfig: git config remote.origin.push HEAD:refs/for/master (git config --global user.name >/dev/null && git config --global user.email >/dev/null) || (printf 'Please configure your name and email in git:\n\n git config --global user.name "Your Name Comes Here"\n git config --global user.email your.email(a)example.com\n'; exit 1) +help:: + @echo '*** Toolchain ***' + @echo ' crossgcc - Build coreboot cross-compilers for all platforms' + @echo ' crosstools - Build coreboot cross-compiler and GDB for all platforms' + @echo ' crossgcc-clean - Remove all built coreboot cross-compilers' + @echo ' crossgcc-ARCH - Build cross-compiler for specific architecture' + @echo ' crosstools-ARCH - Build cross-compiler with GDB for specific architecture' + @echo ' ARCH can be "i386", "x64", "arm", "aarch64", "mips", or "riscv"' + @echo ' Use "make [target] CPUS=#" to build toolchain using multiple cores' + @echo + crossgcc: crossgcc-i386 crossgcc-x64 crossgcc-arm crossgcc-aarch64 crossgcc-mips crossgcc-riscv .PHONY: crossgcc-i386 crossgcc-x64 crossgcc-arm crossgcc-aarch64 crossgcc-mips crossgcc-riscv diff --git a/util/kconfig/Makefile b/util/kconfig/Makefile index 243f763..a468125 100644 --- a/util/kconfig/Makefile +++ b/util/kconfig/Makefile @@ -104,22 +104,24 @@ olddefconfig: $(objk)/conf $< --defconfig=configs/$@ $(Kconfig) # Help text used by make help -help: +help:: + @echo '*** Kconfig Help ***' @echo ' config - Update current config utilising a line-oriented program' @echo ' nconfig - Update current config utilising a ncurses menu based program' @echo ' menuconfig - Update current config utilising a menu based program' @echo ' xconfig - Update current config utilising a QT based front-end' @echo ' gconfig - Update current config utilising a GTK based front-end' @echo ' oldconfig - Update current config utilising a provided .config as base' - @echo ' localmodconfig - Update current config disabling modules not loaded' - @echo ' localyesconfig - Update current config converting local mods to core' + #@echo ' localmodconfig - Update current config disabling modules not loaded' + #@echo ' localyesconfig - Update current config converting local mods to core' @echo ' silentoldconfig - Same as oldconfig, but quietly, additionally update deps' @echo ' defconfig - New config with default answer to all options' @echo ' savedefconfig - Save current config as ./defconfig (minimal config)' - @echo ' allnoconfig - New config where all options are answered with no' - @echo ' allyesconfig - New config where all options are accepted with yes' - @echo ' allmodconfig - New config selecting modules when possible' - @echo ' randconfig - New config with random answer to all options' + #@echo ' allnoconfig - New config where all options are answered with no' + #@echo ' allyesconfig - New config where all options are accepted with yes' + #@echo ' allmodconfig - New config selecting modules when possible' + #@echo ' randconfig - New config with random answer to all options' + @echo # lxdialog stuff check-lxdialog := $(srck)/lxdialog/check-lxdialog.sh

1 0

New patch to review for coreboot: Kconfig: fix typo in description of the TRACE option
by Ben Gardner 18 Nov '15

18 Nov '15

Ben Gardner (gardner.ben(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12457 -gerrit commit 9471ca3cfa4498b6ab84f854ed37f208985ee13c Author: Ben Gardner <gardner.ben(a)gmail.com> Date: Wed Nov 18 10:46:53 2015 -0600 Kconfig: fix typo in description of the TRACE option Change-Id: Icec6d047530e64228a3e71a636af4266ed5a73f0 Signed-off-by: Ben Gardner <gardner.ben(a)gmail.com> --- src/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Kconfig b/src/Kconfig index 98d553a..2417faa 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1046,7 +1046,7 @@ config TRACE If enabled, every function will print information to console once the function is entered. The syntax is ~0xaaaabbbb(0xccccdddd) the 0xaaaabbbb is the actual function and 0xccccdddd is EIP - of calling function. Please note some printk releated functions + of calling function. Please note some printk related functions are omitted from trace to have good looking console dumps. config DEBUG_COVERAGE

1 0

Patch merged into coreboot/master: cpu/amd/fam10h-fam15h: Update Fam15h APIC config and startup sequence
by gerrit＠coreboot.org 18 Nov '15

18 Nov '15

the following patch was just integrated into master: commit 0122afb6093849102caa9662ac14380a41cfb094 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Thu Jul 30 14:07:15 2015 -0500 cpu/amd/fam10h-fam15h: Update Fam15h APIC config and startup sequence This fixes Family 15h multiple package support; the previous code hung in CAR setup and romstage when more than one CPU package was installed for a variety of loosely related reasons. TEST: Booted ASUS KGPE-D16 with two Opteron 6328 processors and several different RDIMM configurations. Change-Id: I171197c90f72d3496a385465937b7666cbf7e308 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/12020 Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See http://review.coreboot.org/12020 for details. -gerrit

1 0

Patch merged into coreboot/master: AMD/Bettong: add FCH's GPIO, UART & I2C support
by gerrit＠coreboot.org 18 Nov '15

18 Nov '15

the following patch was just integrated into master: commit 631c8a269006bb8f02860606d35f8d6590954f5e Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Wed Nov 18 22:52:37 2015 +0800 AMD/Bettong: add FCH's GPIO, UART & I2C support Merlin Falcon's FCH has GPIO, UART and I2C. All of them are controlled by registers mapped at MMIO space. This ASL code is used for Windows drivers. TEST: 1. Boot Windows 8 or Windows 10. 2. Install AMD Catalyst driver. 3. AMD FPIO, UART and I2C can be found in device manager. 4. I2C passed Multi Interface Test Tool (MITT) test. Change-Id: I7ffe3fe0046d9a078cc38176c29a8e334646a5a3 Signed-off-by: WANG Siyuan <wangsiyuanbuaa(a)gmail.com> Signed-off-by: WANG Siyuan <SiYuan.Wang(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> Reviewed-on: http://review.coreboot.org/11750 Reviewed-by: Martin Roth <martinroth(a)google.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/11750 for details. -gerrit

1 0

Patch merged into coreboot/master: google/chell: Set USB current limit to 2A
by gerrit＠coreboot.org 18 Nov '15

18 Nov '15

the following patch was just integrated into master: commit 4aca1477cbad0dd0511d974baa57a540b3cfc373 Author: Duncan Laurie <dlaurie(a)chromium.org> Date: Thu Nov 12 08:33:37 2015 -0800 google/chell: Set USB current limit to 2A The GPIO for USBA_1_ILIM_SEL_L should be low to enable 2A charging from the Type-A port. BUG=chrome-os-partner:47172 BRANCH=none TEST=emerge-glados coreboot Change-Id: I1bbcdd467684e7c1372c8ca862d498fb6cbb966c Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: c8a8fbed6d0fd7aea0a41db2bde104fe7a05cabe Original-Change-Id: I3b18cbb204cfa19e50f34ea9533018e286342513 Original-Signed-off-by: Duncan Laurie <dlaurie(a)chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/312451 Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/12447 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See http://review.coreboot.org/12447 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2015