coreboot-gerrit November 2015

coreboot-gerrit@coreboot.org

1 participants
1544 discussions

Patch set updated for coreboot: Enable KCONFIG_STRICT mode
by Martin Roth 20 Nov '15

20 Nov '15

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10978 -gerrit commit b2a1840c3ab17b3fad931f3f475ee8ac74ed500c Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Jul 17 17:29:19 2015 -0700 Enable KCONFIG_STRICT mode Change-Id: I6aa77db1b12a67472302ea39d7433993a6838af6 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 107f3c8..dc4f191 100644 --- a/Makefile +++ b/Makefile @@ -55,6 +55,7 @@ export KCONFIG_DEPENDENCIES := $(obj)/auto.conf.cmd export KCONFIG_SPLITCONFIG := $(obj)/config export KCONFIG_TRISTATE := $(obj)/tristate.conf export KCONFIG_NEGATIVES := 1 +export KCONFIG_STRICT := 1 # directory containing the toplevel Makefile.inc TOPLEVEL := .

1 0

Patch set updated for coreboot: chromeos: Fix Kconfig TPM warnings on systems with no LPC TPM
by Martin Roth 20 Nov '15

20 Nov '15

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12497 -gerrit commit d9eb00ef9b77e7cdef371b78a7e024c3c8551b80 Author: Martin Roth <martinroth(a)google.com> Date: Thu Nov 19 18:24:30 2015 -0700 chromeos: Fix Kconfig TPM warnings on systems with no LPC TPM Put dependecies on CHROMEOS's selection of the Kconfig symbols TPM_INIT_FAILURE_IS_FATAL and SKIP_TPM_STARTUP_ON_NORMAL_BOOT to match the dependencies on those symbols where they are defined in src/drivers/pc80/tpm/Kconfig The file that uses these only gets built in if CONFIG_LPC_TPM is selected selected. The warnings were: warning: (CHROMEOS) selects TPM_INIT_FAILURE_IS_FATAL which has unmet direct dependencies (PC80_SYSTEM && LPC_TPM) warning: (CHROMEOS) selects SKIP_TPM_STARTUP_ON_NORMAL_BOOT which has unmet direct dependencies (PC80_SYSTEM && LPC_TPM) Change-Id: I7af00c79050bf511758bf29e3d57f6ff34d2a296 Signed-off-by: Martin Roth <martinroth(a)google.com> --- src/vendorcode/google/chromeos/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vendorcode/google/chromeos/Kconfig b/src/vendorcode/google/chromeos/Kconfig index 02bb227..4d05b3e 100644 --- a/src/vendorcode/google/chromeos/Kconfig +++ b/src/vendorcode/google/chromeos/Kconfig @@ -22,8 +22,8 @@ config CHROMEOS bool "Build for ChromeOS" default n select TPM - select TPM_INIT_FAILURE_IS_FATAL - select SKIP_TPM_STARTUP_ON_NORMAL_BOOT + select TPM_INIT_FAILURE_IS_FATAL if PC80_SYSTEM && LPC_TPM + select SKIP_TPM_STARTUP_ON_NORMAL_BOOT if PC80_SYSTEM && LPC_TPM select BOOTMODE_STRAPS select ELOG select COLLECT_TIMESTAMPS

1 0

New patch to review for coreboot: chromeos: Fix Kconfig TPM warnings on systems with no LPC TPM
by Martin Roth 20 Nov '15

20 Nov '15

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12497 -gerrit commit b8a7d2e055ff46920c39adef9d65476431f28b23 Author: Martin Roth <martinroth(a)google.com> Date: Thu Nov 19 18:24:30 2015 -0700 chromeos: Fix Kconfig TPM warnings on systems with no LPC TPM Put dependecies on CHROMEOS's selection of the Kconfig symbols TPM_INIT_FAILURE_IS_FATAL and SKIP_TPM_STARTUP_ON_NORMAL_BOOT to match the dependencies on those symbols where they are defined in src/drivers/pc80/tpm/Kconfig The file that uses these only gets built in if CONFIG_LPC_TPM is selected selected. The warnings were: warning: (CHROMEOS) selects TPM_INIT_FAILURE_IS_FATAL which has unmet direct dependencies (PC80_SYSTEM && LPC_TPM) warning: (CHROMEOS) selects SKIP_TPM_STARTUP_ON_NORMAL_BOOT which has unmet direct dependencies (PC80_SYSTEM && LPC_TPM) Change-Id: I7af00c79050bf511758bf29e3d57f6ff34d2a296 Signed-off-by: Martin Roth <martinroth(a)google.com> --- src/vendorcode/google/chromeos/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vendorcode/google/chromeos/Kconfig b/src/vendorcode/google/chromeos/Kconfig index 02bb227..4d05b3e 100644 --- a/src/vendorcode/google/chromeos/Kconfig +++ b/src/vendorcode/google/chromeos/Kconfig @@ -22,8 +22,8 @@ config CHROMEOS bool "Build for ChromeOS" default n select TPM - select TPM_INIT_FAILURE_IS_FATAL - select SKIP_TPM_STARTUP_ON_NORMAL_BOOT + select TPM_INIT_FAILURE_IS_FATAL if PC80_SYSTEM && LPC_TPM + select SKIP_TPM_STARTUP_ON_NORMAL_BOOT if PC80_SYSTEM && LPC_TPM select BOOTMODE_STRAPS select ELOG select COLLECT_TIMESTAMPS

1 0

New patch to review for coreboot: Add rules.h to FSP include util.h
by Stefan Reinauer 20 Nov '15

20 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12495 -gerrit commit a8d43350a741f42d90bddf3d5c3448115a0f38fe Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Thu Nov 19 17:12:30 2015 -0800 Add rules.h to FSP include util.h util.h uses ENV_* and hence needs to have rules.h This is required for successful compilation of strago. Change-Id: I0df35e90e2010aac43ef0a4d900f20c842d3bcb5 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- src/drivers/intel/fsp1_1/include/fsp/util.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/drivers/intel/fsp1_1/include/fsp/util.h b/src/drivers/intel/fsp1_1/include/fsp/util.h index 49a7798..5595e73 100644 --- a/src/drivers/intel/fsp1_1/include/fsp/util.h +++ b/src/drivers/intel/fsp1_1/include/fsp/util.h @@ -17,6 +17,7 @@ #ifndef FSP1_1_UTIL_H #define FSP1_1_UTIL_H +#include <rules.h> #include <fsp/api.h> /* Current users expect to get the SoC's FSP definitions by including util.h. */ #include <fsp/soc_binding.h>

1 0

Patch set updated for coreboot: Drop abuild.disabled files for Braswell / Skylake boards
by Stefan Reinauer 20 Nov '15

20 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12463 -gerrit commit 7fb286a3ee5118c26b4339b5ef2fcc732a73ef70 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Wed Nov 18 15:21:34 2015 -0800 Drop abuild.disabled files for Braswell / Skylake boards Make sure the latest & greatest Intel targets actually build in our build system. Change-Id: I479ad473c260fc914d224cb58f4be1837aff2502 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- src/mainboard/google/chell/abuild.disabled | 2 -- src/mainboard/google/cyan/abuild.disabled | 2 -- src/mainboard/google/glados/abuild.disabled | 2 -- src/mainboard/google/lars/abuild.disabled | 2 -- src/mainboard/intel/kunimitsu/abuild.disabled | 2 -- src/mainboard/intel/sklrvp/abuild.disabled | 2 -- src/mainboard/intel/strago/abuild.disabled | 2 -- 7 files changed, 14 deletions(-) diff --git a/src/mainboard/google/chell/abuild.disabled b/src/mainboard/google/chell/abuild.disabled deleted file mode 100644 index 7d1725a..0000000 --- a/src/mainboard/google/chell/abuild.disabled +++ /dev/null @@ -1,2 +0,0 @@ -Successful builds for this board require the Skylake FSP binary and header files -along with the Skylake microcode files from Intel. diff --git a/src/mainboard/google/cyan/abuild.disabled b/src/mainboard/google/cyan/abuild.disabled deleted file mode 100644 index 025ebea..0000000 --- a/src/mainboard/google/cyan/abuild.disabled +++ /dev/null @@ -1,2 +0,0 @@ -Successful builds for this board require the Braswell FSP binary and header -files along with the Braswell microcode files from Intel. diff --git a/src/mainboard/google/glados/abuild.disabled b/src/mainboard/google/glados/abuild.disabled deleted file mode 100644 index 7d1725a..0000000 --- a/src/mainboard/google/glados/abuild.disabled +++ /dev/null @@ -1,2 +0,0 @@ -Successful builds for this board require the Skylake FSP binary and header files -along with the Skylake microcode files from Intel. diff --git a/src/mainboard/google/lars/abuild.disabled b/src/mainboard/google/lars/abuild.disabled deleted file mode 100644 index 7d1725a..0000000 --- a/src/mainboard/google/lars/abuild.disabled +++ /dev/null @@ -1,2 +0,0 @@ -Successful builds for this board require the Skylake FSP binary and header files -along with the Skylake microcode files from Intel. diff --git a/src/mainboard/intel/kunimitsu/abuild.disabled b/src/mainboard/intel/kunimitsu/abuild.disabled deleted file mode 100644 index 7d1725a..0000000 --- a/src/mainboard/intel/kunimitsu/abuild.disabled +++ /dev/null @@ -1,2 +0,0 @@ -Successful builds for this board require the Skylake FSP binary and header files -along with the Skylake microcode files from Intel. diff --git a/src/mainboard/intel/sklrvp/abuild.disabled b/src/mainboard/intel/sklrvp/abuild.disabled deleted file mode 100644 index 7d1725a..0000000 --- a/src/mainboard/intel/sklrvp/abuild.disabled +++ /dev/null @@ -1,2 +0,0 @@ -Successful builds for this board require the Skylake FSP binary and header files -along with the Skylake microcode files from Intel. diff --git a/src/mainboard/intel/strago/abuild.disabled b/src/mainboard/intel/strago/abuild.disabled deleted file mode 100644 index 025ebea..0000000 --- a/src/mainboard/intel/strago/abuild.disabled +++ /dev/null @@ -1,2 +0,0 @@ -Successful builds for this board require the Braswell FSP binary and header -files along with the Braswell microcode files from Intel.

1 0

Patch set updated for coreboot: Enable KCONFIG_STRICT mode
by Martin Roth 19 Nov '15

19 Nov '15

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10978 -gerrit commit 5dced06cabb67207c634170ba9df624c025225f3 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Jul 17 17:29:19 2015 -0700 Enable KCONFIG_STRICT mode Change-Id: I6aa77db1b12a67472302ea39d7433993a6838af6 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 107f3c8..dc4f191 100644 --- a/Makefile +++ b/Makefile @@ -55,6 +55,7 @@ export KCONFIG_DEPENDENCIES := $(obj)/auto.conf.cmd export KCONFIG_SPLITCONFIG := $(obj)/config export KCONFIG_TRISTATE := $(obj)/tristate.conf export KCONFIG_NEGATIVES := 1 +export KCONFIG_STRICT := 1 # directory containing the toplevel Makefile.inc TOPLEVEL := .

1 0

New patch to review for coreboot: x86emu: Remove XFree86 CVS tags
by Stefan Reinauer 19 Nov '15

19 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12494 -gerrit commit d3bc792ddc7466f74d5a44f39963f1d7cbbaeb96 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Thu Nov 19 15:32:17 2015 -0800 x86emu: Remove XFree86 CVS tags They're not supported by git. Change-Id: I8157cdc0f5f4072af588772680741b72d21a9223 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- src/device/oprom/include/x86emu/regs.h | 1 - src/device/oprom/include/x86emu/x86emu.h | 1 - src/device/oprom/x86emu/debug.h | 1 - src/device/oprom/x86emu/prim_asm.h | 1 - src/device/oprom/x86emu/sys.c | 1 - src/device/oprom/x86emu/x86emui.h | 2 -- 6 files changed, 7 deletions(-) diff --git a/src/device/oprom/include/x86emu/regs.h b/src/device/oprom/include/x86emu/regs.h index 4bf1294..2fee548 100644 --- a/src/device/oprom/include/x86emu/regs.h +++ b/src/device/oprom/include/x86emu/regs.h @@ -35,7 +35,6 @@ * Description: Header file for x86 register definitions. * ****************************************************************************/ -/* $XFree86: xc/extras/x86emu/include/x86emu/regs.h,v 1.3 2001/10/28 03:32:25 tsi Exp $ */ #ifndef __X86EMU_REGS_H #define __X86EMU_REGS_H diff --git a/src/device/oprom/include/x86emu/x86emu.h b/src/device/oprom/include/x86emu/x86emu.h index b912bd2..bdc861f 100644 --- a/src/device/oprom/include/x86emu/x86emu.h +++ b/src/device/oprom/include/x86emu/x86emu.h @@ -37,7 +37,6 @@ * include this header * ****************************************************************************/ -/* $XFree86: xc/extras/x86emu/include/x86emu.h,v 1.2 2000/11/21 23:10:25 tsi Exp $ */ #ifndef __X86EMU_X86EMU_H #define __X86EMU_X86EMU_H diff --git a/src/device/oprom/x86emu/debug.h b/src/device/oprom/x86emu/debug.h index 186c161..f89d5ab 100644 --- a/src/device/oprom/x86emu/debug.h +++ b/src/device/oprom/x86emu/debug.h @@ -35,7 +35,6 @@ * Description: Header file for debug definitions. * ****************************************************************************/ -/* $XFree86: xc/extras/x86emu/src/x86emu/x86emu/debug.h,v 1.4 2000/11/21 23:10:27 tsi Exp $ */ #ifndef __X86EMU_DEBUG_H #define __X86EMU_DEBUG_H diff --git a/src/device/oprom/x86emu/prim_asm.h b/src/device/oprom/x86emu/prim_asm.h index 4fa8d55..e023cf8 100644 --- a/src/device/oprom/x86emu/prim_asm.h +++ b/src/device/oprom/x86emu/prim_asm.h @@ -39,7 +39,6 @@ * platform. * ****************************************************************************/ -/* $XFree86: xc/extras/x86emu/src/x86emu/x86emu/prim_asm.h,v 1.3 2000/04/19 15:48:15 tsi Exp $ */ #ifndef __X86EMU_PRIM_ASM_H #define __X86EMU_PRIM_ASM_H diff --git a/src/device/oprom/x86emu/sys.c b/src/device/oprom/x86emu/sys.c index 9785a9d..e550c45 100644 --- a/src/device/oprom/x86emu/sys.c +++ b/src/device/oprom/x86emu/sys.c @@ -39,7 +39,6 @@ * user library. * ****************************************************************************/ -/* $XFree86: xc/extras/x86emu/src/x86emu/sys.c,v 1.5 2000/08/23 22:10:01 tsi Exp $ */ #include <arch/io.h> #include <x86emu/x86emu.h> diff --git a/src/device/oprom/x86emu/x86emui.h b/src/device/oprom/x86emu/x86emui.h index fb6f8ca..741153c 100644 --- a/src/device/oprom/x86emu/x86emui.h +++ b/src/device/oprom/x86emu/x86emui.h @@ -38,8 +38,6 @@ * ****************************************************************************/ -/* $XFree86: xc/extras/x86emu/src/x86emu/x86emu/x86emui.h,v 1.4 2001/04/01 13:59:58 tsi Exp $ */ - #ifndef __X86EMU_X86EMUI_H #define __X86EMU_X86EMUI_H

1 0

New patch to review for coreboot: x86emu: Undefine _NO_INLINE
by Stefan Reinauer 19 Nov '15

19 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12493 -gerrit commit b2c7be061b8566a17571cc721b3b7c7c767b5c6c Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Thu Nov 19 15:02:21 2015 -0800 x86emu: Undefine _NO_INLINE Never defined by the server. Change-Id: If22727cf3953c2931d107146fb99b5997f8a13d5 Original-Reviewed-by: Eric Anholt <eric(a)anholt.net> Original-Signed-off-by: Adam Jackson <ajax(a)redhat.com> Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- src/device/oprom/x86emu/x86emui.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/device/oprom/x86emu/x86emui.h b/src/device/oprom/x86emu/x86emui.h index 37339d5..fb6f8ca 100644 --- a/src/device/oprom/x86emu/x86emui.h +++ b/src/device/oprom/x86emu/x86emui.h @@ -48,7 +48,7 @@ * dramatically in this case). */ -#if defined(__cplusplus) && !defined(_NO_INLINE) +#if defined(__cplusplus) #define _INLINE inline #else #define _INLINE static

1 0

New patch to review for coreboot: x86emu: Fix some set-but-not-used warnings.
by Stefan Reinauer 19 Nov '15

19 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12492 -gerrit commit caa0b7631231ed888bff6283501994b86ca32392 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Thu Nov 19 14:45:39 2015 -0800 x86emu: Fix some set-but-not-used warnings. Change-Id: Ide861733d721a21b77862076bf7ad70c7ee6a472 Original-Reviewed-by: Adam Jackson <ajax(a)redhat.com> Original-Signed-off-by: Eric Anholt <eric(a)anholt.net> Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- src/device/oprom/x86emu/debug.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/device/oprom/x86emu/debug.c b/src/device/oprom/x86emu/debug.c index e7a111b..bc249a9 100644 --- a/src/device/oprom/x86emu/debug.c +++ b/src/device/oprom/x86emu/debug.c @@ -211,9 +211,7 @@ void X86EMU_dump_memory (u16 seg, u16 off, u32 amt) u32 start = off & 0xfffffff0; u32 end = (off+16) & 0xfffffff0; u32 i; - u32 current; - current = start; while (end <= off + amt) { printf("%04x:%04x ", seg, start); for (i=start; i< off; i++) @@ -239,8 +237,6 @@ void x86emu_single_step (void) static int breakpoint; static int noDecode = 1; - char *p; - if (DEBUG_BREAK()) { if (M.x86.saved_ip != breakpoint) { return; @@ -256,7 +252,7 @@ void x86emu_single_step (void) offset = M.x86.saved_ip; while (!done) { printf("-"); - p = fgets(s, 1023, stdin); + (void)fgets(s, 1023, stdin); cmd = parse_line(s, ps, &ntok); switch(cmd) { case 'u':

1 0

Patch merged into coreboot/master: google/veyron_danger & veyron_emile: Fix Kconfig warnings
by gerrit＠coreboot.org 19 Nov '15

19 Nov '15

the following patch was just integrated into master: commit f730e44baaf061e2ab8ea4e21b5b0d60bc681dc3 Author: Martin Roth <martinroth(a)google.com> Date: Wed Nov 18 16:13:12 2015 -0700 google/veyron_danger & veyron_emile: Fix Kconfig warnings These platforms needed to be adjusted to fix various Kconfig warnings. Both platforms needed MAINBOARD_HAS_NATIVE_VGA_INIT because they're setting MAINBOARD_DO_NATIVE_VGA_INIT. veyron_emile needed a few symbols that depend on CHROMEOS to be moved into a new config CHROMEOS section. This matches the other CHROMEOS platforms. veyron_danger needed to select MAINBOARD_HAS_CHROMEOS before the CHROMEOS symbol was set. Change-Id: I8c7f594ba572a02513a68095c16314006fb4e379 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: http://review.coreboot.org/12462 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) See http://review.coreboot.org/12462 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2015