the following patch was just integrated into master:
commit 1bb4083859b848b9ffe98ca9fdfbd10adcf482dd
Author: zbao <fishbaozi(a)gmail.com>
Date: Thu Nov 5 15:33:33 2015 +0800
Makefile: Set HOSTCC as gcc or cc respectively
The HOSTCC should be set in .xcompile, which tests the existence of gcc
and cc. But the .xcompile has to be included after kconfig/Makefile. So
building util/kconfig uses the seperated HOSTCC definition above it,
instead of the one in .xcompile.
For the system which clang is the default host compiler, gcc is not
installed by default. In that case, we need to set HOSTCC as cc.
Change-Id: I1e51a37c4426e2c97d36a31f26a18ab4b0d0608d
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
Reviewed-on: http://review.coreboot.org/12331
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See http://review.coreboot.org/12331 for details.
-gerrit
the following patch was just integrated into master:
commit 669807682ed4fe2d01295bf99fe63c4c097ebc6f
Author: zbao <fishbaozi(a)gmail.com>
Date: Fri Sep 18 06:17:09 2015 -0700
xcompile: Redirect the objdump stderr to /dev/null
On system with clang, "as" is available but "objdump" is not by default.
So if ${gccprefix} is empty, "as" can run successfully and the "objdump"
below might report error. Mask that output.
Change-Id: I9940f069f66e097973ed6138cf3c696087fa5531
Signed-off-by: Zheng Bao <zheng.bao(a)amd.com>
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
Reviewed-on: http://review.coreboot.org/11681
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Reviewed-by: Martin Roth <martinroth(a)google.com>
See http://review.coreboot.org/11681 for details.
-gerrit
the following patch was just integrated into master:
commit 2f3fd2640f0630760497f59c6f5b137c1fb39e75
Author: zbao <fishbaozi(a)gmail.com>
Date: Sat Sep 26 06:20:53 2015 -0400
util/kconfig: Set parameter of mkdir to only one for mingw.
The second parameter is to set file permissions for the directory, which
is not needed in mingw.
Change-Id: I88e317f075e8a39f0a280b3dd6e597d119f0f741
Signed-off-by: Zheng Bao <zheng.bao(a)amd.com>
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
Reviewed-on: http://review.coreboot.org/11723
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See http://review.coreboot.org/11723 for details.
-gerrit
the following patch was just integrated into master:
commit 37450ff5343ffa3326a3f23a8ae7448d48e14e3c
Author: zbao <fishbaozi(a)gmail.com>
Date: Thu Nov 5 14:35:57 2015 +0800
cbfstool: Fix build error with clang when comparing enum
If HOSTCC=clang, the -Wtautological-constant-out-of-range-compare is
set automaticaaly. That assume the value of type enum is in the defined
range. Then testing if a type enum is out of range causes build error.
Error:
coreboot/util/cbfstool/cbfs_image.c:1387:16: error:
comparison of constant 4 with expression of type 'enum vb2_hash_algorithm'
is always false [-Werror,-Wtautological-constant-out-of-range-compare]
if (hash_type >= CBFS_NUM_SUPPORTED_HASHES)
~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
clang version:
FreeBSD clang version 3.4.1 (tags/RELEASE_34/dot1-final 208032) 20140512
Target: x86_64-unknown-freebsd10.2
Thread model: posix
Change-Id: I3e1722bf6f9553793a9f0c7f4e790706b6938522
Signed-off-by: zbao <fishbaozi(a)gmail.com>
Reviewed-on: http://review.coreboot.org/12330
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See http://review.coreboot.org/12330 for details.
-gerrit
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12335
-gerrit
commit b003aa6057ac10498430728a94a9ac5f003ddc54
Author: Martin Roth <martinroth(a)google.com>
Date: Thu Nov 5 09:00:20 2015 -0700
fsp_model_406dx: use external microcode .h files for rangeley
The microcode for the Rangeley chip is supplied as .h files in the
Rangeley FSP POSTGOLD4 package.
When the rangeley microcode gets put into the blobs directory, this
can be reverted and the binary file put into the makefile.
Change-Id: I30e7436f26a247bc9431f249becfa5fe8c581be7
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
src/cpu/intel/fsp_model_406dx/Kconfig | 20 ++++++++------------
src/cpu/intel/fsp_model_406dx/Makefile.inc | 3 ---
2 files changed, 8 insertions(+), 15 deletions(-)
diff --git a/src/cpu/intel/fsp_model_406dx/Kconfig b/src/cpu/intel/fsp_model_406dx/Kconfig
index 30e7e59..2e58b35 100644
--- a/src/cpu/intel/fsp_model_406dx/Kconfig
+++ b/src/cpu/intel/fsp_model_406dx/Kconfig
@@ -28,11 +28,14 @@ config CPU_SPECIFIC_OPTIONS
select SMP
select SSE2
select UDELAY_LAPIC
- select SUPPORT_CPU_UCODE_IN_CBFS
+ select SUPPORT_CPU_UCODE_IN_CBFS if HAVE_FSP_BIN
select PARALLEL_CPU_INIT
select TSC_SYNC_MFENCE
select LAPIC_MONOTONIC_TIMER
+ # Microcode header files are delivered in FSP package
+ select USES_MICROCODE_HEADER_FILES if HAVE_FSP_BIN
+
choice
prompt "Rangeley CPU Stepping"
default FSP_MODEL_406DX_B0
@@ -58,16 +61,9 @@ config CPU_MICROCODE_CBFS_LOC
depends on SUPPORT_CPU_UCODE_IN_CBFS
default 0xfff60040
-config HAVE_CPU_MICROCODE_FILE
- bool "Add microcode file"
- help
- The microcode binary
-
-config CPU_MICROCODE_FILE
- string "Path and filename of CPU microcode"
- default "microcode.bin"
- depends on HAVE_CPU_MICROCODE_FILE
- help
- The path and filename of the file containing the CPU microcode.
+#set up microcode for rangeley POSTGOLD4 release
+config CPU_MICROCODE_HEADER_FILES
+ string
+ default "../intel/cpu/rangeley/microcode/microcode-m01406d000e.h ../intel/cpu/rangeley/microcode/microcode-m01406d8128.h"
endif #CPU_INTEL_FSP_MODEL_406DX
diff --git a/src/cpu/intel/fsp_model_406dx/Makefile.inc b/src/cpu/intel/fsp_model_406dx/Makefile.inc
index 91c7d96..3e29348 100644
--- a/src/cpu/intel/fsp_model_406dx/Makefile.inc
+++ b/src/cpu/intel/fsp_model_406dx/Makefile.inc
@@ -23,6 +23,3 @@ cpu_microcode_bins += $(call strip_quotes,$(CONFIG_CPU_MICROCODE_FILE))
endif
CPPFLAGS_romstage += -I$(src)/cpu/intel/fsp_model_406dx
-# We don't have microcode for this CPU
-# Use CONFIG_CPU_MICROCODE_CBFS_EXTERNAL with a binary microcode file
-# cpu_microcode_bins += ???
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12499
-gerrit
commit 8d068b25926f2042fc19a201e1d1030712ef6ab5
Author: Martin Roth <martinroth(a)google.com>
Date: Thu Nov 19 19:02:07 2015 -0700
drivers/ti/tps65913: Set default values in Kconfig
Set default values for the hex and int kconfig symbols so they don't
come up as undefined.
Change-Id: Ib51272f35baa32fe5f3dc369c7f554c77bc2add1
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
src/drivers/ti/tps65913/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/drivers/ti/tps65913/Kconfig b/src/drivers/ti/tps65913/Kconfig
index 0f3ebdf..5da1793 100644
--- a/src/drivers/ti/tps65913/Kconfig
+++ b/src/drivers/ti/tps65913/Kconfig
@@ -26,7 +26,9 @@ config DRIVERS_TI_TPS65913_RTC
config DRIVERS_TI_TPS65913_RTC_BUS
int "TI TPS65913 RTC bus"
depends on DRIVERS_TI_TPS65913_RTC
+ default 0
config DRIVERS_TI_TPS65913_RTC_ADDR
hex "TI TPS65913 RTC chip address"
depends on DRIVERS_TI_TPS65913_RTC
+ default 0x00
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12498
-gerrit
commit bc9efafe140e4443725e152ae2412d8d08164faa
Author: Martin Roth <martinroth(a)google.com>
Date: Thu Nov 19 19:01:20 2015 -0700
drivers/ams: Set default values in Kconfig
Set default values for the hex and int kconfig symbols so they don't
come up as undefined.
Change-Id: If104cbf7d84719a63fb80aa955efa8baa3953d09
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
src/drivers/ams/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/drivers/ams/Kconfig b/src/drivers/ams/Kconfig
index 6729443..30e8667 100644
--- a/src/drivers/ams/Kconfig
+++ b/src/drivers/ams/Kconfig
@@ -6,7 +6,9 @@ config DRIVERS_AS3722_RTC
config DRIVERS_AS3722_RTC_BUS
int "AS3722 RTC bus"
depends on DRIVERS_AS3722_RTC
+ default 0
config DRIVERS_AS3722_RTC_ADDR
hex "AS3722 RTC chip address"
depends on DRIVERS_AS3722_RTC
+ default 0x00