coreboot-gerrit July 2014

coreboot-gerrit@coreboot.org

1 participants
861 discussions

Patch set updated for coreboot: bbd7dc6 arch/x86/*/ioapic.h: Missing stdint.h header inclusion
by Edward O'Callaghan 11 Jul '14

11 Jul '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6263 -gerrit commit bbd7dc66d6db4a2888290ff2640b71365047b947 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Jul 11 16:45:56 2014 +1000 arch/x86/*/ioapic.h: Missing stdint.h header inclusion Currently the inclusion happens due to hoops and loops though other headers. Change-Id: I526e28983e6affa0b524253e22beca598bef5802 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/arch/x86/include/arch/ioapic.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/arch/x86/include/arch/ioapic.h b/src/arch/x86/include/arch/ioapic.h index 7ff47bb..8f84c84 100644 --- a/src/arch/x86/include/arch/ioapic.h +++ b/src/arch/x86/include/arch/ioapic.h @@ -24,6 +24,7 @@ #define IO_APIC_INTERRUPTS 24 #ifndef __ACPI__ +#include <stdint.h> #define ALL (0xff << 24) #define NONE (0) #define DISABLED (1 << 16) @@ -44,6 +45,6 @@ void io_apic_write(u32 ioapic_base, u32 reg, u32 value); void set_ioapic_id(u32 ioapic_base, u8 ioapic_id); void setup_ioapic(u32 ioapic_base, u8 ioapic_id); void clear_ioapic(u32 ioapic_base); -#endif +#endif /* !__ACPI__ */ -#endif +#endif /* __I386_ARCH_IOAPIC_H */

1 0

Patch merged into coreboot/master: 7fc2da9 kontron/ktqm77: Clean up int15 handler
by gerrit＠coreboot.org 11 Jul '14

11 Jul '14

the following patch was just integrated into master: commit 7fc2da910766686d55d489d0e539a1586b98d5bb Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Fri Jun 27 12:17:17 2014 +0200 kontron/ktqm77: Clean up int15 handler Worked out the purpose of more int15 calls and let them return appropriate values. Also remove handlers for copy-pasted calls never observed on this board. Change-Id: I3d8c4ec5542bd19baca1dca83badc9b568779e1b Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: http://review.coreboot.org/6249 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> See http://review.coreboot.org/6249 for details. -gerrit

1 0

Patch merged into coreboot/master: 40f9ce9 kontron/ktqm77: Improve W83627DHG's GPIO config
by gerrit＠coreboot.org 11 Jul '14

11 Jul '14

the following patch was just integrated into master: commit 40f9ce93fa1d9e5206cd5c1081d22c60bfc6d3f3 Author: Nico Huber <nico.huber(a)secunet.com> Date: Tue Oct 22 11:07:23 2013 +0200 kontron/ktqm77: Improve W83627DHG's GPIO config Fix some outputs of the super i/o that should be GPIOs and make variables out of magic values that configure LVDS. Change-Id: Ib9eef065980cefff0046485549a68cf8f070d5b9 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: http://review.coreboot.org/6248 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> See http://review.coreboot.org/6248 for details. -gerrit

1 0

Patch merged into coreboot/master: 2b2f849 YABEL: Initialize global `biosmem` pointer for VBE
by gerrit＠coreboot.org 11 Jul '14

11 Jul '14

the following patch was just integrated into master: commit 2b2f849b537db935453694e863f9b4f73efbbff5 Author: Nico Huber <nico.huber(a)secunet.com> Date: Tue Jul 8 15:32:02 2014 +0200 YABEL: Initialize global `biosmem` pointer for VBE The global pointer `biosmem` defined in vbe.c was never set. Thus, VBE calls didn't work within YABEL. Change-Id: I63c1c77755f9c442cfec227a495332595ce2b70c Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: http://review.coreboot.org/6250 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> See http://review.coreboot.org/6250 for details. -gerrit

1 0

New patch to review for coreboot: b8f9408 IOAPIC: Fix missing stdint include
by Kyösti Mälkki 11 Jul '14

11 Jul '14

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6264 -gerrit commit b8f9408f29481653beaedebd02435c62d18088d6 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Fri Jul 11 09:44:54 2014 +0300 IOAPIC: Fix missing stdint include Change-Id: Ib26f48d3ac66788246834cdc25d97910cd79fe98 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/arch/x86/include/arch/ioapic.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/arch/x86/include/arch/ioapic.h b/src/arch/x86/include/arch/ioapic.h index 7ff47bb..ef1be0f 100644 --- a/src/arch/x86/include/arch/ioapic.h +++ b/src/arch/x86/include/arch/ioapic.h @@ -20,6 +20,8 @@ #ifndef __I386_ARCH_IOAPIC_H #define __I386_ARCH_IOAPIC_H +#include <stdint.h> + #define IO_APIC_ADDR 0xfec00000 #define IO_APIC_INTERRUPTS 24

1 0

Patch set updated for coreboot: 533f191 AGESA: Drop some excessive agesawrapper.h includes
by Kyösti Mälkki 11 Jul '14

11 Jul '14

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6262 -gerrit commit 533f1917eefa02406d9b02daf083ff6eda43103c Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Jul 10 22:16:58 2014 +0300 AGESA: Drop some excessive agesawrapper.h includes Change-Id: I3807912b1dc68fae8248a66e37bbe642fb92d3ae Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/cpu/amd/agesa/heapmanager.c | 2 +- src/cpu/amd/agesa/s3_resume.c | 1 - src/mainboard/amd/dinar/get_bus_conf.c | 1 - src/mainboard/amd/inagua/get_bus_conf.c | 1 - src/mainboard/amd/olivehill/acpi_tables.c | 1 - src/mainboard/amd/olivehill/get_bus_conf.c | 1 - src/mainboard/amd/parmer/acpi_tables.c | 5 ++--- src/mainboard/amd/parmer/get_bus_conf.c | 1 - src/mainboard/amd/persimmon/get_bus_conf.c | 1 - src/mainboard/amd/south_station/get_bus_conf.c | 1 - src/mainboard/amd/thatcher/acpi_tables.c | 5 ++--- src/mainboard/amd/thatcher/get_bus_conf.c | 1 - src/mainboard/amd/torpedo/get_bus_conf.c | 1 - src/mainboard/amd/union_station/get_bus_conf.c | 1 - src/mainboard/asrock/e350m1/get_bus_conf.c | 1 - src/mainboard/asrock/imb-a180/acpi_tables.c | 1 - src/mainboard/asrock/imb-a180/get_bus_conf.c | 1 - src/mainboard/asus/f2a85-m/get_bus_conf.c | 1 - src/mainboard/gizmosphere/gizmo/get_bus_conf.c | 1 - src/mainboard/hp/pavilion_m6_1035dx/get_bus_conf.c | 1 - src/mainboard/jetway/nf81-t56n-lf/get_bus_conf.c | 1 - src/mainboard/lippert/frontrunner-af/get_bus_conf.c | 1 - src/mainboard/lippert/toucan-af/get_bus_conf.c | 1 - src/mainboard/supermicro/h8qgi/get_bus_conf.c | 1 - src/mainboard/supermicro/h8scm/get_bus_conf.c | 1 - src/mainboard/tyan/s8226/get_bus_conf.c | 1 - src/northbridge/amd/agesa/def_callouts.h | 1 - 27 files changed, 5 insertions(+), 31 deletions(-) diff --git a/src/cpu/amd/agesa/heapmanager.c b/src/cpu/amd/agesa/heapmanager.c index 0f908cc..ed25f34 100644 --- a/src/cpu/amd/agesa/heapmanager.c +++ b/src/cpu/amd/agesa/heapmanager.c @@ -1,5 +1,5 @@ -#include "agesawrapper.h" +#include "AGESA.h" #include "amdlib.h" #include "northbridge/amd/agesa/def_callouts.h" #include "heapManager.h" diff --git a/src/cpu/amd/agesa/s3_resume.c b/src/cpu/amd/agesa/s3_resume.c index 1899408..0990469 100644 --- a/src/cpu/amd/agesa/s3_resume.c +++ b/src/cpu/amd/agesa/s3_resume.c @@ -33,7 +33,6 @@ #include "Porting.h" #include "BiosCallOuts.h" #include "s3_resume.h" -#include "agesawrapper.h" /* The size needs to be 4k aligned, which is the sector size of most flashes. */ #define S3_DATA_VOLATILE_SIZE 0x6000 diff --git a/src/mainboard/amd/dinar/get_bus_conf.c b/src/mainboard/amd/dinar/get_bus_conf.c index d62e111..1b207e3 100644 --- a/src/mainboard/amd/dinar/get_bus_conf.c +++ b/src/mainboard/amd/dinar/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam15.h> -#include "agesawrapper.h" /* Global variables for MB layouts and these will be shared by irqtable mptable diff --git a/src/mainboard/amd/inagua/get_bus_conf.c b/src/mainboard/amd/inagua/get_bus_conf.c index be113b3..1bf4aff 100644 --- a/src/mainboard/amd/inagua/get_bus_conf.c +++ b/src/mainboard/amd/inagua/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" /* Global variables for MB layouts and these will be shared by irqtable mptable diff --git a/src/mainboard/amd/olivehill/acpi_tables.c b/src/mainboard/amd/olivehill/acpi_tables.c index 07fad8e..a02b92c 100644 --- a/src/mainboard/amd/olivehill/acpi_tables.c +++ b/src/mainboard/amd/olivehill/acpi_tables.c @@ -25,7 +25,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <cpu/x86/msr.h> -#include "agesawrapper.h" #include <cpu/amd/mtrr.h> #include <cpu/amd/amdfam16.h> diff --git a/src/mainboard/amd/olivehill/get_bus_conf.c b/src/mainboard/amd/olivehill/get_bus_conf.c index f1643a4..032dd0c 100644 --- a/src/mainboard/amd/olivehill/get_bus_conf.c +++ b/src/mainboard/amd/olivehill/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" #if IS_ENABLED(CONFIG_HUDSON_IMC_FWM) #include "imc.h" #endif diff --git a/src/mainboard/amd/parmer/acpi_tables.c b/src/mainboard/amd/parmer/acpi_tables.c index 503ba48..e24ecc8 100644 --- a/src/mainboard/amd/parmer/acpi_tables.c +++ b/src/mainboard/amd/parmer/acpi_tables.c @@ -17,6 +17,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include "agesawrapper.h" + #include <console/console.h> #include <string.h> #include <arch/acpi.h> @@ -25,12 +27,9 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <cpu/x86/msr.h> -#include "agesawrapper.h" #include <cpu/amd/mtrr.h> #include <cpu/amd/amdfam15.h> -#include "agesawrapper.h" - extern const unsigned char AmlCode[]; unsigned long acpi_fill_mcfg(unsigned long current) diff --git a/src/mainboard/amd/parmer/get_bus_conf.c b/src/mainboard/amd/parmer/get_bus_conf.c index 4c4777f..23c23d8 100644 --- a/src/mainboard/amd/parmer/get_bus_conf.c +++ b/src/mainboard/amd/parmer/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" #if IS_ENABLED(CONFIG_HUDSON_IMC_FWM) #include "imc.h" #endif diff --git a/src/mainboard/amd/persimmon/get_bus_conf.c b/src/mainboard/amd/persimmon/get_bus_conf.c index b31f687..c5dc4e9 100644 --- a/src/mainboard/amd/persimmon/get_bus_conf.c +++ b/src/mainboard/amd/persimmon/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" #include <arch/ioapic.h> diff --git a/src/mainboard/amd/south_station/get_bus_conf.c b/src/mainboard/amd/south_station/get_bus_conf.c index 99b3880..e03fcb8 100644 --- a/src/mainboard/amd/south_station/get_bus_conf.c +++ b/src/mainboard/amd/south_station/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" /* Global variables for MB layouts and these will be shared by irqtable mptable diff --git a/src/mainboard/amd/thatcher/acpi_tables.c b/src/mainboard/amd/thatcher/acpi_tables.c index 503ba48..e24ecc8 100644 --- a/src/mainboard/amd/thatcher/acpi_tables.c +++ b/src/mainboard/amd/thatcher/acpi_tables.c @@ -17,6 +17,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include "agesawrapper.h" + #include <console/console.h> #include <string.h> #include <arch/acpi.h> @@ -25,12 +27,9 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <cpu/x86/msr.h> -#include "agesawrapper.h" #include <cpu/amd/mtrr.h> #include <cpu/amd/amdfam15.h> -#include "agesawrapper.h" - extern const unsigned char AmlCode[]; unsigned long acpi_fill_mcfg(unsigned long current) diff --git a/src/mainboard/amd/thatcher/get_bus_conf.c b/src/mainboard/amd/thatcher/get_bus_conf.c index d4a5654..a4250e1 100644 --- a/src/mainboard/amd/thatcher/get_bus_conf.c +++ b/src/mainboard/amd/thatcher/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" #if IS_ENABLED(CONFIG_HUDSON_IMC_FWM) #include "imc.h" #endif diff --git a/src/mainboard/amd/torpedo/get_bus_conf.c b/src/mainboard/amd/torpedo/get_bus_conf.c index b7895e4..8cf5049 100644 --- a/src/mainboard/amd/torpedo/get_bus_conf.c +++ b/src/mainboard/amd/torpedo/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam12.h> -#include "agesawrapper.h" /* Global variables for MB layouts and these will be shared by irqtable mptable * and acpi_tables busnum is default. diff --git a/src/mainboard/amd/union_station/get_bus_conf.c b/src/mainboard/amd/union_station/get_bus_conf.c index 99b3880..e03fcb8 100644 --- a/src/mainboard/amd/union_station/get_bus_conf.c +++ b/src/mainboard/amd/union_station/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" /* Global variables for MB layouts and these will be shared by irqtable mptable diff --git a/src/mainboard/asrock/e350m1/get_bus_conf.c b/src/mainboard/asrock/e350m1/get_bus_conf.c index 99b3880..e03fcb8 100644 --- a/src/mainboard/asrock/e350m1/get_bus_conf.c +++ b/src/mainboard/asrock/e350m1/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" /* Global variables for MB layouts and these will be shared by irqtable mptable diff --git a/src/mainboard/asrock/imb-a180/acpi_tables.c b/src/mainboard/asrock/imb-a180/acpi_tables.c index 41354fb..2c480c3 100644 --- a/src/mainboard/asrock/imb-a180/acpi_tables.c +++ b/src/mainboard/asrock/imb-a180/acpi_tables.c @@ -25,7 +25,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <cpu/x86/msr.h> -#include "agesawrapper.h" #include <cpu/amd/mtrr.h> #include <cpu/amd/amdfam16.h> diff --git a/src/mainboard/asrock/imb-a180/get_bus_conf.c b/src/mainboard/asrock/imb-a180/get_bus_conf.c index eecffb5..ae54c89 100644 --- a/src/mainboard/asrock/imb-a180/get_bus_conf.c +++ b/src/mainboard/asrock/imb-a180/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" /* Global variables for MB layouts and these will be shared by irqtable mptable * and acpi_tables busnum is default. diff --git a/src/mainboard/asus/f2a85-m/get_bus_conf.c b/src/mainboard/asus/f2a85-m/get_bus_conf.c index 08e5795..ecf0cf9 100644 --- a/src/mainboard/asus/f2a85-m/get_bus_conf.c +++ b/src/mainboard/asus/f2a85-m/get_bus_conf.c @@ -17,7 +17,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include "agesawrapper.h" #include <console/console.h> #include <cpu/amd/amdfam15.h> diff --git a/src/mainboard/gizmosphere/gizmo/get_bus_conf.c b/src/mainboard/gizmosphere/gizmo/get_bus_conf.c index 44d0b0f..b3e6e1c 100755 --- a/src/mainboard/gizmosphere/gizmo/get_bus_conf.c +++ b/src/mainboard/gizmosphere/gizmo/get_bus_conf.c @@ -25,7 +25,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" /* Global variables for MB layouts and these will be shared by irqtable mptable diff --git a/src/mainboard/hp/pavilion_m6_1035dx/get_bus_conf.c b/src/mainboard/hp/pavilion_m6_1035dx/get_bus_conf.c index 78193eb..6b9d927 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/get_bus_conf.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/get_bus_conf.c @@ -17,7 +17,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include "agesawrapper.h" #include <console/console.h> #include <cpu/amd/amdfam15.h> diff --git a/src/mainboard/jetway/nf81-t56n-lf/get_bus_conf.c b/src/mainboard/jetway/nf81-t56n-lf/get_bus_conf.c index 3992cb7..f3b6b3b 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/get_bus_conf.c +++ b/src/mainboard/jetway/nf81-t56n-lf/get_bus_conf.c @@ -17,7 +17,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include "agesawrapper.h" #include <arch/ioapic.h> #include <console/console.h> diff --git a/src/mainboard/lippert/frontrunner-af/get_bus_conf.c b/src/mainboard/lippert/frontrunner-af/get_bus_conf.c index c1a3fc2..9f53a2c 100644 --- a/src/mainboard/lippert/frontrunner-af/get_bus_conf.c +++ b/src/mainboard/lippert/frontrunner-af/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" /* Global variables for MB layouts and these will be shared by irqtable mptable diff --git a/src/mainboard/lippert/toucan-af/get_bus_conf.c b/src/mainboard/lippert/toucan-af/get_bus_conf.c index c49fff1..4aee1e8 100644 --- a/src/mainboard/lippert/toucan-af/get_bus_conf.c +++ b/src/mainboard/lippert/toucan-af/get_bus_conf.c @@ -24,7 +24,6 @@ #include <stdint.h> #include <stdlib.h> #include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" /* Global variables for MB layouts and these will be shared by irqtable mptable diff --git a/src/mainboard/supermicro/h8qgi/get_bus_conf.c b/src/mainboard/supermicro/h8qgi/get_bus_conf.c index bce9737..e848c98 100644 --- a/src/mainboard/supermicro/h8qgi/get_bus_conf.c +++ b/src/mainboard/supermicro/h8qgi/get_bus_conf.c @@ -23,7 +23,6 @@ #include <string.h> #include <stdint.h> #include <stdlib.h> -#include "agesawrapper.h" #include <cpu/amd/amdfam10_sysconf.h> diff --git a/src/mainboard/supermicro/h8scm/get_bus_conf.c b/src/mainboard/supermicro/h8scm/get_bus_conf.c index 9a70fca..5aa5c75 100644 --- a/src/mainboard/supermicro/h8scm/get_bus_conf.c +++ b/src/mainboard/supermicro/h8scm/get_bus_conf.c @@ -23,7 +23,6 @@ #include <string.h> #include <stdint.h> #include <stdlib.h> -#include "agesawrapper.h" #include <cpu/amd/amdfam10_sysconf.h> diff --git a/src/mainboard/tyan/s8226/get_bus_conf.c b/src/mainboard/tyan/s8226/get_bus_conf.c index e7529c3..b074984 100644 --- a/src/mainboard/tyan/s8226/get_bus_conf.c +++ b/src/mainboard/tyan/s8226/get_bus_conf.c @@ -23,7 +23,6 @@ #include <string.h> #include <stdint.h> #include <stdlib.h> -#include "agesawrapper.h" /* Global variables for MB layouts and these will be shared by irqtable mptable diff --git a/src/northbridge/amd/agesa/def_callouts.h b/src/northbridge/amd/agesa/def_callouts.h index b679bae..cccce54 100644 --- a/src/northbridge/amd/agesa/def_callouts.h +++ b/src/northbridge/amd/agesa/def_callouts.h @@ -21,7 +21,6 @@ #ifndef CALLOUTS_AMD_AGESA_H #define CALLOUTS_AMD_AGESA_H -#include "agesawrapper.h" #include "Porting.h" #include "AGESA.h"

1 0

Patch set updated for coreboot: 6496629 build system: remove duplicate architecture list
by Patrick Georgi 11 Jul '14

11 Jul '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6254 -gerrit commit 649662906403acdae499c9ea5b2aaa0ca52136b9 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Thu Jul 10 20:38:21 2014 +0200 build system: remove duplicate architecture list Let xcompile pass the list of architectures, given that it already has it. This potentially requires removing $(src)/.xcompile so it gets updated. Change-Id: I565512d3bef987c9a4e48a39bfd88bacf0b65de9 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- toolchain.inc | 2 -- util/xcompile/xcompile | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/toolchain.inc b/toolchain.inc index b5b4fe0..842473b 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -17,8 +17,6 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## -ARCH_SUPPORTED := armv7 x86_32 - # ccache integration ifeq ($(CONFIG_CCACHE),y) diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index d133bd2..b42da7b 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -147,6 +147,7 @@ detect_special_flags() { report_arch_toolchain() { cat <<EOF # elf${TWIDTH}-${TBFDARCH} toolchain (${GCCPREFIX}gcc) +ARCH_SUPPORTED+=${TARCH} CC_${TARCH}:=${GCCPREFIX}gcc CFLAGS_${TARCH}:=${CFLAGS} CPP_${TARCH}:=${GCCPREFIX}cpp

1 0

Patch set updated for coreboot: 13baff7 build system: create .xcompile dependency
by Patrick Georgi 11 Jul '14

11 Jul '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6255 -gerrit commit 13baff75edd1c0d29fc393bbe9f6aa7fbf50a9bd Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Thu Jul 10 21:06:04 2014 +0200 build system: create .xcompile dependency It's probably safe to say that .xcompile needs an update if util/xcompile/xcompile changed, so tell make about this dependency. Updates are honored immediately due to GNU make's feature of reinterpreting everything when an included file changes. See "How Makefiles Are Remade" in the GNU make documentation for details. Change-Id: Ide2f028eaddcee66028c6403688cc83e1622fa6b Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- Makefile | 4 +++- util/xcompile/xcompile | 0 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c8cad4f..b1a7d19 100644 --- a/Makefile +++ b/Makefile @@ -30,7 +30,9 @@ ## SUCH DAMAGE. ## -$(if $(wildcard .xcompile),,$(eval $(shell bash util/xcompile/xcompile $(XGCCPATH) > .xcompile))) +.xcompile: util/xcompile/xcompile + -$< $(XGCCPATH) > $@.tmp && mv $@.tmp $@ 2> /dev/null + include .xcompile export top := $(CURDIR) diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile old mode 100644 new mode 100755

1 0

New patch to review for coreboot: 3080e15 arch/x86/*/ioapic.h: Missing stdint.h header inclusion
by Edward O'Callaghan 11 Jul '14

11 Jul '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6263 -gerrit commit 3080e152dea14c157f114798cce7a9af2b914da9 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Jul 11 16:45:56 2014 +1000 arch/x86/*/ioapic.h: Missing stdint.h header inclusion Currently the inclusion happens due to hoops and loops though other headers. Change-Id: I526e28983e6affa0b524253e22beca598bef5802 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/arch/x86/include/arch/ioapic.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/arch/x86/include/arch/ioapic.h b/src/arch/x86/include/arch/ioapic.h index 7ff47bb..af5772e 100644 --- a/src/arch/x86/include/arch/ioapic.h +++ b/src/arch/x86/include/arch/ioapic.h @@ -20,6 +20,8 @@ #ifndef __I386_ARCH_IOAPIC_H #define __I386_ARCH_IOAPIC_H +#include <arch/stdint.h> + #define IO_APIC_ADDR 0xfec00000 #define IO_APIC_INTERRUPTS 24 @@ -44,6 +46,6 @@ void io_apic_write(u32 ioapic_base, u32 reg, u32 value); void set_ioapic_id(u32 ioapic_base, u8 ioapic_id); void setup_ioapic(u32 ioapic_base, u8 ioapic_id); void clear_ioapic(u32 ioapic_base); -#endif +#endif /* !__ACPI__ */ -#endif +#endif /* __I386_ARCH_IOAPIC_H */

1 0

Patch merged into coreboot/master: f6e1cbe southbridge/amd/rsXY0/cmn.c: Trivial - Style fixes
by gerrit＠coreboot.org 11 Jul '14

11 Jul '14

the following patch was just integrated into master: commit f6e1cbec2a68211225c6281b1f451173de688f44 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat Jun 28 22:47:22 2014 +1000 southbridge/amd/rsXY0/cmn.c: Trivial - Style fixes Remove some ASCII art past 80 columns. Change-Id: I00ad79f2e1ddd78935efcfab19d9e166f0349ae3 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-on: http://review.coreboot.org/6155 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> See http://review.coreboot.org/6155 for details. -gerrit

1 0

← Newer
1
...
52
53
54
55
56
57
58
...
87
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2014