Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5930
-gerrit
commit a150d72fd726603115d065c5bad7de4e3d68234f
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Thu Jun 5 09:04:40 2014 +0200
lenovo/x60/i915.c: Remove one of the two `PGETBL_CTL` defines
Change-Id: I459c2576d91e80accaae313b34875cc7b8c446ad
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/lenovo/x60/i915.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mainboard/lenovo/x60/i915.c b/src/mainboard/lenovo/x60/i915.c
index 2dc018c..5ebd066 100644
--- a/src/mainboard/lenovo/x60/i915.c
+++ b/src/mainboard/lenovo/x60/i915.c
@@ -49,8 +49,6 @@ enum {
vmsg = 1, vio = 2, vspin = 4,
};
-#define PGETLB_CTL 0x2020
-
static int verbose = 0;
static unsigned int *mmio;
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5932
-gerrit
commit 9ec59bbca8917ecdb1835919aee5b07f4ebf8a73
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Thu Jun 5 08:50:17 2014 +0200
lenovo/x60/i915.c: Use define for `BSM`
Although it builds without any further chanegs, include the header
src/northbridge/intel/i945/i945.h
where `BSM` is defined.
Change-Id: I7c0a795338c34038169e082446907987364a0e88
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/lenovo/x60/i915.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mainboard/lenovo/x60/i915.c b/src/mainboard/lenovo/x60/i915.c
index b41a0ba..2dc018c 100644
--- a/src/mainboard/lenovo/x60/i915.c
+++ b/src/mainboard/lenovo/x60/i915.c
@@ -31,6 +31,7 @@
#include <arch/io.h>
#include <arch/interrupt.h>
#include <boot/coreboot_tables.h>
+#include <northbridge/intel/i945/i945.h>
#include <southbridge/intel/bd82x6x/pch.h>
#include <smbios.h>
#include <device/pci.h>
@@ -138,7 +139,7 @@ int gtt_setup(unsigned int mmiobase)
PGETBL_save = read32(mmiobase + PGETBL_CTL) & ~PGETBL_ENABLED;
PGETBL_save |= PGETBL_ENABLED;
- PGETBL_save |= pci_read_config32(dev_find_slot(0, PCI_DEVFN(2,0)), 0x5c) & 0xfffff000;
+ PGETBL_save |= pci_read_config32(dev_find_slot(0, PCI_DEVFN(2,0)), BSM) & 0xfffff000;
PGETBL_save |= 2; /* set GTT to 256kb */
write32(mmiobase + GFX_FLSH_CNTL, 0);
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5933
-gerrit
commit 89dea46f54ea5b6887ffd37fd15b31190ae18524
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Thu Jun 5 09:41:06 2014 +0200
lenovo/x60/i915.c: Rename variable `PGETBL_save` to `pgetbl_ctl`
The name was taken from the function `intel_gtt_init()` in
`drivers/char/agp/intel-gtt.c` in the Linux kernel. It is used
differently here `gtt_setup()`, so rename it.
Change-Id: I16896fc9383a5e40992a24fa096fd373db66e436
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/lenovo/x60/i915.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/mainboard/lenovo/x60/i915.c b/src/mainboard/lenovo/x60/i915.c
index 5ebd066..8399ae7 100644
--- a/src/mainboard/lenovo/x60/i915.c
+++ b/src/mainboard/lenovo/x60/i915.c
@@ -132,17 +132,17 @@ setgtt(int start, int end, unsigned long base, int inc)
int gtt_setup(unsigned int mmiobase);
int gtt_setup(unsigned int mmiobase)
{
- unsigned long PGETBL_save;
+ unsigned long pgetbl_ctl;
- PGETBL_save = read32(mmiobase + PGETBL_CTL) & ~PGETBL_ENABLED;
- PGETBL_save |= PGETBL_ENABLED;
+ pgetbl_ctl = read32(mmiobase + PGETBL_CTL) & ~PGETBL_ENABLED;
+ pgetbl_ctl |= PGETBL_ENABLED;
- PGETBL_save |= pci_read_config32(dev_find_slot(0, PCI_DEVFN(2,0)), BSM) & 0xfffff000;
- PGETBL_save |= 2; /* set GTT to 256kb */
+ pgetbl_ctl |= pci_read_config32(dev_find_slot(0, PCI_DEVFN(2,0)), BSM) & 0xfffff000;
+ pgetbl_ctl |= 2; /* set GTT to 256kb */
write32(mmiobase + GFX_FLSH_CNTL, 0);
- write32(mmiobase + PGETBL_CTL, PGETBL_save);
+ write32(mmiobase + PGETBL_CTL, pgetbl_ctl);
/* verify */
if (read32(mmiobase + PGETBL_CTL) & PGETBL_ENABLED) {
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5933
-gerrit
commit 59c85c917a0fc353fe40dd97571b97dcb4813761
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Thu Jun 5 09:41:06 2014 +0200
lenovo/x60/i915.c: Rename variable `PGETBL_save` to `pgetbl_ctl`
The name was taken from the function `intel_gtt_init()` in
`drivers/char/agp/intel-gtt.c` in the Linux kernel. It is used
differently here `gtt_setup()`, so rename it.
Change-Id: I16896fc9383a5e40992a24fa096fd373db66e436
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/lenovo/x60/i915.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/mainboard/lenovo/x60/i915.c b/src/mainboard/lenovo/x60/i915.c
index 5ebd066..8399ae7 100644
--- a/src/mainboard/lenovo/x60/i915.c
+++ b/src/mainboard/lenovo/x60/i915.c
@@ -132,17 +132,17 @@ setgtt(int start, int end, unsigned long base, int inc)
int gtt_setup(unsigned int mmiobase);
int gtt_setup(unsigned int mmiobase)
{
- unsigned long PGETBL_save;
+ unsigned long pgetbl_ctl;
- PGETBL_save = read32(mmiobase + PGETBL_CTL) & ~PGETBL_ENABLED;
- PGETBL_save |= PGETBL_ENABLED;
+ pgetbl_ctl = read32(mmiobase + PGETBL_CTL) & ~PGETBL_ENABLED;
+ pgetbl_ctl |= PGETBL_ENABLED;
- PGETBL_save |= pci_read_config32(dev_find_slot(0, PCI_DEVFN(2,0)), BSM) & 0xfffff000;
- PGETBL_save |= 2; /* set GTT to 256kb */
+ pgetbl_ctl |= pci_read_config32(dev_find_slot(0, PCI_DEVFN(2,0)), BSM) & 0xfffff000;
+ pgetbl_ctl |= 2; /* set GTT to 256kb */
write32(mmiobase + GFX_FLSH_CNTL, 0);
- write32(mmiobase + PGETBL_CTL, PGETBL_save);
+ write32(mmiobase + PGETBL_CTL, pgetbl_ctl);
/* verify */
if (read32(mmiobase + PGETBL_CTL) & PGETBL_ENABLED) {
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5932
-gerrit
commit 853115e56c0d3372cb7c533b4649dc43a3d1d912
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Thu Jun 5 08:50:17 2014 +0200
mainboard/lenovo/x60/i915.c: Use define for `BSM`
Although it builds without any further chanegs, include the header
src/northbridge/intel/i945/i945.h
where `BSM` is defined.
Change-Id: I7c0a795338c34038169e082446907987364a0e88
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/lenovo/x60/i915.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mainboard/lenovo/x60/i915.c b/src/mainboard/lenovo/x60/i915.c
index b41a0ba..2dc018c 100644
--- a/src/mainboard/lenovo/x60/i915.c
+++ b/src/mainboard/lenovo/x60/i915.c
@@ -31,6 +31,7 @@
#include <arch/io.h>
#include <arch/interrupt.h>
#include <boot/coreboot_tables.h>
+#include <northbridge/intel/i945/i945.h>
#include <southbridge/intel/bd82x6x/pch.h>
#include <smbios.h>
#include <device/pci.h>
@@ -138,7 +139,7 @@ int gtt_setup(unsigned int mmiobase)
PGETBL_save = read32(mmiobase + PGETBL_CTL) & ~PGETBL_ENABLED;
PGETBL_save |= PGETBL_ENABLED;
- PGETBL_save |= pci_read_config32(dev_find_slot(0, PCI_DEVFN(2,0)), 0x5c) & 0xfffff000;
+ PGETBL_save |= pci_read_config32(dev_find_slot(0, PCI_DEVFN(2,0)), BSM) & 0xfffff000;
PGETBL_save |= 2; /* set GTT to 256kb */
write32(mmiobase + GFX_FLSH_CNTL, 0);
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5930
-gerrit
commit 6e3c0d9f68336cd233129979ca97b60063899ddd
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Thu Jun 5 09:04:40 2014 +0200
lenovo/x60/i915.c: Remove one of the two `PGETBL_CTL` defines
Change-Id: I459c2576d91e80accaae313b34875cc7b8c446ad
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/lenovo/x60/i915.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mainboard/lenovo/x60/i915.c b/src/mainboard/lenovo/x60/i915.c
index 2dc018c..5ebd066 100644
--- a/src/mainboard/lenovo/x60/i915.c
+++ b/src/mainboard/lenovo/x60/i915.c
@@ -49,8 +49,6 @@ enum {
vmsg = 1, vio = 2, vspin = 4,
};
-#define PGETLB_CTL 0x2020
-
static int verbose = 0;
static unsigned int *mmio;