coreboot-gerrit May 2014

coreboot-gerrit@coreboot.org

1 participants
1066 discussions

New patch to review for coreboot: 6b90632 abuild: update version and copyright
by Patrick Georgi 21 May '14

21 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5806 -gerrit commit 6b9063236ae8abe80524ab01e4880c77da8b257a Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed May 21 22:48:35 2014 +0200 abuild: update version and copyright Enough changed to warrant a new version, date, and copyright. Change-Id: Ia099cd4fec3b05efc3f8bac09d38baede1c719e0 Signed-off-by: Patrick … [View More]

1 0

New patch to review for coreboot: d38da19 abuild: allow build results outside the source tree
by Patrick Georgi 21 May '14

21 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5805 -gerrit commit d38da194dcc23ee458aed46ec065d654ccb4adda Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed May 21 23:00:32 2014 +0200 abuild: allow build results outside the source tree A reasonable configuration that minimizes disk traffic could be $ abuild -o /tmp/abuild-$$ -z Change-Id: … [View More]Ic91798af7e799a40a77025e09a6078ea6758cdac Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/abuild/abuild | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/util/abuild/abuild b/util/abuild/abuild index 6c8c304..4d98b9a 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -277,7 +277,7 @@ function build_target CONFIG=$3 TARCH=$( architecture $VENDOR $MAINBOARD ) - if [ "`cat $TOP/$TARGET/${VENDOR}_${MAINBOARD}/compile.status 2>/dev/null`" = "ok" -a \ + if [ "`cat $TARGET/${VENDOR}_${MAINBOARD}/compile.status 2>/dev/null`" = "ok" -a \ "$buildall" = "false" ]; then printf "Skipping $VENDOR/$MAINBOARD; (already successful)\n" return @@ -286,8 +286,8 @@ function build_target HOSTCC='gcc' printf "Building $VENDOR/$MAINBOARD; " - mkdir -p $TOP/$TARGET/${VENDOR}_${MAINBOARD} $TOP/$TARGET/abuild - XMLFILE=$TOP/$TARGET/abuild/${VENDOR}_${MAINBOARD}.xml + mkdir -p $TARGET/${VENDOR}_${MAINBOARD} $TARGET/abuild + XMLFILE=$TARGET/abuild/${VENDOR}_${MAINBOARD}.xml stime=`perl -e 'print time();' 2>/dev/null || date +%s` @@ -398,6 +398,8 @@ function myhelp printf " [-P|--prefix <name>] file name prefix in CBFS\n" printf " [-B|--blobs] Allow using binary files\n" printf " [-z|--clean] Remove build results when finished\n" + printf " [-o|--outdir <path>] store build results in path\n" + printf " (defaults to $TARGET)\n" printf " [-L|--clang] Use clang\n" printf " [--scan-build] use clang's static analyzer\n" printf " [cbroot] absolute path to coreboot sources\n" @@ -440,7 +442,7 @@ cmdline="$* -c 1" getoptbrand="`getopt -V`" if [ "${getoptbrand:0:6}" == "getopt" ]; then # Detected GNU getopt that supports long options. - args=`getopt -l version,verbose,help,all,target:,payloads:,test,cpus:,silent,junit,config,loglevel:,remove,prefix:,update,scan-build,ccache,blobs,clang,clean -o Vvhat:p:Tc:sJCl:rP:uyBLz -- "$@"` || exit 1 + args=`getopt -l version,verbose,help,all,target:,payloads:,test,cpus:,silent,junit,config,loglevel:,remove,prefix:,update,scan-build,ccache,blobs,clang,clean,outdir: -o Vvhat:p:Tc:sJCl:rP:uyBLzo: -- "$@"` || exit 1 eval set -- $args else # Detected non-GNU getopt @@ -509,12 +511,20 @@ while true ; do customizing="${customizing}, clean" clean_work=true ;; + -o|--outdir) shift + TARGET=$1; shift + ;; --) shift; break;; -*) printf "Invalid option\n\n"; myhelp; exit 1;; *) break;; esac done +if [ -z "$TARGET" -o "$TARGET" = "/" ]; then + echo "Please specify a valid, non-root build directory." + exit 1 +fi + customizing=`echo $customizing |cut -c3-` if [ "$customizing" = "" ]; then customizing="default configuration" [View Less]

1 0

New patch to review for coreboot: 34dec5f abuild: allow deleting the work directories immediately
by Patrick Georgi 21 May '14

21 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5804 -gerrit commit 34dec5f02e06061212b6aa60d2a13f9a13118d76 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed May 21 22:47:05 2014 +0200 abuild: allow deleting the work directories immediately This is useful on pure build nodes that don't care for object files, just for a build log and success flag. Change-Id: … [View More]Ida65d4e41652af0f1b7255309aec2eeb6ef5c9ef Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/abuild/abuild | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/util/abuild/abuild b/util/abuild/abuild index 85b6406..6c8c304 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -254,18 +254,20 @@ function compile_target junit "</system-out>" printf "ok\n" > compile.status printf "ok. (took ${duration}s)\n" - cd $CURR - return 0 else + ret=1 junit "<failure type='BuildFailed'>" junitfile make.log junit "</failure>" printf "FAILED after ${duration}s!\nLog excerpt:\n" tail -n $CONTEXT make.log 2> /dev/null || tail -$CONTEXT make.log - cd $CURR failed=1 - return 1 fi + cd $CURR + if [ $clean_work = "true" ]; then + rm -rf $TARGET/${VENDOR}_${MAINBOARD} + fi + return $ret } function build_target @@ -395,6 +397,7 @@ function myhelp printf " [-u|--update] update existing image\n" printf " [-P|--prefix <name>] file name prefix in CBFS\n" printf " [-B|--blobs] Allow using binary files\n" + printf " [-z|--clean] Remove build results when finished\n" printf " [-L|--clang] Use clang\n" printf " [--scan-build] use clang's static analyzer\n" printf " [cbroot] absolute path to coreboot sources\n" @@ -437,7 +440,7 @@ cmdline="$* -c 1" getoptbrand="`getopt -V`" if [ "${getoptbrand:0:6}" == "getopt" ]; then # Detected GNU getopt that supports long options. - args=`getopt -l version,verbose,help,all,target:,payloads:,test,cpus:,silent,junit,config,loglevel:,remove,prefix:,update,scan-build,ccache,blobs,clang -o Vvhat:p:Tc:sJCl:rP:uyBL -- "$@"` || exit 1 + args=`getopt -l version,verbose,help,all,target:,payloads:,test,cpus:,silent,junit,config,loglevel:,remove,prefix:,update,scan-build,ccache,blobs,clang,clean -o Vvhat:p:Tc:sJCl:rP:uyBLz -- "$@"` || exit 1 eval set -- $args else # Detected non-GNU getopt @@ -450,6 +453,7 @@ if [ $? != 0 ]; then exit 1 fi +clean_work=false customizing="" configoptions="" while true ; do @@ -501,6 +505,10 @@ while true ; do customizing="${customizing}, clang" configoptions="${configoptions}CONFIG_COMPILER_LLVM_CLANG=y\n" ;; + -z|--clean) shift + customizing="${customizing}, clean" + clean_work=true + ;; --) shift; break;; -*) printf "Invalid option\n\n"; myhelp; exit 1;; *) break;; [View Less]

1 0

New patch to review for coreboot: e5ae1a9 build: allow obj=/absolute/path
by Patrick Georgi 21 May '14

21 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5803 -gerrit commit e5ae1a93969fa5eda73c68bbaf3fbddcbd41cfc4 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed May 21 22:36:13 2014 +0200 build: allow obj=/absolute/path This allows moving the build tree outside the source tree. Change-Id: I97882c4820d2c962c27bf8d50378e64016ce5790 Signed-off-by: Patrick Georgi <… [View More]

1 0

Patch merged into coreboot/master: 16d953a device_romstage: Add a way to move to the next device
by gerrit＠coreboot.org 21 May '14

21 May '14

the following patch was just integrated into master: commit 16d953a46001e8852d63095e5310ed7869d109e7 Author: Martin Roth <gaumless(a)gmail.com> Date: Mon May 12 17:38:59 2014 -0600 device_romstage: Add a way to move to the next device When trying to loop through all the devices in romstage, there was no function to just go from one to the next. This allows an easy way to go all the way down the chain of devices. Change-Id: … [View More]

1 0

New patch to review for coreboot: 3002b40 amd/agesa/f14: Backport f15tn fixes from DDR3 in mtspd3.c
by Edward O'Callaghan 21 May '14

21 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5802 -gerrit commit 3002b400c6665b5d90b4b9313ad1bfad459826c7 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu May 22 06:16:15 2014 +1000 amd/agesa/f14: Backport f15tn fixes from DDR3 in mtspd3.c Change-Id: I710efc3171e1653241f2dba1217a9560d2d99a16 Signed-off-by: Edward O'Callaghan <eocallaghan(a)… [View More]

1 0

Patch merged into coreboot/master: db0e0e2 amd/agesa/*/gcc-intrin.h: Invaild inline asm
by gerrit＠coreboot.org 21 May '14

21 May '14

the following patch was just integrated into master: commit db0e0e2c54397dffa8b55bfbfb76a15d641e4235 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu May 15 21:13:33 2014 +1000 amd/agesa/*/gcc-intrin.h: Invaild inline asm The 'm' (a memory reference) constraint makes little sense here since we are talking about a fs relative read, rather 'ir' (immediate or register) constraint is more sensible. N.B. The 'p' constraint allows anything … [View More]

1 0

Patch merged into coreboot/master: 3312ed7 amd/agesa/f1?/Lib/amdlib.c: Integer overflow in loop construct
by gerrit＠coreboot.org 21 May '14

21 May '14

the following patch was just integrated into master: commit 3312ed7e7a0b3269d6559207cdf9ed932ffecd31 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu May 22 03:36:22 2014 +1000 amd/agesa/f1?/Lib/amdlib.c: Integer overflow in loop construct The semantics of this loop relies on an integer overflow in Index >=0 that implies a return value of (UINT8)-1 which around wraps to 0xFF, or VOLT_UNSUPPORTED. Change-Id: … [View More]

1 0

New patch to review for coreboot: de3e51b amd/agesa/f1?/Lib/amdlib.c: Integer overflow in loop construct
by Edward O'Callaghan 21 May '14

21 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5801 -gerrit commit de3e51b1c20aafb5f764156892fe58323fa416b1 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu May 22 03:36:22 2014 +1000 amd/agesa/f1?/Lib/amdlib.c: Integer overflow in loop construct The semantics of this loop relies on an integer overflow in Index >=0 that implies a return value of (… [View More]UINT8)-1 which around wraps to 0xFF, or VOLT_UNSUPPORTED. Change-Id: I44d68973d0a80093350b2a8a4d3b46bfbb57917a Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/vendorcode/amd/agesa/f10/Lib/amdlib.c | 6 +++--- src/vendorcode/amd/agesa/f12/Lib/amdlib.c | 6 +++--- src/vendorcode/amd/agesa/f14/Lib/amdlib.c | 6 +++--- src/vendorcode/amd/agesa/f15/Lib/amdlib.c | 6 +++--- src/vendorcode/amd/agesa/f15tn/Lib/amdlib.c | 6 +++--- 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/vendorcode/amd/agesa/f10/Lib/amdlib.c b/src/vendorcode/amd/agesa/f10/Lib/amdlib.c index d88eee7..83e6a00 100644 --- a/src/vendorcode/amd/agesa/f10/Lib/amdlib.c +++ b/src/vendorcode/amd/agesa/f10/Lib/amdlib.c @@ -344,11 +344,11 @@ LibAmdBitScanReverse ( IN UINT32 value ) { - UINTN Index; + UINT8 Index; for (Index = 31; Index >= 0; Index--){ - if (value & (1 << Index)) break; + if (value & (1 << Index)) return Index; } - return (UINT8) Index; + return 0xFF; } VOID LibAmdMsrRead ( diff --git a/src/vendorcode/amd/agesa/f12/Lib/amdlib.c b/src/vendorcode/amd/agesa/f12/Lib/amdlib.c index cb8f695..f88eb98 100644 --- a/src/vendorcode/amd/agesa/f12/Lib/amdlib.c +++ b/src/vendorcode/amd/agesa/f12/Lib/amdlib.c @@ -348,11 +348,11 @@ LibAmdBitScanReverse ( IN UINT32 value ) { - UINTN Index; + UINT8 Index; for (Index = 31; Index >= 0; Index--){ - if (value & (1 << Index)) break; + if (value & (1 << Index)) return Index; } - return (UINT8) Index; + return 0xFF; } VOID LibAmdMsrRead ( diff --git a/src/vendorcode/amd/agesa/f14/Lib/amdlib.c b/src/vendorcode/amd/agesa/f14/Lib/amdlib.c index 31b3f1e..c1fa494 100644 --- a/src/vendorcode/amd/agesa/f14/Lib/amdlib.c +++ b/src/vendorcode/amd/agesa/f14/Lib/amdlib.c @@ -348,11 +348,11 @@ LibAmdBitScanReverse ( IN UINT32 value ) { - UINTN Index; + UINT8 Index; for (Index = 31; Index >= 0; Index--){ - if (value & (1 << Index)) break; + if (value & (1 << Index)) return Index; } - return (UINT8) Index; + return 0xFF; } VOID LibAmdMsrRead ( diff --git a/src/vendorcode/amd/agesa/f15/Lib/amdlib.c b/src/vendorcode/amd/agesa/f15/Lib/amdlib.c index e51a971..1180ad2 100644 --- a/src/vendorcode/amd/agesa/f15/Lib/amdlib.c +++ b/src/vendorcode/amd/agesa/f15/Lib/amdlib.c @@ -348,11 +348,11 @@ LibAmdBitScanReverse ( IN UINT32 value ) { - UINTN Index; + UINT8 Index; for (Index = 31; Index >= 0; Index--){ - if (value & (1 << Index)) break; + if (value & (1 << Index)) return Index; } - return (UINT8) Index; + return 0xFF; } UINT64 diff --git a/src/vendorcode/amd/agesa/f15tn/Lib/amdlib.c b/src/vendorcode/amd/agesa/f15tn/Lib/amdlib.c index 55adc8a..9646e6d 100644 --- a/src/vendorcode/amd/agesa/f15tn/Lib/amdlib.c +++ b/src/vendorcode/amd/agesa/f15tn/Lib/amdlib.c @@ -359,11 +359,11 @@ LibAmdBitScanReverse ( IN UINT32 value ) { - UINTN Index; + UINT8 Index; for (Index = 31; Index >= 0; Index--){ - if (value & (1 << Index)) break; + if (value & (1 << Index)) return Index; } - return (UINT8) Index; + return 0xFF; } VOID LibAmdMsrRead ( [View Less]

1 0

New patch to review for coreboot: 1ef9cd2 mainboard/asus/k8v-x: Remove dubious SIO PNP programming in romstage
by Edward O'Callaghan 21 May '14

21 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5800 -gerrit commit 1ef9cd2b55dee9f0d4b433ba1493e218e15a5c65 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu May 22 00:16:39 2014 +1000 mainboard/asus/k8v-x: Remove dubious SIO PNP programming in romstage Remove bogus attempt to double program the Super I/O. Remove also a questionable function that enters … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2014