Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5398
-gerrit
commit fc8dca201c65d30c3786f973d470035e6b29ac74
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sun Mar 23 00:09:32 2014 +0100
samsung/lumpy/ec.c: Do not include `chromeos/chromeos.h`
When not selecting the Kconfig option CHROMEOS, compilation of the board
SAMSUNG Lumpy fails as the included header file uses `chromeos_acpi_t`,
which is not known to the compiler when not building with support for
Chrome OS.
In file included from src/mainboard/samsung/lumpy/ec.c:21:0:
src/vendorcode/google/chromeos/chromeos.h:65:43: error: unknown type name 'chromeos_acpi_t'
Luckily, nothing from the header `chromeos.h` is used in `ec.c`, which
was probably the case for the board the file was copied from, so do
not include it at all.
Change-Id: I7923717bfc5c84698044008e5f2441206041e0dd
Reported-by: Idwer Vollering <vidwer(a)gmail.com>
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/samsung/lumpy/ec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mainboard/samsung/lumpy/ec.c b/src/mainboard/samsung/lumpy/ec.c
index 40d8319..2406012 100644
--- a/src/mainboard/samsung/lumpy/ec.c
+++ b/src/mainboard/samsung/lumpy/ec.c
@@ -18,7 +18,6 @@
*/
#include <arch/acpi.h>
-#include <vendorcode/google/chromeos/chromeos.h>
#include <types.h>
#include <console/console.h>
#include <ec/smsc/mec1308/ec.h>
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5397
-gerrit
commit ad715be5ccbadb5636a8005d118e10848498081e
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat Mar 22 23:22:29 2014 +0100
asrock/e350m1/mainboard.c: Disable GPP CLK4 through SLT_GFX_CLK
According to Edward this might fix the problems with the Ethernet device
not showing up sometimes, when the PSU is not turned off during restarts
or shut down and start.
According to the SB800 Register Reference Guide [1] the clock pins are
powered on (0xFF) by default. Powering off the clock pins for GPP4 to
GPP8 and the Gfx PCIe device, hopefully sets the Ethernet device up
correctly, so it is always detected during start up.
Similar to the one applied to AMD Persimmon in [2].
[1] AMD SB800-Series Southbridges Register Reference Guide
Publication: #45482
Revision: 3.04
[2] http://review.coreboot.org/1876
Change-Id: Ibd839bb469f06cbbb8a50d6a0bc58ad967a1a5e1
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/asrock/e350m1/mainboard.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/src/mainboard/asrock/e350m1/mainboard.c b/src/mainboard/asrock/e350m1/mainboard.c
index a98a179..56f3696 100644
--- a/src/mainboard/asrock/e350m1/mainboard.c
+++ b/src/mainboard/asrock/e350m1/mainboard.c
@@ -25,6 +25,8 @@
#include <cpu/amd/mtrr.h>
#include <device/pci_def.h>
#include <southbridge/amd/cimx/cimx_util.h>
+#include <agesawrapper.h>
+#include "SBPLATFORM.h"
//#define SMBUS_IO_BASE 0x6000
void set_pcie_reset(void);
@@ -54,6 +56,15 @@ static void mainboard_enable(device_t dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
+ /* enable GPP CLK0 thru CLK3 (interleaved) */
+ /* disable GPP CLK4 thru SLT_GFX_CLK */
+ u8 *misc_mem_clk_cntrl = (u8 *)(ACPI_MMIO_BASE + MISC_BASE);
+ *(misc_mem_clk_cntrl + 0) = 0xFF;
+ *(misc_mem_clk_cntrl + 1) = 0xFF;
+ *(misc_mem_clk_cntrl + 2) = 0x00;
+ *(misc_mem_clk_cntrl + 3) = 0x00;
+ *(misc_mem_clk_cntrl + 4) = 0x00;
+
/*
* Initialize ASF registers to an arbitrary address because someone
* long ago set things up this way inside the SPD read code. The
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5397
-gerrit
commit 39bf208b388b10a51ad96067126667584e88db20
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat Mar 22 23:22:29 2014 +0100
asrock/e350m1/mainboard.c: Disable GPP CLK0 through SLT_GFX_CLK
According to Edward this might fix the problems with the Ethernet device
not showing up sometimes, when the PSU is not turned off during restarts
or shut down and start.
According to the SB800 Register Reference Guide [1] the clock pins are
powered on (0xFF) by default. Powering off the clock pins for GPP4 to
GPP8 and the Gfx PCIe device, hopefully sets the Ethernet device up
correctly, so it is always detected during start up.
Similar to the one applied to AMD Persimmon in [2].
[1] AMD SB800-Series Southbridges Register Reference Guide
Publication: #45482
Revision: 3.04
[2] http://review.coreboot.org/1876
Change-Id: Ibd839bb469f06cbbb8a50d6a0bc58ad967a1a5e1
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/asrock/e350m1/mainboard.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/src/mainboard/asrock/e350m1/mainboard.c b/src/mainboard/asrock/e350m1/mainboard.c
index a98a179..56f3696 100644
--- a/src/mainboard/asrock/e350m1/mainboard.c
+++ b/src/mainboard/asrock/e350m1/mainboard.c
@@ -25,6 +25,8 @@
#include <cpu/amd/mtrr.h>
#include <device/pci_def.h>
#include <southbridge/amd/cimx/cimx_util.h>
+#include <agesawrapper.h>
+#include "SBPLATFORM.h"
//#define SMBUS_IO_BASE 0x6000
void set_pcie_reset(void);
@@ -54,6 +56,15 @@ static void mainboard_enable(device_t dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
+ /* enable GPP CLK0 thru CLK3 (interleaved) */
+ /* disable GPP CLK4 thru SLT_GFX_CLK */
+ u8 *misc_mem_clk_cntrl = (u8 *)(ACPI_MMIO_BASE + MISC_BASE);
+ *(misc_mem_clk_cntrl + 0) = 0xFF;
+ *(misc_mem_clk_cntrl + 1) = 0xFF;
+ *(misc_mem_clk_cntrl + 2) = 0x00;
+ *(misc_mem_clk_cntrl + 3) = 0x00;
+ *(misc_mem_clk_cntrl + 4) = 0x00;
+
/*
* Initialize ASF registers to an arbitrary address because someone
* long ago set things up this way inside the SPD read code. The
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5397
-gerrit
commit 4a0d57d74d3e887c8c0adc310520c601c809bb53
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat Mar 22 23:22:29 2014 +0100
asrock/e350m1/mainboard.c: Disable GPP CLK0 through SLT_GFX_CLK
According to Edward this might fix the problems with the Ethernet device
not showing up sometimes, when the PSU is not turned off during restarts
or shut down and start.
According to the SB800 Register Reference Guide [1] the clock pins are
powered on (0xFF) by default. Powering off the clock pins for GPP4 to
GPP8 and the Gfx PCIe device, hopefully sets the Ethernet device up
correctly, so it is always detected during start up.
[1] AMD SB800-Series Southbridges Register Reference Guide
Publication: #45482
Revision: 3.04
Change-Id: Ibd839bb469f06cbbb8a50d6a0bc58ad967a1a5e1
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/asrock/e350m1/mainboard.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/src/mainboard/asrock/e350m1/mainboard.c b/src/mainboard/asrock/e350m1/mainboard.c
index a98a179..e04bb92 100644
--- a/src/mainboard/asrock/e350m1/mainboard.c
+++ b/src/mainboard/asrock/e350m1/mainboard.c
@@ -54,6 +54,15 @@ static void mainboard_enable(device_t dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
+ /* enable GPP CLK0 thru CLK3 (interleaved) */
+ /* disable GPP CLK4 thru SLT_GFX_CLK */
+ u8 *misc_mem_clk_cntrl = (u8 *)(ACPI_MMIO_BASE + MISC_BASE);
+ *(misc_mem_clk_cntrl + 0) = 0xFF;
+ *(misc_mem_clk_cntrl + 1) = 0xFF;
+ *(misc_mem_clk_cntrl + 2) = 0x00;
+ *(misc_mem_clk_cntrl + 3) = 0x00;
+ *(misc_mem_clk_cntrl + 4) = 0x00;
+
/*
* Initialize ASF registers to an arbitrary address because someone
* long ago set things up this way inside the SPD read code. The
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5397
-gerrit
commit 261113bbe11c2776ae90a97bec52819f60e33aee
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat Mar 22 23:22:29 2014 +0100
asrock/e350m1/mainboard.c: GPP CLK
According to Edward this might fix the problems with the Ethernet device
not showing up sometimes.
Change-Id: Ibd839bb469f06cbbb8a50d6a0bc58ad967a1a5e1
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/asrock/e350m1/mainboard.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/src/mainboard/asrock/e350m1/mainboard.c b/src/mainboard/asrock/e350m1/mainboard.c
index a98a179..e04bb92 100644
--- a/src/mainboard/asrock/e350m1/mainboard.c
+++ b/src/mainboard/asrock/e350m1/mainboard.c
@@ -54,6 +54,15 @@ static void mainboard_enable(device_t dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
+ /* enable GPP CLK0 thru CLK3 (interleaved) */
+ /* disable GPP CLK4 thru SLT_GFX_CLK */
+ u8 *misc_mem_clk_cntrl = (u8 *)(ACPI_MMIO_BASE + MISC_BASE);
+ *(misc_mem_clk_cntrl + 0) = 0xFF;
+ *(misc_mem_clk_cntrl + 1) = 0xFF;
+ *(misc_mem_clk_cntrl + 2) = 0x00;
+ *(misc_mem_clk_cntrl + 3) = 0x00;
+ *(misc_mem_clk_cntrl + 4) = 0x00;
+
/*
* Initialize ASF registers to an arbitrary address because someone
* long ago set things up this way inside the SPD read code. The
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5352
-gerrit
commit ea7d4bfbdcae4e9a1fb4ad2cdfef5fc539ddca3c
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat Mar 8 12:39:30 2014 +0100
intel/cougar_canyon2/romstage.c: Remove unneeded `cbmemc_reinit`
Enabling CBMEM console for the Cougar Canyon 2 makes the build fail as
there is no prototype for `cbmemc_reinit()`. The reason is that since
commit
1d7541fe console: Fix includes
`console/cbmem_console.h` is not included anymore through
`console/console.h`.
Since commit
cbf5bdfe6 CBMEM: Always select CAR_MIGRATION
calling `cbmemc_reinit()` in the board’s romstage is not needed
anymore, so remove it.
According to Martin Roth, CBMEM console does not work on the board
Cougar Canyon 2 as CAR_MIGRATION is not supported due to shortcomings
of the currently used FSP version. Therefore this patch just addresses
the compile failure, so CBMEM console can be enabled by default for all
boards.
Change-Id: I4dff2d11f073e2829ab3b081b5460f66eead4640
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/intel/cougar_canyon2/romstage.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/src/mainboard/intel/cougar_canyon2/romstage.c b/src/mainboard/intel/cougar_canyon2/romstage.c
index afd7e25..76a2689 100644
--- a/src/mainboard/intel/cougar_canyon2/romstage.c
+++ b/src/mainboard/intel/cougar_canyon2/romstage.c
@@ -340,10 +340,6 @@ void romstage_main_continue(EFI_STATUS status, VOID *HobListPtr) {
timestamp_add(TS_AFTER_INITRAM, after_initram_time);
timestamp_add_now(TS_END_ROMSTAGE);
#endif
-#if CONFIG_CONSOLE_CBMEM
- /* Keep this the last thing this function does. */
- cbmemc_reinit();
-#endif
/*
* FSP returns to this function instead of main, so we can't return back