coreboot-gerrit March 2014

coreboot-gerrit@coreboot.org

1 participants
584 discussions

New patch to review for coreboot: 3b3d6cc sb/amd/amd8111/acpi.c: Remove set but unused variable `dword`
by Paul Menzel 01 Mar '14

01 Mar '14

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5315 -gerrit commit 3b3d6cc996131d8fc7a4c78703e96b8e55a7e376 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Mar 1 12:49:57 2014 +0100 sb/amd/amd8111/acpi.c: Remove set but unused variable `dword` Removing `-Wno-unused-but-set-variable` from `CFLAGS` results in the error below, when building for example the HP DL145 GL1. CC southbridge/amd/amd8111/acpi.ramstage.o src/southbridge/amd/amd8111/acpi.c: In function 'acpi_init': src/southbridge/amd/amd8111/acpi.c:100:11: error: variable 'dword' set but not used [-Werror=unused-but-set-variable] Removing the variable `dword` fixes this error. The read is left in the code, as I do not know if it has an effect or not. Change-Id: I9957cef3a996c5974c275423c9de63ccf230974e Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/southbridge/amd/amd8111/acpi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/southbridge/amd/amd8111/acpi.c b/src/southbridge/amd/amd8111/acpi.c index b734846..bfa5224 100644 --- a/src/southbridge/amd/amd8111/acpi.c +++ b/src/southbridge/amd/amd8111/acpi.c @@ -97,7 +97,6 @@ static void acpi_init(struct device *dev) { uint8_t byte; uint16_t pm10_bar; - uint32_t dword; int on; #if 0 @@ -156,7 +155,7 @@ static void acpi_init(struct device *dev) if(on) { pm10_bar = (pci_read_config16(dev, 0x58)&0xff00); outl(((on<<1)+0x10) ,(pm10_bar + 0x10)); - dword = inl(pm10_bar + 0x10); + inl(pm10_bar + 0x10); on = 8-on; printk(BIOS_DEBUG, "Throttling CPU %2d.%1.1d percent.\n", (on*12)+(on>>1),(on&1)*5);

1 0

Patch set updated for coreboot: 294b942 util/xcompile/xcompile: Remove `-Wno-unused-but-set-variable` from `CFLAGS`
by Paul Menzel 01 Mar '14

01 Mar '14

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3981 -gerrit commit 294b94281be1011c638c9867befe02d540be5c3c Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sun Oct 20 00:11:34 2013 +0200 util/xcompile/xcompile: Remove `-Wno-unused-but-set-variable` from `CFLAGS` Do not disable warnings about unused but set variables to further improve the code quality. Change-Id: I25fa29ac42c9d09596d03f11fb01f31635a62a11 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- util/xcompile/xcompile | 5 ----- 1 file changed, 5 deletions(-) diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index df7d558..bfb6da1 100644 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -89,11 +89,6 @@ testas() { detect_special_flags() { local architecture="$1" - # GCC 4.6 is much more picky about unused variables. - # Turn off it's warnings for now: - testcc "$CC" "$CFLAGS -Wno-unused-but-set-variable " && - CFLAGS="$CFLAGS -Wno-unused-but-set-variable " - # Use bfd linker instead of gold if available: testcc "$CC" "$CFLAGS -fuse-ld=bfd" && CFLAGS="$CFLAGS -fuse-ld=bfd" && LINKER_SUFFIX='.bfd'

1 0

Patch merged into coreboot/master: 6d53cd9 intel/sandybridge: add PCI IDs for 6-Series PCH
by gerrit＠coreboot.org 01 Mar '14

01 Mar '14

the following patch was just integrated into master: commit 6d53cd9d7e25786ed1a4feafc488b4dac5be3ffe Author: Chris Douglass <cdouglass.orion(a)gmail.com> Date: Fri Feb 14 13:51:52 2014 -0500 intel/sandybridge: add PCI IDs for 6-Series PCH The PCI ids are taken from: Intel® 6 Series Chipset and Intel® C200 Series Chipset Specification Update – NDA October 2013 CDI / IBP#: 440377 Change-Id: Ib8418173fd36fd4109b3c4ec0d5543ca8e39ffa6 Signed-off-by: Christopher Douglass <cdouglass.orion(a)gmail.com> See http://review.coreboot.org/5226 for details. -gerrit

1 0

Patch set updated for coreboot: f7078b7 lib/selfboot: s_srcaddr is uninitialized.
by Edward O'Callaghan 01 Mar '14

01 Mar '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5314 -gerrit commit f7078b76abe5c7f2da3440b690b4b21ce6940ea4 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat Mar 1 09:27:37 2014 +1100 lib/selfboot: s_srcaddr is uninitialized. s_srcaddr is uninitialized in the BSS section, leading to a garbage valued operand on the LHS of a '<' on line 383. Change-Id: Ie4fec91b09c70fb1d91ad3918ac3f60653fa1d83 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/lib/selfboot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lib/selfboot.c b/src/lib/selfboot.c index 222eae2..98ed66d 100644 --- a/src/lib/selfboot.c +++ b/src/lib/selfboot.c @@ -352,6 +352,9 @@ static int build_self_segment_list( ntohl(segment->mem_len)); new = malloc(sizeof(*new)); new->s_filesz = 0; + new->s_srcaddr = (uintptr_t) + ((unsigned char *)first_segment) + + ntohl(segment->offset); new->s_dstaddr = ntohll(segment->load_addr); new->s_memsz = ntohl(segment->mem_len); break;

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2014