Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5136
-gerrit
commit 24a130d84250ff5b61d90bb486b0e7df57d00a80
Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Date: Sun Feb 2 19:12:14 2014 +0200
QEMU debugcon: Move under drivers/emulation/qemu
Also prepare this console for use in romstage.
Change-Id: I26a4d4b5db1e44a261396a21bb0f0574d72aa86d
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
src/drivers/emulation/qemu/Makefile.inc | 3 +++
src/drivers/emulation/qemu/qemu_debugcon.c | 41 ++++++++++++++++++++++++++++++
src/include/console/qemu_debugcon.h | 7 +++++
3 files changed, 51 insertions(+)
diff --git a/src/drivers/emulation/qemu/Makefile.inc b/src/drivers/emulation/qemu/Makefile.inc
index e7dc5ed..3351627 100644
--- a/src/drivers/emulation/qemu/Makefile.inc
+++ b/src/drivers/emulation/qemu/Makefile.inc
@@ -1,3 +1,6 @@
+romstage-$(CONFIG_CONSOLE_QEMU_DEBUGCON) += qemu_debugcon.c
+ramstage-$(CONFIG_CONSOLE_QEMU_DEBUGCON) += qemu_debugcon.c
+
ramstage-$(CONFIG_DRIVERS_EMULATION_QEMU_BOCHS) += bochs.c
ramstage-$(CONFIG_DRIVERS_EMULATION_QEMU_BOCHS) += cirrus.c
ramstage-$(CONFIG_DRIVERS_EMULATION_QEMU_BOCHS) += ../../pc80/vga/vga_io.c
diff --git a/src/drivers/emulation/qemu/qemu_debugcon.c b/src/drivers/emulation/qemu/qemu_debugcon.c
new file mode 100644
index 0000000..9c00585
--- /dev/null
+++ b/src/drivers/emulation/qemu/qemu_debugcon.c
@@ -0,0 +1,41 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2013 Red Hat Inc.
+ * Written by Gerd Hoffmann <kraxel(a)redhat.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include <console/console.h>
+#include <console/qemu_debugcon.h>
+#include <arch/io.h>
+#include <arch/early_variables.h>
+
+static int qemu_debugcon_detected CAR_GLOBAL;
+
+void qemu_debugcon_init(void)
+{
+ int detected = (inb(CONFIG_CONSOLE_QEMU_DEBUGCON_PORT) == 0xe9);
+ car_set_var(qemu_debugcon_detected, detected);
+ printk(BIOS_INFO, "QEMU debugcon %s [port 0x%x]\n",
+ detected ? "detected" : "not found",
+ CONFIG_CONSOLE_QEMU_DEBUGCON_PORT);
+}
+
+void qemu_debugcon_tx_byte(unsigned char data)
+{
+ if (car_get_var(qemu_debugcon_detected) != 0)
+ outb(data, CONFIG_CONSOLE_QEMU_DEBUGCON_PORT);
+}
diff --git a/src/include/console/qemu_debugcon.h b/src/include/console/qemu_debugcon.h
new file mode 100644
index 0000000..63b1455
--- /dev/null
+++ b/src/include/console/qemu_debugcon.h
@@ -0,0 +1,7 @@
+#ifndef _QEMU_DEBUGCON_H_
+#define _QEMU_DEBUGCON_H_
+
+void qemu_debugcon_init(void);
+void qemu_debugcon_tx_byte(unsigned char data);
+
+#endif
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3981
-gerrit
commit ce1ee045b3b01e726e10adc5b521f9827b3a9f90
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sun Oct 20 00:11:34 2013 +0200
util/xcompile/xcompile: Remove `-Wno-unused-but-set-variable` from `CFLAGS`
Do not disable warnings about unused but set variables to further
improve the code quality.
Change-Id: I25fa29ac42c9d09596d03f11fb01f31635a62a11
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
util/xcompile/xcompile | 5 -----
1 file changed, 5 deletions(-)
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index df7d558..bfb6da1 100644
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -89,11 +89,6 @@ testas() {
detect_special_flags() {
local architecture="$1"
- # GCC 4.6 is much more picky about unused variables.
- # Turn off it's warnings for now:
- testcc "$CC" "$CFLAGS -Wno-unused-but-set-variable " &&
- CFLAGS="$CFLAGS -Wno-unused-but-set-variable "
-
# Use bfd linker instead of gold if available:
testcc "$CC" "$CFLAGS -fuse-ld=bfd" &&
CFLAGS="$CFLAGS -fuse-ld=bfd" && LINKER_SUFFIX='.bfd'
Idwer Vollering (vidwer(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4561
-gerrit
commit 276f46f1d221c48f7e05255d0b39ef56f9767548
Author: Idwer Vollering <vidwer(a)gmail.com>
Date: Sun Dec 22 21:01:51 2013 +0000
Asus F2A85-M: show POST codes
Add conditional POST code output, tunable with CONFIG_IO_POST.
Change-Id: If92b50ab3888518228d2d3b76f5c50c4aef968dd
Signed-off-by: Idwer Vollering <vidwer(a)gmail.com>
---
src/mainboard/asus/f2a85-m/romstage.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mainboard/asus/f2a85-m/romstage.c b/src/mainboard/asus/f2a85-m/romstage.c
index fe66dde..b0111eb 100644
--- a/src/mainboard/asus/f2a85-m/romstage.c
+++ b/src/mainboard/asus/f2a85-m/romstage.c
@@ -64,7 +64,9 @@ static void sbxxx_enable_48mhzout(void)
void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
{
+#if CONFIG_IO_POST
hudson_pci_port80();
+#endif
u32 val;
u8 byte;
Idwer Vollering (vidwer(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4561
-gerrit
commit 1e12f9212285b4e931930207cc1c3691c8a3f542
Author: Idwer Vollering <vidwer(a)gmail.com>
Date: Sun Dec 22 21:01:51 2013 +0000
Asus F2A85-M: show POST codes
Add conditional POST code output, tunable with CONFIG_IO_POST.
Change-Id: If92b50ab3888518228d2d3b76f5c50c4aef968dd
Signed-off-by: Idwer Vollering <vidwer(a)gmail.com>
---
src/mainboard/asus/f2a85-m/romstage.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mainboard/asus/f2a85-m/romstage.c b/src/mainboard/asus/f2a85-m/romstage.c
index fe66dde..df21ede 100644
--- a/src/mainboard/asus/f2a85-m/romstage.c
+++ b/src/mainboard/asus/f2a85-m/romstage.c
@@ -64,7 +64,9 @@ static void sbxxx_enable_48mhzout(void)
void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
{
+#if CONFIG_IO_POST_PORT
hudson_pci_port80();
+#endif
u32 val;
u8 byte;
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5132
-gerrit
commit ab88b5b382d5aa22a4fa5d0dc18a4419d757beef
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Wed Feb 5 14:27:22 2014 +0100
Kill ALT_CBFS_LOAD_PAYLOAD
Not used anymore.
Change-Id: Icf3a4a7f932776981048b805478582ad2b784182
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
src/Kconfig | 9 ---------
src/lib/cbfs.c | 2 --
2 files changed, 11 deletions(-)
diff --git a/src/Kconfig b/src/Kconfig
index 31a41ab..e6b237a 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -47,15 +47,6 @@ config CBFS_PREFIX
Select the prefix to all files put into the image. It's "fallback"
by default, "normal" is a common alternative.
-config ALT_CBFS_LOAD_PAYLOAD
- bool "Use alternative cbfs_load_payload() implementation."
- default n
- help
- Either board or southbridge provide an alternative cbfs_load_payload()
- implementation. This may be used, for example, if accessing the ROM
- through memory-mapped I/O is slow and a faster alternative can be
- provided.
-
choice
prompt "Compiler to use"
default COMPILER_GCC
diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c
index 9fe1757..30e7949 100644
--- a/src/lib/cbfs.c
+++ b/src/lib/cbfs.c
@@ -213,7 +213,6 @@ void * cbfs_load_stage(struct cbfs_media *media, const char *name)
}
#endif /* CONFIG_RELOCATABLE_RAMSTAGE */
-#if !CONFIG_ALT_CBFS_LOAD_PAYLOAD
void *cbfs_load_payload(struct cbfs_media *media, const char *name)
{
struct cbfs_payload *payload;
@@ -226,7 +225,6 @@ void *cbfs_load_payload(struct cbfs_media *media, const char *name)
media, name, CBFS_TYPE_PAYLOAD, NULL);
return payload;
}
-#endif
/* Simple buffer */