coreboot-gerrit April 2013

coreboot-gerrit@coreboot.org

1 participants
506 discussions

Patch merged into coreboot/master: 3402a7f inteltool: Cast to `intptr_t` instead of `uint64_t`
by gerrit＠coreboot.org 04 Apr '13

04 Apr '13

the following patch was just integrated into master: commit 3402a7fa7001e40035b6ae303b2e47b6281fef1c Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Mon Apr 1 18:26:58 2013 +0200 inteltool: Cast to `intptr_t` instead of `uint64_t` When building inteltool under x86-32, the following warnings are shown. $ gcc --version gcc-4.7.real (Debian 4.7.2-15) 4.7.2 Copyright (C) 2012 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ make […] amb.c: In function ‘amb_read_config32’: amb.c:31:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] amb.c:31:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] amb.c: In function ‘amb_read_config16’: amb.c:45:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] amb.c:45:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] amb.c: In function ‘amb_read_config8’: amb.c:60:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] amb.c:60:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] […] Nico Huber commented the following [1]. I don't see those warnings because I build for x86-64. I guess they could be fixed by casting to `ptrdiff_t` (from stddef.h) instead of `uint64_t`. And indeed, using `ptrdiff_t` fixes the warning. But as Stefan Reinauer commented in [2], `intptr_t` is more appropriate as this is just a pointer and no pointer difference. So `intptr_t` is taken, which fixes these issues warned about too. These warnings were introduced in commit »inteltool: Add support for dumping AMB registers« (4b7b320f) [3]. [1] http://review.coreboot.org/#/c/2996/1//COMMIT_MSG [2] http://review.coreboot.org/#/c/3002/1/util/inteltool/amb.c [3] http://review.coreboot.org/525 Change-Id: I2ea1a31dc1e3db129e767d6a9e0433fd75a77d0f Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-on: http://review.coreboot.org/3002 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.huber(a)secunet.com> Build-Tested: build bot (Jenkins) at Wed Apr 3 12:08:10 2013, giving +1 Reviewed-By: Nico Huber <nico.huber(a)secunet.com> at Thu Apr 4 14:24:25 2013, giving +2 See http://review.coreboot.org/3002 for details. -gerrit

1 0

New patch to review for coreboot: d563987 libpayload, superiotool: README: Prepend `coreboot/` to path of change directory line
by Paul Menzel 04 Apr '13

04 Apr '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3021 -gerrit commit d5639876584ccca8f11033e0568d2a3e6e07a36a Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Thu Apr 4 14:12:26 2013 +0200 libpayload, superiotool: README: Prepend `coreboot/` to path of change directory line Nico Huber spotted [1], that commit (4d6ab4e2) [1] updating superiotools’s `README` with the Git command line superiotool: Update README with Git repository URL and directory location missed, that after `git clone` one sitll has to change into the cloned directory. So prepend the path with `coreboot/` to fix that. The same error happened in the commit (e1ea5151) for libpayload [2] libpayload: Update README with Git repository URL and directory location and is fixed in this patch too. [1] http://review.coreboot.org/#/c/3019/ [2] http://review.coreboot.org/2228 Change-Id: Ib6e8b678af6276556a40ccfd52ae35ca7e674455 Reported-by: Nico Huber <nico.h(a)gmx.de> Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- payloads/libpayload/README | 2 +- util/superiotool/README | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/payloads/libpayload/README b/payloads/libpayload/README index acb3f97..70bd5ef 100644 --- a/payloads/libpayload/README +++ b/payloads/libpayload/README @@ -16,7 +16,7 @@ Installation $ git clone http://review.coreboot.org/p/coreboot.git - $ cd payloads/libpayload + $ cd coreboot/payloads/libpayload $ make menuconfig diff --git a/util/superiotool/README b/util/superiotool/README index 2607d8d..dfa6c1c 100644 --- a/util/superiotool/README +++ b/util/superiotool/README @@ -20,7 +20,7 @@ Installation $ git clone http://review.coreboot.org/p/coreboot.git - $ cd util/superiotool + $ cd coreboot/util/superiotool Optional: Edit the Makefile and set 'CONFIG_PCI = no' if you don't want to support PCI-attached "Super I/Os" (which needs libpci-dev) such as the

1 0

Patch merged into coreboot/master: 190011e AMD: Drop six copies of wrmsr_amd and rdmsr_amd
by gerrit＠coreboot.org 04 Apr '13

04 Apr '13

the following patch was just integrated into master: commit 190011e47c6187479db69344ccf87762009af444 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Mon Mar 25 12:48:49 2013 +0200 AMD: Drop six copies of wrmsr_amd and rdmsr_amd Based on comments in cpu/x86/msr.h for wrmsr/rdmsr, and for symmetry, I have added __attribute__((always_inline)) for these. Change-Id: Ia0a34c15241f9fbc8c78763386028ddcbe6690b1 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/2898 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Marc Jones <marc.jones(a)se-eng.com> Build-Tested: build bot (Jenkins) at Mon Mar 25 13:01:09 2013, giving +1 Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Mon Mar 25 13:17:37 2013, giving +2 Reviewed-By: Marc Jones <marc.jones(a)se-eng.com> at Thu Apr 4 04:52:18 2013, giving +2 See http://review.coreboot.org/2898 for details. -gerrit

1 0

Patch merged into coreboot/master: 4d6ab4e superiotool: Update README with Git repository URL and directory location
by gerrit＠coreboot.org 04 Apr '13

04 Apr '13

the following patch was just integrated into master: commit 4d6ab4e2ae25c8148e699e3821b71991ac4d80dc Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Wed Apr 3 23:10:22 2013 +0200 superiotool: Update README with Git repository URL and directory location Change-Id: I36d980cea5ca9cc67262dba809441091757e1fb5 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-on: http://review.coreboot.org/3019 Tested-by: build bot (Jenkins) Reviewed-by: Marc Jones <marc.jones(a)se-eng.com> Build-Tested: build bot (Jenkins) at Thu Apr 4 00:29:23 2013, giving +1 Reviewed-By: Marc Jones <marc.jones(a)se-eng.com> at Thu Apr 4 04:49:57 2013, giving +2 See http://review.coreboot.org/3019 for details. -gerrit

1 0

Patch merged into coreboot/master: 5b5cf3d AMD GX1: Remove useless copied header file `northbridge.h`
by gerrit＠coreboot.org 04 Apr '13

04 Apr '13

the following patch was just integrated into master: commit 5b5cf3d610f28bd44b15b0ef7a0816fd41d326af Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Thu Apr 4 01:50:17 2013 +0200 AMD GX1: Remove useless copied header file `northbridge.h` This was there since the beginning commit d24d6993b6d7bcf7977d74d081e718e1b076d1b0 Author: arch import user (historical) <svn(a)openbios.org> Date: Wed Jul 6 17:06:46 2005 +0000 Revision: linuxbios(a)linuxbios.org--devel/freebios--devel--2.0--patch-26 Creator: Hamish Guthrie <hamish(a)prodigi.ch> Added AMD GX1 northbridge and cs5530 Southbridge but blindly copied from Intel 440 BX and is not used anywhere. Thanks to Idwer Vollering for spotting this. Change-Id: I38b3d3feb25966c3aa382994d323e59c3f3c9e6c Reported-by: Idwer Vollering Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-on: http://review.coreboot.org/3020 Reviewed-by: Marc Jones <marc.jones(a)se-eng.com> Tested-by: build bot (Jenkins) Build-Tested: build bot (Jenkins) at Thu Apr 4 02:47:40 2013, giving +1 Reviewed-By: Marc Jones <marc.jones(a)se-eng.com> at Thu Apr 4 02:04:49 2013, giving +2 See http://review.coreboot.org/3020 for details. -gerrit

1 0

New patch to review for coreboot: bb9f69b AMD GX1: Remove useless copied header file `northbridge.h`
by Paul Menzel 04 Apr '13

04 Apr '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3020 -gerrit commit bb9f69b987d14edf40a6a7237bb57ae7b6e95ed9 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Thu Apr 4 01:50:17 2013 +0200 AMD GX1: Remove useless copied header file `northbridge.h` This was there since the beginning commit d24d6993b6d7bcf7977d74d081e718e1b076d1b0 Author: arch import user (historical) <svn(a)openbios.org> Date: Wed Jul 6 17:06:46 2005 +0000 Revision: linuxbios(a)linuxbios.org--devel/freebios--devel--2.0--patch-26 Creator: Hamish Guthrie <hamish(a)prodigi.ch> Added AMD GX1 northbridge and cs5530 Southbridge but blindly copied from Intel 440 BX and is not used anywhere. Thanks to Idwer Vollering for spotting this. Change-Id: I38b3d3feb25966c3aa382994d323e59c3f3c9e6c Reported-by: Idwer Vollering Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/northbridge/amd/gx1/northbridge.c | 1 - src/northbridge/amd/gx1/northbridge.h | 6 ------ 2 files changed, 7 deletions(-) diff --git a/src/northbridge/amd/gx1/northbridge.c b/src/northbridge/amd/gx1/northbridge.c index 4547b8d..d670a19 100644 --- a/src/northbridge/amd/gx1/northbridge.c +++ b/src/northbridge/amd/gx1/northbridge.c @@ -6,7 +6,6 @@ #include <device/pci_ids.h> #include <stdlib.h> #include <string.h> -#include "northbridge.h" #include <cpu/amd/gx1def.h> #include <cpu/x86/cache.h> #include <cpu/cpu.h> diff --git a/src/northbridge/amd/gx1/northbridge.h b/src/northbridge/amd/gx1/northbridge.h deleted file mode 100644 index 3e569bb..0000000 --- a/src/northbridge/amd/gx1/northbridge.h +++ /dev/null @@ -1,6 +0,0 @@ -#ifndef NORTHBRIDGE_INTEL_440BX_H -#define NORTHBRIDGE_INTEL_440BX_H - -extern unsigned int i440bx_scan_root_bus(device_t root, unsigned int max); - -#endif /* NORTHBRIDGE_INTEL_440BX_H */

1 0

New patch to review for coreboot: 02637e7 superiotool: Update README with Git repository URL and directory location
by Paul Menzel 03 Apr '13

03 Apr '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3019 -gerrit commit 02637e7e12346f0013dc2b5112c2364fea8f61ed Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Wed Apr 3 23:10:22 2013 +0200 superiotool: Update README with Git repository URL and directory location Change-Id: I36d980cea5ca9cc67262dba809441091757e1fb5 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- util/superiotool/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/superiotool/README b/util/superiotool/README index 0a969c5..2607d8d 100644 --- a/util/superiotool/README +++ b/util/superiotool/README @@ -18,9 +18,9 @@ for details on coreboot), but it may also be useful for other things. Installation ------------ - $ svn co svn://coreboot.org/repos/trunk/util/superiotool + $ git clone http://review.coreboot.org/p/coreboot.git - $ cd superiotool + $ cd util/superiotool Optional: Edit the Makefile and set 'CONFIG_PCI = no' if you don't want to support PCI-attached "Super I/Os" (which needs libpci-dev) such as the

1 0

Patch merged into coreboot/master: 3c156dd lynxpoint: Cosmetic cleanup
by gerrit＠coreboot.org 03 Apr '13

03 Apr '13

the following patch was just integrated into master: commit 3c156dd98c03dda5d579e0530ffc724399ed84fe Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Mon Apr 1 14:40:59 2013 -0700 lynxpoint: Cosmetic cleanup src/southbridge/intel/lynxpoint/pmutil.c was committed with two things that needed fixing. Change-Id: Ib83343a75840aa29847b607b0275971eb8140f12 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/3003 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Anton Kochkov <anton.kochkov(a)gmail.com> Build-Tested: build bot (Jenkins) at Tue Apr 2 07:42:58 2013, giving +1 Reviewed-By: Anton Kochkov <anton.kochkov(a)gmail.com> at Wed Apr 3 23:07:12 2013, giving +2 See http://review.coreboot.org/3003 for details. -gerrit

1 0

Patch set updated for coreboot: e14fe8d mtrr: add rom caching comment about hyperthreads
by Aaron Durbin 03 Apr '13

03 Apr '13

Aaron Durbin (adurbin(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3018 -gerrit commit e14fe8da5ae27c752c7dcb0b27793e0864e54d96 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Apr 3 09:57:53 2013 -0500 mtrr: add rom caching comment about hyperthreads Explicitly call out the effects of hyperthreads running the MTRR code and its impact on the enablement of ROM caching. Change-Id: I14b8f3fdc112340b8f483f2e554c5680576a8a7c Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- src/include/cpu/x86/mtrr.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/include/cpu/x86/mtrr.h b/src/include/cpu/x86/mtrr.h index 15a5cad..38c3f7c 100644 --- a/src/include/cpu/x86/mtrr.h +++ b/src/include/cpu/x86/mtrr.h @@ -74,7 +74,11 @@ int x86_mtrr_check(void); /* ROM caching can be used after variable MTRRs are set up. Beware that * enabling CONFIG_CACHE_ROM will eat through quite a few MTRRs based on * one's IO hole size and WRCOMB resources. Be sure to check the console - * log when enabling CONFIG_CACHE_ROM or adding WRCOMB resources. */ + * log when enabling CONFIG_CACHE_ROM or adding WRCOMB resources. Beware that + * on CPUs with core-scoped MTRR registers such as hyperthreaded CPUs the + * rom caching will be disabled if all threads run the MTRR code. Therefore, + * one needs to call x86_mtrr_enable_rom_caching() after all threads of the + * same core have run the MTRR code. */ #if CONFIG_CACHE_ROM void x86_mtrr_enable_rom_caching(void); void x86_mtrr_disable_rom_caching(void);

1 0

Patch merged into coreboot/master: 27a1be9 Partially revert "AMD Inagua: broadcom.c: Add missing prototype for `broadcom_init()`"
by gerrit＠coreboot.org 03 Apr '13

03 Apr '13

the following patch was just integrated into master: commit 27a1be9169eb165d4f23ef19042f26db3769c24f Author: Jens Rottmann <JRottmann(a)LiPPERTembedded.de> Date: Wed Apr 3 10:12:55 2013 +0200 Partially revert "AMD Inagua: broadcom.c: Add missing prototype for `broadcom_init()`" Commit 5d741567 added a prototype to broadcom.c to fix a warning. This part is fine. It also changed mainboard.c to #include broadcom.c. But broadcom.c is already in Makefile.inc, now building will fail because the linker gets broadcom_init() twice. Undo the change to mainboard.c but keep the change to broadcom.c. Change-Id: Ieccc098f477ffacccf4174056998034a220a9744 Signed-off-by: Jens Rottmann <JRottmann(a)LiPPERTembedded.de> Reviewed-on: http://review.coreboot.org/3012 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Marc Jones <marc.jones(a)se-eng.com> Build-Tested: build bot (Jenkins) at Wed Apr 3 11:28:42 2013, giving +1 See http://review.coreboot.org/3012 for details. -gerrit

1 0

← Newer
1
...
41
42
43
44
45
46
47
...
51
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2013